mini_model 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e8708424bd24b1a49650936429addbe7a258728
-  data.tar.gz: 677ed6b7a4b871dcff0f9c1eaee2e44c9c06cce4
+  metadata.gz: b80bb2389a67ac22d77537e366e2de43491ad63c
+  data.tar.gz: 989d69035efd19a70fb42e32377894a86b079469
 SHA512:
-  metadata.gz: c57dfc9f23486c77ea40014113240c8f5e847a38b0dff3331ce161e383ec0849dc2432b31d118940a4730356d43b890d8a3ca6b4aef960d8ee0889b7aa9a784a
-  data.tar.gz: 3fc9fc50f95689f908bf098fba7d44071a4c42c416d703503fe6eecd8c67f99b02ffd28dd1f2b1cc01e3620e2b76c56dcbb4abdbc7309b97aebbe258bcf028ce
+  metadata.gz: daf447cd0e17c3ae3f290363d6ae915c412672fbc2ea465a61f0b2bd7a1216c776ec652f5fe1bc8667c75248d3a60ed4007fc9d008beef8de793611fd2883135
+  data.tar.gz: 66f1c3d97813966cfdac883001720d9f1d800c62bcb5c75fdb6b9c05e692ce0ce66c3fd18914f430f1d29d8667dd68a0b58f7b3bc847dae08ce32081b75e8106

data/README.md

@@ -78,9 +78,8 @@ We don't want to be assigning nil all over our associations and what have you.
 
 `#attributes` Gets the attributes hash.
 
-`#attributes=` For each key/value in the given hash, sends the writer to self.
-This means it'll be a missing method if you have not created the writer via the
-`::attribute` macro, or manually. This is not safe to use with user input.
+`#attributes=` For each key/value in the given hash, sends the writer (from key)
+to self if the method exists.
 
 `#==` Compares two models to see if they are equals. It ensures that the class,
 id, and attributes of each are the same.

data/lib/mini_model.rb

@@ -1,5 +1,5 @@
 module MiniModel
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 
   class Error < StandardError; end
 
@@ -151,13 +151,16 @@ module MiniModel
 
   # #attributes= is vulnerable to mass assignment attacks if used
   # directly with user input. Some sort of filter must be in place
-  # before setting attributes or initializing a new model. Sending
-  # a key in the hash argument that doesn't have an accessor raises an error.
+  # before setting attributes or initializing a new model.
   def attributes=(attributes)
     @attributes = {}
 
     attributes.each do |key, value|
-      send(:"#{key}=", value)
+      writer = :"#{key}="
+
+      if respond_to?(writer)
+        send(writer, value)
+      end
     end
   end
 

data/test/all.rb

@@ -248,12 +248,12 @@ test '#attributes= resets all attributes, but not id' do
   assert_equal user.email, user.attributes[:email]
 end
 
-test '#attributes= raises when there is no accessor for a key' do
+test '#attributes= ignores keys without a writer' do
   user = User.new
 
-  assert_raise do
-    user.attributes = { foo: :bar }
-  end
+  user.attributes = { foo: :bar }
+
+  assert !user.attributes.has_key?(:foo)
 end
 
 setup do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mini_model
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Steve Weiss