mini_histogram 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 387d46563e24fde087f05153983b93b8209b5b83f8291515baa9458acd55f696
-  data.tar.gz: d74fafa98d169baf6de9cd66f46d8a25f514ac7d4f40a3ac9ea9029feeb9c2d9
+  metadata.gz: f74ffb350c63f9f26ea90db6a41c8135c3b2e180de663a1747d649a47e8e2df4
+  data.tar.gz: 3a69ae4f5a0f4d64d830f7a39b0b79f3ab011cae5cf7479328ee8a907b5f7820
 SHA512:
-  metadata.gz: e8a23b6ebdb80c2a06679d6ef5fa7183ee4d2e7a6e4bf7b8caf46cbd335398b30af8dfb8dd7fd8970ea6fe73e35650297595db57381223744d3b7b787efb4b0a
-  data.tar.gz: 2c8fafef6d1bed5fa60b7e5ebb46698ad3305ac110fb3414d33502a9e4b0f44cfd9fbc9f83eef60eddbb6d9815c0dd9c2541703ab2fba92041e5881a6cf9fb3f
+  metadata.gz: 477c617614b9ed9202dc2f42aa6c3571a44651173ffb7357c5650aefedaeb599b9a98b38daa107e9c2002f8c59700cc2e349ddb2ead5412e99c339d37f4f6691
+  data.tar.gz: a6dc9302632ab19b9264c5787d31fe8387dc9130669ec0fe2ae7860bab6fbcb10fee9d712943aa00a3a41167873fee214df9c07c5af2101dc5914da5662f9472

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Master
 
+## 0.1.3
+
+- Handle edge cases (https://github.com/zombocom/mini_histogram/pull/2)
+
 ## 0.1.2
 
 - Add `edge` as alias to `edges`

data/lib/mini_histogram.rb

@@ -21,12 +21,13 @@ class MiniHistogram
   class Error < StandardError; end
   attr_reader :array, :left_p, :max
 
-  def initialize(array, left_p: false, edges: nil)
+  def initialize(array, left_p: true, edges: nil)
     @array = array
     @left_p = left_p
     @edges = edges
     @weights = nil
-    @max = array.max
+
+    @min, @max = array.minmax
   end
 
   def edges_min
@@ -42,7 +43,7 @@ class MiniHistogram
   end
 
   def closed
-    :left
+    @left_p ? :left : :right
   end
 
   # Sets the edge value to something new,
@@ -54,6 +55,8 @@ class MiniHistogram
   end
 
   def bin_size
+    return 0 if edges.length <= 1
+
     edges[1] - edges[0]
   end
 
@@ -86,6 +89,7 @@ class MiniHistogram
   #   4 values between 4.0 and 6.0 and three values between 10.0 and 12.0
   def weights
     return @weights if @weights
+    return @weights = [] if array.empty?
 
     lo = edges.first
     step = edges[1] - edges[0]
@@ -118,16 +122,18 @@ class MiniHistogram
   def edges
     return @edges if @edges
 
-    hi = array.max
-    lo = array.min
+    return @edges = [0.0] if array.empty?
 
-    nbins = sturges * 1.0
+    lo = @min
+    hi = @max
+
+    nbins = sturges.to_f
 
     if hi == lo
-      start = hi
+      start = lo
       step = 1.0
       divisor = 1.0
-      len = 1.0
+      len = 1
     else
       bw = (hi - lo) / nbins
       lbw = Math.log10(bw)
@@ -163,31 +169,32 @@ class MiniHistogram
         start = (lo * divisor).floor
         len = (hi * divisor - start).ceil
       end
+    end
 
-      if left_p
-        while (lo < start/divisor)
-          start -= step
-        end
-
-        while (start + (len - 1)*step)/divisor <= hi
-          len += 1
-        end
-      else
-        while lo <= start/divisor
-          start -= step
-        end
-        while (start + (len - 1)*step)/divisor < hi
-          len += 1
-        end
+    if left_p
+      while (lo < start/divisor)
+        start -= step
       end
 
-      @edges = []
-      len.next.times.each do
-        @edges << start/divisor
-        start += step
+      while (start + (len - 1)*step)/divisor <= hi
+        len += 1
+      end
+    else
+      while lo <= start/divisor
+        start -= step
       end
-      return @edges
+      while (start + (len - 1)*step)/divisor < hi
+        len += 1
+      end
+    end
+
+    @edges = []
+    len.times.each do
+      @edges << start/divisor
+      start += step
     end
+
+    return @edges
   end
   alias :edge :edges
 

data/lib/mini_histogram/version.rb

@@ -1,3 +1,3 @@
 class MiniHistogram
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/mini_histogram.gemspec

@@ -26,4 +26,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "m"
+  # Used for comparison testing, but only supports Ruby 2.4+
+  # spec.add_development_dependency "enumerable-statistics"
+  spec.add_development_dependency "benchmark-ips"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mini_histogram
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - schneems
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: benchmark-ips
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: It makes histograms out of Ruby data. How cool is that!? Pretty cool
   if you ask me.
 email: