mini_form 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6d0c0c470b74ebc5e81006fa9f4f226de8d821d6
-  data.tar.gz: 38393dfb6c142a1f85dca47a2aa16072a63f657f
+  metadata.gz: e2ce5edc41122a2b5bd8053b3d41fa696c26c1cc
+  data.tar.gz: 1851cb3f9154ee58adedbdcec78c91655b83b731
 SHA512:
-  metadata.gz: 1f8c4900a91ceedd1b9f7c12b73e5b2fc30f033fd47783ae792a4c9e8dbb3f0bae93c65953da6ddebf1bbc75e3bb8c4484e863e33925b67672f11246e4b094b6
-  data.tar.gz: 5a3a73ad3547ba949a1900918a1cdcfefc73c8bf77d0764d89fa0858c6fe8ae075a0493066f80b65d62429160e5a93d2734303d75fcc66d8b8746596d3455730
+  metadata.gz: f5f02066e7377bb4eb6439fee9a96c97df91d884d0fff99e11d31199560f541fd10592c1135a8002553fc82dead710115113e4de7a8192f9e0ba7eeb77e7eb75
+  data.tar.gz: fad81e7df2308e9c93dd7ff7adf229e4d185372bd5f73a5bd4cec09a1041a80c368a403af56024b47f25f1d33d04330ca729036a53fec83f3cd48624fecb7a92

data/.rubocop.yml

@@ -1,16 +1,32 @@
 require: rubocop-rspec
 
-AllCops:
-  RunRailsCops: true
+Rails:
+  Enabled: true
   Exclude:
     - example/db/**/*
     - example/config/**/*
     - search_object.gemspec
 
+# Disables "Module definition is too long"
+ModuleLength:
+  Enabled: false
+
 # Disables "Line is too long"
 LineLength:
   Enabled: false
 
+# Disables "Method is too long"
+MethodLength:
+  Enabled: false
+
+# Disables "Assignment Branch Condition size for included is too high"
+AbcSize:
+  Enabled: false
+
+# Disables "Block has too many lines"
+BlockLength:
+  Enabled: false
+
 # Disables "Missing top-level class documentation comment"
 Documentation:
   Enabled: false
@@ -22,3 +38,15 @@ Style/EachWithObject:
 # Disables "Prefer reduce over inject."
 Style/CollectionMethods:
   Enabled: false
+
+# Disables "Use tr instead of gsubs"
+Performance/StringReplacement:
+  Enabled: false
+
+# Disables "Example has too many expectations"
+RSpec/MultipleExpectations:
+  Enabled: false
+
+# Disables "Example has too many lines"
+RSpec/ExampleLength:
+  Enabled: false

data/.travis.yml

@@ -1,10 +1,12 @@
 language: ruby
 rvm:
-  - 2.0
-  - 2.1
-  - 2.2
+  - 2.2.5
+  - 2.3.3
+  - 2.4.0
 script:
   - bundle exec rubocop
   - bundle exec rspec spec
+sudo: false
+cache: bundle
 notifications:
   email: false

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased 0.2.1
+
+* Fix typo in `assignment` callbaks
+* Alias `assignment` to `assigment` for backwards compatibility
+
 ## Version 0.2.0
 
 * Don't expose model name on `model`. _(security fix)_

data/README.md

@@ -267,11 +267,11 @@ form.id = 42   # => raises `NoMethodError`
     <td>Meant to be overwritten.</td>
   </tr>
   <tr>
-    <td>#before_assigment</td>
+    <td>#before_assignment</td>
     <td>Meant to be overwritten.</td>
   </tr>
   <tr>
-    <td>#after_assigment</td>
+    <td>#after_assignment</td>
     <td>Meant to be overwritten.</td>
   </tr>
   <tr>

data/lib/mini_form/model.rb

@@ -3,7 +3,7 @@ require 'active_model'
 
 module MiniForm
   module Model
-    def self.included(base) # rubocop:disable MethodLength
+    def self.included(base)
       base.class_eval do
         include ActiveModel::Validations
         include ActiveModel::Validations::Callbacks
@@ -15,11 +15,18 @@ module MiniForm
         extend ClassMethods
 
         define_model_callbacks :update
+        define_model_callbacks :assignment
+
+        # For backwards compatibility purpose
         define_model_callbacks :assigment
 
         before_update :before_update
         after_update :after_update
 
+        before_assignment :before_assignment
+        after_assignment :after_assignment
+
+        # For backwards compatibility purpose
         before_assigment :before_assigment
         after_assigment :after_assigment
       end
@@ -34,14 +41,16 @@ module MiniForm
     end
 
     def attributes=(attributes)
-      run_callbacks :assigment do
-        attributes.slice(*self.class.attribute_names).each do |name, value|
-          public_send "#{name}=", value
+      run_callbacks :assignment do
+        run_callbacks :assigment do
+          attributes.slice(*self.class.attribute_names).each do |name, value|
+            public_send "#{name}=", value
+          end
         end
       end
     end
 
-    alias_method :assign_attributes, :attributes=
+    alias assign_attributes attributes=
 
     def attributes
       Hash[self.class.attribute_names.map { |name| [name, public_send(name)] }]
@@ -63,7 +72,7 @@ module MiniForm
     end
 
     def update!(attributes = {})
-      fail InvalidForm, self unless update attributes
+      raise InvalidForm, self unless update attributes
       self
     end
 
@@ -94,6 +103,14 @@ module MiniForm
       # noop
     end
 
+    def before_assignment
+      # noop
+    end
+
+    def after_assignment
+      # noop
+    end
+
     def before_assigment
       # noop
     end

data/lib/mini_form/version.rb

@@ -1,3 +1,3 @@
 module MiniForm
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'.freeze
 end

data/mini_form.gemspec

@@ -14,14 +14,14 @@ Gem::Specification.new do |spec|
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  spec.executables   = spec.files.grep(/^bin\//) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(/^(spec)\//)
+  spec.executables   = spec.files.grep(%r{^bin\/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(spec)\/})
   spec.require_paths = ['lib']
 
   spec.add_dependency 'activemodel', '~> 4.0'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rake', '< 11.0'
   spec.add_development_dependency 'rspec', '~> 2.14'
   spec.add_development_dependency 'rspec-mocks', '>= 2.12.3'
   spec.add_development_dependency 'coveralls'

data/spec/mini_form_spec.rb

@@ -204,7 +204,7 @@ module MiniForm
 
         model :user, attributes: %i(name), save: true
 
-        def initialize(user: user)
+        def initialize(user:)
           self.user = user
         end
       end
@@ -224,9 +224,11 @@ module MiniForm
       it 'calls "perfom" method when validation pass' do
         object = ExampleForUpdate.new name: 'value'
 
-        expect(object).to receive(:perform)
+        allow(object).to receive(:perform)
 
         object.update
+
+        expect(object).to have_received(:perform)
       end
 
       it 'calls "save" for the model' do
@@ -242,19 +244,37 @@ module MiniForm
       it 'supports update callbacks' do
         object = ExampleForUpdate.new name: 'value'
 
-        expect(object).to receive(:before_update)
-        expect(object).to receive(:after_update)
+        allow(object).to receive(:before_update)
+        allow(object).to receive(:after_update)
 
         object.update
+
+        expect(object).to have_received(:before_update)
+        expect(object).to have_received(:after_update)
+      end
+
+      it 'supports legacy assig callbacks' do
+        object = ExampleForUpdate.new
+
+        allow(object).to receive(:before_assigment)
+        allow(object).to receive(:after_assigment)
+
+        object.update name: 'value'
+
+        expect(object).to have_received(:before_assigment)
+        expect(object).to have_received(:after_assigment)
       end
 
       it 'supports assign callbacks' do
         object = ExampleForUpdate.new
 
-        expect(object).to receive(:before_assigment)
-        expect(object).to receive(:after_assigment)
+        allow(object).to receive(:before_assignment)
+        allow(object).to receive(:after_assignment)
 
         object.update name: 'value'
+
+        expect(object).to have_received(:before_assignment)
+        expect(object).to have_received(:after_assignment)
       end
 
       it 'returns false when validations fail' do
@@ -266,9 +286,11 @@ module MiniForm
       it 'does not call "perfom" method when validation fail' do
         object = ExampleForUpdate.new name: nil
 
-        expect(object).not_to receive(:perform)
+        allow(object).to receive(:perform)
 
         object.update
+
+        expect(object).not_to have_received(:perform)
       end
     end
 
@@ -281,9 +303,11 @@ module MiniForm
       it 'calls update with given arguments' do
         object = Example.new
 
-        expect(object).to receive(:update).with(:attributes).and_return true
+        allow(object).to receive(:update).and_return true
 
         object.update! :attributes
+
+        expect(object).to have_received(:update).with(:attributes)
       end
 
       it 'raises error when update fails' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_form
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Radoslav Stankov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-28 00:00:00.000000000 Z
+date: 2017-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -42,16 +42,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement