mini_exiftool 1.4.2 → 1.4.4

data/Changelog

@@ -1,3 +1,10 @@
+v1.4.4
+- Fix escaping of values for older versions of Shellwords.
+
+v1.4.3
+- Fixing rubyforge bug [#29596] (Quotes in values)
+  Thanks to Michael Grove for reporting
+
 v1.4.2
 - Add .yardopts file to gem.
 

data/lib/mini_exiftool.rb

@@ -32,7 +32,7 @@ class MiniExiftool
   attr_reader :filename
   attr_accessor :numerical, :composite, :convert_encoding, :errors, :timestamps
 
-  VERSION = '1.4.2'
+  VERSION = '1.4.4'
 
   # +opts+ support at the moment
   # * <code>:numerical</code> for numerical values, default is +false+
@@ -154,7 +154,7 @@ class MiniExiftool
       arr_val.map! {|e| convert e}
       tag_params = ''
       arr_val.each do |v|
-        tag_params << %Q(-#{original_tag}="#{v}" )
+        tag_params << %Q(-#{original_tag}=#{Shellwords.escape(v.to_s)} )
       end
       opt_params = ''
       opt_params << (arr_val.detect {|x| x.kind_of?(Numeric)} ? '-n ' : '')

data/mini_exiftool.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = "mini_exiftool"
-  s.version = "1.4.2"
+  s.version = "1.4.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jan Friedrich"]
-  s.date = "2012-04-11"
+  s.date = "2012-05-31"
   s.description = "This library is wrapper for the Exiftool command-line application (http://www.sno.phy.queensu.ca/~phil/exiftool)."
   s.email = "janfri26@gmail.com"
   s.extra_rdoc_files = ["README.rdoc", "Tutorial.rdoc", "lib/mini_exiftool.rb"]
@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Mini_exiftool", "--main", "README.rdoc"]
   s.require_paths = ["lib"]
   s.rubyforge_project = "mini_exiftool"
-  s.rubygems_version = "1.8.21"
+  s.rubygems_version = "1.8.24"
   s.summary = "This library is wrapper for the Exiftool command-line application (http://www.sno.phy.queensu.ca/~phil/exiftool)."
   s.test_files = ["test/helpers_for_test.rb", "test/test_class_methods.rb", "test/test_composite.rb", "test/test_dumping.rb", "test/test_read.rb", "test/test_read_numerical.rb", "test/test_save.rb", "test/test_special.rb", "test/test_special_dates.rb", "test/test_write.rb"]
 

data/test/test_write.rb

@@ -55,6 +55,28 @@ class TestWrite < TestCase
     assert_equal true, @mini_exiftool_num.changed?
   end
 
+  # Catching rubyforge bug [#29596]
+  # Thanks to Michael Grove for reporting
+  # Part 1
+  def test_quotes_in_values
+    caption = "\"String in quotes\""
+    @mini_exiftool.caption = caption
+    assert_equal true, @mini_exiftool.save, 'Saving error'
+    @mini_exiftool.reload
+    assert_equal caption, @mini_exiftool.caption
+  end
+
+  # Catching rubyforge bug [#29596]
+  # Thanks to Michael Grove for reporting
+  # Part 2
+  def test_quotes_and_apostrophe_in_values
+    caption = caption = "\"Watch your step, it's slippery.\""
+    @mini_exiftool.caption = caption
+    assert_equal true, @mini_exiftool.save, 'Saving error'
+    @mini_exiftool.reload
+    assert_equal caption, @mini_exiftool.caption
+  end
+
   def test_time_conversion
     t = Time.now
     @mini_exiftool_num['DateTimeOriginal'] = t

metadata

@@ -1,25 +1,29 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: mini_exiftool
-version: !ruby/object:Gem::Version
-  version: 1.4.2
+version: !ruby/object:Gem::Version 
   prerelease: 
+  version: 1.4.4
 platform: ruby
-authors:
+authors: 
 - Jan Friedrich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-11 00:00:00.000000000 Z
+
+date: 2012-05-31 00:00:00 Z
 dependencies: []
+
 description: This library is wrapper for the Exiftool command-line application (http://www.sno.phy.queensu.ca/~phil/exiftool).
 email: janfri26@gmail.com
 executables: []
+
 extensions: []
-extra_rdoc_files:
+
+extra_rdoc_files: 
 - README.rdoc
 - Tutorial.rdoc
 - lib/mini_exiftool.rb
-files:
+files: 
 - COPYING
 - Changelog
 - Manifest
@@ -50,39 +54,42 @@ files:
 - mini_exiftool.gemspec
 homepage: http://gitorious.org/mini_exiftool
 licenses: []
-post_install_message: ! "\n+-----------------------------------------------------------------------+\n|
-  Please ensure you have installed exiftool and it's found in your PATH |\n| (Try
-  \"exiftool -ver\" on your commandline). For more details see       |\n| http://www.sno.phy.queensu.ca/~phil/exiftool/install.html
-  \            |\n+-----------------------------------------------------------------------+\n
-  \ "
-rdoc_options:
+
+post_install_message: "\n\
+  +-----------------------------------------------------------------------+\n\
+  | Please ensure you have installed exiftool and it's found in your PATH |\n\
+  | (Try \"exiftool -ver\" on your commandline). For more details see       |\n\
+  | http://www.sno.phy.queensu.ca/~phil/exiftool/install.html             |\n\
+  +-----------------------------------------------------------------------+\n  "
+rdoc_options: 
 - --line-numbers
 - --inline-source
 - --title
 - Mini_exiftool
 - --main
 - README.rdoc
-require_paths:
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '1.2'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "1.2"
 requirements: []
+
 rubyforge_project: mini_exiftool
-rubygems_version: 1.8.21
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: This library is wrapper for the Exiftool command-line application (http://www.sno.phy.queensu.ca/~phil/exiftool).
-test_files:
+test_files: 
 - test/helpers_for_test.rb
 - test/test_class_methods.rb
 - test/test_composite.rb