mingle_events 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d698d7bfba52d210386fcfcc08932d91c83e1eee
-  data.tar.gz: ecbc8067509a2d0c09d752f0f29e3b7c769b2a92
+  metadata.gz: 1653b5493ba56fce35515d2a49dc0a54e97667c4
+  data.tar.gz: 069cfd676643e547e4731385addff547abd468a9
 SHA512:
-  metadata.gz: 6dd16e77733ee7dbd5703bc82ca8201c5b52d89d7fdc81d7e08959b4e137f72ac52d4b5c1761c7b7a792bf0bd6aea3f1ff45036864359ba65e2a7ab5c11c40af
-  data.tar.gz: 64b001acbcd89fd8f45e11e43dfdb18069a22e41b4f4a14396e256ed57e65c3fb776be245e965b6fecb61289b92ebac50b8d7d08c42f9a3af25cc80e0e184a1c
+  metadata.gz: e13638f0c01b832cf57fb1f6d21fcd840e7a10243be789b3116cca122d03f395eb5d1c34adb685b901e4fb271fd9b599cf32840154ad0e4ae0874c118a3c061b
+  data.tar.gz: 5490fd62b2c4627754f0a11ac1ce2a0e3b1b8b5c9c1fafa5aa00be032b7d4d157feef0ca5f85c6dbff9b7c2cbb3c8c4bfb722156611ee49014e4ea9b4f48f148

data/lib/mingle_events/project_event_fetcher.rb

@@ -53,6 +53,23 @@ module MingleEvents
       @entry_cache.update_current_state(next_entry, most_recent_new_entry)
       @entry_cache.entries(next_entry, most_recent_new_entry)
     end
+
+    def clear_cache_if_first_entry_mismatch!
+      unless first_entry_cached_match?
+        reset
+      end
+    end
+
+    def first_entry_cached_match?
+      if first_entry_cached = first_entry_fetched
+        page = page_with_first_entries
+        if first_entry = page.entries.last
+          first_entry_fetched.entry_id == first_entry.entry_id
+        end
+      else
+        true
+      end
+    end
     
     # returns all previously fetched entries; can be used to reprocess the events for, say,
     # various historical analyses
@@ -72,6 +89,10 @@ module MingleEvents
     
     def page_with_latest_entries
       Feed::Page.new("/api/v2/projects/#{@project_identifier}/feeds/events.xml", @mingle_access)
-    end        
+    end
+        
+    def page_with_first_entries
+      Feed::Page.new("/api/v2/projects/#{@project_identifier}/feeds/events.xml?page=1", @mingle_access)
+    end
   end
 end

data/lib/mingle_events/zip_directory.rb

@@ -1,4 +1,6 @@
 module MingleEvents
+  class FileNotExist < StandardError; end
+
   class ZipDirectory
 
     def initialize(name)
@@ -24,7 +26,7 @@ module MingleEvents
 
     def file(path, &block)
       measure("read file") do
-        raise "File at '#{path}' in archive '#{@root}' dose not exisits" unless exists?(path)
+        raise FileNotExist, "File at '#{path}' in archive '#{@root}' dose not exisits" unless exists?(path)
         entry_map[path].open { |entry_stream| yield(entry_stream) }
       end
     end

data/test/mingle_events/project_event_fetcher_test.rb

@@ -109,8 +109,8 @@ module MingleEvents
       state_dir = temp_dir
       mingle_access = stub_mingle_access
       fetcher = ProjectEventFetcher.new('atlas', mingle_access, state_dir)
-
       fetcher.set_current_state_to_now_if_no_current_state
+
       assert fetcher.fetch_latest.to_a.empty?
 
       mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml',%{
@@ -196,6 +196,65 @@ module MingleEvents
       assert_equal([entry(104)], fetcher.fetch_latest.to_a)
     end
 
+    def test_should_clear_old_cache_if_the_first_event_does_not_match
+      state_dir = temp_dir
+      mingle_access = StubMingleAccess.new
+      mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml', EMPTY_EVENTS_XML)
+      fetcher = ProjectEventFetcher.new('atlas', mingle_access, state_dir)
+      assert fetcher.first_entry_cached_match?
+
+      mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml?page=1',%{
+        <feed xmlns="http://www.w3.org/2005/Atom" xmlns:mingle="http://www.thoughtworks-studios.com/ns/mingle">
+
+          <link href="https://mingle.example.com/api/v2/projects/atlas/feeds/events.xml?page=1" rel="current"/>
+          <link href="https://mingle.example.com/api/v2/projects/atlas/feeds/events.xml?page=1" rel="self"/>
+
+          <entry>
+            <id>https://mingle.example.com/projects/atlas/events/index/104</id>
+            <title>entry 104</title>
+            <updated>2011-02-03T08:14:42Z</updated>
+            <author><name>Bob</name></author>
+          </entry>
+        </feed>
+      })
+      mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml',%{
+        <feed xmlns="http://www.w3.org/2005/Atom" xmlns:mingle="http://www.thoughtworks-studios.com/ns/mingle">
+
+          <link href="https://mingle.example.com/api/v2/projects/atlas/feeds/events.xml" rel="current"/>
+          <link href="https://mingle.example.com/api/v2/projects/atlas/feeds/events.xml" rel="self"/>
+
+          <entry>
+            <id>https://mingle.example.com/projects/atlas/events/index/104</id>
+            <title>entry 104</title>
+            <updated>2011-02-03T08:14:42Z</updated>
+            <author><name>Bob</name></author>
+          </entry>
+        </feed>
+      })
+
+      fetcher.fetch_latest
+      assert_equal([entry(104)], fetcher.all_fetched_entries.to_a)
+      assert fetcher.first_entry_cached_match?
+
+      mingle_access.register_page_content('/api/v2/projects/atlas/feeds/events.xml?page=1',%{
+        <feed xmlns="http://www.w3.org/2005/Atom" xmlns:mingle="http://www.thoughtworks-studios.com/ns/mingle">
+
+          <link href="https://mingle.example.com/api/v2/projects/atlas/feeds/events.xml?page=1" rel="current"/>
+          <link href="https://mingle.example.com/api/v2/projects/atlas/feeds/events.xml?page=1" rel="self"/>
+
+          <entry>
+            <id>https://mingle.example.com/projects/atlas/events/index/105</id>
+            <title>entry 105</title>
+            <updated>2011-02-03T08:14:42Z</updated>
+            <author><name>Bob</name></author>
+          </entry>
+        </feed>
+      })
+      assert !fetcher.first_entry_cached_match?
+      fetcher.clear_cache_if_first_entry_mismatch!
+      assert_equal([], fetcher.all_fetched_entries.to_a)
+    end
+
     private
 
     def setup_current_state(first_entry_id, second_entry_id, last_entry_id, fetcher)

data/test/mingle_events/zip_directory_test.rb

@@ -18,6 +18,12 @@ module MingleEvents
       assert_equal 's' * 1000, @dir.file('a', &:read)
     end
 
+    def test_file_not_exist_error
+      assert_raises MingleEvents::FileNotExist do
+        @dir.file('a')
+      end
+    end
+
     def test_read_write_files_with_sub_directory
       @dir.write_file('a/b/c') { |f| f.write( 's' * 1000) }
       @dir.reload

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mingle_events
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - David Rice
@@ -201,7 +201,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '1.2'
 requirements: []
 rubyforge_project: mingle_events
-rubygems_version: 2.2.0
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 3
 summary: A gem that lets you process Mingle events in a pipes and filters style.