mimi-messaging-sqs_sns 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf7944b9a3e10f154f738d66544cfa63611b17a742b156460969f70821ad86bb
-  data.tar.gz: f26e3e3623208170de192174c9c0fdb2ef5e26fa8cca831e73065eb86e21b0b5
+  metadata.gz: d8ca2b61a4f7cc802b628397b74d45a19f81dd50cf7d285bfc813922e17e7327
+  data.tar.gz: fea7216f18b7707cedefaac1090349791c01f35b76f0a3019531039e28e8a39e
 SHA512:
-  metadata.gz: 37bbb87ba16df4886a5e525ca13732b3712021c5269418d8d8c90e1af125cbaa7e32aa5757a96293569a1717cc4c00542aaf20d12f3fc7514477cd3d708cd615
-  data.tar.gz: 9d53cc0479c47af711f0e89203f9ef1ced767115743fb2fa685ea559ebb0b891226a248219ff2103ec95207b678814c1c0b983f82a22eda8e741feac01a2d4dc
+  metadata.gz: c4734aef7603919fe1485b1403fe63cfe3751b25ca0c753336b1567b524817ad68d9a0255fb14a993f365d58963b3a5a894bb02b338eac19d2af01303455510b
+  data.tar.gz: 017f5eb8d84cb0b10196c6a76fee01b5c1f3909c3b3eca2883e729992b02370f9be9827639858cbcb7e68beb02c35e4ac6cc9b5f40726b9e8faaccf5c8ee7eb6

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## UNRELEASED
 
+## v0.8.1
+
+* [#5](https://github.com/kukushkin/mimi-messaging-sqs_sns/pull/5)
+  * Refactored worker pool based message processing and error handling
+
 ## v0.8.0
 
 * [#3](https://github.com/kukushkin/mimi-messaging-sqs_sns/pull/3)

data/TODO.md

@@ -3,7 +3,7 @@
 List of missing features planned for future releases.
 
 * [X] Log error and recover if the reply cannot be sent
-* [ ] Threadsafe TimeoutQueue
-* [ ] Multithreaded consumers
+* [X] Threadsafe TimeoutQueue
+* [X] Multithreaded consumers
 * [ ] Subscribe to topic without a queue (Temporary queues)
 

data/lib/mimi/messaging/sqs_sns/adapter.rb

@@ -186,14 +186,7 @@ module Mimi
           opts = opts.dup
           queue_url = find_or_create_queue(queue_name)
           @consumers << Consumer.new(self, queue_url) do |m|
-            worker_pool.post do
-              process_request_message(processor, m)
-            end
-          rescue Concurrent::RejectedExecutionError
-            # the backlog is overflown, put the message back
-            Mimi::Messaging.log "Worker pool backlog is full, nack-ing the message " \
-              "(workers:#{worker_pool.length}, backlog:#{worker_pool.queue_length})"
-            raise Mimi::Messaging::NACK # exception raised in Consumer thread
+            process_request_message(processor, m)
           end
         end
 
@@ -210,14 +203,7 @@ module Mimi
           queue_url = find_or_create_queue(queue_name)
           subscribe_topic_queue(topic_arn, queue_url)
           @consumers << Consumer.new(self, queue_url) do |m|
-            worker_pool.post do
-              process_event_message(processor, m)
-            end
-          rescue Concurrent::RejectedExecutionError
-            # the backlog is overflown, put the message back
-            Mimi::Messaging.log "Worker pool backlog is full, nack-ing the message " \
-              "(workers:#{worker_pool.length}, backlog:#{worker_pool.queue_length})"
-            raise Mimi::Messaging::NACK # exception raised in Consumer thread
+            process_event_message(processor, m)
           end
         end
 

data/lib/mimi/messaging/sqs_sns/consumer.rb

@@ -48,14 +48,17 @@ module Mimi
           return unless message
 
           Mimi::Messaging.log "Read message from: #{queue_url}"
-          block.call(message)
-          ack_message(adapter, queue_url, message)
-        rescue Mimi::Messaging::NACK
-          Mimi::Messaging.log "NACK-ing message from: #{queue_url}"
+          adapter.worker_pool.post do
+            process_message(adapter, queue_url, message, block)
+          end
+        rescue Concurrent::RejectedExecutionError
+          # the backlog is overflown, put the message back
+          Mimi::Messaging.log "Worker pool backlog is full, nack-ing the message " \
+            "(workers:#{adapter.worker_pool.length}, backlog:#{adapter.worker_pool.queue_length})"
           nack_message(adapter, queue_url, message)
         rescue StandardError => e
           Mimi::Messaging.logger&.error(
-            "#{self.class}: failed to read and process message from: #{queue_url}," \
+            "#{self.class}: failed to read or process message from: #{queue_url}," \
             " error: (#{e.class}) #{e}"
           )
         end
@@ -73,6 +76,20 @@ module Mimi
           raise Mimi::Messaging::ConnectionError, "Unexpected number of messages read"
         end
 
+        def process_message(adapter, queue_url, message, block)
+          block.call(message)
+          ack_message(adapter, queue_url, message)
+        rescue Mimi::Messaging::NACK
+          Mimi::Messaging.log "NACK-ing message from: #{queue_url}"
+          nack_message(adapter, queue_url, message)
+        rescue StandardError => e
+          Mimi::Messaging.logger&.error(
+            "#{self.class}: failed to process message from: #{queue_url}," \
+            " error: (#{e.class}) #{e}"
+          )
+          # NOTE: message is neither ACKed or NACKed
+        end
+
         # ACK-ing the message indicates successfull processing of it
         # and removes the message from the queue
         #

data/lib/mimi/messaging/sqs_sns/version.rb

@@ -3,7 +3,7 @@
 module Mimi
   module Messaging
     module SQS_SNS
-      VERSION = "0.8.0"
+      VERSION = "0.8.1"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mimi-messaging-sqs_sns
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Alex Kukushkin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-16 00:00:00.000000000 Z
+date: 2021-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mimi-messaging