milkfarm-onix 0.8.8 → 0.8.9

data/CHANGELOG

@@ -1,3 +1,9 @@
+v0.8.9 (24 March 2011)
+- Add RelatedProduct composite (PR.23.7 - PR.23.33)
+- Create ProductIdentifiers module
+- Create ListWriter module
+- WARNING: Set methods product_identifier, product_identifier_set removed
+
 v0.8.8 (15 March 2011)
 - Format EpubType value as 3-digit, padded number
 

data/lib/onix/list_writer.rb

@@ -0,0 +1,21 @@
+# coding: utf-8
+
+module ONIX
+  module ListWriter
+    
+    def list_writer(name, options = {})
+      options.symbolize_keys!
+      unless options.is_a?(Hash) && options[:list].is_a?(Integer)
+        raise ArgumentError, "Must specify code list number as ':list => Integer'"
+      end
+      define_method("#{name}=") do |value|
+        if value.nil? || ONIX::Lists.list(options[:list]).keys.include?(value)
+          self.instance_variable_set("@#{name}", value)
+        else
+          raise ArgumentError, "Invalid #{("_" + name.to_s).downcase.gsub!(/_(.)/) { $1.upcase }} '#{value}' -- Refer to ONIX Code List #{options[:list]}"
+        end
+      end
+    end
+    
+  end
+end

data/lib/onix/product.rb

@@ -3,6 +3,7 @@
 module ONIX
   class Product
     include ROXML
+    extend ONIX::ListWriter
 
     xml_name "Product"
 
@@ -12,6 +13,7 @@ module ONIX
     xml_accessor :product_form, :from => "ProductForm"
     xml_accessor :product_form_detail, :from => "ProductFormDetail"
     xml_reader   :epub_type, :from => "EpubType", :as => Fixnum, :to_xml => ONIX::Formatters.three_digit
+    list_writer  :epub_type, :list => 10
     xml_accessor :series, :from => "Series", :as => [ONIX::Series]
     xml_accessor :sets, :from => "Set", :as => [ONIX::Set]
     xml_accessor :titles, :from => "Title", :as => [ONIX::Title]
@@ -42,6 +44,7 @@ module ONIX
     xml_accessor :year_first_published, :from => "YearFirstPublished", :as => Fixnum
     xml_accessor :sales_restrictions, :from => "SalesRestriction", :as => [ONIX::SalesRestriction]
     xml_accessor :measurements, :from => "Measure", :as => [ONIX::Measure]
+    xml_accessor :related_products, :from => "RelatedProduct", :as => [ONIX::RelatedProduct]
     xml_accessor :supply_details, :from => "SupplyDetail", :as => [ONIX::SupplyDetail]
     xml_accessor :market_representations, :from => "MarketRepresentation", :as => [ONIX::MarketRepresentation]
 
@@ -71,19 +74,10 @@ module ONIX
       self.publishers = []
       self.sales_restrictions = []
       self.measurements = []
+      self.related_products = []
       self.supply_details = []
       self.market_representations = []
     end
     
-    # TODO: Refactor writer methods using method_missing
-    def epub_type=(new_epub_type)
-      if new_epub_type.nil? || ONIX::Lists.list(10).keys.include?(new_epub_type)
-        # ProductForm code must equal DG if EpubType element is present
-        @product_form = "DG"
-        @epub_type = new_epub_type
-      else
-        raise "Invalid EpubType #{new_epub_type}"
-      end
-    end
   end
 end

data/lib/onix/product_identifiers.rb

@@ -0,0 +1,63 @@
+# coding: utf-8
+
+module ONIX
+  module ProductIdentifiers
+    ACCESSOR_METHODS = {:proprietary_id => 1, :ean => 3, :isbn10 => 2, :isbn13 => 15, :isbn => 15, :lccn => 13}
+    
+    def initialize_product_identifiers(options)
+      @product_identifiers ||= []
+      ACCESSOR_METHODS.keys.push(:product_identifiers).each do |name|
+        self.send("#{name}=", options[name]) if options[name]
+      end
+    end
+    
+    ACCESSOR_METHODS.each do |name, digit|
+      define_method(name) do
+        identifier(digit).andand.id_value
+      end
+      define_method("#{name}=") do |value|
+        identifier_set(digit, value)
+      end
+    end
+    
+    def product_identifiers
+      @product_identifiers ||= []
+    end
+
+    private
+    
+    def product_identifiers=(values)
+      values = [values] if values.nil? || values.is_a?(ONIX::ProductIdentifier)
+      if values.is_a?(Array)
+        # Empty array
+        @product_identifiers = []
+        # Add any valid value
+        values.each do |value|
+          @product_identifiers << value if value.is_a?(ONIX::ProductIdentifier)
+        end
+      else
+        raise ArgumentError, "Invalid ProductIdentifier value: #{values.inspect}"
+      end
+    end
+
+    # find the ProductIdentifier matching a particular type
+    def identifier(type)
+      @product_identifiers.find { |obj| obj.product_id_type == type }
+    end
+
+    # set the value of a particular ProductIdentifier (found by type)
+    def identifier_set(type, value)
+      obj = identifier(type)
+
+      # create a new product identifier object if we necessary
+      if obj.nil?
+        obj = ONIX::ProductIdentifier.new
+        obj.product_id_type = type
+        @product_identifiers << obj
+      end
+
+      obj.id_value = value
+    end
+    
+  end
+end

data/lib/onix/related_product.rb

@@ -0,0 +1,22 @@
+# coding: utf-8
+
+module ONIX
+  class RelatedProduct
+    include ROXML
+    include ONIX::ProductIdentifiers
+    extend ONIX::ListWriter
+    
+    xml_name "RelatedProduct"
+
+    xml_reader :relation_code, :from => "RelationCode", :as => Fixnum, :to_xml => ONIX::Formatters.two_digit
+    xml_reader :product_identifiers, :from => "ProductIdentifier", :as => [ONIX::ProductIdentifier]
+    list_writer :relation_code, :list => 51
+    
+    def initialize(options = {})
+      options.symbolize_keys!
+      self.relation_code = options[:relation_code]
+      self.initialize_product_identifiers(options) # Must be called to setup @product_identifiers array
+    end
+    
+  end
+end

data/lib/onix/set.rb

@@ -3,74 +3,26 @@
 module ONIX
   class Set
     include ROXML
+    include ONIX::ProductIdentifiers
 
     xml_name "Set"
 
-    xml_accessor :product_identifiers, :from => "ProductIdentifier", :as => [ONIX::ProductIdentifier]
+    xml_reader :product_identifiers, :from => "ProductIdentifier", :as => [ONIX::ProductIdentifier]
     xml_accessor :title_of_set, :from => "TitleOfSet"
     
-    def initialize
-      self.product_identifiers = []
+    def initialize(options = {})
+      options.symbolize_keys!
+      self.initialize_product_identifiers(options) # Must be called to setup @product_identifiers array
     end
     
-    # retrieve the proprietary set ID
-    def proprietary_set_id
-      product_identifier(1).andand.id_value
-    end
-
-    # set a new proprietary set ID
-    def proprietary_set_id=(id)
-      product_identifier_set(1, id)
-    end
+    # Following methods removed os of gem 0.8.9 (aliased for backwards compatible):
+    alias_method :proprietary_set_id, :proprietary_id
+    alias_method :proprietary_set_id=, :proprietary_id=
     
-    # retrieve the 10-digit isbn
-    def isbn10
-      product_identifier(2).andand.id_value
-    end
-
-    # set a new 10-digit isbn
-    def isbn10=(id)
-      product_identifier_set(2, id)
-    end
+    # Following methods removed os of gem 0.8.9 (NOT backwards compatible):
+    #   original method -> replacement method
+    #   product_identifier(type) -> see product_identifiers.rb (eg, use isbn, lccn...)
+    #   product_identifier_set(type, value) -> see product_identifiers.rb (eg, use isbn=, lccn=...)
     
-    # retrieve the 13-digit isbn
-    def isbn
-      product_identifier(15).andand.id_value
-    end
-
-    # set a new 13-digit isbn
-    def isbn=(id)
-      product_identifier_set(15, id)
-    end
-    
-    # retrieve the lccn
-    def lccn
-      product_identifier(13).andand.id_value
-    end
-
-    # set a new lccn
-    def lccn=(id)
-      product_identifier_set(13, id)
-    end
-    
-    # retrieve the value of a particular ID
-    def product_identifier(type)
-      identifier = product_identifiers.find { |id| id.product_id_type == type }
-    end
-
-    # set the value of a particular ID
-    def product_identifier_set(type, value)
-      product_identifier_id = product_identifiers.find { |id| id.product_id_type == type }
-      
-      # create a new set identifier record if we need to
-      if product_identifier_id.nil?
-        product_identifier_id = ONIX::ProductIdentifier.new
-      end
-      
-      product_identifier_id.product_id_type = type
-      product_identifier_id.id_value = value
-      
-      product_identifiers << product_identifier_id
-    end
   end
 end

data/lib/onix/sl_product.rb

@@ -8,6 +8,7 @@ module ONIX
     delegate :product_form_detail, :product_form_detail=
     delegate :basic_main_subject, :basic_main_subject=
     delegate :epub_type, :epub_type=
+    delegate :related_products, :related_products=
     
     # retrieve the value of a particular ID
     def series(str)
@@ -63,14 +64,28 @@ module ONIX
       # process based on value type
       if value.is_a?(WorkIdentifier)
         str = value.id_value
-        work_identifier_obj = value
+        obj = value
       else
         str = value
-        work_identifier_obj = ONIX::WorkIdentifier.new(:work_id_type => type, :id_value => value)
+        obj = ONIX::WorkIdentifier.new(:work_id_type => type, :id_value => value)
       end
       # check if exists already
       unless work_identifier(str)
-        product.work_identifiers << work_identifier_obj
+        product.work_identifiers << obj
+      end
+    end
+    
+    # find the related_product that has relation_code 5
+    def replacement
+      product.related_products.find { |obj| obj.relation_code == 5 }
+    end
+    
+    # set the proprietary_id of the replacement product
+    def replacement=(value)
+      if obj = replacement
+        obj.proprietary_id = value
+      else
+        product.related_products << ONIX::RelatedProduct.new(:relation_code => 5, :proprietary_id => value)
       end
     end
     

data/lib/onix/version.rb

@@ -1,3 +1,3 @@
 module ONIX
-  VERSION = "0.8.8"
+  VERSION = "0.8.9"
 end

data/lib/onix/work_identifier.rb

@@ -3,12 +3,14 @@
 module ONIX
   class WorkIdentifier
     include ROXML
+    extend ONIX::ListWriter
     
     xml_name "WorkIdentifier"
     
     xml_reader :work_id_type, :from => "WorkIDType", :as => Fixnum, :to_xml => ONIX::Formatters.two_digit
     xml_accessor :id_type_name, :from => "IDTypeName"
     xml_accessor :id_value, :from => "IDValue"
+    list_writer :work_id_type, :list => 16
     
     def initialize(options = {})
       options.symbolize_keys!
@@ -17,12 +19,5 @@ module ONIX
       @id_value = options[:id_value]
     end
     
-    def work_id_type=(new_work_id_type)
-      if new_work_id_type.nil? || ::ONIX::Lists.list(16).keys.include?(new_work_id_type)
-        @work_id_type = new_work_id_type
-      else
-        raise "Invalid WorkIDType #{new_work_id_type}"
-      end
-    end
   end
 end

data/lib/onix.rb

@@ -55,9 +55,11 @@ end
 # core files
 # - ordering is important, classes need to be defined before any
 #   other class can use them
+require File.join(File.dirname(__FILE__), "onix", "list_writer")
 require File.join(File.dirname(__FILE__), "onix", "sender_identifier")
 require File.join(File.dirname(__FILE__), "onix", "addressee_identifier")
 require File.join(File.dirname(__FILE__), "onix", "header")
+require File.join(File.dirname(__FILE__), "onix", "product_identifiers")
 require File.join(File.dirname(__FILE__), "onix", "product_identifier")
 require File.join(File.dirname(__FILE__), "onix", "series_identifier")
 require File.join(File.dirname(__FILE__), "onix", "series")
@@ -76,6 +78,7 @@ require File.join(File.dirname(__FILE__), "onix", "media_file")
 require File.join(File.dirname(__FILE__), "onix", "sales_restriction")
 require File.join(File.dirname(__FILE__), "onix", "stock")
 require File.join(File.dirname(__FILE__), "onix", "price")
+require File.join(File.dirname(__FILE__), "onix", "related_product")
 require File.join(File.dirname(__FILE__), "onix", "supply_detail")
 require File.join(File.dirname(__FILE__), "onix", "market_representation")
 require File.join(File.dirname(__FILE__), "onix", "measure")

data/spec/list_writer_spec.rb

@@ -0,0 +1,46 @@
+# coding: utf-8
+
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+describe ONIX::ListWriter do
+  
+  module ONIX
+    class FakeEntity
+      include ROXML
+      extend ONIX::ListWriter
+      
+      xml_name "FakeEntity"
+      xml_reader :series_id_type, :from => "SeriesIDType", :as => Fixnum, :to_xml => ONIX::Formatters.two_digit
+      list_writer :series_id_type, :list => 13
+      
+      def initialize(options = {})
+        self.series_id_type = options[:series_id_type]
+      end
+    end
+  end
+  
+  before :each do
+    data_path = File.join(File.dirname(__FILE__),"..","data")
+    file1 = File.join(data_path, "fake_entity_for_lists.xml")
+    @doc = Nokogiri::XML::Document.parse(File.read(file1))
+    @root = @doc.root
+  end
+  
+  it "should provide read access to first level attribute" do
+    fake = ONIX::FakeEntity.from_xml(@root.to_s)
+    fake.series_id_type.should eql(1)
+  end
+  
+  it "should provide write access to first level attribute" do
+    fake = ONIX::FakeEntity.new(:series_id_type => 3)
+    fake.series_id_type.should eql(3)
+    fake.to_xml.to_s.include?("<SeriesIDType>03</SeriesIDType>").should be_true
+  end
+  
+  it "should raise error writing value not in list" do
+    fake = ONIX::FakeEntity.new
+    lambda {fake.series_id_type = 100}.should raise_error
+    lambda {ONIX::FakeEntity.new(:series_id_type => 100)}.should raise_error
+  end
+
+end

data/spec/product_identifiers_spec.rb

@@ -0,0 +1,71 @@
+# coding: utf-8
+
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+describe ONIX::ProductIdentifiers do
+  
+  module ONIX
+    class FakeEntity
+      include ROXML
+      include ONIX::ProductIdentifiers
+      
+      xml_name "FakeEntity"
+      xml_reader :product_identifiers, :from => "ProductIdentifier", :as => [ONIX::ProductIdentifier]
+      
+      def initialize(options = {})
+        self.initialize_product_identifiers(options)
+      end
+    end
+  end
+  
+  before :each do
+    @fake = ONIX::FakeEntity.new(:isbn => 123456)
+    data_path = File.join(File.dirname(__FILE__),"..","data")
+    file1 = File.join(data_path, "fake_entity.xml")
+    @doc = Nokogiri::XML::Document.parse(File.read(file1))
+    @root = @doc.root
+  end
+  
+  it "should instantiate product identifiers array" do
+    @fake.product_identifiers.should be_a(Array)
+  end
+  
+  it "should provide read access to product identifiers" do
+    fe = ONIX::FakeEntity.from_xml(@root.to_s)
+    fe.proprietary_id.should eql("PROPRIETARY_ID")
+    fe.isbn10.should eql("ISBN10")
+    fe.isbn.should eql("ISBN13")
+    fe.isbn13.should eql("ISBN13")
+    fe.ean.should eql("EAN")
+    fe.lccn.should eql("LCCN")
+  end
+
+  it "should provide write access to product identifiers" do
+    id_value = "123456"
+    {:proprietary_id => 1, :ean => 3, :isbn10 => 2, :isbn13 => 15, :isbn => 15, :lccn => 13}.each do |key, product_id_type|
+      fe = ONIX::FakeEntity.new(key => id_value)
+      fe.to_xml.to_s.include?("<ProductIDType>#{sprintf('%02d', product_id_type)}</ProductIDType>").should be_true
+      fe.to_xml.to_s.include?("<IDValue>#{id_value}</IDValue>").should be_true
+    end
+  end
+  
+  it "should provide write access to product_identifiers array" do
+    id = ONIX::ProductIdentifier.new
+    id.product_id_type = 1
+    id.id_value = "123456"
+    fe = ONIX::FakeEntity.new(:product_identifiers => id)
+  
+    fe.to_xml.to_s.include?("<ProductIdentifier>").should be_true
+    fe.to_xml.to_s.include?("<ProductIDType>01</ProductIDType>").should be_true
+    fe.to_xml.to_s.include?("<IDValue>123456</IDValue>").should be_true
+  
+    id = ONIX::ProductIdentifier.new
+    id.product_id_type = 2
+    id.id_value = "987654"
+    fe.product_identifiers << id
+  
+    fe.to_xml.to_s.include?("<ProductIDType>02</ProductIDType>").should be_true
+    fe.to_xml.to_s.include?("<IDValue>987654</IDValue>").should be_true
+  end
+
+end

data/spec/related_product_spec.rb

@@ -0,0 +1,45 @@
+# coding: utf-8
+
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+describe ONIX::RelatedProduct do
+
+  before(:each) do
+    data_path = File.join(File.dirname(__FILE__),"..","data")
+    file1    = File.join(data_path, "related_product.xml")
+    @doc = Nokogiri::XML::Document.parse(File.read(file1))
+    @root = @doc.root
+  end
+
+  it "should correctly convert to a string" do
+    rp = ONIX::RelatedProduct.from_xml(@root.to_s)
+    rp.to_xml.to_s[0,16].should eql("<RelatedProduct>")
+  end
+
+  it "should provide read access to relation_code" do
+    rp = ONIX::RelatedProduct.from_xml(@root.to_s)
+    rp.relation_code.should eql(5)
+  end
+
+  it "should provide write access to relation_code" do
+    rp = ONIX::RelatedProduct.new(:relation_code => 1)
+    rp.to_xml.to_s.include?("<RelationCode>01</RelationCode>").should be_true
+    
+    rp.relation_code = 2
+    rp.to_xml.to_s.include?("<RelationCode>02</RelationCode>").should be_true
+  end
+  
+  # This is essentially testing product_identifers.rb module
+  it "should provide read access to proprietary_id" do
+    rp = ONIX::RelatedProduct.from_xml(@root.to_s)
+    rp.proprietary_id.should eql("123456")
+  end
+  
+  # This is essentially testing product_identifers.rb module
+  it "should provide write access to proprietary_id" do
+    rp = ONIX::RelatedProduct.new(:proprietary_id => 123456)
+    rp.to_xml.to_s.include?("<ProductIDType>01</ProductIDType>").should be_true
+    rp.to_xml.to_s.include?("<IDValue>123456</IDValue>").should be_true
+  end
+
+end

data/spec/set_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::Set" do
+describe ONIX::Set do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,18 +11,18 @@ context "ONIX::Set" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     set = ONIX::Set.from_xml(@root.to_s)
     set.to_xml.to_s[0,5].should eql("<Set>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     set = ONIX::Set.from_xml(@root.to_s)
 
     set.title_of_set.should eql("Citizens and Their Governments")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     set = ONIX::Set.new
 
     set.title_of_set = "Cool Science Careers"

data/spec/sl_product_spec.rb

@@ -3,43 +3,45 @@
 require File.dirname(__FILE__) + '/spec_helper.rb'
 require 'date'
 
-context "ONIX::SLProduct" do
+describe ONIX::SLProduct do
 
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")
-    file1    = File.join(@data_path, "product.xml")
+    file1    = File.join(@data_path, "sl_product.xml")
     @doc     = Nokogiri::XML::Document.parse(File.read(file1))
     @product_node = @doc.root
   end
 
-  specify "should provide read access to attributes" do
-    @product = ONIX::Product.from_xml(@product_node.to_s)
-    @sl     = ONIX::SLProduct.new(@product)
+  it "should provide read access to attributes" do
+    @product  = ONIX::Product.from_xml(@product_node.to_s)
+    @sl       = ONIX::SLProduct.new(@product)
 
-    @sl.record_reference.should eql("365-9780194351898")
+    @sl.record_reference.should eql("200002")
     @sl.notification_type.should eql(3)
-    @sl.product_form.should eql("BC")
-    @sl.number_of_pages.should eql(100)
-    @sl.bic_main_subject.should eql("EB")
+    @sl.product_form.should eql("BB")
+    @sl.number_of_pages.should eql(32)
+    @sl.basic_main_subject.should eql("JNF053090")
     @sl.publishing_status.should eql(4)
-    @sl.publication_date.should eql(Date.civil(1998,9,1))
-    @sl.pack_quantity.should eql(12)
+    @sl.publication_date.should eql(Date.civil(2007,8,1))
+    @sl.related_products.should be_a(Array)
+    @sl.related_products[0].should be_a(ONIX::RelatedProduct)
+    @sl.related_products[0].relation_code.should eql(5)
   end
 
-  specify "should provide write access to attributes" do
+  it "should provide write access to attributes" do
     sl = ONIX::SLProduct.new
 
     sl.notification_type = 3
     sl.to_xml.to_s.include?("<NotificationType>03</NotificationType>").should be_true
 
-    sl.record_reference = "365-9780194351898"
-    sl.to_xml.to_s.include?("<RecordReference>365-9780194351898</RecordReference>").should be_true
+    sl.record_reference = "200002"
+    sl.to_xml.to_s.include?("<RecordReference>200002</RecordReference>").should be_true
 
-    sl.product_form = "BC"
-    sl.to_xml.to_s.include?("<ProductForm>BC</ProductForm>").should be_true
+    sl.product_form = "BB"
+    sl.to_xml.to_s.include?("<ProductForm>BB</ProductForm>").should be_true
 
-    sl.number_of_pages = 100
-    sl.to_xml.to_s.include?("<NumberOfPages>100</NumberOfPages>").should be_true
+    sl.number_of_pages = 32
+    sl.to_xml.to_s.include?("<NumberOfPages>32</NumberOfPages>").should be_true
 
     sl.basic_main_subject = "JNF053090"
     sl.to_xml.to_s.include?("<BASICMainSubject>JNF053090</BASICMainSubject>").should be_true
@@ -47,17 +49,50 @@ context "ONIX::SLProduct" do
     sl.publishing_status = 4
     sl.to_xml.to_s.include?("<PublishingStatus>04</PublishingStatus>").should be_true
 
-    sl.publication_date = Date.civil(1998,9,1)
-    sl.to_xml.to_s.include?("<PublicationDate>19980901</PublicationDate>").should be_true
+    sl.publication_date = Date.civil(2007,8,1)
+    sl.to_xml.to_s.include?("<PublicationDate>20070801</PublicationDate>").should be_true
+    
+    id = ONIX::ProductIdentifier.new
+    id.product_id_type = 1
+    id.id_value = "123456"
+    sl.related_products = [ONIX::RelatedProduct.new(:relation_code => 1, :product_identifiers => id)]
+    sl.related_products << ONIX::RelatedProduct.new(:relation_code => 2, :product_identifiers => id)
+    sl.related_products[0].to_xml.to_s.include?("<RelationCode>01</RelationCode>").should be_true
+    sl.related_products[1].to_xml.to_s.include?("<RelationCode>02</RelationCode>").should be_true
+  end
+  
+  it "should provide read access to replacement" do
+    @product  = ONIX::Product.from_xml(@product_node.to_s)
+    @sl       = ONIX::SLProduct.new(@product)
 
-    sl.pack_quantity = 12
-    sl.to_xml.to_s.include?("<PackQuantity>12</PackQuantity>").should be_true
+    @sl.replacement.relation_code.should eql(5)
+    @sl.replacement.proprietary_id.should eql("123456")
+  end
+  
+  it "should provide write access to replacement" do
+    sl = ONIX::SLProduct.new
+    
+    sl.replacement = "XYZ123"
+    sl.related_products[0].to_xml.to_s.include?("<RelationCode>05</RelationCode>").should be_true
+    sl.related_products[0].to_xml.to_s.include?("<ProductIDType>01</ProductIDType>").should be_true
+    sl.related_products[0].to_xml.to_s.include?("<IDValue>XYZ123</IDValue>").should be_true
+  end
+  
+  it "should provide write access to epub_type" do
+    sl = ONIX::SLProduct.new
+    sl.epub_type = 1
+    sl.to_xml.to_s.include?("<EpubType>001</EpubType>").should be_true
+  end
+  
+  it "should raise error when writing invalid epub_type" do
+    sl = ONIX::SLProduct.new
+    lambda {sl.epub_type = 999}.should raise_error
   end
 
 end
 
-context ONIX::SLProduct, "series method" do
-  specify "should set the nested series value on the underlying product class" do
+describe ONIX::SLProduct, "series method" do
+  it "should set the nested series value on the underlying product class" do
     sl = ONIX::SLProduct.new
 
     sl.series = "Harry Potter"
@@ -67,7 +102,7 @@ context ONIX::SLProduct, "series method" do
   end
 end
 
-context ONIX::SLProduct, "price method" do
+describe ONIX::SLProduct, "price method" do
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(@data_path, "usd.xml")
@@ -75,7 +110,7 @@ context ONIX::SLProduct, "price method" do
     @product_node = @doc.root
   end
 
-  specify "should return the first price in the file, regardless of type" do
+  it "should return the first price in the file, regardless of type" do
     @product = ONIX::Product.from_xml(@product_node.to_s)
     @sl     = ONIX::SLProduct.new(@product)
 
@@ -83,7 +118,7 @@ context ONIX::SLProduct, "price method" do
   end
 end
 
-context ONIX::SLProduct, "rrp_exc_sales_tax method" do
+describe ONIX::SLProduct, "rrp_exc_sales_tax method" do
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")
     file1    = File.join(@data_path, "usd.xml")
@@ -91,7 +126,7 @@ context ONIX::SLProduct, "rrp_exc_sales_tax method" do
     @product_node = @doc.root
   end
 
-  specify "should return the first price in the file of type 1" do
+  it "should return the first price in the file of type 1" do
     @product = ONIX::Product.from_xml(@product_node.to_s)
     @sl     = ONIX::SLProduct.new(@product)
 

data/spec/work_identifier_spec.rb

@@ -35,5 +35,11 @@ describe ONIX::WorkIdentifier do
     t.id_value = "ABC123"
     t.to_xml.to_s.include?("<IDValue>ABC123</IDValue>").should be_true
   end
+  
+  it "should raise error writing work_id_type value not in list" do
+    t = ONIX::WorkIdentifier.new
+    lambda {t.work_id_type = 999}.should raise_error
+    lambda {ONIX::WorkIdentifier.new(:work_id_type => 999)}.should raise_error
+  end
 
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: milkfarm-onix
 version: !ruby/object:Gem::Version 
-  hash: 47
+  hash: 45
   prerelease: 
   segments: 
   - 0
   - 8
-  - 8
-  version: 0.8.8
+  - 9
+  version: 0.8.9
 platform: ruby
 authors: 
 - James Healy
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-15 00:00:00 -07:00
+date: 2011-03-24 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -126,6 +126,7 @@ files:
 - lib/onix/header.rb
 - lib/onix/imprint.rb
 - lib/onix/language.rb
+- lib/onix/list_writer.rb
 - lib/onix/lists.rb
 - lib/onix/market_representation.rb
 - lib/onix/measure.rb
@@ -135,8 +136,10 @@ files:
 - lib/onix/price.rb
 - lib/onix/product.rb
 - lib/onix/product_identifier.rb
+- lib/onix/product_identifiers.rb
 - lib/onix/publisher.rb
 - lib/onix/reader.rb
+- lib/onix/related_product.rb
 - lib/onix/sales_restriction.rb
 - lib/onix/sender_identifier.rb
 - lib/onix/series.rb
@@ -335,6 +338,7 @@ files:
 - spec/header_spec.rb
 - spec/imprint_spec.rb
 - spec/language_spec.rb
+- spec/list_writer_spec.rb
 - spec/lists_spec.rb
 - spec/market_representation_spec.rb
 - spec/measure_spec.rb
@@ -343,9 +347,11 @@ files:
 - spec/other_text_spec.rb
 - spec/price_spec.rb
 - spec/product_identifier_spec.rb
+- spec/product_identifiers_spec.rb
 - spec/product_spec.rb
 - spec/publisher_spec.rb
 - spec/reader_spec.rb
+- spec/related_product_spec.rb
 - spec/sales_restriction_spec.rb
 - spec/sender_identifier.rb
 - spec/series_identifier_spec.rb
@@ -403,6 +409,7 @@ test_files:
 - spec/header_spec.rb
 - spec/imprint_spec.rb
 - spec/language_spec.rb
+- spec/list_writer_spec.rb
 - spec/lists_spec.rb
 - spec/market_representation_spec.rb
 - spec/measure_spec.rb
@@ -411,9 +418,11 @@ test_files:
 - spec/other_text_spec.rb
 - spec/price_spec.rb
 - spec/product_identifier_spec.rb
+- spec/product_identifiers_spec.rb
 - spec/product_spec.rb
 - spec/publisher_spec.rb
 - spec/reader_spec.rb
+- spec/related_product_spec.rb
 - spec/sales_restriction_spec.rb
 - spec/sender_identifier.rb
 - spec/series_identifier_spec.rb