mikehale-akismet 0.0.4 → 0.1.0

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:minor: 0
-:patch: 4
+:minor: 1
+:patch: 0
 :major: 0

data/lib/akismet.rb

@@ -23,10 +23,12 @@ class Akismet
 
     case response.body
     when "invalid"
-      raise Akismet::VerifyException, response.to_hash["x-akismet-debug-help"], caller
+      raise Akismet::VerifyError, response.to_hash["x-akismet-debug-help"], caller
     when "valid"
       true
     end
+  rescue SocketError => e
+    raise Akismet::VerifyError, e, caller
   end
   
   def submit_spam(args)
@@ -58,6 +60,8 @@ class Akismet
     when "false"
       false
     end
+  rescue SocketError => e
+    raise Akismet::CheckError, e, caller
   end
   
   def post_data(hash)
@@ -68,5 +72,6 @@ class Akismet
     end.join('&')
   end
 
-  class VerifyException < Exception; end
+  class VerifyError < StandardError; end
+  class CheckError < StandardError; end
 end

data/spec/akismet_spec.rb

@@ -44,7 +44,7 @@ describe "Akismet" do
   
   it "should not verify an invalid key" do
     map Rack::URLMap.new("http://rest.akismet.com/" => lambda { |env| [200, {'x-akismet-debug-help' => 'sorry!'}, ["invalid"]]})    
-    lambda {@akismet.verify?}.should raise_error(Akismet::VerifyException)
+    lambda {@akismet.verify?}.should raise_error(Akismet::VerifyError)
     response['x-akismet-debug-help'].should == 'sorry!'
   end
   
@@ -92,4 +92,19 @@ describe "Akismet" do
     @akismet.submit_ham(params.update(:comment_content => "this-is-ham"))
     request.script_name.should == "/1.1/submit-ham"
   end
+  
+  describe "verify?" do
+    it "should handle a SocketError" do
+      map Rack::URLMap.new("http://rest.akismet.com/" => lambda { |env| raise SocketError })
+      mock.proxy(Net::HTTP).start(anything, numeric)
+      lambda {@akismet.verify?}.should raise_error(Akismet::VerifyError)
+    end
+  end
+
+  describe "call_akismet" do
+    it "should handle a SocketError" do
+      map Rack::URLMap.new("http://thekey.rest.akismet.com/1.1/comment-check" => lambda { |env| raise SocketError })
+      lambda { @akismet.ham?(params.update(:comment_content => "not spam"))}.should raise_error(Akismet::CheckError)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: mikehale-akismet
 version: !ruby/object:Gem::Version 
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors: 
 - Michael Hale
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-15 00:00:00 -07:00
+date: 2009-06-05 00:00:00 -07:00
 default_executable: 
 dependencies: []