migration_investigation 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 698aa3dfb32aa648d5a042ce6f82180fa661658e
-  data.tar.gz: be6eb8f95205d6268a85f7ea3079d392ba421b68
+  metadata.gz: db343e9aa4896c11604706e41c4edc07fafe6575
+  data.tar.gz: eaeb8cc77fed174079ed9f10c22f7b7344ae6d87
 SHA512:
-  metadata.gz: 46bbd693ef9b2729cba74692597475368dd399c31e8a84380f1b7aaf2375a2cd998a032b314afec08c1d568dec2efb12582ca64e5aa770191f87b98118421f26
-  data.tar.gz: d9ad4ea08aaf11ab13f864a90b70aa26de8600122559fa512b73ae4b95dbf28df995b5a219f87821254d7958d5a2c7929e25a39df512428bb641640282539f48
+  metadata.gz: 5be35dec195cdd849bb44b208ce33221de745226e64a0b9e3addb5cd7aa0725e66b736c20398f46324d2b8fd6ed18f74ce12239d03d9f9c8bcb4550f5f1390f0
+  data.tar.gz: fe69836f7d5ed7502ea801c8fa8a7e200ba3665619e9848b305fab9274e8bc5217d48b77a763042afefa8071d8721fb9338a176a2388f454df2259e410373f82

data/README.md

@@ -32,6 +32,10 @@ parameter:
 
     $ MigrationInvestigation.pending_migrations? "staging", "abc123", additional_paths: ["db/seed.rb", "app/foo.txt"]
 
+You can also add a pattern for migrations to ignore:
+
+    $ MigrationInvestigation.pending_migrations? "staging", "abc123", skip_filepath_pattern: /\d_online_/
+
 ## Contributing
 
 1. Fork it

data/lib/migration_investigation.rb

@@ -6,7 +6,7 @@ module MigrationInvestigation
       old_sha = latest_stage_sha stage
       return true if old_sha.nil?
 
-      change_count(old_sha, new_sha, build_interesting_paths(options)) != 0
+      change_count(old_sha, new_sha, build_interesting_paths(options.fetch(:additional_paths, [])), options[:skip_filepath_pattern]) != 0
     end
 
     private
@@ -16,14 +16,15 @@ module MigrationInvestigation
       latest_tag.sha if latest_tag
     end
 
-    def change_count(old_sha, new_sha, interesting_paths)
-      changes = `git diff --name-only #{old_sha} #{new_sha} #{interesting_paths.join(" ")} | wc -l`
-      changes.to_i
+    def change_count(old_sha, new_sha, interesting_paths, skip_filepath_pattern)
+      cmd = "git diff --name-only #{old_sha} #{new_sha} #{interesting_paths.join(" ")}"
+      changes = `#{cmd}`
+      changes.split("\n").reject { |l| l.length == 0 }.reject { |l| skip_filepath_pattern && l =~ skip_filepath_pattern }.length
     end
 
-    def build_interesting_paths(options)
+    def build_interesting_paths(additional_paths)
       interesting_paths = ["db/migrate/"]
-      interesting_paths << options.fetch(:additional_paths, [])
+      interesting_paths << additional_paths
       interesting_paths.flatten
     end
   end

data/lib/migration_investigation/version.rb

@@ -1,3 +1,3 @@
 module MigrationInvestigation
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/migration_investigation_spec.rb

@@ -21,37 +21,78 @@ describe MigrationInvestigation do
         subject { MigrationInvestigation.pending_migrations? stage, new_sha }
 
         before do
-          allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/ | wc -l").and_return(git_diff)
+          allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/").and_return(git_diff)
         end
 
         context "when there are migrations changed between the last tag for the given change, and the new SHA" do
-          let(:git_diff) { "       3\n" }
+          let(:git_diff) do
+            <<~GITDIFF
+            db/migrate/121345_foo_migration.rb
+            db/migrate/121345_bar_migration.rb
+            db/migrate/121345_baz_migration.rb
+            GITDIFF
+          end
 
           it { is_expected.to be_truthy }
         end
 
         context "when there are no migrations changes between the last tag for the given change, and the new SHA" do
-          let(:git_diff) { "       0\n" }
+          let(:git_diff) { "\n" }
 
           it { is_expected.to be_falsy }
         end
       end
 
+      context "when an uptime pattern is provided" do
+        subject { MigrationInvestigation.pending_migrations? stage, new_sha, skip_filepath_pattern: /\d_online_/}
+
+        before do
+          allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/").and_return(git_diff)
+        end
+
+        context "when only online migrations exist" do
+          let(:git_diff) do
+            <<~GITDIFF
+            db/migrate/121345_online_bar_migration.rb
+            db/migrate/121345_online_baz_migration.rb
+            GITDIFF
+          end
+
+          it { is_expected.to be_falsy }
+        end
+
+        context "when there are some offline migrations" do
+          let(:git_diff) do
+            <<~GITDIFF
+            db/migrate/121345_foo_migration.rb
+            db/migrate/121345_bar_migration.rb
+            db/migrate/121345_online_baz_migration.rb
+            GITDIFF
+          end
+
+          it { is_expected.to be_truthy }
+        end
+      end
+
       context "when additional paths are passed in" do
-        subject { MigrationInvestigation.pending_migrations? stage, new_sha, additional_paths: ["app/foo.rb"]  }
+        subject { MigrationInvestigation.pending_migrations? stage, new_sha, additional_paths: ["app/foo.rb"] }
 
         before do
-          allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/ app/foo.rb | wc -l").and_return(git_diff)
+          allow(MigrationInvestigation).to receive(:`).with("git diff --name-only #{old_sha} #{new_sha} db/migrate/ app/foo.rb").and_return(git_diff)
         end
 
         context "when there are changes between the last tag for the given change, and the new SHA" do
-          let(:git_diff) { "       3\n" }
+          let(:git_diff) do
+            <<~GITDIFF
+            app/foo.rb
+            GITDIFF
+          end
 
           it { is_expected.to be_truthy }
         end
 
         context "when there are no changes between the last tag for the given change, and the new SHA" do
-          let(:git_diff) { "       0\n" }
+          let(:git_diff) { "\n" }
 
           it { is_expected.to be_falsy }
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: migration_investigation
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Brent Wheeldon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-30 00:00:00.000000000 Z
+date: 2016-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: auto_tagger
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Checks whether migrations, or other parts of your repo, have any changes.