midwife-client 0.0.7 → 0.0.8

data/lib/midwife/client/version.rb

@@ -1,5 +1,5 @@
 module Midwife
   class Client
-    VERSION = "0.0.7"
+    VERSION = "0.0.8"
   end
 end

data/lib/midwife/client.rb

@@ -13,11 +13,13 @@ module Midwife
     end
   end
 
+  class NotFoundError < RequestError; end
+
   module Request
     private
 
     def request(path, attributes)
-      uri = URI.parse(@endpoint + path)
+      uri = URI.join(@endpoint, path)
 
       request = Net::HTTP::Post.new(uri.path)
       request["content-type"] = "application/json"
@@ -32,8 +34,11 @@ module Midwife
 
       response = http.request(request)
 
-      if response.code =~ /2../
+      case response.code
+      when /2../
         JSON.parse(response.body)
+      when /404/
+        raise NotFoundError.new(response)
       else
         raise RequestError.new(response)
       end

data/midwife-client.gemspec

@@ -22,4 +22,5 @@ Gem::Specification.new do |s|
   s.add_dependency 'json'
 
   s.add_development_dependency 'rspec', '~> 2.5'
+  s.add_development_dependency 'webmock', '~> 1.6.4'
 end

data/spec/client_spec.rb

@@ -141,11 +141,13 @@ describe Midwife::Client do
 
   context 'when processing a non-success response' do
     let(:client) { Midwife::Client.new }
+    let(:http) { double.as_null_object }
     let(:response) { double(:code => '404', :body => 'error') }
 
 
     before do
-      Net::HTTP.stub(:start).and_return(response)
+      http.stub(:request).and_return(response)
+      Net::HTTP.stub(:new).and_return(http)
     end
 
     it 'raises an exception' do

data/spec/fixtures/unsubscribe/recipient_does_not_exist.json

@@ -0,0 +1 @@
+{"status":false}

data/spec/fixtures/unsubscribe/recipient_exists.json

@@ -0,0 +1 @@
+{"status":true}

data/spec/integration_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+require 'webmock/rspec'
+
+describe Midwife::Client do
+
+  let(:client) { Midwife::Client.new }
+
+  def file_fixture(path)
+    File.read(File.join('spec/fixtures', path))
+  end
+
+  describe '#unsubscribe' do
+    context 'when the recipient exists' do
+      before do
+        stub_request(:post, "http://localhost:3000/unsubscribe").
+          with(:body => "{\"list_id\":42,\"email\":\"exists@email.com\"}").
+          to_return(:body => file_fixture('unsubscribe/recipient_exists.json'))
+      end
+
+      it 'returns the JSON from the response' do
+        response = client.unsubscribe(:list_id => 42, :email => 'exists@email.com')
+
+        response.should == { 'status' => true }
+      end
+    end
+
+    context 'when the recipient does not exist' do
+      before do
+        stub_request(:post, "http://localhost:3000/unsubscribe").
+          with(:body => "{\"list_id\":42,\"email\":\"doesnotexist@email.com\"}").
+          to_return(:status => 404, :body => file_fixture('unsubscribe/recipient_does_not_exist.json'))
+      end
+
+      it 'raises a RecipientNotFound exception' do
+        expect {
+          client.unsubscribe(:list_id => 42, :email => 'doesnotexist@email.com')
+        }.to raise_error(Midwife::NotFoundError)
+      end
+    end
+  end
+
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: midwife-client
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 15
   prerelease: 
   segments: 
   - 0
   - 0
-  - 7
-  version: 0.0.7
+  - 8
+  version: 0.0.8
 platform: ruby
 authors: 
 - Michael Guterl
@@ -47,6 +47,22 @@ dependencies:
         version: "2.5"
   type: :development
   version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: webmock
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 6
+        - 4
+        version: 1.6.4
+  type: :development
+  version_requirements: *id003
 description: A ruby wrapper for the Midwife HTTP API
 email: 
 - mguterl@gmail.com
@@ -66,7 +82,10 @@ files:
 - lib/midwife/client/version.rb
 - midwife-client.gemspec
 - spec/client_spec.rb
-- spec_helper.rb
+- spec/fixtures/unsubscribe/recipient_does_not_exist.json
+- spec/fixtures/unsubscribe/recipient_exists.json
+- spec/integration_spec.rb
+- spec/spec_helper.rb
 has_rdoc: true
 homepage: ""
 licenses: []
@@ -103,3 +122,7 @@ specification_version: 3
 summary: A ruby wrapper for the Midwife HTTP API
 test_files: 
 - spec/client_spec.rb
+- spec/fixtures/unsubscribe/recipient_does_not_exist.json
+- spec/fixtures/unsubscribe/recipient_exists.json
+- spec/integration_spec.rb
+- spec/spec_helper.rb