middleman-s3_sync 4.6.5 → 4.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae6310b6bdcb35bb9bdeb6b35b5a5471321cd2aa31e2301cb2b85bb40f06c6d8
-  data.tar.gz: d0a22baf1a2f20e5e2ea4ffa0a727042ad42b8d0234ee058925a83c85557705a
+  metadata.gz: 6b94ebf16b78ae47530a08332b802f50aa9c4510a47b07b60cab9a8b004576e0
+  data.tar.gz: 6d097be5659e364f9c789164da5838bed6781fbb0db3a4724433d2b78d43cbad
 SHA512:
-  metadata.gz: 133e5c9a90cd90800cb4c63e443a529b5ea7d0c3d2f803972b58b0ccc01a0af4c0188932f7d0bb3030e42d157c7722f3e8e2cc8c0757c9d5207075fe016653ad
-  data.tar.gz: 0d1438c52b583df33a8bce0ac0faab99d13675470092c70facd356508e096c55fdfc4d64e4bb2a58bdc03ba3cda88afcc7b378f3f5f58374939bd678b46f1de2
+  metadata.gz: 0f29594758ad18658482ee676c9fa2d505dbe133ccd164e9a76816a7803982736f644f62193b61a45aa5bc4204439dad2c0911852dad6b596897caed93fbfd4a
+  data.tar.gz: 5f309d8e5aa6b43e0b6cb76cf7be241b4d198cff4b87d561f33c140c2886cd9337be6f7187b70f38235bed8e469deeb9ce02fb7433c82c8ca08f208cb9a28a02

data/.github/workflows/ci.yml

@@ -0,0 +1,29 @@
+name: CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['3.1', '3.2', '3.3', '3.4']
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rspec
+
+      - name: Build gem
+        run: gem build middleman-s3_sync.gemspec

data/.github/workflows/release.yml

@@ -0,0 +1,53 @@
+name: Release
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write  # For creating GitHub releases
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.4'
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rspec
+
+      - name: Build gem
+        run: gem build middleman-s3_sync.gemspec
+
+      - name: Get version
+        id: version
+        run: echo "VERSION=${GITHUB_REF#refs/tags/v}" >> $GITHUB_OUTPUT
+
+      - name: Generate checksums
+        run: |
+          sha256sum middleman-s3_sync-*.gem > checksums.txt
+          cat checksums.txt
+
+      - name: Publish to RubyGems
+        run: |
+          mkdir -p ~/.gem
+          echo -e "---\n:rubygems_api_key: ${RUBYGEMS_API_KEY}" > ~/.gem/credentials
+          chmod 0600 ~/.gem/credentials
+          gem push middleman-s3_sync-*.gem
+        env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+
+      - name: Create GitHub Release
+        uses: softprops/action-gh-release@v2
+        with:
+          files: |
+            middleman-s3_sync-*.gem
+            checksums.txt
+          generate_release_notes: true

data/README.md

@@ -19,6 +19,33 @@ that are no longer needed.
 * Use middleman-s3_sync version 4.x for Middleman 4.x
 * Use middleman-s3_sync version 3.x for Middleman 3.x
 
+## What's New in 4.7.0
+
+**New Features**
+- `after_s3_sync` callback for post-sync hooks (notifications, custom actions)
+- `scan_build_dir` option to sync files outside the Middleman sitemap
+- `routing_rules` option for S3 website redirect configuration
+- Improved content type detection with mime-types gem fallback
+
+**Performance & Efficiency**
+- Batch deletes using S3 `delete_objects` (up to 1,000 keys per request)
+- Streaming uploads to reduce memory usage on large files
+- Single-pass MD5 computation avoids redundant file reads
+- Single-pass resource categorization (create/update/delete)
+- Faster redundant-path pruning for CloudFront invalidations
+
+**Reliability**
+- Thread-safe CloudFront invalidation path tracking (mutex-protected Set)
+- Cached CloudFront client to reduce re-instantiation overhead
+- Proper sitemap population before sync (`ensure_resource_list_updated!`)
+- Fixed redirect detection to return boolean values
+
+**Developer Experience**
+- Extension now properly delegates option writers (`verbose=`, `dry_run=`, etc.)
+- GitHub Actions CI and release workflows
+- Tightened gemspec with bounded dependency versions
+- Ruby >= 3.0 requirement
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -258,6 +285,57 @@ Your AWS credentials need CloudFront permissions in addition to S3:
 - Use `cloudfront_invalidate_all: true` for major updates to minimize costs (counts as 1 path)
 - Consider the trade-off between immediate cache invalidation and cost
 
+## Callbacks
+
+### after_s3_sync
+
+You can configure a callback that runs after the sync completes. This is useful for triggering notifications, updating external services, or running post-deployment tasks.
+
+```ruby
+activate :s3_sync do |s3_sync|
+  # ... other configuration ...
+  
+  # Using a lambda/proc
+  s3_sync.after_s3_sync = ->(results) {
+    puts "Created: #{results[:created]} files"
+    puts "Updated: #{results[:updated]} files"
+    puts "Deleted: #{results[:deleted]} files"
+    puts "Invalidation paths: #{results[:invalidation_paths].join(', ')}"
+  }
+end
+```
+
+The callback receives a hash with sync results:
+
+| Key                   | Type    | Description |
+| --------------------- | ------- | ----------- |
+| `:created`            | Integer | Number of files created |
+| `:updated`            | Integer | Number of files updated |
+| `:deleted`            | Integer | Number of files deleted |
+| `:invalidation_paths` | Array   | CloudFront paths that were invalidated |
+
+You can also use a symbol to call a method on the Middleman app:
+
+```ruby
+# In config.rb
+def notify_slack(results)
+  # Send deployment notification to Slack
+end
+
+activate :s3_sync do |s3_sync|
+  # ... other configuration ...
+  s3_sync.after_s3_sync = :notify_slack
+end
+```
+
+Callbacks that take no arguments are also supported:
+
+```ruby
+activate :s3_sync do |s3_sync|
+  s3_sync.after_s3_sync = -> { puts "Sync complete!" }
+end
+```
+
 #### IAM Policy
 
 Here's a sample IAM policy with least-privilege permissions that will allow syncing to a bucket named "mysite.com":
@@ -514,6 +592,16 @@ The full values and their semantics are [documented on AWS's
 documentation
 site](http://docs.aws.amazon.com/AmazonS3/latest/dev/ACLOverview.html#CannedACL).
 
+##### Buckets with ACLs Disabled
+
+If your bucket uses "Object Ownership: Bucket owner enforced" (ACLs disabled), set:
+
+```ruby
+s3_sync.acl = ''   # or: s3_sync.acl = nil
+```
+
+The gem will also auto-detect buckets that reject ACL headers and transparently retry uploads without the `:acl` parameter.
+
 #### Encryption
 
 You can ask Amazon to encrypt your files at rest by setting the

data/lib/middleman/s3_sync/options.rb

@@ -26,13 +26,16 @@ module Middleman
         :ignore_paths,
         :index_document,
         :error_document,
+        :routing_rules,
+        :scan_build_dir,
         :cloudfront_distribution_id,
         :cloudfront_invalidate,
         :cloudfront_invalidate_all,
         :cloudfront_invalidation_batch_size,
         :cloudfront_invalidation_max_retries,
         :cloudfront_invalidation_batch_delay,
-        :cloudfront_wait
+        :cloudfront_wait,
+        :after_s3_sync
       ]
       attr_accessor *OPTIONS
 
@@ -113,6 +116,14 @@ module Middleman
         @version_bucket.nil? ? false : @version_bucket
       end
 
+      def routing_rules
+        @routing_rules || []
+      end
+
+      def scan_build_dir
+        @scan_build_dir.nil? ? false : @scan_build_dir
+      end
+
     end
   end
 end

data/lib/middleman/s3_sync/resource.rb

@@ -6,9 +6,11 @@ module Middleman
 
       include Status
 
-      def initialize(resource, partial_s3_resource)
+      def initialize(resource, partial_s3_resource, path: nil)
         @resource = resource
-        @path = if resource
+        @path = if path
+                  path.sub(/^\//, '')
+                elsif resource
                   resource.destination_path.sub(/^\//, '')
                 elsif partial_s3_resource&.key
                   partial_s3_resource.key.sub(/^\//, '')
@@ -224,7 +226,8 @@ module Middleman
       end
 
       def local?
-        File.exist?(local_path) && resource
+        # For orphan files (scan_build_dir), resource is nil but file exists
+        File.exist?(local_path)
       end
 
       def remote?
@@ -232,8 +235,8 @@ module Middleman
       end
 
       def redirect?
-        (resource && resource.respond_to?(:redirect?) && resource.redirect?) || 
-          (full_s3_resource && full_s3_resource.respond_to?(:website_redirect_location) && full_s3_resource.website_redirect_location)
+        !!(resource && resource.respond_to?(:redirect?) && resource.redirect?) || 
+          !!(full_s3_resource && full_s3_resource.respond_to?(:website_redirect_location) && full_s3_resource.website_redirect_location)
       end
 
       def metadata_match?
@@ -323,8 +326,24 @@ module Middleman
       end
 
       def content_type
-        @content_type ||= Middleman::S3Sync.content_types[local_path]
-        @content_type ||= !resource.nil? && resource.respond_to?(:content_type) ? resource.content_type : nil
+        @content_type ||= begin
+          # Priority: content_types option > mm_resource > mime-types > default
+          ct = options.content_types[local_path] if options.content_types
+          ct ||= options.content_types[path] if options.content_types
+          ct ||= Middleman::S3Sync.content_types[local_path]
+          ct ||= Middleman::S3Sync.content_types[path]
+          ct ||= resource.content_type if resource&.respond_to?(:content_type)
+          ct ||= detect_content_type_from_extension
+          ct || 'application/octet-stream'
+        end
+      end
+
+      def detect_content_type_from_extension
+        return nil unless defined?(MIME::Types)
+        extension = File.extname(original_path).delete_prefix('.')
+        return nil if extension.empty?
+        types = MIME::Types.type_for(extension)
+        types.first&.content_type
       end
 
       def caching_policy

data/lib/middleman/s3_sync/version.rb

@@ -1,5 +1,5 @@
 module Middleman
   module S3Sync
-    VERSION = "4.6.5"
+    VERSION = "4.7.0"
   end
 end

data/lib/middleman/s3_sync.rb

@@ -1,5 +1,6 @@
 require 'aws-sdk-s3'
 require 'digest/md5'
+require 'mime/types'
 require 'middleman/s3_sync/version'
 require 'middleman/s3_sync/options'
 require 'middleman/s3_sync/caching_policy'
@@ -37,6 +38,12 @@ module Middleman
         @app ||= ::Middleman::Application.new
         @invalidation_paths = Set.new
 
+        # Ensure sitemap is fully populated before syncing
+        # This catches resources from extensions activated in :build mode
+        if @app.respond_to?(:sitemap) && @app.sitemap.respond_to?(:ensure_resource_list_updated!)
+          @app.sitemap.ensure_resource_list_updated!
+        end
+
         say_status "Let's see if there's work to be done..."
         unless work_to_be_done?
           say_status "All S3 files are up to date."
@@ -63,6 +70,9 @@ module Middleman
         if s3_sync_options.cloudfront_invalidate
           CloudFront.invalidate(@invalidation_paths.to_a, s3_sync_options)
         end
+
+        # Run after_s3_sync callback if provided
+        run_after_s3_sync_callback
       end
 
       def bucket
@@ -100,6 +110,44 @@ module Middleman
         @content_types || {}
       end
 
+      # Run the after_s3_sync callback if configured
+      def run_after_s3_sync_callback
+        callback = s3_sync_options.after_s3_sync
+        return unless callback
+
+        say_status 'callback', 'Running after_s3_sync callback...'
+        
+        # Build sync results hash
+        results = {
+          created: files_to_create.size,
+          updated: files_to_update.size,
+          deleted: files_to_delete.size,
+          invalidation_paths: @invalidation_paths.to_a
+        }
+
+        begin
+          if callback.respond_to?(:call)
+            # Lambda/Proc callback - check arity to decide whether to pass results
+            if callback.arity == 0 || callback.arity == -1 && callback.parameters.empty?
+              callback.call
+            else
+              callback.call(results)
+            end
+          elsif callback.is_a?(Symbol) && @app.respond_to?(callback)
+            # Symbol method name - call on app
+            if @app.method(callback).arity == 0
+              @app.send(callback)
+            else
+              @app.send(callback, results)
+            end
+          end
+          
+          say_status 'callback', 'after_s3_sync completed successfully'
+        rescue => e
+          say_status 'error', "after_s3_sync callback failed: #{e.message}"
+        end
+      end
+
       protected
       def update_bucket_versioning
         s3_client.put_bucket_versioning({
@@ -115,10 +163,41 @@ module Middleman
         opts[:index_document] = { suffix: s3_sync_options.index_document } if s3_sync_options.index_document
         opts[:error_document] = { key: s3_sync_options.error_document } if s3_sync_options.error_document
 
+        # Add routing rules if specified
+        if s3_sync_options.routing_rules && !s3_sync_options.routing_rules.empty?
+          opts[:routing_rules] = s3_sync_options.routing_rules.map do |rule|
+            routing_rule = {}
+            
+            # Handle condition (optional)
+            if rule[:condition] || rule['condition']
+              condition = rule[:condition] || rule['condition']
+              routing_rule[:condition] = {}
+              routing_rule[:condition][:key_prefix_equals] = condition[:key_prefix_equals] || condition['key_prefix_equals'] if condition[:key_prefix_equals] || condition['key_prefix_equals']
+              routing_rule[:condition][:http_error_code_returned_equals] = condition[:http_error_code_returned_equals] || condition['http_error_code_returned_equals'] if condition[:http_error_code_returned_equals] || condition['http_error_code_returned_equals']
+            end
+            
+            # Handle redirect (required)
+            redirect = rule[:redirect] || rule['redirect']
+            routing_rule[:redirect] = {}
+            routing_rule[:redirect][:host_name] = redirect[:host_name] || redirect['host_name'] if redirect[:host_name] || redirect['host_name']
+            routing_rule[:redirect][:http_redirect_code] = redirect[:http_redirect_code] || redirect['http_redirect_code'] if redirect[:http_redirect_code] || redirect['http_redirect_code']
+            routing_rule[:redirect][:protocol] = redirect[:protocol] || redirect['protocol'] if redirect[:protocol] || redirect['protocol']
+            routing_rule[:redirect][:replace_key_prefix_with] = redirect[:replace_key_prefix_with] || redirect['replace_key_prefix_with'] if redirect[:replace_key_prefix_with] || redirect['replace_key_prefix_with']
+            routing_rule[:redirect][:replace_key_with] = redirect[:replace_key_with] || redirect['replace_key_with'] if redirect[:replace_key_with] || redirect['replace_key_with']
+            
+            routing_rule
+          end
+        end
+
         if opts[:error_document] && !opts[:index_document]
           raise 'S3 requires `index_document` if `error_document` is specified'
         end
 
+        # S3 requires index_document if routing_rules are specified
+        if opts[:routing_rules] && !opts[:index_document]
+          raise 'S3 requires `index_document` if `routing_rules` are specified'
+        end
+
         unless opts.empty?
           say_status "Putting bucket website: #{opts.to_json}"
           s3_client.put_bucket_website({
@@ -234,6 +313,11 @@ module Middleman
       def work_to_be_done?
         Parallel.each(mm_resources, in_threads: THREADS_COUNT, progress: "Processing sitemap") { |mm_resource| add_local_resource(mm_resource) }
 
+        # Scan build directory for orphan files (not in sitemap)
+        if s3_sync_options.scan_build_dir
+          discover_orphan_files
+        end
+
         Parallel.each(remote_only_paths, in_threads: THREADS_COUNT, progress: "Processing remote files") do |remote_path|
           s3_sync_resources[remote_path] ||= S3Sync::Resource.new(nil, remote_resource_for_path(remote_path)).tap(&:status)
         end
@@ -241,6 +325,38 @@ module Middleman
         !(files_to_create.empty? && files_to_update.empty? && files_to_delete.empty?)
       end
 
+      # Discover files in build directory that are not in the sitemap
+      # This handles files generated by after_build callbacks, image optimizers, etc.
+      def discover_orphan_files
+        return unless build_dir && File.directory?(build_dir)
+
+        orphan_files = []
+        
+        Dir.glob(File.join(build_dir, '**', '*')).each do |file_path|
+          next if File.directory?(file_path)
+          
+          # Get path relative to build_dir
+          relative_path = file_path.sub(/^#{Regexp.escape(build_dir)}\/?/, '')
+          
+          # Skip if already in sitemap resources
+          next if s3_sync_resources.key?(relative_path)
+          
+          orphan_files << relative_path
+        end
+
+        return if orphan_files.empty?
+
+        say_status "Found #{orphan_files.size} files outside sitemap"
+        
+        Parallel.each(orphan_files, in_threads: THREADS_COUNT, progress: "Processing orphan files") do |relative_path|
+          # Create a Resource with nil mm_resource but explicit path
+          # It will use mime-types for content type detection
+          remote = remote_resource_for_path(relative_path)
+          resource = S3Sync::Resource.new(nil, remote, path: relative_path)
+          s3_sync_resources[relative_path] = resource.tap(&:status)
+        end
+      end
+
       # Single-pass categorization of resources by status
       # Avoids multiple iterations over s3_sync_resources
       def categorized_resources

data/lib/middleman-s3_sync/commands.rb

@@ -102,7 +102,9 @@ module Middleman
         verbose = options[:verbose] ? 0 : 1
         instrument = options[:instrument]
 
-        mode = options[:build] ? :build : :config
+        # Always use :build mode to ensure build-time extensions are active
+        # (e.g., asset_hash in `configure :build` blocks)
+        mode = :build
 
         ::Middleman::S3Sync.app = ::Middleman::Application.new do
           config[:mode] = mode

data/lib/middleman-s3_sync/extension.rb

@@ -26,8 +26,10 @@ module Middleman
     option :dry_run, false, 'Whether to perform a dry-run'
     option :index_document, nil, 'S3 custom index document path'
     option :error_document, nil, 'S3 custom error document path'
+    option :routing_rules, [], 'S3 website routing rules (array of rule hashes)'
     option :content_types, {}, 'Custom content types'
     option :ignore_paths, [], 'Paths that should be ignored during sync, strings or regex are allowed'
+    option :scan_build_dir, false, 'Scan build directory for files not in sitemap (e.g., after_build files)'
     option :cloudfront_distribution_id, nil, 'CloudFront distribution ID for invalidation'
     option :cloudfront_invalidate, false, 'Whether to invalidate CloudFront cache after sync'
     option :cloudfront_invalidate_all, false, 'Whether to invalidate all paths (/*) or only changed files'
@@ -35,6 +37,7 @@ module Middleman
     option :cloudfront_invalidation_max_retries, 5, 'Maximum number of retries for rate-limited invalidation requests'
     option :cloudfront_invalidation_batch_delay, 2, 'Delay in seconds between invalidation batches'
     option :cloudfront_wait, false, 'Whether to wait for CloudFront invalidation to complete'
+    option :after_s3_sync, nil, 'Proc/lambda to call after sync completes (receives changed_paths array)'
 
     expose_to_config :s3_sync_options, :default_caching_policy, :caching_policy
 

data/middleman-s3_sync.gemspec

@@ -13,28 +13,32 @@ Gem::Specification.new do |gem|
   gem.homepage      = "http://github.com/fredjean/middleman-s3_sync"
   gem.license       = 'MIT'
 
+  gem.required_ruby_version = '>= 3.0'
+
   gem.files         = `git ls-files`.split($/)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_runtime_dependency 'middleman-core'
-  gem.add_runtime_dependency 'middleman-cli'
-  gem.add_runtime_dependency 'aws-sdk-s3', '>= 1.187.0'
-  gem.add_runtime_dependency 'aws-sdk-cloudfront'
-  gem.add_runtime_dependency 'parallel'
-  gem.add_runtime_dependency 'ruby-progressbar'
-  gem.add_runtime_dependency 'ansi', '~> 1.5.0'
-  gem.add_runtime_dependency 'mime-types', '~> 3.1'
-  gem.add_runtime_dependency 'nokogiri', '>= 1.18.4'
+  # Runtime dependencies
+  gem.add_runtime_dependency 'middleman-core', '~> 4.4'
+  gem.add_runtime_dependency 'middleman-cli', '~> 4.4'
+  gem.add_runtime_dependency 'aws-sdk-s3', '~> 1.187', '>= 1.187.0'
+  gem.add_runtime_dependency 'aws-sdk-cloudfront', '~> 1.0'
+  gem.add_runtime_dependency 'parallel', '~> 1.20'
+  gem.add_runtime_dependency 'ruby-progressbar', '~> 1.11'
+  gem.add_runtime_dependency 'ansi', '~> 1.5'
+  gem.add_runtime_dependency 'mime-types', '~> 3.4'
+  gem.add_runtime_dependency 'nokogiri', '~> 1.18', '>= 1.18.4'
 
-  gem.add_development_dependency 'rake'
-  gem.add_development_dependency 'pry'
-  gem.add_development_dependency 'pry-byebug'
-  gem.add_development_dependency 'rspec'
-  gem.add_development_dependency 'rspec-support'
-  gem.add_development_dependency 'rspec-its'
-  gem.add_development_dependency 'rspec-mocks'
-  gem.add_development_dependency 'timerizer'
-  gem.add_development_dependency 'webrick'
+  # Development dependencies
+  gem.add_development_dependency 'rake', '~> 13.0'
+  gem.add_development_dependency 'pry', '~> 0.14'
+  gem.add_development_dependency 'pry-byebug', '~> 3.10'
+  gem.add_development_dependency 'rspec', '~> 3.12'
+  gem.add_development_dependency 'rspec-support', '~> 3.12'
+  gem.add_development_dependency 'rspec-its', '~> 2.0'
+  gem.add_development_dependency 'rspec-mocks', '~> 3.12'
+  gem.add_development_dependency 'timerizer', '~> 0.3'
+  gem.add_development_dependency 'webrick', '~> 1.8'
 end

data/spec/aws_sdk_parameters_spec.rb

@@ -87,6 +87,60 @@ describe 'AWS SDK Parameter Validation' do
         }.to raise_error('S3 requires `index_document` if `error_document` is specified')
       end
     end
+
+    context 'when routing_rules are set' do
+      before do
+        options.routing_rules = [
+          {
+            condition: { key_prefix_equals: 'docs/' },
+            redirect: { replace_key_prefix_with: 'documents/' }
+          },
+          {
+            condition: { http_error_code_returned_equals: '404' },
+            redirect: { host_name: 'example.com', replace_key_with: 'error.html' }
+          }
+        ]
+      end
+
+      it 'includes routing_rules in website configuration' do
+        expect(s3_client).to receive(:put_bucket_website) do |params|
+          expect(params[:website_configuration]).to have_key(:routing_rules)
+          rules = params[:website_configuration][:routing_rules]
+          expect(rules).to be_an(Array)
+          expect(rules.length).to eq(2)
+          
+          # First rule
+          expect(rules[0][:condition][:key_prefix_equals]).to eq('docs/')
+          expect(rules[0][:redirect][:replace_key_prefix_with]).to eq('documents/')
+          
+          # Second rule
+          expect(rules[1][:condition][:http_error_code_returned_equals]).to eq('404')
+          expect(rules[1][:redirect][:host_name]).to eq('example.com')
+          expect(rules[1][:redirect][:replace_key_with]).to eq('error.html')
+        end
+
+        Middleman::S3Sync.send(:update_bucket_website)
+      end
+    end
+
+    context 'when routing_rules are set without index_document' do
+      before do
+        options.index_document = nil
+        options.error_document = nil
+        options.routing_rules = [
+          {
+            condition: { key_prefix_equals: 'old/' },
+            redirect: { replace_key_prefix_with: 'new/' }
+          }
+        ]
+      end
+
+      it 'raises an error because S3 requires index_document if routing_rules are specified' do
+        expect {
+          Middleman::S3Sync.send(:update_bucket_website)
+        }.to raise_error('S3 requires `index_document` if `routing_rules` are specified')
+      end
+    end
   end
 
   describe 'put_bucket_versioning parameters' do