middleman-core 4.3.6 → 4.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98dadc6225336b42689d4bff3f049f9e622348a7eb5d687f98fada4019fcc412
-  data.tar.gz: 9f43fc8334cd3c9e51fd831e56b7a15c7d48c7ecfdff6bd28dd4f2c62da68c49
+  metadata.gz: a62bb451348c77bfb582a6fd7a97f8913c30e1602e256bb307672e022bfcc314
+  data.tar.gz: 83fe52a59f84380ad4eb754d00c79754eeb546ed3f15fa15f47603d0740e72b5
 SHA512:
-  metadata.gz: 28469ba32bb8d13aebef2d72050aa04aad438b9b4564db3015f0920b61e096d5dcfe8917bde2e0fce7c97d49f6c6f0eecf3d1b3d8946b5ea6177572cb6386122
-  data.tar.gz: '018c5cf3cfcd507a1f0d2fd0a1092e2c6dbd56c25f196ea968ca8734cbc1868d7fc4e48507988bc90b223694a06fb10994538aae8164f5bb36556cf654be1dff'
+  metadata.gz: 33de280861e5d60ef103a6abb8fd1602dc7c36899dc08731a63975049c96961c5e0e8bda083b14a40d1638f08c614dcd903799d15ffa550a39d3e276287f74ae
+  data.tar.gz: 5e42f113d14f5dcd70276bfb548ed6c2f8d38ce889e1fbd4f35f6407d906827b46132e156c152f80c77de4b93afc8df65f6f381c4292fd569d0922145cc50c8e

data/features/default_alt_tag.feature

@@ -0,0 +1,11 @@
+Feature: Add an empty alt tag for images that don't have alt tags specified
+
+  Scenario: Image does not have alt tag specified
+    Given the Server is running at "default-alt-tags-app"
+    When I go to "/empty-alt-tag.html"
+    Then I should see 'alt=""'
+
+  Scenario: Image has alt tag specified
+    Given the Server is running at "default-alt-tags-app"
+    When I go to "/meaningful-alt-tag.html"
+    Then I should see 'alt="Meaningful alt text"'

data/features/relative_assets.feature

@@ -131,7 +131,7 @@ Feature: Relative Assets
       """
     And the Server is running at "relative-assets-app"
     When I go to "/sub/image_tag.html"
-    Then I should see '<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" />'
+    Then I should see '<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" alt="" />'
 
   Scenario: URLs are not rewritten for rewrite ignored paths
     Given a fixture app "relative-assets-app"

data/features/relative_assets_helpers_only.feature

@@ -87,7 +87,7 @@ Feature: Relative Assets (Helpers Only)
       """
     And the Server is running at "relative-assets-app"
     When I go to "/sub/image_tag.html"
-    Then I should see '<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" />'
+    Then I should see '<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" alt="" />'
 
   @wip
   Scenario: URLs are not rewritten for rewrite ignored paths

data/fixtures/default-alt-tags-app/source/empty-alt-tag.html.erb

@@ -0,0 +1 @@
+<%= image_tag "blank.gif" %>

data/fixtures/default-alt-tags-app/source/meaningful-alt-tag.html.erb

@@ -0,0 +1 @@
+<%= image_tag "blank.gif", alt: "Meaningful alt text" %>

data/lib/middleman-core/core_extensions/default_helpers.rb

@@ -282,6 +282,8 @@ class Middleman::CoreExtensions::DefaultHelpers < ::Middleman::Extension
         params[:srcset] = images_sources.join(', ')
       end
 
+      params[:alt] ||= ''
+
       super(path, params)
     end
 

data/lib/middleman-core/version.rb

@@ -1,5 +1,5 @@
 module Middleman
   # Current Version
   # @return [String]
-  VERSION = '4.3.6'.freeze unless const_defined?(:VERSION)
+  VERSION = '4.3.7'.freeze unless const_defined?(:VERSION)
 end

data/middleman-core.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |s|
   s.add_dependency('dotenv')
 
   # Helpers
-  s.add_dependency('activesupport', ['>= 4.2', '< 5.1'])
+  s.add_dependency('activesupport', ['>= 4.2', '< 6.0'])
   s.add_dependency('padrino-helpers', ['~> 0.13.0'])
   s.add_dependency("addressable", ["~> 2.3"])
   s.add_dependency('memoist', ['~> 0.14'])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: middleman-core
 version: !ruby/object:Gem::Version
-  version: 4.3.6
+  version: 4.3.7
 platform: ruby
 authors:
 - Thomas Reynolds
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-20 00:00:00.000000000 Z
+date: 2020-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -139,7 +139,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -149,7 +149,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: padrino-helpers
   requirement: !ruby/object:Gem::Requirement
@@ -370,6 +370,7 @@ files:
 - features/custom_layouts.feature
 - features/data.feature
 - features/default-layout.feature
+- features/default_alt_tag.feature
 - features/directory_index.feature
 - features/dynamic_pages.feature
 - features/encoding_option.feature
@@ -658,6 +659,10 @@ files:
 - fixtures/data-app/data/pages.yml
 - fixtures/data-app/source/index.html.erb
 - fixtures/data-app/source/layout.erb
+- fixtures/default-alt-tags-app/config.rb
+- fixtures/default-alt-tags-app/source/empty-alt-tag.html.erb
+- fixtures/default-alt-tags-app/source/images/blank.gif
+- fixtures/default-alt-tags-app/source/meaningful-alt-tag.html.erb
 - fixtures/different-engine-layout/config.rb
 - fixtures/different-engine-layout/source/index.haml
 - fixtures/different-engine-layout/source/index.html.str
@@ -1579,6 +1584,7 @@ test_files:
 - features/custom_layouts.feature
 - features/data.feature
 - features/default-layout.feature
+- features/default_alt_tag.feature
 - features/directory_index.feature
 - features/dynamic_pages.feature
 - features/encoding_option.feature
@@ -1867,6 +1873,10 @@ test_files:
 - fixtures/data-app/data/pages.yml
 - fixtures/data-app/source/index.html.erb
 - fixtures/data-app/source/layout.erb
+- fixtures/default-alt-tags-app/config.rb
+- fixtures/default-alt-tags-app/source/empty-alt-tag.html.erb
+- fixtures/default-alt-tags-app/source/images/blank.gif
+- fixtures/default-alt-tags-app/source/meaningful-alt-tag.html.erb
 - fixtures/different-engine-layout/config.rb
 - fixtures/different-engine-layout/source/index.haml
 - fixtures/different-engine-layout/source/index.html.str