miasma 0.2.12 → 0.2.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7396d4fda42e875b71624a0eca9ab303a606140
-  data.tar.gz: dc2d67fa4c59fdb2a0d0411bfbb099f91bc753dc
+  metadata.gz: 245960ddc013bc31980e434709199977532bdc4b
+  data.tar.gz: a62c8ccb2f4a5d097bd1096bf6612a6614e62410
 SHA512:
-  metadata.gz: 4c58428f59a25b11576541387304375e4d7232c0016fbcef9fbaa5dfb746eda92a85cad33d7fc474e808c11ded50425b4699618fb6cec67c6a81be5728346a4c
-  data.tar.gz: 361b96d5a94c44335cc68f34b4cb7b36006cd85c270189aedb4356480dd17c5064d1da12a1702c20158a5ca87457681b3aca5a6d3f26a317309135ed11a83f2d
+  metadata.gz: 3e38b67ea2b1ae9cd546bc229958cf49f56f6b32a5b81a694cd1ecffa689574e894d67a48423d2d268f861b36fe01e5d7613b93b2fa5e2364a3dc32dab76a099
+  data.tar.gz: b08eac5bdf5ce4724981af35310a2b2108b856c8806bc0f99c5cb09c540afa4c6d7b3e03eb83733d583ddd49ef9d6ac14cb8546cc09de09e9e9b7a6c667966b3

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# v0.2.14
+* Add non-response failure retry support on non-modify requests
+
 # v0.2.12
 * Extract provider implementations to standalone libraries
 * Add test helper executable

data/lib/miasma/types/api.rb

@@ -6,6 +6,13 @@ module Miasma
     # Remote API connection
     class Api
 
+      # HTTP request methods that are allowed retry
+      VALID_REQUEST_RETRY_METHODS=[:get, :head]
+      # Maximum allowed HTTP request retries (for non-HTTP related errors)
+      MAX_REQUEST_RETRIES=5
+      # Seconds to pause between retries
+      REQUEST_RETRY_DELAY=0.5
+
       include Miasma::Utils::Lazy
       include Miasma::Utils::Memoization
 
@@ -93,13 +100,37 @@ module Miasma
         else
           _connection = connection
         end
-        result = make_request(_connection, http_method, request_args)
+        result = retryable_request(http_method) do
+          make_request(_connection, http_method, request_args)
+        end
         unless([args.fetch(:expects, 200)].flatten.compact.map(&:to_i).include?(result.code))
           raise Error::ApiError::RequestError.new(result.reason, :response => result)
         end
         format_response(result, !args[:disable_body_extraction])
       end
 
+      # If HTTP request method is allowed to be retried then retry
+      # request on non-response failures. Otherwise just re-raise
+      # immediately
+      #
+      # @param http_method [Symbol] HTTP request method
+      # @yield request to be retried if allowed
+      # @return [Object] result of block
+      def retryable_request(http_method)
+        attempts = VALID_REQUEST_RETRY_METHODS.include?(http_method) ? 0 :nil
+        begin
+          yield
+        rescue => e
+          if(attempts && attempts < MAX_REQUEST_RETRIES)
+            attempts += 1
+            sleep RETRY_REQUEST_DELAY
+            retry
+          else
+            raise
+          end
+        end
+      end
+
       # Perform request
       #
       # @param connection [HTTP]

data/lib/miasma/version.rb

@@ -1,4 +1,4 @@
 module Miasma
   # current library version
-  VERSION = Gem::Version.new('0.2.12')
+  VERSION = Gem::Version.new('0.2.14')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: miasma
 version: !ruby/object:Gem::Version
-  version: 0.2.12
+  version: 0.2.14
 platform: ruby
 authors:
 - Chris Roberts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-11 00:00:00.000000000 Z
+date: 2015-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie