mexbt-transfer-api 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6fcf07436d1e15b860976fd32152bf3be4f19639
-  data.tar.gz: 53c95f06603f12c55d9f3838d2c4142c74593607
+  metadata.gz: 14be930cb3afbb63d5954d5aba4e8648907b6f84
+  data.tar.gz: bc50d4b44c5af4ebaf558ad44e197bbb0f41c9df
 SHA512:
-  metadata.gz: 59b3f569e5e6815fa0c67ffe1e96f788783de1f29a090b309285ccb84e825f89e7a0c18b57e98b00ea0fa6b76432b3e018a930161764d217d5ccf2454591190c
-  data.tar.gz: bf86131a1c2b129d4c717680765cf591d62bb5aa23ac2ec053462ba4cdaf9eb416fbe586f25549bbfdfaa5d6dc6411e466d081ae7a710a619fd93de89ba20020
+  metadata.gz: 401aef1b248a249bea9f849202270043057851a21b1f1d2ef947200b68d718b6daeb8f3d2e7c4d644393942819cced96a925af9ae813ac948bd730e8cbd06a58
+  data.tar.gz: f69c2e7c1d877e11dbb2f0e7009246c9646cdc673d84b0cffd70b948acc504f80214096c520a47a48607aea4ff7b6cb24b0cb5ebf61f8b8583e7cafa7a745666

data/lib/mexbt_transfer_api.rb

@@ -12,10 +12,14 @@ module Mexbt
       @api_secret = api_secret
       @client_id = client_id
       @endpoint = endpoint
+      raise "Api key cannot be null" if @api_key.nil?
+      raise "Api secret cannot be null" if @api_secret.nil?
+      raise "Client id cannot be null" if @client_id.nil?
     end
 
     def create_order(in_currency:, out_currency:, out_via:, webhook:, in_amount: 0, out_amount: 0,
                      sender_info: {}, recipient_info: {}, skip_deposit_address_setup: false)
+      raise "You must specify a value for either in or out" if in_amount.nil? && out_amount.nil?
       params = {
         in_currency: in_currency,
         out_currency: out_currency,
@@ -25,12 +29,20 @@ module Mexbt
         recipient_info: recipient_info,
         skip_deposit_address_setup: skip_deposit_address_setup
       }
-      if in_amount > 0
-        params[:in] = in_amount
-      elsif out_amount > 0
-        params[:out] = out_amount
-      else
-        raise "You must specify a value for either in or out"
+      amounts = {
+        in: in_amount,
+        out: out_amount
+      }
+      [:in, :out].each do |a|
+        amount = amounts[a]
+        if amount && amount.kind_of?(String)
+          amounts[a] = BigDecimal.new(amount)
+        end
+      end
+      if amounts[:in] > 0
+        params[:in] = amounts[:in]
+      elsif amounts[:out] > 0
+        params[:out] = amounts[:out]
       end
       call("/orders", params)
     end
@@ -77,4 +89,4 @@ module Mexbt
     end
 
   end
-end
+end

data/lib/mexbt_transfer_api/version.rb

@@ -1,5 +1,5 @@
 module Mexbt
   class TransferApi
-    CLIENT_VERSION = "0.0.2"
+    CLIENT_VERSION = "0.0.3"
   end
 end

data/spec/transfer_api_spec.rb

@@ -30,6 +30,12 @@ describe Mexbt::TransferApi do
         "status"=>"quote"
       })
     end
+
+    context "validation" do
+      it "rejects orders without an in or out amount specified" do
+        expect {transfer_api.create_order(in_currency: 'btc', out_currency: 'mxn', out_via: 'atm', webhook: nil, in_amount: nil, out_amount: nil)}.to raise_error("You must specify a value for either in or out")
+      end
+    end
   end
 
   context "getting orders" do
@@ -38,4 +44,4 @@ describe Mexbt::TransferApi do
 
   end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mexbt-transfer-api
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - williamcoates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-16 00:00:00.000000000 Z
+date: 2015-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport