metry 2.0.2 → 2.0.3

data/History.txt

@@ -1,3 +1,8 @@
+=== 2.0.3 / 2009-08-08
+
+* Really ignore events generated by Psycho.
+* Handle bogus visitor ids.
+
 === 2.0.2 / 2009-08-08
 
 * More ObjectID handling.

data/TODO

@@ -1,4 +1,12 @@
+Figure out why Psycho events are not being ignored in production
+Allow goals to have N paths
+Limit visitors on dashboard to 10 most recent
+Add full listing of visitors
+Show more details about visitors
+Add referrer to event display on visitor pages
+Add display of last 10 events to dashboard
 Show goal conversion for each experiment
+Allow manually viewing a particular alternatively
 
 Switch to submodules for vendor'd libs
 

data/lib/metry.rb

@@ -6,7 +6,7 @@ require 'metry/experiment'
 require 'metry/psycho'
 
 module Metry
-  VERSION = '2.0.2'
+  VERSION = '2.0.3'
   
   def self.init(dbname)
     @storage = Storage.new(dbname)

data/lib/metry/psycho.rb

@@ -14,7 +14,7 @@ module Metry
         
         before do
           if unescape(@request.path_info) =~ /^#{path}/
-            @request.env["metry.ignore"] = "true"
+            @env["metry.event"]["ignore"] = "true"
             if !auth.call(env)
               reply = on_deny.call(env)
               status reply.first

data/lib/metry/rack/tracking.rb

@@ -20,7 +20,7 @@ module Metry
 
         save_visitor(response, visitor)
 
-        unless env["metry.ignore"] == "true"
+        unless event["ignore"] == "true"
           event["status"] = status.to_s
           event["visitor"] = visitor['_id'].to_s
           @storage.add_event(event)

data/lib/metry/storage.rb

@@ -94,7 +94,11 @@ module Metry
       elsif id = selector['_id']
         case id
         when String
-          selector['_id'] = ObjectID.from_string(id)
+          begin
+            selector['_id'] = ObjectID.from_string(id)
+          rescue RuntimeError => e
+            raise unless e.message =~ /illegal objectid/i
+          end
         end
       end
       selector

data/test/test_storage.rb

@@ -15,5 +15,11 @@ class TestTokyo < Test::Unit::TestCase
       v = @storage.new_visitor
       assert_equal v, @storage.visitor(v['_id'].to_s)
     end
+    
+    should "handle bad object ids" do
+      assert_nothing_raised do
+        assert_nil @storage.visitor('1')
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: metry
 version: !ruby/object:Gem::Version 
-  version: 2.0.2
+  version: 2.0.3
 platform: ruby
 authors: 
 - Nathaniel Talbott