metriks-middleware 1.2.1 → 1.2.2

data/lib/metriks/middleware.rb

@@ -2,7 +2,7 @@ require 'metriks'
 
 module Metriks
   class Middleware
-    VERSION = '1.2.1'
+    VERSION = '1.2.2'
 
     def initialize(app)
       @app = app
@@ -55,6 +55,8 @@ module Metriks
         Metriks.meter("responses.error").mark
       elsif status == 404
         Metriks.meter("responses.not_found").mark
+      elsif status == 304
+        Metriks.meter("responses.not_modified").mark
       end
     end
 

data/metriks-middleware.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'metriks-middleware'
-  s.version           = '1.2.1'
-  s.date              = '2012-09-25'
+  s.version           = '1.2.2'
+  s.date              = '2012-10-05'
 
   ## Make sure your summary is short. The description may be as long
   ## as you like.

data/test/async_app_test.rb

@@ -107,6 +107,29 @@ class AsyncAppTest < Test::Unit::TestCase
     assert_equal 2, not_founds
   end
 
+  def test_records_not_modified_responses
+    not_modified_sync_app  = lambda do |env| [304, {}, ['']] end
+    not_modified_async_app = lambda do |env|
+      env['async.callback'].call [304, {}, ['']]
+      [-1, {}, ['']]
+    end
+
+    success_sync_app  = lambda do |env| [200, {}, ['']] end
+    success_async_app = lambda do |env|
+      env['async.callback'].call [200, {}, ['']]
+      [-1, {}, ['']]
+    end
+
+    Metriks::Middleware.new(not_modified_sync_app).call(@env.dup)
+    Metriks::Middleware.new(not_modified_async_app).call(@env.dup)
+    Metriks::Middleware.new(success_sync_app).call(@env.dup)
+    Metriks::Middleware.new(success_async_app).call(@env.dup)
+
+    not_modifieds = Metriks.meter('responses.not_modified').count
+
+    assert_equal 2, not_modifieds
+  end
+
   def test_omits_queue_metrics
     Metriks::Middleware.new(@downstream).call(@env)
     @async_close.call

data/test/sync_app_test.rb

@@ -65,6 +65,16 @@ class SyncAppTest < Test::Unit::TestCase
     assert_equal 2, not_founds
   end
 
+  def test_records_not_modified_responses
+    not_modified_app = lambda do |env| [304, {}, ['']] end
+    2.times { Metriks::Middleware.new(not_modified_app).call(@env) }
+    Metriks::Middleware.new(@downstream).call(@env)
+
+    not_modifieds = Metriks.meter('responses.not_modified').count
+
+    assert_equal 2, not_modifieds
+  end
+
   def test_omits_queue_metrics
     Metriks::Middleware.new(@downstream).call(@env)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metriks-middleware
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-25 00:00:00.000000000 Z
+date: 2012-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: metriks