metricsd 0.2.1 → 0.2.2

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.2.2 (July 27, 2011)
+
+Bugfixes:
+
+  - Fixed problem in connection establishing code
+
 ## 0.2.1 (July 27, 2011)
 
 Bugfixes:

data/lib/metricsd/client.rb

@@ -175,9 +175,8 @@ module Metricsd
 
       # Returns a UDP socket used to send metrics to MetricsD.
       def collector_socket
-        @@socket ||= begin
-          @@socket = UDPSocket.new
-          @@socket.connect(Metricsd.server_host, Metricsd.server_port)
+        @@socket ||= UDPSocket.new.tap do |sock|
+          sock.connect(Metricsd.server_host, Metricsd.server_port)
         end
       end
 
@@ -203,17 +202,17 @@ module Metricsd
           end
 
           if msg.size + s.size + (msg.size > 0 ? 1 : 0) > 250
-            safe_send_packet(msg)
+            safe_send(msg)
             msg = ''
           end
           msg << (msg.size > 0 ? ';' : '') << s
         end
-        safe_send_packet(msg) if msg.size > 0
+        safe_send(msg) if msg.size > 0
       end
 
       # Sends a string to the MetricsD. Should never raise any network-specific
       # exceptions, but log them instead, and silently return.
-      def safe_send_packet(msg)
+      def safe_send(msg)
         collector_socket.send(msg, 0)
         true
       rescue Errno::ECONNREFUSED => e

data/lib/metricsd/version.rb

@@ -1,3 +1,3 @@
 module Metricsd
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/client_spec.rb

@@ -23,6 +23,13 @@ describe Metricsd::Client do
       @socket.should_not_receive(:send)
       Metricsd::Client.record_value('custom.metric', 5)
     end
+
+    it 'should create and cache UDPSocket in collector_socket method' do
+      Metricsd::Client.unstub!(:collector_socket)
+      sock = Metricsd::Client.send(:collector_socket)
+      sock.should be_a(UDPSocket)
+      Metricsd::Client.send(:collector_socket).should be(sock)
+    end
   end
 
   describe '.record_hit' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: metricsd
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: 
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Dmytro Shteflyuk