metrics_adapter 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6525fffc00cde5df061ba6ce5621b9db422ddd5d09393b754ce5919b7c536f87
-  data.tar.gz: 0663ee07b6c96170f4b4050e90821b64093ff9fe9e784d14b28c2478139ceda7
+  metadata.gz: d7d1968699aa29c1905c1c244a71b9099a16cfccb66e9395ffa8c59b1332440d
+  data.tar.gz: 7f96f6eb51f45b679a845d1d42fd25d2fa1ca7672f3427b256d952bcf8e3a7bb
 SHA512:
-  metadata.gz: 4ccad7b481311aaa2b2bc79eac01993f466e0a842ca5428d63b87aa53554da2a44148e08f5dec0305b374ee187272d64c21137becf530cde6e85c129fb4c46e4
-  data.tar.gz: 3f6bd8da506014433441d190aed87607800e2bd1d1a21ad2cb2c07bf9bba1b72349980db823fef09d8a38730c8bff39772b5736ef8fda57459ae1e859550315a
+  metadata.gz: 705ae7487d7d3ba8969fa0f06f34d32849b1b897d912c5083f7ba37d2dc64a595e93fe98e28e6d0abcdad5dd30cc9fba0b656f785f0355337e839fbc53c6143c
+  data.tar.gz: a650442ffb4ff0bac4307b502a785c98b3addb38069f70888fac2ef2fcb0884f363cae0b489a0a5b06d089823f65fcccdd66326863043783ff4caba28a61328c

data/README.md

@@ -60,6 +60,8 @@ Below we setup the Keen service using the slow request tracker:
     config.extra_attributes = { app: 'My-App' }
     config.logger = Rails.logger
     config.trackers = %i(slow_request)
+    block = -> { ENV['SOME_ENVIRONMENT_VARIABLE'] == 'production' }
+    config.conditionals = { slow_request: block }
     config.thresholds = { slow_request: 1_000 }
   end
 ```

data/lib/metrics_adapter/adapters/mixpanel.rb

@@ -1,7 +1,7 @@
 require 'mixpanel-ruby'
 
 class MetricsAdapter::Adapters::Mixpanel
-  attr_reader :tracker
+  attr_reader :tracker, :logger
 
   def initialize(options)
     @tracker = ::Mixpanel::Tracker.new(options.fetch(:secret))

data/lib/metrics_adapter/rails.rb

@@ -2,12 +2,7 @@
 ##   1. Tracks slow request given a threshold
 ##
 ActiveSupport::Notifications.subscribe('process_action.action_controller') do |event|
-  trackers = MetricsAdapter.trackers
-  conditional = MetricsAdapter.conditionals[:slow_request]
-
-  if conditional.present? && conditional.call.blank?
-    Rails.logger.info('Metrics Adapter wont publish slow request metric.')
-  else
-    MetricsAdapter::Trackers::SlowRequest.new(event).call if trackers.include?(:slow_request)
+  if MetricsAdapter.trackers.include?(:slow_request)
+    MetricsAdapter::Trackers::SlowRequest.new(event).call
   end
 end

data/lib/metrics_adapter/trackers/base.rb

@@ -2,6 +2,7 @@ module MetricsAdapter
   module Trackers
     class Base
       attr_reader :adapter,
+                  :conditional,
                   :event,
                   :extra_attributes,
                   :logger,
@@ -16,6 +17,7 @@ module MetricsAdapter
         @extra_attributes = ::MetricsAdapter.extra_attributes
         @logger = ::MetricsAdapter.logger
         @metric_name = self.class.name.demodulize.underscore
+        @conditional = ::MetricsAdapter.conditionals[@metric_name.to_sym]
       end
 
       def call

data/lib/metrics_adapter/trackers/slow_request.rb

@@ -9,6 +9,8 @@ module MetricsAdapter
       end
 
       def call
+        return if conditional.present? && conditional.call.blank?
+
         if event.duration > slow_request_threshold
           data = {
             id: event.transaction_id,
@@ -19,6 +21,9 @@ module MetricsAdapter
             idle_time_in_ms: event.idle_time,
             path: event.payload[:path]
           }.merge(extra_attributes)
+          logger.info(
+            "Slow request detected. Sending data to #{adapter.class.name}"
+          ) if logger
           adapter.publish(data)
         end
       end

data/lib/metrics_adapter/version.rb

@@ -1,3 +1,3 @@
 module MetricsAdapter
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/metrics_adapter.gemspec

@@ -29,4 +29,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.17'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'byebug'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metrics_adapter
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Form builder developers
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-02 00:00:00.000000000 Z
+date: 2020-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Collect custom metrics from your application.
 email:
 - form-builder-team@digital.justice.gov.uk