metrician 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ab0cafbd476b019c807691285fbdbe519e009c5d
-  data.tar.gz: db71e9161020218c01d26fbfcbdd328863c01396
+  metadata.gz: a191afe161c4357de6c30940adf1dd405419aed1
+  data.tar.gz: a1154276f6c09cc3c4ca9bdffbcdfcf00044309a
 SHA512:
-  metadata.gz: 13ccde697c529f5c19019f964e7be4f2c8263f819c0b7d7ca908302ba1fe6695921a44d0ec77a3a816a3e81e80783d5fdf74b5fcdf526e3016bdc891e7864367
-  data.tar.gz: 612ddbe8de8989b52bcae7ae06b5fe94c4281d041e3ce573f8d7ae2707803f022916eb378b1bd70d1ed437c92d4c64b086fc0bdc34532d85b9b6e748e27387bb
+  metadata.gz: e3dde17cb1da6670d88fa0bf88d7833b28fdf979519e107b1ccb24b9986a359aa6b8b00e1cb62e4dd91e15052a3be8bbc53ab65313c036d7cb31e7a880c957a5
+  data.tar.gz: 95c30e45864e10cd236739eb5b1f5d1aaa74dc2e592db616cf5f803fe9ba3b2a0bc10f8ee16730ee5db4daf8b81d4f12b12d17717c30babd774d0c4420c484c0

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+### 0.0.4 [July 24, 2017]
+* Handle exceptions in other middlewares for response size tracking
+
+### 0.0.3 [July 20, 2017]
+* Publish to Rubygems

data/gemfiles/Gemfile.4.2.sidekiq-4.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    metrician (0.0.1)
+    metrician (0.0.4)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/Gemfile.5.0.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    metrician (0.0.1)
+    metrician (0.0.4)
 
 GEM
   remote: https://rubygems.org/

data/lib/metrician.rb

@@ -1,3 +1,4 @@
+require "English"
 require "metrician/configuration"
 require "metrician/reporter"
 require "metrician/jobs"

data/lib/metrician/middleware/request_timing.rb

@@ -51,7 +51,7 @@ module Metrician
             if Middleware.error?
               # We to_i the status because in some circumstances it is a
               # Fixnum and some it is a string. Because why not.
-              increment(:error, current_route) if status.to_i >= 500
+              increment(:error, current_route) if $ERROR_INFO || status.to_i >= 500
             end
             if Middleware.response_size?
               # Note that 30xs don't have content-length, so cached
@@ -143,7 +143,7 @@ module Metrician
       end
 
       def self.get_response_size(headers:, body:)
-        return headers[HEADER_CONTENT_LENGTH] if headers[HEADER_CONTENT_LENGTH]
+        return headers[HEADER_CONTENT_LENGTH] if headers && headers[HEADER_CONTENT_LENGTH]
         body.first.length.to_s if body.respond_to?(:length) && body.length == 1
       end
 

data/lib/metrician/version.rb

@@ -1,5 +1,5 @@
 module Metrician
 
-  VERSION = "0.0.3".freeze
+  VERSION = "0.0.4".freeze
 
 end

data/spec/metrician_spec.rb

@@ -271,6 +271,28 @@ RSpec.describe Metrician do
       end
     end
 
+    describe "middleware exceptions" do
+      def app
+        require "metrician/middleware/request_timing"
+        require "metrician/middleware/application_timing"
+        Rack::Builder.app do
+          use Metrician::Middleware::RequestTiming
+          use Metrician::Middleware::ApplicationTiming
+          run lambda { |env| raise "boom" }
+        end
+      end
+
+      specify "middleware exceptions don't cause errors in response size tracking" do
+        Metrician.configuration[:request_timing][:response_size][:enabled] = true
+        agent.stub(:gauge)
+        agent.stub(:increment)
+
+        agent.should_receive(:gauge).with("web.request", anything)
+        agent.should_receive(:increment).with("web.error", 1)
+        lambda { get "/" }.should raise_error(RuntimeError, "boom")
+      end
+    end
+
     describe "queueing timing" do
       def app
         require "metrician/middleware/request_timing"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metrician
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Expected Behavior
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-20 00:00:00.000000000 Z
+date: 2017-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: instrumental_agent
@@ -108,6 +108,7 @@ files:
 - ".rubocop_todo.yml"
 - ".ruby-version"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - METRICS.MD