metric_fu 4.3.1 → 4.4.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 741f0378823b8b42fce3ad9e4bc36b0312988660
+  data.tar.gz: 66dce50c5876c8dc84d672e5ed5571e6e9854dd5
+SHA512:
+  metadata.gz: fc38e9dfd106e6f8c92d9f044a3ee1d9d192d6ae3de367b871efa70bc40bd7c67f877f6bc9628440c05094284eb333a635d96c9626e05f2e79f6be4aacd79b14
+  data.tar.gz: 1487b7c82f5f8bf932bbd81b1b538fdd0bf03216fd32af2b3c3f294c7d83edd808cae889f827b1c4e0b788667593f2d0f9e159ce149beb7396b1cd29bd270267

data/.metrics

@@ -3,34 +3,63 @@
 # For testing that this file gets loaded
 $metric_file_loaded = true
 
-# example configuration
-# MetricFu::Configuration.run do |config|
-#   coverage_file = File.expand_path("coverage/rcov/rcov.txt", Dir.pwd)
-#   config.add_metric(:rcov)
-#   config.add_graph(:rcov)
-#   config.configure_metric(:rcov, {:external => coverage_file})
-#   config.cane = {:abc_max => 15, :line_length => 80, :no_doc => 'y', :no_readme => 'y'}
-# end
-# or
+# Example Configuration
+#
 # MetricFu::Configuration.run do |config|
-#   config.metrics -= [ :rcov ]
-# end
-# you may enable running rcov manually with
-# MetricFu.run_rcov
 #
-# By default, metric_fu will use the built-in html formatter
-# to generate HTML reports for each metric with pretty graphs.
+#   Configure Metrics
+#
+#   To configure individual metrics...
+#
+#   config.configure_metric(:rcov) do |rcov|
+#     rcov.enabled = true
+#     coverage_file = File.expand_path("coverage/rcov/rcov.txt", Dir.pwd)
+#     rcov.external = coverage_file
+#   end
+#
+#   config.configure_metric(:cane) do |cane|
+#     cane.enabled = true
+#     cane.abc_max = 15
+#     cane.line_length = 80
+#     cane.no_doc = 'y'
+#     cane.no_readme = 'y'
+#   end
+#
+#   Or, to configure a group of metrics...
+#   config.configure_metrics.each do |metric|
+#     if [:churn, :flay, :flog].include?(metric.name)
+#       metric.enabled = true
+#     else
+#       metric.enabled = false
+#     end
+#   end
+#
+#
+#   Configure Formatters
+#
+#   By default, metric_fu will use the built-in html formatter
+#   to generate HTML reports for each metric with pretty graphs.
 
-# To configure different formatter(s) or output ...
-# MetricFu::Configuration.run do |config|
-#   config.add_formatter(:html)
-#   config.add_formatter(:yaml, "customreport.yml")
-#   config.add_formatter(MyCustomFormatter)
-# end
+#   To configure different formatter(s) or output ...
+#
+#   config.configure_formatter(:html)
+#   config.configure_formatter(:yaml, "customreport.yml")
+#   config.configure_formatter(MyCustomFormatter)
+#
+#   MetricFu will attempt to require a custom formatter by
+#   fully qualified name based on ruby search path,
+#   but you may find that you need to add a require above.
 #
-# metric_fu will attempt to require a custom formatter by
-# fully qualified name based on ruby search path,
-# but you may find that you need to add a require above.
+#   For instance, to require a formatter in your app's lib directory, add the
+#   following line to the top of this file.
+#   require './lib/my_custom_formatter.rb'
 #
-# For instance, to require a formatter in your app's lib directory:
-# require './lib/my_custom_formatter.rb'
+#
+#   Configure Graph Engine
+#
+#   By default, metric_fu uses the bluff graph engine.
+#   To configure a different graph engine...
+#
+#   config.configure_graph_engine(:gchart)
+#
+# end

data/.travis.yml

@@ -9,6 +9,9 @@ gemfile:
 rvm:
   - 2.0.0
   - 1.9.3
-  - 1.9.2
+  # - 1.9.2 # code_metric 0.1.0 requires ruby 1.9.3 or greater
   - jruby-19mode # JRuby in 1.9 mode
   - rbx-19mode
+# matrix:
+#   allow_failures:
+#     - rvm: rbx-19mode

data/AUTHORS

@@ -0,0 +1,12 @@
+Jake Scruggs
+Sean Soper
+Andre Arko
+Petrik de Heus
+Grant McInnes
+Nick Quaranto
+Édouard Brière
+Carl Youngblood
+Richard Huang
+Dan Mayer
+Benjamin Fleischer
+Robin Curry

data/Gemfile

@@ -15,5 +15,6 @@ group :test do
     gem 'simplecov-rcov-text'
   end
   gem "fakefs", :require => "fakefs/safe"
+  gem 'json'
 end
 gemspec :path => File.expand_path('..', __FILE__)

data/HISTORY.md

@@ -10,6 +10,30 @@ As such, a _Feature_ would map to either major or minor. A _bug fix_ to a patch.
 * Fixes
 * Misc
 
+### MetricFu 4.4.0 / 2013-08-15
+
+* Features
+  * Metrics now configure themselves in a subclass of MetricFu::Metric ( Benjamin Fleischer / Robin Curry #91, #111)
+  * Metrics can be configured individually via Metric.configuration.configure_metric(:some_metric) or Metric.configuration.configure_metrics {|metric| }.  See .metrics file for examples ( Benjamin Fleischer / Robin Curry #91, #111)
+  * Distinguish between an activated metric library and an enabled metric.
+    * An enabled metric will be run.
+    * An activated metric has had its library successfully required. (Benjamin Fleischer #125)
+  * Code Statistics metrics always runs now, relies on the code_metrics gem extracted from Rails. Does not shell out. ( Benjamin Fleischer, #108 )
+  * Rails Best Practices report now provides a link to the description and solution of the problem (Calveto #117)
+  * Rails Best Practices now runs as a library. It is no longer shelled out. (Calveto #117)
+  * Update flog to ~> 4.1.1, this is needed to use keyword parameters in ruby 2. (George Erickson, #122)
+* Fixes
+  * Skip reek when no files are found to run against.  Otherwise, reek hangs trying to read from STDIN (Benjamin Fleischer, #119, #121)
+  * Reek will now find files on Windows.  Remove *nix-specific '/' directory separators from Reek file glob.  (Benjamin Fleischer, #119, #121)
+  * Link to correct reek url on report. (Calveto #116)
+  * Hack to accomodate Rails Best Practices dependency Code Analyzer monkey patch of Sexp (Benjamin Fleischer #123, #124)
+* Misc
+  * Moved environmental concerns into an Environment module ( Benjamin Fleischer / Robin Curry #91, #111)
+  * Exposed RubyParser patch ( Benjamin Fleischer / Robin Curry #91, #111)
+  * Separated out io / filesystem /templating concerns into their own classes or modules. Thus, we removed all the metaprogrammatically defined methods and instance variables.( Benjamin Fleischer / Robin Curry #91, #111, #112, #115)
+  * Generator subclasses can now be found by metric name. MetricFu::Generator.get_generator(:flog) (Benjamin Fleischer, #126)
+  * Breaking change related to the above: removed configuration methods / MetricFu module methods: add_graph, add_metric, configure_graph, configure_metric, configure_graph_engine, graph_engine, metrics, formatters, graphs, graph_engines, rails?, code_dirs, base_directory, scratch_directory, output_directory, data_directory, file_globs_to_ignore, metric_fu_root_directory, template_directory, template_class, link_prefix, darwin_txmt_protocol_no_thanks, syntax_highlighting
+
 ### MetricFu 4.3.1 / 2013-08-02
 
 * Features

data/README.md

@@ -1,7 +1,9 @@
-# MetricFu [![Gem Version](https://badge.fury.io/rb/metric_fu.png)](http://badge.fury.io/rb/metric_fu) [![Build Status](https://travis-ci.org/metricfu/metric_fu.png?branch=master)](http://travis-ci.org/metricfu/metric_fu) [Rdoc](http://rdoc.info/github/metricfu/metric_fu/)
+# MetricFu [![Gem Version](https://badge.fury.io/rb/metric_fu.png)](http://badge.fury.io/rb/metric_fu) [![Build Status](https://travis-ci.org/metricfu/metric_fu.png?branch=master)](http://travis-ci.org/metricfu/metric_fu) 
 
 [![Code Climate](https://codeclimate.com/github/metricfu/metric_fu.png)](https://codeclimate.com/github/metricfu/metric_fu) [![Dependency Status](https://gemnasium.com/metricfu/metric_fu.png)](https://gemnasium.com/metricfu/metric_fu)
 
+[Rdoc](http://rdoc.info/github/metricfu/metric_fu/)
+
 ## Metrics
 
 * [Cane](https://rubygems.org/gems/cane), [Source](http://github.com/square/cane)
@@ -10,13 +12,13 @@
 * [Flay](https://rubygems.org/gems/flay), [Source](https://github.com/seattlerb/flay)
 * [Reek](https://rubygems.org/gems/reek) [Source](https://github.com/troessner/reek)
 * [Roodi](https://rubygems.org/gems/metric_fu-roodi), [Source](https://github.com/metricfu/roodi)
-* [Saikuro](https://rubygems.org/gems/japgolly-Saikuro), [Source](https://github.com/japgolly/Saikuro)
+* [Saikuro](https://rubygems.org/gems/metric_fu-Saikuro), [Source](https://github.com/metricfu/Saikuro)
+  [Code Statistics](https://rubygems.org/gems/code_metrics), [Source](https://github.com/bf4/code_metrics) )
 * Rails-only
   * [Rails Best Practices](https://rubygems.org/gems/rails_best_practices), [Source](https://github.com/railsbp/rails_best_practices)
-  * Rails `rake stats` task (see [gem](https://rubygems.org/gems/code_statistics), [Source](https://github.com/danmayer/code_statistics) )
 * Test Coverage
   * 1.9: [SimpleCov](http://rubygems.org/gems/simplecov) and [SimpleCov-Rcov-Text](http://rubygems.org/gems/simplecov-rcov-text)
-  * 1.8 [Rcov](http://rubygems.org/gems/rcov)
+  * 1.8: [Rcov](http://rubygems.org/gems/rcov)
 * Hotspots (a meta-metric of the above)
 
 ## Installation
@@ -29,25 +31,25 @@ See documentation on the rubyforge page for how to customize your metrics. Other
 
 ## Usage
 
-By default, you can run all metrics from the root of an app with the command `metric_fu -r`
+By default, you can run all metrics from the root of an app with the command `metric_fu`
 
 See `metric_fu --help` for more options
 
 ## Compatibility
 
-* It is currently testing on MRI 1.9.2, 1.9.3 and 2.0.0. Ruby 1.8 is no longer supported due to the cane library.
+* It is currently testing on MRI (1.9.3 and 2.0.0), JRuby (19 mode), and Rubinius (19 mode). Ruby 1.8 is no longer supported due to the cane library.
 
 * For 1.8.7 support, see version 3.0.0 for partial support, or 2.1.3.7.18.1 (where [Semantic Versioning](http://semver.org/) goes to die)
 
-* The `japgolly-Saikuro` fork and `metric_fu-roodi` fork are a part of an attempt to get metric_fu working in a modern Ruby environment, specifically compatibility with Ruby 1.9 and Bundler.
+* The `metric_fu-Saikuro` fork and `metric_fu-roodi` fork are a part of an attempt to get metric_fu working in a modern Ruby environment, specifically compatibility with Ruby 1.9 and Bundler.
 
 * metric_fu no longer runs rcov itself. You may still use rcov metrics as documented below
 
-* The Cane, Flog, and Rails Best Practices metrics are disabled in non-MRI rubies as they depend on ripper
+* The Cane, Flog, and Rails Best Practices metrics are disabled when Ripper is not available 
 
 ## Documentation
 
-* Cane code quality threshold checking is not included in the hotspots report
+*[See wiki](https://github.com/metricfu/metric_fu/wiki#usage)
 
 ## Formatters
 
@@ -115,15 +117,14 @@ see the .metrics file
 in your .metrics file add the below to run pre-generated metrics
 
     MetricFu::Configuration.run do |config|
-      coverage_file = File.expand_path("coverage/rcov/rcov.txt", Dir.pwd)
-      config.add_metric(:rcov)
-      config.add_graph(:rcov)
-      config.configure_metric(:rcov, {:external => coverage_file})
+      config.configure_metric(:rcov) do |rcov|
+        rcov.enabled = true
+        coverage_file = File.expand_path("coverage/rcov/rcov.txt", Dir.pwd)
+        rcov.external = coverage_file
+      end
     end
 
-if you want metric_fu to actually run rcov itself (1.8 only), just add
-
-    MetricFu.run_rcov
+If you want metric_fu to actually run rcov itself (1.8 only), don't specify an external file to read from
 
 #### Rcov metrics with Ruby 1.8
 
@@ -156,19 +157,23 @@ There is some useful-but-out-of-date documentation about configuring metric_fu a
 
 See the TODO for some ideas
 
-See CONTRIBUTING for how to contribute
+See [CONTRIBUTING](https://github.com/metricfu/metric_fu/blob/master/CONTRIBUTING.md) for how to contribute
 
 ## Resources:
 
-This is the official repository for metric_fu.  The original repository by Jake Scruggs at [https://github.com/jscruggs/metric_fu](https://github.com/jscruggs/metric_fu) [has been deprecated.](http://jakescruggs.blogspot.com/2012/08/why-i-abandoned-metricfu.html).
+This is the official repository for metric_fu.  The original repository by Jake Scruggs at [https://github.com/jscruggs/metric_fu](https://github.com/jscruggs/metric_fu) has been deprecated.
 
-* Github: http://github.com/metricfu/metric_fu
-* Issue Tracker: http://github.com/metricfu/metric_fu/issues
-* Google Group: http://groups.google.com/group/metric_fu
-* Historical Homepage: http://metric-fu.rubyforge.org/
+* [Official Repository](http://github.com/metricfu/metric_fu)
+* [Issue Tracker](http://metricfu.github.io/metric_fu/)
+* [Google Group](http://metricfu.github.io/metric_fu/)
+* [Outdated Homepage](http://metricfu.github.io/metric_fu/)
+* [List of code tools](https://github.com/metricfu/metric_fu/wiki/Code-Tools)
+* [Roadmap](https://github.com/metricfu/metric_fu/wiki/Roadmap)
 
 ### Original Resources:
 
 * Github: http://github.com/jscruggs/metric_fu
 * Issue Tracker: http://github.com/jscruggs/metric_fu/issues
+* Historical Homepage: http://metric-fu.rubyforge.org/
 * Jake's Blog: http://jakescruggs.blogspot.com/
+* Jake's Post about stepping down: http://jakescruggs.blogspot.com/2012/08/why-i-abandoned-metricfu.html

data/checksum/metric_fu-4.3.1.gem.sha512

@@ -0,0 +1 @@
+8ceae4f1bb2719d8ecbe2c7b3e929fe477cbe4ea6582297092a1bc09a6bef9e423f3a33c619b62372b208f956c4d8f9839257cd491475b58c06a2c8341eafc77

data/checksum/metric_fu-4.4.0.gem.sha512

@@ -0,0 +1 @@
+1f9be27229b5a441bc4e4367d099f6f92641d994246b88f9a396fc8c99d832a00412fe7c9a5dc5078c9beecc8d77d575d9b9ab55b50ab7b0b7583130763369bf

data/lib/metric_fu.rb

@@ -1,98 +1,47 @@
+require 'metric_fu/version'
 module MetricFu
   APP_ROOT = File.expand_path(File.join(File.dirname(__FILE__),'..'))
   LIB_ROOT = File.join(APP_ROOT,'lib/metric_fu')
-  @loaded_files = []
-  class << self
-    attr_reader :loaded_files
-  end
-  def self.lib_require(base='',&block)
-    paths = []
-    base_path = File.join(LIB_ROOT, base)
-    Array((yield paths, base_path)).each do |path|
-      file = File.join(base_path, *Array(path))
-      require file
-      if @loaded_files.include?(file)
-        puts "!!!\tAlready loaded #{file}" if !!(ENV['MF_DEBUG'] =~ /true/i)
-      else
-        @loaded_files << file
-      end
-    end
-  end
   def self.root_dir
     APP_ROOT
   end
   def self.lib_dir
     LIB_ROOT
   end
-  class << self
-    %w(metrics formatter reporting logging errors data_structures tasks).each do |dir|
-      define_method("#{dir}_dir") do
-        File.join(lib_dir,dir)
-      end
-      module_eval(%Q(def #{dir}_require(&block); lib_require('#{dir}', &block); end))
-    end
+
+  require 'metric_fu/loader'
+  LOADER = MetricFu::Loader.new(LIB_ROOT)
+  def self.lib_require(base='',&block)
+    LOADER.lib_require(base,&block)
   end
-  def self.tasks_load(tasks_relative_path)
-    load File.join(LIB_ROOT, 'tasks', *Array(tasks_relative_path))
+
+  LOADER.create_dirs(self) do
+    %w(metrics formatter reporting logging errors data_structures tasks)
   end
-  # path is relative to where the task is being run,
+
+  # @note artifact_dir is relative to where the task is being run,
   # not to the metric_fu library
+  require 'metric_fu/io'
   def self.artifact_dir
-    (ENV['CC_BUILD_ARTIFACTS'] || 'tmp/metric_fu')
-  end
-  def self.configure
-    MetricFu.lib_require { 'configuration' }
-    init_files = Dir.glob(File.join(MetricFu.metrics_dir, '**/init.rb')).reject do |file|
-      if file =~ /rcov/o
-        MetricFu.configuration.mf_debug("rcov is not available. See README")
-        true
-      elsif MetricFu.configuration.mri?
-        false
-      elsif file =~ /cane/o
-        MetricFu.configuration.mf_debug("Cane is only available in MRI. It requires ripper")
-        true
-      elsif file =~ /flog/o
-        MetricFu.configuration.mf_debug("Flog is only available in MRI. It requires ripper")
-        true
-      elsif file =~ /rails_best_practices/o
-        MetricFu.configuration.mf_debug("Rails Best Practices only available in MRI. It requires ripper")
-        true
-      else
-        false
-      end
-    end
-    init_files.each do |file|
-      load file
-    end
-    MetricFu.configuration
+    MetricFu::Io::FileSystem.artifact_dir
   end
-  def self.mri_only_metrics
-    if MetricFu.configuration.mri?
-      []
-    else
-      [:cane, :flog, :rails_best_practices]
-    end
-  end
-  def self.run_rcov
-    load File.join(MetricFu.metrics_dir, 'rcov/init.rb')
+
+  LOADER.create_artifact_subdirs(self) do
+    %w(scratch output _data)
   end
-  def self.skip_rcov
-    MetricFu.metrics -= [:rcov]
-    MetricFu.graphs  -= [:rcov]
+
+  def self.tasks_load(tasks_relative_path)
+    LOADER.load_tasks(tasks_relative_path)
   end
-  class << self
-    %w(scratch output _data).each do |dir|
-      define_method("#{dir.gsub(/[^A-Za-z0-9]/,'')}_dir") do
-        File.join(artifact_dir,dir)
-      end
-    end
 
+  LOADER.setup
+
+  def self.reset
+    # TODO Don't like how this method needs to know
+    # all of these class variables that are defined
+    # in separate classes.
+    @configuration = nil
+    @graph = nil
+    @result = nil
   end
-  # def const_missing(name)
-  #
-  # end
 end
-MetricFu.lib_require { 'version' }
-MetricFu.lib_require { 'initial_requires' }
-# Load a few things to make our lives easier elsewhere.
-MetricFu.lib_require { 'load_files' }

data/lib/metric_fu/cli/helper.rb

@@ -32,7 +32,7 @@ module MetricFu
       end
 
       def metrics
-        MetricFu.configuration.metrics.sort_by(&:to_s)
+        MetricFu::Metric.metrics.map(&:name).sort_by(&:to_s)
       end
 
       def process_options(argv=[])

data/lib/metric_fu/cli/parser.rb

@@ -54,7 +54,7 @@ module MetricFu
                 "This option applies to the previously",
                 "specified --format, or the default format",
                 "if no format is specified. Paths are relative to",
-                "#{Pathname.pwd.join(MetricFu.base_directory)}",
+                "#{Pathname.pwd.join(MetricFu::Io::FileSystem.directory('base_directory'))}",
                 "Check the specific formatter\'s docs to see",
                 "whether to pass a file or a dir.") do |o|
               @result[:format] ||= MetricFu::Formatter::DEFAULT

data/lib/metric_fu/configuration.rb

@@ -1,9 +1,8 @@
-require 'fileutils'
-require 'rbconfig'
-MetricFu.reporting_require { 'templates/awesome/awesome_template' }
 MetricFu.logging_require { 'mf_debugger' }
 module MetricFu
 
+  # Even though the below class methods are defined on the MetricFu module
+  # They are included here as they deal with configuration
 
   # The @configuration class variable holds a global type configuration
   # object for any parts of the system to use.
@@ -12,21 +11,29 @@ module MetricFu
     @configuration ||= Configuration.new
   end
 
+  def self.configure
+    Dir.glob(File.join(MetricFu.metrics_dir, '**/init.rb')).each{|init_file|require(init_file)}
+    Dir.glob(File.join(MetricFu.reporting_dir, '**/init.rb')).each{|init_file|require(init_file)}
+    configuration.tap do |config|
+      config.configure_metrics
+    end
+  end
+
+  # TODO: Remove this method.  It is really a test concern for identifying
+  #   metrics turned off for environmental reasons
+  def self.mri_only_metrics
+    if MetricFu.configuration.mri?
+      []
+    else
+      [:cane, :flog, :rails_best_practices]
+    end
+  end
+
   # = Configuration
   #
   # The Configuration class, as it sounds, provides methods for
   # configuring the behaviour of MetricFu.
   #
-  # == Customization for Rails
-  #
-  # The Configuration class checks for the presence of a
-  # 'config/environment.rb' file.  If the file is present, it assumes
-  # it is running in a Rails project.  If it is, it will:
-  #
-  # * Add 'app' to the @code_dirs directory to include the
-  #   code in the app directory in the processing
-  # * Add :stats  and :rails_best_practices to the list of metrics to run
-  #
   # == Customization for CruiseControl.rb
   #
   # The Configuration class checks for the presence of a
@@ -36,186 +43,133 @@ module MetricFu
   #
   # == Metric Configuration
   #
-  # Each metric can be configured by e.g. config.churn, config.flog, config.saikuro
+  # Each metric can be configured by e.g.
+  #   config.configure_metric(:flog) do |flog|
+  #     flog.enable
+  #     flog.dirs_to_flog = %w(app lib spec)
+  #     ...
+  #   end
+  #
+  # or iterate over all metrics to configure by e.g.
+  #   config.configure_metrics.each do |metric|
+  #     ...
+  #   end
+  #
+  # == Formatter Configuration
+  #
+  # Formatters can be configured by e.g.
+  #   config.configure_formatter(:html)
+  #   config.configure_formatter(:yaml, "customreport.yml")
+  #   config.configure_formatter(MyCustomFormatter)
+  #
+  # == Graph Configuration
+  #
+  # Graphing engine can be configured by e.g.
+  #   config.configure_graph_engine(:bluff)
+  #
+  #
   class Configuration
+    require_relative 'environment'
+    require_relative 'io'
+    require_relative 'formatter'
+    # TODO: Remove need to include the module
+    include MetricFu::Environment
 
     def initialize #:nodoc:#
       reset
     end
 
-    def verbose
-      MfDebugger::Logger.debug_on
-    end
-
-    def verbose=(toggle)
-      MfDebugger::Logger.debug_on = toggle
-    end
-
     def mf_debug(msg)
       MfDebugger.mf_debug msg
     end
 
     # TODO review if these code is functionally duplicated in the
     # base generator initialize
+    attr_reader :formatters
     def reset
-      set_directories
-      configure_template
-      add_promiscuous_instance_variable(:metrics, [])
-      add_promiscuous_instance_variable(:formatters, [])
-      add_promiscuous_instance_variable(:graphs, [])
-      add_promiscuous_instance_variable(:graph_engines, [])
-      add_promiscuous_method(:graph_engine)
+      # TODO: Remove calls to self and/or allow querying the
+      #   template/filesystem/metric/graph/environment, etc settings
+      #   from the configuration instance
+      MetricFu::Io::FileSystem.set_directories(self)
+      MetricFu::Formatter::Templates.configure_template(self)
+      @formatters = []
+      @graph_engine_config = MetricFu::GraphEngine.new
     end
 
     # This allows us to have a nice syntax like:
     #
     #   MetricFu.run do |config|
-    #     config.base_directory = 'tmp/metric_fu'
+    #     congif.configure_metric(:churn) do
+    #       ...
+    #     end
+    #
+    #     config.configure_graph_engine(:bluff)
     #   end
     #
     # See the README for more information on configuration options.
+    # TODO: Consider breaking compatibility by removing this, now unused method
     def self.run
       yield MetricFu.configuration
     end
 
-    attr_accessor :metrics
-    # e.g. :churn
-    def add_metric(metric)
-      add_promiscuous_method(metric)
-      self.metrics = (metrics << metric).uniq
+    def configure_metric(name)
+      yield MetricFu::Metric.get_metric(name)
     end
 
-    # e.g. :reek
-    def add_graph(metric)
-      add_promiscuous_method(metric)
-      self.graphs = (graphs << metric).uniq
-    end
-
-    def add_formatter(format, output = nil)
-      @formatters << MetricFu::Formatter.class_for(format).new(output: output)
-    end
-
-    # e.g. :reek, {}
-    def configure_metric(metric, metric_configuration)
-      add_promiscuous_instance_variable(metric, metric_configuration)
-    end
-
-    # e.g. :bluff
-    def add_graph_engine(graph_engine)
-      add_promiscuous_method(graph_engine)
-      self.graph_engines = (graph_engines << graph_engine).uniq
-    end
-
-    # e.g. :bluff
-    def configure_graph_engine(graph_engine)
-      add_promiscuous_instance_variable(:graph_engine, graph_engine)
-    end
-
-    # Perform a simple check to try and guess if we're running
-    # against a rails app.
-    #
-    # TODO This should probably be made a bit more robust.
-    def rails?
-      add_promiscuous_instance_variable(:rails, File.exist?("config/environment.rb"))
-    end
-
-    def is_cruise_control_rb?
-      !!ENV['CC_BUILD_ARTIFACTS']
-    end
-
-    def jruby?
-      @jruby ||= !!RedCard.check(:jruby)
-    end
-
-    def mri?
-      @mri ||= !!RedCard.check(:ruby)
-    end
-
-    def rubinius?
-      @rubinius ||= !!RedCard.check(:rubinius)
-    end
-
-    def platform #:nodoc:
-      # TODO, change
-      # RbConfig::CONFIG['ruby_install_name'].dup
-      return RUBY_PLATFORM
-    end
-
-    def self.ruby_strangely_makes_accessors_private?
-       ruby192? || jruby?
-    end
-
-    def self.ruby192?
-      @ruby192 ||= !!RedCard.check('1.9.2')
+    def configure_metrics
+      MetricFu::Metric.metrics.each do |metric|
+        if block_given?
+          yield metric
+        elsif !metric_manually_configured?(metric)
+          metric.enabled = false
+          metric.enable
+        end
+        metric.activate if metric.enabled unless metric.activated
+      end
     end
 
-    protected unless ruby_strangely_makes_accessors_private?
-
-    def add_promiscuous_instance_variable(name,value)
-      instance_variable_set("@#{name}", value)
-      add_promiscuous_method(name)
-      value
+    # TODO: Remove this method.  If we run configure_metrics
+    #   and it disabled rcov, we shouldn't have to worry here
+    #   that rcov is a special case that can only be enabled
+    #   manually
+    def metric_manually_configured?(metric)
+      [:rcov].include?(metric.name)
     end
 
-    def add_promiscuous_method(method_name)
-        add_promiscuous_class_method_to_metric_fu(method_name)
-        add_accessor_to_config(method_name)
+    # TODO: Reconsider method name/behavior, as it really adds a formatter
+    def configure_formatter(format, output = nil)
+      @formatters << MetricFu::Formatter.class_for(format).new(output: output)
     end
 
-    def add_promiscuous_class_method_to_metric_fu(method_name)
-        metric_fu_method = <<-EOF
-                  def self.#{method_name}
-                    configuration.send(:#{method_name})
-                  end
-        EOF
-      MetricFu.module_eval(metric_fu_method)
+    # @return [Array<Symbol>] names of enabled metrics with graphs
+    def graphs
+      # TODO: This is a common enough need to be pushed into MetricFu::Metric as :enabled_metrics_with_graphs
+      MetricFu::Metric.enabled_metrics.select{|metric|metric.has_graph?}.map(&:name)
     end
 
+    # TODO: Consider if we need to delegate so much to graph_engine_config
+    #   if we should use forwardable or change the api
 
-    def add_accessor_to_config(method_name)
-      self.class.send(:attr_accessor, method_name)
+    # @return [Array<Symbol>] names of available graph engines
+    # @example [:bluff, :gchart]
+    def graph_engines
+      @graph_engine_config.graph_engines
     end
 
-    private
-
-    def configure_template
-      add_promiscuous_instance_variable(:template_class, AwesomeTemplate)
-      add_promiscuous_instance_variable(:link_prefix, nil)
-      add_promiscuous_instance_variable(:darwin_txmt_protocol_no_thanks, true)
-      # turning off syntax_highlighting may avoid some UTF-8 issues
-      add_promiscuous_instance_variable(:syntax_highlighting, true)
+    # @return [Symbol] the selected graph engine
+    def graph_engine
+      @graph_engine_config.graph_engine
     end
 
-    def set_directories
-      add_promiscuous_instance_variable(:base_directory,MetricFu.artifact_dir)
-      add_promiscuous_instance_variable(:scratch_directory,MetricFu.scratch_dir)
-      add_promiscuous_instance_variable(:output_directory,MetricFu.output_dir)
-      add_promiscuous_instance_variable(:data_directory,MetricFu.data_dir)
-      # due to behavior differences between ruby 1.8.7 and 1.9.3
-      # this is good enough for now
-      create_directories [base_directory, scratch_directory, output_directory]
-
-      add_promiscuous_instance_variable(:metric_fu_root_directory,MetricFu.root_dir)
-      add_promiscuous_instance_variable(:template_directory,
-                                        File.join(metric_fu_root_directory,
-                                         'lib', 'templates'))
-      add_promiscuous_instance_variable(:file_globs_to_ignore,[])
-      set_code_dirs
+    # @param graph_engine [Symbol] the name of an available graph engine
+    def add_graph_engine(graph_engine)
+      @graph_engine_config.add_graph_engine(graph_engine)
     end
 
-    def create_directories(*dirs)
-      Array(*dirs).each do |dir|
-        FileUtils.mkdir_p dir
-      end
+    # @param graph_engine [Symbol] sets the selected graph engine to use
+    def configure_graph_engine(graph_engine)
+      @graph_engine_config.configure_graph_engine(graph_engine)
     end
 
-    # Add the 'app' directory if we're running within rails.
-    def set_code_dirs
-      if rails?
-        add_promiscuous_instance_variable(:code_dirs,['app', 'lib'])
-      else
-        add_promiscuous_instance_variable(:code_dirs,['lib'])
-      end
-    end
   end
 end