metric_fu 4.11.4 → 4.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 834d485742a2a76cd17281abed4170463309ce5a
-  data.tar.gz: e8eac12b0defc2efaf922b9a1d9a0d305f8f93e5
+  metadata.gz: 17c8fa2540d144f89979c7f5586a71c3889a29f5
+  data.tar.gz: 23514588a8ce5ab8ebea208c91874c220db2a1fc
 SHA512:
-  metadata.gz: 93253f831c2868e1381702b62eeb22688478fbd800adc9a8193ffecc9a9514e7108c0eb8b9ef4d934b14c061aae9b4a5142780e30887f8cdcf41cbc139251aa9
-  data.tar.gz: 0fb59ee589b173d597ba2a6254ce8553d365fe65e6c2c3360150b7a1121bfa32d453f674ed02462671809def47224baac67999f079f37f09943849f97866115f
+  metadata.gz: 81f84088449c69e96c1e3830e3d938e0cef39d6e81b68c69699924f71d6e012d3b4ef055d19df66ba067a59c202f2fd5f33bfafefae1b4817f678596f79ac232
+  data.tar.gz: 3da37a9252de3c65890b68c5593b9cab45fdaf86a1b36f995c2a3f609787c22382810ab7d5eb3210c1275823eceeef937e2b6111baa52afb0925b823d059f485

data/HISTORY.md

@@ -4,13 +4,22 @@ Each change should fall into categories that would affect whether the release is
 
 As such, a _Feature_ would map to either major (breaking change) or minor. A _bug fix_ to a patch.  And _misc_ is either minor or patch, the difference being kind of fuzzy for the purposes of history.  Adding tests would be patch level.
 
-### Master [changes](https://github.com/metricfu/metric_fu/compare/v4.11.4...master)
+### Master [changes](https://github.com/metricfu/metric_fu/compare/v4.12.0...master)
 
 * Breaking Changes
 * Features
 * Fixes
 * Misc
 
+### [4.12.0](https://github.com/metricfu/metric_fu/compare/v4.11.4...v4.12.0)
+
+* Features
+  * Add line numbers to reek output. (ggallen, #255)
+  * Use reek directly. (Martin Gotink, #258)
+  * Add support for reek 2. (Martin Gotink, #258)
+* Fixes
+  * Use same styling for covered as ignored lines. (Martin Gotink, #254)
+
 ### [4.11.4](https://github.com/metricfu/metric_fu/compare/v4.11.3...v4.11.4)
 
 * Fixes

data/checksum/metric_fu-4.11.4.gem.sha512

@@ -0,0 +1 @@
+9a74861bf6d89f703786e562cdff96eea727aac874e0d9615d4ac8af57b2c97d15e2121de8d978b7097b56bd72b40744c9a27be9d3d12f9ecf75b66ac565e3ef

data/lib/metric_fu/metrics/rcov/rcov_line.rb

@@ -40,9 +40,9 @@ module MetricFu
     end
 
     def css_class
-      return "" if ignored?
+      return "rcov_not_run" if missed?
 
-      missed? ? "rcov_not_run" : "rcov_run"
+      "rcov_run"
     end
   end
 end

data/lib/metric_fu/metrics/reek/generator.rb

@@ -1,7 +1,5 @@
 module MetricFu
   class ReekGenerator < Generator
-    REEK_REGEX = /^(\S+) (.*) \((.*)\)$/
-
     def self.metric
       :reek
     end
@@ -10,36 +8,20 @@ module MetricFu
       files = files_to_analyze
       if files.empty?
         mf_log "Skipping Reek, no files found to analyze"
-        @output = ""
+        @output = run!([], config_files)
       else
-        args = cli_options(files)
-        @output = run!(args)
-        @output = massage_for_reek_12 if reek_12?
+        @output = run!(files, config_files)
       end
     end
 
-    def run!(args)
-      require "reek/cli/application"
-
-      MetricFu::Utility.capture_output do
-        Reek::Cli::Application.new(args).execute
-      end
+    def run!(files, config_files)
+      examiner.new(files, config_files)
     end
 
     def analyze
-      @matches = @output.chomp.split("\n\n").map { |m| m.split("\n") }
-      @matches = @matches.map do |match|
-        break {} if zero_warnings?(match)
-        file_path = match.shift.split(" -- ").first
-        file_path = file_path.gsub('"', " ").strip
-        code_smells = match.map do |smell|
-          match_object = smell.match(REEK_REGEX)
-          next unless match_object
-          { method: match_object[1].strip,
-            message: match_object[2].strip,
-            type: match_object[3].strip }
-        end.compact
-        { file_path: file_path, code_smells: code_smells }
+      @matches = @output.smells.group_by(&:source).collect do |file_path, smells|
+        { file_path: file_path,
+          code_smells: analyze_smells(smells) }
       end
     end
 
@@ -67,31 +49,6 @@ module MetricFu
       end
     end
 
-    def reek_12?
-      return false if @output.length == 0
-      (@output =~ /^"/) != 0
-    end
-
-    def massage_for_reek_12
-      section_break = ""
-      @output.split("\n").map do |line|
-        case line
-        when /^  /
-          "#{line.gsub(/^  /, '')}\n"
-        else
-          parts = line.split(" -- ")
-          if parts[1].nil?
-            "#{line}\n"
-          else
-            warnings = parts[1].gsub(/ \(.*\):/, ":")
-            result = "#{section_break}\"#{parts[0]}\" -- #{warnings}\n"
-            section_break = "\n"
-            result
-          end
-        end
-      end.join
-    end
-
     private
 
     def files_to_analyze
@@ -100,47 +57,36 @@ module MetricFu
       remove_excluded_files(files_to_reek)
     end
 
-    def cli_options(files)
-      [
-        disable_line_number_option,
-        turn_off_color,
-        *config_option,
-        *files
-      ].reject(&:empty?)
-    end
-
     # TODO: Check that specified line config file exists
-    def config_option
-      config_file_pattern =  options[:config_file_pattern]
-      if config_file_pattern.to_s.empty?
-        [""]
-      else
-        ["--config", config_file_pattern]
-      end
+    def config_files
+      Array(options[:config_file_pattern])
     end
 
-    # Work around "Error: invalid option: --no-color" in reek < 1.3.7
-    def turn_off_color
-      if reek_version >= "1.3.7"
-        "--no-color"
-      else
-        ""
-      end
+    def analyze_smells(smells)
+      smells.collect(&method(:smell_data))
     end
 
-    def reek_version
-      @reek_version ||=  `reek --version`.chomp.sub(/\s*reek\s*/, "")
-      # use the above, as the below may activate a version not available in
-      # a Bundler context
-      # MetricFu::GemVersion.activated_version('reek').to_s
+    def smell_data(smell)
+      { method: smell.context,
+        message: smell.message,
+        type: smell_type(smell),
+        lines: smell.lines }
     end
 
-    def disable_line_number_option
-      "--no-line-numbers"
+    def smell_type(smell)
+      return smell.subclass if smell.respond_to?(:subclass)
+
+      smell.smell_type
     end
 
-    def zero_warnings?(match)
-      match.last == "0 total warnings"
+    def examiner
+      require "reek"
+      # To load any changing dependencies such as "reek/configuration/app_configuration"
+      #   Added in 1.6.0 https://github.com/troessner/reek/commit/7f4ed2be442ca926e08ccc41945e909e8f710947
+      #   But not always loaded
+      require "reek/cli/application"
+
+      Reek.const_defined?(:Examiner) ? Reek.const_get(:Examiner) : Reek.const_get(:Core).const_get(:Examiner)
     end
   end
 end

data/lib/metric_fu/version.rb

@@ -1,3 +1,9 @@
 module MetricFu
-  VERSION = "4.11.4"
+  class Version
+    MAJOR = "4"
+    MINOR = "12"
+    PATCH = "0"
+    PRE   = ""
+  end
+  VERSION = [Version::MAJOR, Version::MINOR, Version::PATCH].join(".")
 end

data/metric_fu.gemspec

@@ -45,7 +45,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "flay",                  [">= 2.0.1",  "~> 2.1"]
   s.add_runtime_dependency "churn",                 ["~> 0.0.35"]
   s.add_runtime_dependency "flog",                  [">= 4.1.1",  "~> 4.1"]
-  s.add_runtime_dependency "reek",                  [">= 1.3.4",  "~> 1.3"]
+  s.add_runtime_dependency "reek",                  [">= 1.3.4",  "< 3.0"]
   s.add_runtime_dependency "cane",                  [">= 2.5.2",  "~> 2.5"]
   s.add_runtime_dependency "rails_best_practices",  [">= 1.14.3", "~> 1.14"]
   s.add_runtime_dependency "metric_fu-Saikuro",     [">= 1.1.3",  "~> 1.1"]

data/spec/capture_warnings.rb

@@ -7,10 +7,10 @@ require "tempfile"
 require "fileutils"
 
 stderr_file = Tempfile.new("app.stderr")
-app_dir = File.expand_path("../..", __FILE__)
-output_dir = File.join(app_dir, "tmp")
+app_root ||= Dir.pwd
+output_dir = File.join(app_root, "tmp")
 FileUtils.mkdir_p(output_dir)
-bundle_dir = File.join(app_dir, "bundle")
+bundle_dir = File.join(app_root, "bundle")
 
 RSpec.configure do |config|
   config.before(:suite) do
@@ -25,9 +25,9 @@ RSpec.configure do |config|
 
     $stderr.reopen(STDERR)
 
-    app_warnings, other_warnings = lines.partition do |line|
-      line.include?(app_dir) && !line.include?(bundle_dir)
-    end
+    app_warnings, other_warnings = lines.partition { |line|
+      line.include?(app_root) && !line.include?(bundle_dir)
+    }
 
     if app_warnings.any?
       puts <<-WARNINGS
@@ -40,13 +40,16 @@ RSpec.configure do |config|
     end
 
     if other_warnings.any?
-      File.write(File.join(output_dir, "warnings.txt"), other_warnings.join("\n") << "\n")
+      output_file = File.join(output_dir, "warnings.txt")
+      File.write(output_file, other_warnings.join("\n") << "\n")
       puts
       puts "Non-app warnings written to tmp/warnings.txt"
       puts
     end
 
     # fail the build...
-    abort "Failing build due to app warnings: #{app_warnings.inspect}" if app_warnings.any?
+    if app_warnings.any?
+      abort "Failing build due to app warnings: #{app_warnings.inspect}"
+    end
   end
 end

data/spec/metric_fu/metrics/rcov/rcov_line_spec.rb

@@ -71,9 +71,9 @@ describe MetricFu::RCovLine do
   end
 
   describe "#css_class" do
-    it "returns '' for an ignored line" do
+    it "returns 'rcov_run' for an ignored line" do
       rcov_line = RCovLine.new("", nil)
-      expect(rcov_line.css_class).to eq("")
+      expect(rcov_line.css_class).to eq("rcov_run")
     end
 
     it "returns 'rcov_not_run' for a missed line" do

data/spec/metric_fu/metrics/reek/generator_spec.rb

@@ -13,80 +13,102 @@ describe MetricFu::ReekGenerator do
 
     it "includes config file pattern into reek parameters when specified" do
       options.merge!(config_file_pattern: "lib/config/*.reek")
-      expect(reek).to receive(:run!) do |args|
-        expect(args).to include("--config", "lib/config/*.reek")
-      end.and_return("")
-      reek.emit
-    end
 
-    it "doesn't add an empty parameter when no config file pattern is specified" do
-      expect(reek).to receive(:run!) do |args|
-        expect(args).not_to include("")
+      expect(reek).to receive(:run!) do |_files, config_files|
+        expect(config_files).to eq(["lib/config/*.reek"])
       end.and_return("")
-      reek.emit
-    end
 
-    it "turns off color output from reek output, for reek 1.3.7 or greater" do
-      allow(reek).to receive(:reek_version).and_return("1.3.7")
-      expect(reek).to receive(:run!) do |args|
-        expect(args).to include("--no-color")
-      end.and_return("")
       reek.emit
     end
 
-    it "does not set an (invalid) --no-color option for reek < 1.3.7" do
-      allow(reek).to receive(:reek_version).and_return("1.3.6")
-      expect(reek).to receive(:run!) do |args|
-        expect(args).not_to include("--no-color")
+    it "passes an empty array when no config file pattern is specified" do
+      expect(reek).to receive(:run!) do |_files, config_files|
+        expect(config_files).to eq([])
       end.and_return("")
-      reek.emit
-    end
 
-    it "disables lines numbers from reek output" do
-      expect(reek).to receive(:run!) do |args|
-        expect(args).to include("--no-line-numbers")
-      end.and_return("")
       reek.emit
     end
 
     it "includes files to analyze into reek parameters" do
-      expect(reek).to receive(:run!) do |args|
-        expect(args).to include("lib/foo.rb", "lib/bar.rb")
+      expect(reek).to receive(:run!) do |files, _config_files|
+        expect(files).to eq(["lib/foo.rb", "lib/bar.rb"])
       end.and_return("")
+
       reek.emit
     end
   end
 
-  # TODO review tested output
   describe "analyze method" do
     before :each do
       MetricFu::Configuration.run {}
       allow(File).to receive(:directory?).and_return(true)
       @reek = MetricFu::ReekGenerator.new
+      @examiner = @reek.send(:examiner)
+      @smell_warning = Reek.const_defined?(:SmellWarning) ? Reek.const_get(:SmellWarning) : Reek.const_get(:Smells).const_get(:SmellWarning)
+      if @smell_warning.instance_methods.include?(:subclass)
+        @smell_warning.send(:alias_method, :smell_type, :subclass)
+      end
     end
 
     context "with reek warnings" do
       before :each do
-        @lines = <<-HERE
-"app/controllers/activity_reports_controller.rb" -- 4 warnings:
-ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
-ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
-ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
-ActivityReportsController#authorize_user has approx 6 statements (Long Method)
-
-"app/controllers/application.rb" -- 1 warnings:
-ApplicationController#start_background_task/block/block is nested (Nested Iterators)
-
-"app/controllers/link_targets_controller.rb" -- 1 warnings:
-LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
-
-"app/controllers/newline_controller.rb" -- 1 warnings:
-NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
-      HERE
+        @smells = [
+            instance_double(@smell_warning,
+                            source: "app/controllers/activity_reports_controller.rb",
+                            context: "ActivityReportsController#authorize_user",
+                            message: "calls current_user.primary_site_ids multiple times",
+                            smell_type: "Duplication",
+                            lines: [2, 4]),
+            instance_double(@smell_warning,
+                            source: "app/controllers/activity_reports_controller.rb",
+                            context: "ActivityReportsController#authorize_user",
+                            message: "calls params[id] multiple times",
+                            smell_type: "Duplication",
+                            lines: [5, 7]),
+            instance_double(@smell_warning,
+                            source: "app/controllers/activity_reports_controller.rb",
+                            context: "ActivityReportsController#authorize_user",
+                            message: "calls params[primary_site_id] multiple times",
+                            smell_type: "Duplication",
+                            lines: [11, 15]),
+            instance_double(@smell_warning,
+                            source: "app/controllers/activity_reports_controller.rb",
+                            context: "ActivityReportsController#authorize_user",
+                            message: "has approx 6 statements",
+                            smell_type: "Long Method",
+                            lines: [8]),
+
+            instance_double(@smell_warning,
+                            source: "app/controllers/application.rb",
+                            context: "ApplicationController#start_background_task/block/block",
+                            message: "is nested",
+                            smell_type: "Nested Iterators",
+                            lines: [23]),
+
+            instance_double(@smell_warning,
+                            source: "app/controllers/link_targets_controller.rb",
+                            context: "LinkTargetsController#authorize_user",
+                            message: "calls current_user.role multiple times",
+                            smell_type: "Duplication",
+                            lines: [8]),
+
+            instance_double(@smell_warning,
+                            source: "app/controllers/newline_controller.rb",
+                            context: "NewlineController#some_method",
+                            message: "calls current_user.<< \"new line\n\" multiple times",
+                            smell_type: "Duplication",
+                            lines: [6, 9])
+        ]
+        @lines = instance_double(@examiner, smells: @smells)
         @reek.instance_variable_set(:@output, @lines)
         @matches = @reek.analyze
       end
 
+      it "should find the code smell's line numbers" do
+        smell = @matches.first[:code_smells].first
+        expect(smell[:lines]).to eq([2, 4])
+      end
+
       it "should find the code smell's method name" do
         smell = @matches.first[:code_smells].first
         expect(smell[:method]).to eq("ActivityReportsController#authorize_user")
@@ -109,91 +131,39 @@ NewlineController#some_method calls current_user.<< "new line\n" multiple times
 
       it "should NOT insert nil smells into the array when there's a newline in the method call" do
         expect(@matches.last[:code_smells]).to eq(@matches.last[:code_smells].compact)
-        expect(@matches.last).to eq(file_path: "app/controllers/newline_controller.rb",
-                                    code_smells: [{ type: "Duplication",
-                                                    method: "\"",
-                                                    message: "multiple times" }])
-        # Note: hopefully a temporary solution until I figure out how to deal with newlines in the method call more effectively -Jake 5/11/2009
       end
     end
 
-    context "without reek warnings" do
+    context "with reek 1.3 output" do
       before :each do
-        @lines = <<-HERE
-
-0 total warnings
-      HERE
+        @smells = [
+            double(source: "app/controllers/activity_reports_controller.rb",
+                   context: "ActivityReportsController#authorize_user",
+                   message: "calls current_user.primary_site_ids multiple times",
+                   subclass: "Duplication",
+                   lines: [2, 4]),
+        ]
+        @lines = instance_double(@examiner, smells: @smells)
         @reek.instance_variable_set(:@output, @lines)
         @matches = @reek.analyze
       end
 
-      it "returns empty analysis" do
-        expect(@matches).to eq({})
+      it "uses the subclass field to find the smell type" do
+        smell = @matches.first[:code_smells].first
+        expect(smell[:type]).to eq('Duplication')
       end
     end
-  end
-end
-
-describe MetricFu::ReekGenerator do
-  before :each do
-    MetricFu::Configuration.run {}
-    @reek = MetricFu::ReekGenerator.new
-    @lines11 = <<-HERE
-"app/controllers/activity_reports_controller.rb" -- 4 warnings:
-ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
-ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
-ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
-ActivityReportsController#authorize_user has approx 6 statements (Long Method)
-
-"app/controllers/application.rb" -- 1 warnings:
-ApplicationController#start_background_task/block/block is nested (Nested Iterators)
-
-"app/controllers/link_targets_controller.rb" -- 1 warnings:
-LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
-
-"app/controllers/newline_controller.rb" -- 1 warnings:
-NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
-      HERE
-    @lines12 = <<-HERE
-app/controllers/activity_reports_controller.rb -- 4 warnings (+3 masked):
-  ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
-  ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
-  ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
-  ActivityReportsController#authorize_user has approx 6 statements (Long Method)
-app/controllers/application.rb -- 1 warnings:
-  ApplicationController#start_background_task/block/block is nested (Nested Iterators)
-app/controllers/link_targets_controller.rb -- 1 warnings (+1 masked):
-  LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
-app/controllers/newline_controller.rb -- 1 warnings:
-  NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
-      HERE
-  end
-
-  context "with Reek 1.1 output format" do
-    it "reports 1.1 style when the output is empty" do
-      @reek.instance_variable_set(:@output, "")
-      expect(@reek).not_to be_reek_12
-    end
-    it "detects 1.1 format output" do
-      @reek.instance_variable_set(:@output, @lines11)
-      expect(@reek).not_to be_reek_12
-    end
-
-    it "massages empty output to be unchanged" do
-      @reek.instance_variable_set(:@output, "")
-      expect(@reek.massage_for_reek_12).to be_empty
-    end
-  end
 
-  context "with Reek 1.2 output format" do
-    it "detects 1.2 format output" do
-      @reek.instance_variable_set(:@output, @lines12)
-      expect(@reek).to be_reek_12
-    end
+    context "without reek warnings" do
+      before :each do
+        @lines = instance_double(@examiner, smells: [])
+        @reek.instance_variable_set(:@output, @lines)
+        @matches = @reek.analyze
+      end
 
-    it "correctly massages 1.2 output" do
-      @reek.instance_variable_set(:@output, @lines12)
-      expect(@reek.massage_for_reek_12).to eq(@lines11)
+      it "returns empty analysis" do
+        expect(@matches).to eq([])
+      end
     end
   end
 end

data/spec/quality_spec.rb

@@ -8,18 +8,39 @@ if defined?(Encoding) && Encoding.default_external != "UTF-8"
 end
 
 RSpec.describe "The library itself" do
+  # For some reason RSpec may expect this to be defined
+  # and crash really bad without it
+  def self.uses_transaction?(*)
+    false
+  end
+
+  def encode_utf8!(string)
+    string.encode!(Encoding::UTF_8,
+                   invalid: :replace,
+                   undef: :replace,
+                   replace: "<?>".freeze
+                  )
+  end
+
+  def ignore_whitespace?(filename)
+    @whitespace_regex ||=
+      /\.gitmodules|fixtures|vendor|LICENSE|etc|db|public|reports/
+    !!(filename =~ @whitespace_regex)
+  end
+
   def check_for_spec_defs_with_single_quotes(filename)
     failing_lines = []
 
     File.readlines(filename).each_with_index do |line, number|
-      line.encode!(Encoding::UTF_8, invalid: :replace, undef: :replace, replace: "<?>")
+      encode_utf8!(line)
       failing_lines << number + 1 if line =~ /^ *(describe|it|context) {1}'{1}/
     end
 
-    unless failing_lines.empty?
+    if failing_lines.any?
       # Prevent rubocop from looping infinitely
       # rubocop:disable Style/StringLiterals
-      "#{filename} uses inconsistent single quotes on lines #{failing_lines.join(', ')}"
+      "#{filename} uses inconsistent single quotes "\
+      "on lines #{failing_lines.join(', ')}"
       # rubocop:enable Style/StringLiterals
     end
   end
@@ -27,7 +48,7 @@ RSpec.describe "The library itself" do
   def check_for_tab_characters(filename)
     failing_lines = []
     File.readlines(filename).each_with_index do |line, number|
-      line.encode!(Encoding::UTF_8, invalid: :replace, undef: :replace, replace: "<?>")
+      encode_utf8!(line)
       failing_lines << number + 1 if line =~ /\t/
     end
 
@@ -42,7 +63,7 @@ RSpec.describe "The library itself" do
   def check_for_extra_spaces(filename)
     failing_lines = []
     File.readlines(filename).each_with_index do |line, number|
-      line.encode!(Encoding::UTF_8, invalid: :replace, undef: :replace, replace: "<?>")
+      encode_utf8!(line)
       next if line =~ /^\s+#.*\s+\n$/
       failing_lines << number + 1 if line =~ /\s+\n$/
     end
@@ -63,15 +84,12 @@ RSpec.describe "The library itself" do
     match(&:empty?)
   end
 
-  WHITESPACE_OK =
-    /\.gitmodules|\.marshal|fixtures|ssl_certs|vendor|LICENSE|etc|reports/
-
   it "has no malformed whitespace" do
     error_messages = []
     Dir.chdir(File.expand_path("../..", __FILE__)) do
       `git ls-files -z`.split("\x0").each do |filename|
         next if !File.exist?(filename)
-        next if filename =~ WHITESPACE_OK
+        next if ignore_whitespace?(filename)
         error_messages << check_for_tab_characters(filename)
         error_messages << check_for_extra_spaces(filename)
       end
@@ -83,7 +101,7 @@ RSpec.describe "The library itself" do
     included = /spec/
     error_messages = []
     Dir.chdir(File.expand_path("../", __FILE__)) do
-      `git ls-files -z`.split("\x0").each do |filename|
+      `git ls-files -z spec`.split("\x0").each do |filename|
         next unless filename =~ included
         error_messages << check_for_spec_defs_with_single_quotes(filename)
       end

data/spec/spec_helper.rb

@@ -18,7 +18,9 @@ Dir[MetricFu.root_dir + "/spec/support/**/*.rb"].each { |f| require f }
 RSpec.configure do |config|
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
+  # Skip specs tagged `:slow` unless SLOW_SPECS is set
   config.filter_run_excluding :slow unless ENV["SLOW_SPECS"]
+  # End specs on first failure if FAIL_FAST is set
   config.fail_fast = ENV.include?("FAIL_FAST")
   config.order = :rand
   config.color = true
@@ -27,6 +29,7 @@ RSpec.configure do |config|
   end
   config.mock_with :rspec do |mocks|
     mocks.syntax = :expect
+    mocks.verify_partial_doubles = true
   end
 
   # :suite after/before all specs

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metric_fu
 version: !ruby/object:Gem::Version
-  version: 4.11.4
+  version: 4.12.0
 platform: ruby
 authors:
 - Jake Scruggs
@@ -19,30 +19,8 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIDmjCCAoKgAwIBAgIBATANBgkqhkiG9w0BAQUFADBJMQ8wDQYDVQQDDAZnaXRo
-  dWIxITAfBgoJkiaJk/IsZAEZFhFiZW5qYW1pbmZsZWlzY2hlcjETMBEGCgmSJomT
-  8ixkARkWA2NvbTAeFw0xNTAxMjIxMzAyNTNaFw0xNjAxMjIxMzAyNTNaMEkxDzAN
-  BgNVBAMMBmdpdGh1YjEhMB8GCgmSJomT8ixkARkWEWJlbmphbWluZmxlaXNjaGVy
-  MRMwEQYKCZImiZPyLGQBGRYDY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB
-  CgKCAQEA7V1VZBU7Aft01XAoK8I8tdClfv3H/NIauiV0jfyNtXtZEWwaZ6ooZNLk
-  8kmIUsO2xI7I/B3es6w7le9q9xdEowlYjiR/X/yazNvufu5kpM4f6Ri1AKN8xvPk
-  LFlR8aOAd9LptcusYDfE+BjhmAvnLTgMGODcDLJIaJzLJaRywTLUuFv4digpFwCm
-  Zps9VheJnL4hkgI5BDn6DVjxHSCMRnccQM/kX9L34lbP9KkHXXEtQgkQYpElHbnd
-  MtR753aPeLfOBxSGzsso+6Lhe+fz8huD05mzgWaEZN40e6M7dA9FRSsEzL32ZOad
-  0z13MZWj3Yg5srV/cZvzCDCdVvRphwIDAQABo4GMMIGJMAkGA1UdEwQCMAAwCwYD
-  VR0PBAQDAgSwMB0GA1UdDgQWBBQvUrPExdvmdz0Vau0dH3hRh1YQfDAnBgNVHREE
-  IDAegRxnaXRodWJAYmVuamFtaW5mbGVpc2NoZXIuY29tMCcGA1UdEgQgMB6BHGdp
-  dGh1YkBiZW5qYW1pbmZsZWlzY2hlci5jb20wDQYJKoZIhvcNAQEFBQADggEBAEWo
-  g1soMaRTT/OfFklTuP+odV0w+2qJSfJhOY5bIebDjqxb9BN7hZJ9L6WXhcXCvl6r
-  kuXjpcC05TIv1DoWWaSjGK2ADmEBDNVhaFepYidAYuUQN4+ZjVH/gS9V9OkBcE8h
-  3ZwRv+9RkXM0uY1FwuGI6jgbgPeR1AkkfJnhOPohkG+VN5bFo9aK/Stw8Nwhuuiz
-  axCPD3cmaJBguufRXSMC852SDiBT7AtI4Gl2Fyr+0M5TzXHKbQ9xRBxwfE1bWDd6
-  lEs7ndJ1/vd/Hy0zQ1tIRWyql+ITLhqMi161Pw5flsYpQvPlRLR5pGJ4eD0/JdKE
-  ZG9WSFH7QcGLY65mEYc=
-  -----END CERTIFICATE-----
-date: 2015-02-27 00:00:00.000000000 Z
+- certs/bf4.pem
+date: 2015-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
@@ -105,9 +83,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.4
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -115,9 +93,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.4
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: cane
   requirement: !ruby/object:Gem::Requirement
@@ -369,6 +347,7 @@ files:
 - checksum/metric_fu-4.11.1.gem.sha512
 - checksum/metric_fu-4.11.2.gem.sha512
 - checksum/metric_fu-4.11.3.gem.sha512
+- checksum/metric_fu-4.11.4.gem.sha512
 - checksum/metric_fu-4.2.0.gem.sha512
 - checksum/metric_fu-4.2.1.gem.sha512
 - checksum/metric_fu-4.3.0.gem.sha512
@@ -648,7 +627,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: metric_fu
-rubygems_version: 2.4.3
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: A fistful of code metrics, with awesome templates and graphs

checksums.yaml.gz.sig

@@ -1 +0,0 @@
-+˗�O����8���lz׊�G�t{�b��I�N�yv���ӊ�>y5�ΐ���q�Йd5�z�*뼳�}��I�.��y��bR�"P;N%%=n�O������i3B1���+��t�l��oD������c�M��/���я."?��gK�mH%b<�zw�M��Iɨ���z��遷������ʘdº�#���v �Fh��V!*.��a��hB�wG�7�{��̴����A\	tP�\6u�rM

metadata.gz.sig

@@ -1,3 +0,0 @@
-‡����'@T-d��Ł��*�IZ��Q'�%�ը�-��b��ɵ8���y��.�z�C/�zޡѢ�eTi��KFD8VC��ؑ�����Kn+�h�>��%��BW���m���AoI�>�V�.��3E�[�In~�rUXK��}�=0ln��<��g;��^C�YƠ�*�̻]B�+�8�*�À�>�e�$U�O��(X�Y�z3�!���
-��%����l{��l
-��5��eJ�&;�@���E��~�yE�Qt