method_info 0.1.3 → 0.1.4

data/VERSION

@@ -1 +1 @@
-0.1.3
+0.1.4

data/lib/method_info/ancestor_method_structure.rb

@@ -50,7 +50,7 @@ module MethodInfo
     end
 
     def add_method_to_ancestor(method)
-      ancestor = AncestorMethodStructure.method_owner(@object, method)
+      ancestor = method_owner(method)
       if @ancestors.include?(ancestor)
         @ancestor_methods[ancestor] << method
       end
@@ -101,12 +101,34 @@ module MethodInfo
     end
 
     # Returns the class or module where method is defined
-    def self.method_owner(object, method)
-      # Printing this warning is not spec'ed: it is only here temporarily until the 1.8.6
-      # workaround is implemented
-      STDERR.puts "Ruby >= 1.8.7 required" unless VERSION >= '1.8.7'
-      object.method(method).owner
+    def method_owner(method_symbol)
+      method = @object.method(method_symbol)
+      method.owner
+    rescue
+      poor_mans_method_owner(method, method_symbol.to_s)
     end
 
+    # Ruby 1.8.6 has no Method#owner method, this is a poor man's replacement. It has horrible
+    # performance and may break for other ruby implementations than MRI.
+    def poor_mans_method_owner(method, method_name)
+      # A Method object has no :owner method, but we can infer it's owner from the result of it's
+      # :to_s method. Examples:
+      # 37.method(:rdiv).to_s => "#<Method: Fixnum#rdiv>"
+      # 37.method(:ceil).to_s => "#<Method: Fixnum(Integer)#ceil>"
+      # 37.method(:prec).to_s => "#<Method: Fixnum(Precision)#prec>"
+      # obj.method(:singleton_method).to_s => "#<Method: #<Object:0x5673b8>.singleton_method>"
+      if method.to_s =~ /^#<Method: (.*)[#.]#{Regexp.escape(method_name)}>$/
+        owner_string = $1
+        # Maybe it is a top level class and we're done
+        if owner_string =~ /\w+\((\w+)\)/
+          # Module or subclass (like 'Fixnum(Integer)')
+          owner_string = $1
+        elsif owner_string.include?("#<Object:")
+          # probably the eigen class
+          owner_string = "#<Class:#{owner_string}>"
+        end
+        @ancestors.select { |a| a.to_s == owner_string }.first
+      end
+    end
   end
 end

data/spec/method_info/ancestor_method_structure_spec.rb

@@ -11,5 +11,69 @@ module MethodInfo
       it "should print the methods on an object" do
       end
     end
+
+    describe "method_owner" do
+      it "gets the method from the object" do
+        obj = Object.new
+        obj.should_receive(:method).with(:to_s).and_return(mock('method', :owner => nil))
+        ams = AncestorMethodStructure.new(obj,
+                                          :ancestors_to_show => [],
+                                          :ancestors_to_exclude => [])
+        ams.send(:method_owner, :to_s)
+      end
+
+      describe "for ruby >= 1.8.7" do
+        it "gets the owner of the method and returns it" do
+          obj = mock('object')
+          mock_method = mock('method')
+          obj.stub!(:method).and_return(mock_method)
+          mock_method.should_receive(:owner).and_return :foo
+          ams = AncestorMethodStructure.new(obj,
+                                            :ancestors_to_show => [],
+                                            :ancestors_to_exclude => [])
+          ams.send(:method_owner, :to_s).should == :foo
+        end
+      end
+
+      describe "for ruby 1.8.6" do
+        it "should use the poor_mans_method_owner" do
+          obj = mock('object')
+          mock_method = mock('method', :to_s => 'mock_method_name')
+          obj.stub!(:method).and_return(mock_method)
+          mock_method.stub!(:owner).and_raise NameError
+          ams = AncestorMethodStructure.new(obj,
+                                            :ancestors_to_show => [],
+                                            :ancestors_to_exclude => [])
+          ams.should_receive(:poor_mans_method_owner).with(mock_method, "to_i")
+          ams.send(:method_owner, :to_i)
+        end
+
+        describe "poor_mans_method_owner" do
+          it "finds the owner if it is the base clas" do
+            ams = AncestorMethodStructure.new(37, {})
+            ams.send(:poor_mans_method_owner, 37.method(:rdiv), "rdiv").should == Fixnum
+          end
+
+          it "finds the owner if it is a super clas" do
+            ams = AncestorMethodStructure.new(37, {})
+            ams.send(:poor_mans_method_owner, 37.method(:ceil), "ceil").should == Integer
+          end
+
+          it "finds the owner if it is a module" do
+            ams = AncestorMethodStructure.new(37, {})
+            ams.send(:poor_mans_method_owner, 37.method(:prec), "prec").should == Precision
+          end
+
+          it "finds the owner if it is the eigenclass" do
+            obj = Object.new
+            def obj.foo
+              :foo
+            end
+            ams = AncestorMethodStructure.new(obj, :singleton_methods => true)
+            ams.send(:poor_mans_method_owner, obj.method(:foo), "foo").should == class << obj; self; end
+          end
+        end
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: method_info
 version: !ruby/object:Gem::Version 
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors: 
 - Tom ten Thij