method_info 0.1.9 → 0.1.10

data/VERSION

@@ -1 +1 @@
-0.1.9
+0.1.10

data/lib/method_info/ancestor_method_structure.rb

@@ -23,28 +23,13 @@ module MethodInfo
     # :suppress_slowness_warning Does not print out the warning about slowness on older ruby versions (default: false)
     # :match Shows only those methods that match this option. It's value can be either a string or a regexp (default: nil)
     def self.build(object, options)
-      if VERSION < "1.8.7" && !options[:suppress_slowness_warning]
-        STDERR.puts "You are using Ruby #{VERSION}, this may take a while. It will be faster for >=1.8.7."
+      # print warning message if a Method does not support the :owner method
+      if !options[:suppress_slowness_warning] && ! Method.instance_methods.include?("owner")
+        STDERR.puts "You are using a Ruby version (#{RUBY_VERSION}) that does not support the owner method of a Method - this may take a while. It will be faster for >=1.8.7."
       end
 
-      methods = []
-      methods += object.methods if options[:public_methods]
-      methods += object.protected_methods if options[:protected_methods]
-      methods += object.private_methods if options[:private_methods]
-      methods -= object.singleton_methods unless options[:singleton_methods]
-
       ancestor_method_structure = AncestorMethodStructure.new(object, options)
-
-      if(match = options[:match])
-        unless match.is_a?(Regexp)
-          match = Regexp.new(match)
-        end
-        methods = methods.select { |m| m =~ match }
-      end
-
-      methods.each do |method|
-        ancestor_method_structure.add_method_to_ancestor(method)
-      end
+      ancestor_method_structure.add_selected_methods_to_structure
       ancestor_method_structure
     end
 
@@ -130,8 +115,33 @@ module MethodInfo
       s
     end
 
+    def add_selected_methods_to_structure
+      select_methods
+      apply_match_filter_to_methods
+      @methods.each do |method|
+        add_method_to_ancestor(method)
+      end
+    end
+
     private
 
+    def select_methods
+      @methods = []
+      @methods += @object.methods if @options[:public_methods]
+      @methods += @object.protected_methods if @options[:protected_methods]
+      @methods += @object.private_methods if @options[:private_methods]
+      @methods -= @object.singleton_methods unless @options[:singleton_methods]
+    end
+
+    def apply_match_filter_to_methods
+      if(match = @options[:match])
+        unless match.is_a?(Regexp)
+          match = Regexp.new(match)
+        end
+        @methods = @methods.select { |m| m =~ match }
+      end
+    end
+
     def methodless_ancestors
       @ancestor_filter.picked.select { |ancestor| @ancestor_methods[ancestor].empty? }
     end

data/spec/method_info/ancestor_method_structure_spec.rb

@@ -8,7 +8,31 @@ module MethodInfo
     end
 
     describe "AncestorMethodStructure::build" do
-      it "should print the methods on an object" do
+      describe "if a Method does not support the :owner method" do
+        before do
+          Method.stub!(:instance_methods).and_return ["foo"]
+        end
+
+        it "should print a warning message" do
+          STDERR.should_receive :puts
+          AncestorMethodStructure.build(:foo, {})
+        end
+
+        it "should not print a warning message if :suppress_slowness_warning is set" do
+          STDERR.should_not_receive :puts
+          AncestorMethodStructure.build(:foo, :suppress_slowness_warning => true)
+        end
+      end
+
+      describe "if a Method supports the :owner method" do
+        before do
+          Method.stub!(:instance_methods).and_return ["foo", "owner"]
+        end
+
+        it "should not print a warning message" do
+          STDERR.should_not_receive :puts
+          AncestorMethodStructure.build(:foo, {})
+        end
       end
     end
 

metadata

@@ -1,12 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: method_info
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 9
-  version: 0.1.9
+  version: 0.1.10
 platform: ruby
 authors: 
 - Tom ten Thij
@@ -14,35 +9,29 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-27 00:00:00 +00:00
+date: 2010-03-18 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 2
-        - 9
         version: 1.2.9
-  type: :development
-  version_requirements: *id001
+    version: 
 - !ruby/object:Gem::Dependency 
   name: cucumber
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
-  type: :development
-  version_requirements: *id002
+    version: 
 description: Defines a method_info method on every Object instance which provides information about methods that are defined on the object and the location where they were defined
 email: method_info@tomtenthij.nl
 executables: []
@@ -87,20 +76,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Get info about an object's methods