metatag_cop 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a261480a5e5bbc7214c796a0cd1bee10666c8708
-  data.tar.gz: 872bf784efc1622d25780e68c8b6b51d84fcdcdb
+  metadata.gz: f040b160b5d89f9f6a5233168f5c433dd1cc6e43
+  data.tar.gz: 8707ed68c05b56a66500b3f1b7df89255003cda7
 SHA512:
-  metadata.gz: 6e99fb777035c40f823fe622087ec5262dc0893eb16da1c2b8112dd57293702f84990bf0629d7f943b11b779708ed3a4f78befe77c3541da7efb09dcbefb3652
-  data.tar.gz: fd1fe03226c003eddefa577110b79ab93af0cf0006cf3022d0381ba5cb3ce4c186030e91c6c92f70bb889950bc7b08c2bfd33def82700d7426c0f68ad5f98cf3
+  metadata.gz: 5bb21a4816504a1ee81f99389923066091deab3d610d3f8a67b298d3df7d4ff7a92afb486ed8805d3a1662c69682dd17234f575c1f041cdb334c17d95919febd
+  data.tar.gz: 2423bc403267a13ea729fe44bfde665a2859ad41837280b27ed4a5c8df2c26540d56f522628d9494de632a36abb6298edc1db73818ce958c14f86d247d56fb34

data/.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.3.1
 
 Metrics/PerceivedComplexity:
   Enabled: false

data/Gemfile.lock

@@ -1,13 +1,18 @@
 PATH
   remote: .
   specs:
-    metatag_cop (0.1.0)
+    metatag_cop (0.1.3)
+      formatador (~> 0.2.5)
+      kosi (~> 1.0)
       nokogiri (~> 1.7)
 
 GEM
   remote: https://rubygems.org/
   specs:
     diff-lcs (1.3)
+    formatador (0.2.5)
+    kosi (1.0.0)
+      unicode (>= 0.4.4)
     mini_portile2 (2.1.0)
     nokogiri (1.7.1)
       mini_portile2 (~> 2.1.0)
@@ -25,6 +30,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
+    unicode (0.4.4.4)
 
 PLATFORMS
   ruby

data/README.md

@@ -1,6 +1,9 @@
 # MetatagCop
 
-MetatagCop loads csv file and checks whether meta tags is set proper value.
+MetatagCop loads csv file and checks whether meta tags is set proper value.  
+Any questions, issues and pull requests are welcome!
+
+[![https://gyazo.com/ad116c7c62b7782320a8fe50ba5f8b99](https://i.gyazo.com/ad116c7c62b7782320a8fe50ba5f8b99.gif)](https://gyazo.com/ad116c7c62b7782320a8fe50ba5f8b99)
 
 ## Installation
 
@@ -28,7 +31,24 @@ https://www.google.co.jp/,      exepected title here, exepected description here
 https://www.google.com/doodles, exepected title here, exepected description here, exepected h1 here
 ```
 
-2. Run ` $ metatag_cop file_path `
+2. Run ` $ metatag_cop file_path ` like this.
+
+` $ metatag_cop ~/sample.csv `
+
+3. Check result in the console.
+
+```
+url: https://www.google.co.jp/
+[title] expected: exepected title here, actual: Google
+[description] expected: exepected description here, actual: 世界中のあらゆる情報を検索するためのツールを提供しています。さまざまな検索機能を活用して、お探しの情報を見つけてください。
+[keywords] expected: exepected keywords here, actual:
+[h1] expected: exepected h1 here, actual:
+url: https://www.google.com/doodles
+[title] expected: exepected title here, actual: Google Doodles
+[description] expected: exepected description here, actual:
+[keywords] expected: exepected keywords here, actual:
+[h1] expected: exepected h1 here, actual:
+```
 
 ## Development
 

data/bin/metatag_cop

@@ -2,4 +2,4 @@
 
 require 'metatag_cop'
 
-puts MetatagCop::Handler.execute
+MetatagCop::Handler.execute

data/lib/metatag_cop.rb

@@ -1,4 +1,6 @@
 require 'csv'
+require 'formatador'
+require 'kosi'
 
 require 'metatag_cop/version'
 require 'metatag_cop/handler'

data/lib/metatag_cop/cops/cop.rb

@@ -4,31 +4,53 @@ module MetatagCop
   module Cops
     #
     class Cop
-      attr_reader :records
+      attr_reader :records, :progress
 
       def initialize(records)
         @records = records
+        @progress = Formatador::ProgressBar.new(
+          records.length, color: 'green'
+        )
       end
 
       def run
-        error_msgs = []
+        results = []
         records.each do |record|
-          error_msg = []
+          result = []
           parser = MetatagCop::Parser.new(record.url)
-          error_msg.push error_msg(:title, record.title, parser.title)  unless parser.title == record.title
-          error_msg.push error_msg(:description, record.description, parser.description) unless parser.description == record.description
-          error_msg.push error_msg(:keywords, record.keywords, parser.keywords) unless parser.keywords == record.keywords
-          error_msg.push error_msg(:h1, record.h1, parser.h1) unless parser.h1 == record.h1
-          error_msg.unshift "url: #{record.url}" unless error_msg.empty?
-          error_msgs.push error_msg unless error_msg.empty?
+
+          result.push error_msg(:title, record.title, parser.title) unless parser.title == record.title
+          result.push error_msg(:description, record.description, parser.description) unless parser.description == record.description
+          result.push error_msg(:keywords, record.keywords, parser.keywords) unless parser.keywords == record.keywords
+          result.push error_msg(:h1, record.h1, parser.h1) unless parser.h1 == record.h1
+
+          results.unshift({ url: record.url, res: result }) unless result.empty?
+
+          progress.increment
+        end
+
+        kosi = Kosi::Table.new(connector_char: '-', separate_each_row: true)
+        results.each do |result|
+          Formatador.display_line("[red]#{result[:url]}[/]")
+          result[:res].each do |error|
+            print kosi.render(error)
+          end
         end
-        error_msgs
       end
 
       private
 
       def error_msg(tag, expected, actual)
-        "[#{tag}] expected: #{expected}, actual: #{actual}"
+        [
+          [
+            "[#{tag}] expected",
+            " [#{tag}] actual"
+          ],
+          [
+            "#{expected} ",
+            " #{actual}"
+          ]
+        ]
       end
     end
   end

data/lib/metatag_cop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MetatagCop
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/metatag_cop.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['mailto.takita.yusuke@gmail.com']
 
   spec.summary       = 'metatag_cop loads csv file and checks whether meta tags is set proper value.'
-  spec.description   = 'Any feedback is webcome! You can find me [here](https://twitter.com/3chhe).'
+  spec.description   = 'metatag_cop loads csv file and checks whether meta tags is set proper value.'
   spec.homepage      = 'https://github.com/tackeyy/metatag_cop'
   spec.license       = 'MIT'
 
@@ -23,6 +23,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'nokogiri', '~> 1.7'
+  spec.add_dependency 'formatador', '~> 0.2.5'
+  spec.add_dependency 'kosi', '~> 1.0'
 
   spec.add_development_dependency 'bundler', '~> 1.14'
   spec.add_development_dependency 'rake', '~> 10.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metatag_cop
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - tackeyy
@@ -24,6 +24,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: formatador
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.5
+- !ruby/object:Gem::Dependency
+  name: kosi
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +94,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-description: Any feedback is webcome! You can find me [here](https://twitter.com/3chhe).
+description: metatag_cop loads csv file and checks whether meta tags is set proper
+  value.
 email:
 - mailto.takita.yusuke@gmail.com
 executables: