metar-parser 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9cd36dbde3df4b92e6a196ef774fe54ac20877b942bc04f49a9cc12e9ce9d1f
-  data.tar.gz: a6e77ae8a9ead64ab0877f204d858731e45f29aa7fd2fc8e2fff7a87672eab17
+  metadata.gz: e7f1558724e63f52aee14e0f1775c7f4dc90eb187c9d3060426d7ab14de16fe4
+  data.tar.gz: 189365393cc681c9398dc78fe9d941fb56166276dea4645f1f56a93fef19394f
 SHA512:
-  metadata.gz: 357e2d2187207db5ca6db35a084698eed370a537d8bbbd1ff4293da5748b71c7e9886d3ad45647069a44dcc5454c18878f3799a814a344a760f1c9846e7c6d9f
-  data.tar.gz: fe2acd2ccb94821e6a6c06e283bc131bdb6bc7a99fb646018f8bd7bb85a3a026bce30d6d72af7870cc049d26623adefebcffea0f702a2f39ae5181d3596c1fad
+  metadata.gz: 376de6502034e38fa3581b4c0b7c6cc0df72d4067ae20337c12f3f5f294ca926587628a0a1769848a682545ad04a59b2547fd2697db5aafe73d67e4497c9adb5
+  data.tar.gz: 55bc69ff0cf47c5b7c6a207fe6d56327bc3e0c4c9b9f6b262807c32e13ff554ee611a21158d62acb92426a0223533590a2a221c7dcfab2cced49e8748eb4cdff

data/lib/metar/station.rb

@@ -53,7 +53,7 @@ module Metar
         m = latitude.match(/^(\d+)-(\d+)([SN])/)
         return nil if !m
 
-        (m[3] == 'E' ? 1.0 : -1.0) * (m[1].to_f + m[2].to_f / 60.0)
+        (m[3] == 'N' ? 1.0 : -1.0) * (m[1].to_f + m[2].to_f / 60.0)
       end
     end
 

data/lib/metar/version.rb

@@ -3,7 +3,7 @@
 module Metar
   module VERSION #:nodoc:
     MAJOR = 1
-    MINOR = 6
+    MINOR = 7
     TINY  = 0
 
     STRING = [MAJOR, MINOR, TINY].join('.')

data/spec/station_spec.rb

@@ -104,6 +104,12 @@ describe Metar::Station do
       expect(Metar::Station.to_longitude("055-24E")).to eq(55.4)
     end
 
+    context "with Western values" do
+      it "returns negative results" do
+        expect(Metar::Station.to_longitude("055-24W")).to eq(-55.4)
+      end
+    end
+
     it "returns nil for badly formed strings" do
       expect(Metar::Station.to_longitude("aaa")).to be_nil
     end
@@ -111,7 +117,13 @@ describe Metar::Station do
 
   context ".to_latitude" do
     it "converts strings to latitude" do
-      expect(Metar::Station.to_latitude("11-03S")).to eq(-11.05)
+      expect(Metar::Station.to_latitude("11-03N")).to eq(11.05)
+    end
+
+    context "with Southern values" do
+      it "returns negative results" do
+        expect(Metar::Station.to_latitude("11-03S")).to eq(-11.05)
+      end
     end
 
     it "returns nil for badly formed strings" do
@@ -123,12 +135,25 @@ describe Metar::Station do
   let(:name) { "Station name" }
   let(:state) { "State" }
   let(:country) { "Country" }
+  let(:longitude) { "055-24E" }
+  let(:latitude) { "11-03N" }
   let(:noaa_raw) do
-    cccc +
-      ";00;000;" +
-      name + ";" +
-      state + ";" +
-      country + ";1;11-03S;055-24E;11-03S;055-24E;000;000;P"
+    [
+      cccc,
+      "00",
+      "000",
+      name,
+      state,
+      country,
+      "1",
+      latitude,
+      longitude,
+      latitude,
+      longitude,
+      "000",
+      "000",
+      "P"
+    ].join(";")
   end
   let(:noaa_data) do
     {
@@ -136,8 +161,8 @@ describe Metar::Station do
       name: name,
       state: state,
       country: country,
-      longitude: "055-24E",
-      latitude: "11-03S",
+      longitude: longitude,
+      latitude: latitude,
       raw: noaa_raw
     }
   end
@@ -175,8 +200,24 @@ describe Metar::Station do
       specify { expect(subject.state).to eq(state) }
       specify { expect(subject.country).to eq(country) }
       specify { expect(subject.longitude).to eq(55.4) }
-      specify { expect(subject.latitude).to eq(-11.05) }
+      specify { expect(subject.latitude).to eq(11.05) }
       specify { expect(subject.raw).to eq(noaa_raw) }
+
+      context "when longitude is Western" do
+        let(:longitude) { "055-24W" }
+
+        it "is parsed as negative" do
+          expect(subject.longitude).to eq(-55.4)
+        end
+      end
+
+      context "When latitude is Southern" do
+        let(:latitude) { "11-03S" }
+
+        it "is parsed as negative" do
+          expect(subject.latitude).to eq(-11.05)
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metar-parser
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Joe Yates
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-03 00:00:00.000000000 Z
+date: 2023-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -235,7 +235,7 @@ files:
 homepage: https://github.com/joeyates/metar-parser
 licenses: []
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -250,8 +250,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key:
+rubygems_version: 3.0.3.1
+signing_key: 
 specification_version: 4
 summary: A Ruby gem for worldwide weather reports
 test_files: