metar-parser 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 96aed5c791fc3274cb9758d30633b5f4319b07f4
-  data.tar.gz: 778df304d83213264a12b441004b9da5cde52fb4
+SHA256:
+  metadata.gz: c2221be718069fb9c9ed4791bf08348dd5faf5aaad09b1d3d0275cf74e2f3641
+  data.tar.gz: 67b70702eb6cf48f4f8e1629c259728775dfb3a4a87aadee70f19951708aca01
 SHA512:
-  metadata.gz: 4ff94e01c7441dee8221603c924e30e087681de5326306641c62b20d747093844ea26f876f49cedd391c129b23a230e418dcf195750ee0c0c0b932ec1052847e
-  data.tar.gz: 3f0f8b04af21560c7cc620c557d51b2b556f2a84e56cc57af321d2c7183359a527f36bfb075d6eda872a4953b861e4d03aee47e077c517a8821af37f4375d718
+  metadata.gz: 71168e1083737aab11b6af0bf0f8ecfd62109896805acc79aa8a15e7d78a217aca97902f657ae1c004f5047acfe478a185cd3c13ba23b034e35d62f7571390f3
+  data.tar.gz: bea84d9351eaf9facc647b6ee78fc0fd964d224818af062dd729c3f7ad42b18bc56315d23a0d548b7585f35fcc19b0a5636470e78f512a179bbe77ce29464303

data/lib/metar/raw.rb

@@ -88,7 +88,7 @@ module Metar
         end
 
         def disconnect
-          return if @@connection.nil
+          return if @@connection.nil?
           @@connection.close
           @@connection = nil
         end
@@ -101,6 +101,7 @@ module Metar
               connection.retrbinary("RETR #{ cccc }.TXT", 1024) do |chunk|
                 s << chunk
               end
+              disconnect
               return s
             rescue Net::FTPPermError, Net::FTPTempError, EOFError => e
               connect

data/lib/metar/version.rb

@@ -2,7 +2,7 @@ module Metar
   module VERSION #:nodoc:
     MAJOR = 1
     MINOR = 4
-    TINY  = 1
+    TINY  = 2
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/spec/raw_spec.rb

@@ -159,24 +159,28 @@ describe Metar::Raw::Noaa do
   context '.fetch' do
     before do
       allow(ftp).to receive(:retrbinary).and_yield("chunk 1\n").and_yield("chunk 2\n")
+      allow(ftp).to receive(:close)
     end
 
     it 'uses the connection' do
       Metar::Raw::Noaa.fetch('the_cccc')
 
       expect(Net::FTP).to have_received(:new)
+      expect(ftp).to have_received(:close)
     end
 
     it 'downloads the raw report' do
       Metar::Raw::Noaa.fetch('the_cccc')
 
       expect(ftp).to have_received(:retrbinary).with('RETR the_cccc.TXT', kind_of(Fixnum))
+      expect(ftp).to have_received(:close)
     end
 
     it 'returns the data' do
       raw = Metar::Raw::Noaa.fetch('the_cccc')
 
       expect(raw).to eq("chunk 1\nchunk 2\n")
+      expect(ftp).to have_received(:close)
     end
 
     context 'if retrieval fails once' do
@@ -195,6 +199,7 @@ describe Metar::Raw::Noaa do
         raw = Metar::Raw::Noaa.fetch('the_cccc')
 
         expect(raw).to eq("chunk 1\nchunk 2\n")
+        expect(ftp).to have_received(:close)
       end
     end
 
@@ -206,6 +211,7 @@ describe Metar::Raw::Noaa do
       it 'fails with an error' do
         expect do
           Metar::Raw::Noaa.fetch('the_cccc')
+          expect(ftp).to have_received(:close)
         end.to raise_error(RuntimeError, /failed 2 times/)
       end
     end
@@ -217,6 +223,7 @@ describe Metar::Raw::Noaa do
 
     before do
       allow(ftp).to receive(:retrbinary).and_yield(noaa_metar)
+      allow(ftp).to receive(:close)
     end
 
     subject { Metar::Raw::Noaa.new(cccc) }
@@ -225,6 +232,7 @@ describe Metar::Raw::Noaa do
       subject.metar
 
       expect(ftp).to have_received(:retrbinary).with("RETR #{cccc}.TXT", 1024)
+      expect(ftp).to have_received(:close)
     end
 
     it 'sets data to the returned value' do
@@ -238,8 +246,8 @@ describe Metar::Raw::Noaa do
       let(:raw_time)  { "2016/03/31 23:59" }
       let(:raw_metar) { "OPPS 312359Z 23006KT 4000 HZ SCT040 SCT100 17/12 Q1011" }
 
-      specify "are parsed as UTC" do
-        expect(subject.time.zone).to eq("UTC")
+      specify "are parsed as UTC/GMT" do
+        expect(subject.time.zone).to eq("UTC").or eq("GMT")
       end
 
       context "across month rollover" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metar-parser
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Joe Yates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-15 00:00:00.000000000 Z
+date: 2019-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -237,28 +237,28 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: nowarning
-rubygems_version: 2.4.5
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Ruby gem for worldwide weather reports
 test_files:
+- spec/parser_spec.rb
 - spec/station_spec.rb
-- spec/data/speed_spec.rb
+- spec/i18n_spec.rb
+- spec/raw_spec.rb
+- spec/report_spec.rb
+- spec/data/pressure_spec.rb
 - spec/data/density_altitude_spec.rb
-- spec/data/sky_condition_spec.rb
-- spec/data/distance_spec.rb
 - spec/data/remark_spec.rb
-- spec/data/temperature_spec.rb
 - spec/data/weather_phenomenon_spec.rb
-- spec/data/lightning_spec.rb
-- spec/data/variable_wind_spec.rb
+- spec/data/sky_condition_spec.rb
 - spec/data/visibility_remark_spec.rb
-- spec/data/wind_spec.rb
-- spec/data/pressure_spec.rb
 - spec/data/runway_visible_range_spec.rb
+- spec/data/variable_wind_spec.rb
+- spec/data/wind_spec.rb
+- spec/data/lightning_spec.rb
 - spec/data/vertical_visibility_spec.rb
 - spec/data/visibility_spec.rb
-- spec/i18n_spec.rb
-- spec/raw_spec.rb
-- spec/parser_spec.rb
-- spec/report_spec.rb
+- spec/data/temperature_spec.rb
+- spec/data/speed_spec.rb
+- spec/data/distance_spec.rb