metal-archives 0.1.7 → 0.1.8

data/VERSION

@@ -1 +1 @@
-0.1.7
+0.1.8

data/lib/metal-archives.rb

@@ -70,18 +70,23 @@ module MetalArchives
         if page
           page.encoding = 'iso-8859-1' if !page.nil? && page.encoding != 'iso-8859-1' # needed for foreign characters
           band_and_album = page.search('body table tr:first-child .tt').text
-
-        # these fields can be in one of the following forms, so we need to find the specific fields appropriately:
-        # "\n\t\t", "Demo", ", Nazgûl Distro & Prod.", "", "2011", "\t\t\t"
-        # "\n\t\t", "Demo", ", Deific Mourning", "", "\n\n\t\tJanuary ", "2011", "\t\t\t"
-        # "Full-length", ", ARX Productions", "", "\n\n\t\tFebruary 25th, ", "2011", "\t\t\t"
           album_fields = page.search('body table:nth-child(2n) tr:first-child > td:first-child').first.children
         end
+      rescue NoMethodError => e
+        # this is an unusual error that occurs when a page only has the content "page not found"
+        # this should return an empty hash so the calling method doens't stop searching on this page
+        # or else it will never get past it
+        puts "\nError accessing metal-archives.com's album information: page not found"
+        return {}
       rescue Exception => e
         puts "\nError accessing metal-archives.com's album information: #{e}"
         return nil
       end
 
+      # these fields can be in one of the following forms, so we need to find the specific fields appropriately:
+      # "\n\t\t", "Demo", ", Nazgûl Distro & Prod.", "", "2011", "\t\t\t"
+      # "\n\t\t", "Demo", ", Deific Mourning", "", "\n\n\t\tJanuary ", "2011", "\t\t\t"
+      # "Full-length", ", ARX Productions", "", "\n\n\t\tFebruary 25th, ", "2011", "\t\t\t"
       {
         :album => album_from_content(band_and_album),
         :band => band_from_content(band_and_album),

data/metal-archives.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{metal-archives}
-  s.version = "0.1.7"
+  s.version = "0.1.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Danny Olson"]
-  s.date = %q{2011-03-25}
+  s.date = %q{2011-03-30}
   s.description = %q{metal-archives provides an interface to search for album releases for a specific year, defaulting to the current one if none is provided.}
   s.email = %q{dbolson@gmail.com}
   s.extra_rdoc_files = [

data/spec/metal-archives_spec.rb

@@ -2,8 +2,8 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe "MetalArchives" do
-  context "with an agent" do
-    context "that searches by year" do
+  describe "with an agent" do
+    describe "that searches by year" do
       before do
         search_results_html = File.open(File.dirname(__FILE__) + '/html/search_results.html')
         @search_results = Nokogiri::HTML(search_results_html)
@@ -58,7 +58,19 @@ describe "MetalArchives" do
       end
     end
 
-    context "with an album page" do
+    describe "with an album page" do
+      context "when a page has no content" do
+        it "should find the band information" do
+          @mechanize = stub('Mechanize')
+          Mechanize.stub!(:new).and_return(@mechanize)
+          @mechanize.stub!(:get).and_return('page not found')
+          agent = MetalArchives::Agent.new(2011)
+          album_url = "release.php?id=000001"
+
+          agent.album_from_url(album_url).should == {}
+        end
+      end
+
       context "with only a release year" do
         it "should find the band information" do
           search_results_html = File.open(File.dirname(__FILE__) + '/html/album_result.html')

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 7
-  version: 0.1.7
+  - 8
+  version: 0.1.8
 platform: ruby
 authors: 
 - Danny Olson
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-25 00:00:00 -07:00
+date: 2011-03-30 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -143,7 +143,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -1207388483986643029
+      hash: -2267341529679193989
       segments: 
       - 0
       version: "0"