metainspector 3.1.1 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9335bc2c238b50b6674633cbed8575ca4b8f839d
-  data.tar.gz: aa6f0afd00f2f42662a2d0048851476bf0da8afe
+  metadata.gz: 553be427edfb113d96f5956a55d184ecce6c2874
+  data.tar.gz: 5c11f4b906d2fafa9bda9669521ac1cb1a958734
 SHA512:
-  metadata.gz: 29694513da14081b5197bd3e7ebe2a52e8b0a64cd629ff5f45425a08a546651df454381da0f8b89cb98a03b4b925dbf11ece9baa9cef61c5e643afdf8ccd5cd4
-  data.tar.gz: df6617ce0020ea959dd3e5707dfff94b1157f62cf305866c86052d38bc36c6ebfe3748753d79d3c96a2f2ba36ffd789f426699ac893c3094b2e04d0d9740f53b
+  metadata.gz: 0188e170dce0f4a4e94b5f91c280b6bc597dfe8b14eb3795d4bf0f7719a282ae04b1277c1b9bb02675f27891d2ddc23781e444bc78b47e95c61151a579bf92f3
+  data.tar.gz: 51f3d50f0d1f575f5bafe3977bc9fbac3de740a7caf89a92b54a47e25408ba29946e9e09ea0a475462b7ded4651a237da72f8b8cd50e2672742a20caa9f692bb

data/lib/meta_inspector/document.rb

@@ -68,8 +68,7 @@ module MetaInspector
         :html_content_only => false,
         :warn_level => :raise,
         :headers => {'User-Agent' => "MetaInspector/#{MetaInspector::VERSION} (+https://github.com/jaimeiniesta/metainspector)"},
-        :allow_redirections => true,
-        :exception_log => MetaInspector::ExceptionLog.new
+        :allow_redirections => true
       }
     end
 

data/lib/meta_inspector/exception_log.rb

@@ -7,8 +7,7 @@ module MetaInspector
     attr_reader :exceptions, :warn_level
 
     def initialize(options = {})
-      options     = defaults.merge(options)
-      @warn_level = options[:warn_level]
+      @warn_level = options[:warn_level] || :raise
       @exceptions = []
     end
 
@@ -30,11 +29,5 @@ module MetaInspector
         warn "ExceptionLog#ok? should only be used when warn_level is :store"
       end
     end
-
-    private
-
-    def defaults
-      { warn_level: :raise }
-    end
   end
 end

data/lib/meta_inspector/parser.rb

@@ -8,8 +8,6 @@ module MetaInspector
     include MetaInspector::Exceptionable
 
     def initialize(document, options = {})
-      options = defaults.merge(options)
-
       @document       = document
       @exception_log  = options[:exception_log]
     end
@@ -106,10 +104,6 @@ module MetaInspector
 
     private
 
-    def defaults
-      { exception_log: MetaInspector::ExceptionLog.new }
-    end
-
     def meta_tags_by(attribute)
       hash = {}
       parsed.css("meta[@#{attribute}]").map do |tag|

data/lib/meta_inspector/url.rb

@@ -9,8 +9,7 @@ module MetaInspector
     include MetaInspector::Exceptionable
 
     def initialize(initial_url, options = {})
-      options         = defaults.merge(options)
-      @exception_log  = options[:exception_log]
+      @exception_log = options[:exception_log]
 
       self.url = initial_url
     end
@@ -50,10 +49,6 @@ module MetaInspector
 
     private
 
-    def defaults
-      { exception_log: MetaInspector::ExceptionLog.new }
-    end
-
     # Adds 'http' as default scheme, if there is none
     def with_default_scheme(url)
       parsed(url) && parsed(url).scheme.nil? ? 'http://' + url : url

data/lib/meta_inspector/version.rb

@@ -1,5 +1,5 @@
 # -*- encoding: utf-8 -*-
 
 module MetaInspector
-  VERSION = "3.1.1"
+  VERSION = "3.2.0"
 end

data/spec/document_spec.rb

@@ -89,13 +89,60 @@ describe MetaInspector::Document do
 
       tar_url.title
     end
+
+    context 'when a warn_level of :store is passed in' do
+      before do
+        @bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :store)
+        @bad_request.title
+      end
+
+      it 'stores the exceptions' do
+        @bad_request.exceptions.should_not be_empty
+      end
+
+      it 'makes ok? to return false' do
+        @bad_request.should_not be_ok
+      end
+    end
+
+    context 'when a warn_level of :warn is passed in' do
+      before do
+        $stderr = StringIO.new
+      end
+
+      after do
+        $stderr = STDERR
+      end
+
+      it 'warns on STDERR' do
+        bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :warn)
+        bad_request.title
+
+        $stderr.rewind
+        $stderr.string.chomp.should eq("The url provided contains image/png content instead of text/html content")
+      end
+
+      it 'does not raise an exception' do
+        expect {
+          bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :warn)
+          bad_request.title
+        }.to_not raise_exception
+      end
+
+      it 'does not store exceptions' do
+        bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :warn)
+        bad_request.title
+
+        expect( bad_request.exceptions ).to be_empty
+      end
+    end
   end
 
   describe 'headers' do
     it "should include default headers" do
       url = "http://pagerankalert.com/"
       expected_headers = {'User-Agent' => "MetaInspector/#{MetaInspector::VERSION} (+https://github.com/jaimeiniesta/metainspector)"}
-                                         
+
       headers = {}
       headers.should_receive(:merge!).with(expected_headers)
       Faraday::Connection.any_instance.stub(:headers){headers}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metainspector
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.2.0
 platform: ruby
 authors:
 - Jaime Iniesta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-10 00:00:00.000000000 Z
+date: 2014-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri