metaforce 1.0.5 → 1.0.6

data/README.md

@@ -9,9 +9,17 @@ and [Services](http://www.salesforce.com/us/developer/docs/api/index.htm) APIs.
 
 ## Installation
 
-```bash
-gem install metaforce
-```
+Add this line to your application's Gemfile:
+
+    gem 'metaforce'
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install metaforce
 
 ## Usage
 

data/lib/metaforce/client.rb

@@ -14,6 +14,10 @@ module Metaforce
       @services ||= Metaforce::Services::Client.new(@options)
     end
 
+    def inspect
+      "#<#{self.class} @options=#{@options.inspect}>"
+    end
+
     def method_missing(method, *args, &block)
       if metadata.respond_to? method, false
         metadata.send(method, *args, &block)

data/lib/metaforce/job/retrieve.rb

@@ -64,27 +64,37 @@ module Metaforce
     # Returns self.
     def extract_to(destination)
       return on_complete { |job| job.extract_to(destination) } unless started?
-      Zip::ZipFile.open(tmp_zip_file) do |zip|
+      with_tmp_zip_file do |file|
+        unzip(file, destination)
+      end
+      self
+    end
+
+  private
+
+    # Internal: Unzips source to destination.
+    def unzip(source, destination)
+      Zip::ZipFile.open(source) do |zip|
         zip.each do |f|
           path = File.join(destination, f.name)
           FileUtils.mkdir_p(File.dirname(path))
           zip.extract(f, path) { true }
         end
       end
-      self
     end
 
-  private
-
     # Internal: Writes the zip file content to a temporary location so it can
     # be extracted.
-    def tmp_zip_file
-      @tmp_zip_file ||= begin
-        file = Tempfile.new('retrieve')
+    def with_tmp_zip_file
+      file = Tempfile.new('retrieve')
+      begin
+        file.binmode
         file.write(zip_file)
-        path = file.path
+        file.rewind
+        yield file
+      ensure
         file.close
-        path
+        file.unlink
       end
     end
 

data/lib/metaforce/metadata/client.rb

@@ -9,6 +9,10 @@ module Metaforce
 
       endpoint :metadata_server_url
       wsdl Metaforce.configuration.metadata_wsdl
+
+      def inspect
+        "#<#{self.class} @options=#{@options.inspect}>"
+      end
     end
   end
 end

data/lib/metaforce/services/client.rb

@@ -60,6 +60,10 @@ module Metaforce
           .select { |p| p.picklist_name == field }.first.picklist_values
           .select { |p| p.active }.collect { |p| [ p.label, p.value ] }
       end
+
+      def inspect
+        "#<#{self.class} @options=#{@options.inspect}>"
+      end
     end
   end
 end

data/lib/metaforce/version.rb

@@ -1,3 +1,3 @@
 module Metaforce
-  VERSION = '1.0.5'
+  VERSION = '1.0.6'
 end

data/spec/lib/client_spec.rb

@@ -31,4 +31,9 @@ describe Metaforce::Client do
       end
     end
   end
+
+  describe '.inspect' do
+    subject { client.inspect }
+    it { should eq '#<Metaforce::Client @options={:session_id=>"foobar"}>' }
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metaforce
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-05 00:00:00.000000000 Z
+date: 2013-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon