metadata-json-lint 3.0.3 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 601496e157ed6f6f3f6faee2a68a5b6ec6b725a869adcca63fd61b7631435085
-  data.tar.gz: 887d30fa3c8dbf9d629f64d851a4ee4ee314a66b48f920d96d1bd3ba2ee46bc2
+  metadata.gz: 1327a043726b715003e697e9024bda80b0134896e7fb2b97f9de14ee8b28e8b7
+  data.tar.gz: ff6e85957f67e2d1b2a37f2a9383640867bf7bf4f04cc1ed5bc10ed7b9c738fb
 SHA512:
-  metadata.gz: d869ce3a305ddbb91e4dcf602c33174ed7d8dc734ddc05419b09ac808f87ddbbac64b56be10bd945e3442c6eaab1dea5200170a84f239069abeba63d0900f1d3
-  data.tar.gz: 36a47058aad6c5af739315ca3968b0ac71858d31988383751045b9a0cdfb1832f995b94fedc7b289cbd55017319a73dd5a52545a488c4046a7f20664a649961c
+  metadata.gz: 841c877388db1e132ba061ef657f21f63b5f10b68255b96a673b1a79a5d4052327a54cc696a99c850addb4f8c830dab139c9891ae35ecf7444e83d53e8d86cc2
+  data.tar.gz: caf5db87f9dd3fa2a33fb75b36992f6447ec80c335c0757246d6c9be7d22019581464ee6bc65f26549f162f6cc3ac9efb6ee9f3cbe546af5465f414882179e1c

data/.github/workflows/release.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     if: github.repository_owner == 'voxpupuli'
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Install Ruby 3.0
         uses: ruby/setup-ruby@v1
         with:
@@ -18,7 +18,7 @@ jobs:
         env:
           BUNDLE_WITHOUT: release
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Publish gem to rubygems.org
         run: gem push *.gem
         env:

data/.github/workflows/test.yml

@@ -10,22 +10,34 @@ env:
   BUNDLE_WITHOUT: release
 
 jobs:
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.0"
+          bundler-cache: true
+      - name: Run Rubocop
+        run: bundle exec rake rubocop
   rspec:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         include:
-          - ruby: "2.4"
-          - ruby: "2.5"
-          - ruby: "2.6"
           - ruby: "2.7"
           - ruby: "3.0"
+          - ruby: "3.1"
             coverage: "yes"
+          - ruby: "3.2"
     env:
       COVERAGE: ${{ matrix.coverage }}
+      # https://github.com/rubygems/rubygems/issues/5234#issuecomment-1003773622
+      RUBYOPT: '--disable-did_you_mean'
     name: RSpec - Ruby ${{ matrix.ruby }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Install Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:
@@ -34,4 +46,13 @@ jobs:
       - name: spec tests
         run: bundle exec rake test
       - name: Verify gem builds
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
+
+  tests:
+    needs:
+      - rubocop
+      - rspec
+    runs-on: ubuntu-latest
+    name: Test suite
+    steps:
+      - run: echo Test suite completed

data/.rubocop.yml

@@ -1,35 +1,5 @@
+---
 inherit_from: .rubocop_todo.yml
 
-# we still support ruby 1.8
-Style/HashSyntax:
-  Enabled: false
-
-#Metric cops are rarely useful
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/LineLength:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/BlockLength:
-  Exclude:
-    - spec/**/*_spec.rb
-    - ./*.gemspec
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Max: 185
-
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: consistent_comma
-
-Style/AccessModifierDeclarations:
-  Enabled: false
+inherit_gem:
+  voxpupuli-rubocop: rubocop.yml

data/.rubocop_todo.yml

@@ -1,18 +1,74 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2015-10-08 14:05:42 -0700 using RuboCop version 0.34.2.
+# on 2023-09-15 14:22:01 UTC using RuboCop version 1.54.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
+# Offense count: 2
 Lint/RescueException:
   Exclude:
     - 'lib/metadata_json_lint.rb'
 
 # Offense count: 1
-# Configuration parameters: Exclude.
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/metadata_json_lint_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/version_requirement_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/FilePath:
+  Exclude:
+    - 'spec/schema_spec.rb'
+    - 'spec/version_requirement_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 2
+RSpec/MultipleExpectations:
+  Max: 2
+
+# Offense count: 7
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/schema_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
     - 'lib/metadata_json_lint.rb'
+
+# Offense count: 36
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 153

data/CHANGELOG.md

@@ -1,13 +1,38 @@
 # Changelog
 
+## [4.0.0](https://github.com/voxpupuli/metadata-json-lint/tree/4.0.0) (2023-09-15)
+
+[Full Changelog](https://github.com/voxpupuli/metadata-json-lint/compare/3.0.3...4.0.0)
+
+**Breaking changes:**
+
+- Drop Ruby 2.5/2.6 & switch to voxpupuli-rubocop [\#137](https://github.com/voxpupuli/metadata-json-lint/pull/137) ([bastelfreak](https://github.com/bastelfreak))
+- Drop Ruby =\< 2.4 support [\#125](https://github.com/voxpupuli/metadata-json-lint/pull/125) ([bastelfreak](https://github.com/bastelfreak))
+
+**Implemented enhancements:**
+
+- CI: Build gems with strictness and verbosity & Add upper version limits to gemspec [\#135](https://github.com/voxpupuli/metadata-json-lint/pull/135) ([bastelfreak](https://github.com/bastelfreak))
+- Add Ruby 3.1/3.2 support [\#133](https://github.com/voxpupuli/metadata-json-lint/pull/133) ([bastelfreak](https://github.com/bastelfreak))
+
+**Merged pull requests:**
+
+- Update voxpupuli-rubocop requirement from ~\> 1.2 to ~\> 2.0 [\#139](https://github.com/voxpupuli/metadata-json-lint/pull/139) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Make semantic\_puppet a hard dependency [\#136](https://github.com/voxpupuli/metadata-json-lint/pull/136) ([bastelfreak](https://github.com/bastelfreak))
+- Drop pry development dependency [\#134](https://github.com/voxpupuli/metadata-json-lint/pull/134) ([bastelfreak](https://github.com/bastelfreak))
+- GCG: Add faraday-retry dep [\#132](https://github.com/voxpupuli/metadata-json-lint/pull/132) ([bastelfreak](https://github.com/bastelfreak))
+- Add dummy CI job we can depend on [\#131](https://github.com/voxpupuli/metadata-json-lint/pull/131) ([bastelfreak](https://github.com/bastelfreak))
+
 ## [3.0.3](https://github.com/voxpupuli/metadata-json-lint/tree/3.0.3) (2023-04-24)
 
 [Full Changelog](https://github.com/voxpupuli/metadata-json-lint/compare/3.0.2...3.0.3)
 
+**Fixed bugs:**
+
+- gemspec: drop deprecated `date` attribute [\#129](https://github.com/voxpupuli/metadata-json-lint/pull/129) ([bastelfreak](https://github.com/bastelfreak))
+
 **Merged pull requests:**
 
-- Allow json-schema 4.x [\#122](https://github.com/voxpupuli/metadata-json-lint/pull/122)
-- gemspec: drop deprecated date attribute [\#129](https://github.com/voxpupuli/metadata-json-lint/pull/129)
+- Allow json-schema 4.x [\#128](https://github.com/voxpupuli/metadata-json-lint/pull/128) ([chelnak](https://github.com/chelnak))
 
 ## [3.0.2](https://github.com/voxpupuli/metadata-json-lint/tree/3.0.2) (2022-05-03)
 

data/Gemfile

@@ -3,10 +3,11 @@ source 'https://rubygems.org'
 gemspec
 
 group :release do
-  gem 'github_changelog_generator', :require => false
+  gem 'faraday-retry', require: false
+  gem 'github_changelog_generator', require: false
 end
 
 group :coverage, optional: ENV['COVERAGE'] != 'yes' do
-  gem 'codecov', :require => false
-  gem 'simplecov-console', :require => false
+  gem 'codecov', require: false
+  gem 'simplecov-console', require: false
 end

data/Rakefile

@@ -1,17 +1,16 @@
 desc 'Run all tests'
-task :test => %i[rubocop spec test:acceptance]
+task test: %i[spec test:acceptance]
 
-require 'rubocop/rake_task'
-RuboCop::RakeTask.new(:rubocop) do |task|
-  # These make the rubocop experience maybe slightly less terrible
-  task.options = ['-D', '-S', '-E']
-
-  # Use Rubocop's Github Actions formatter if possible
-  if ENV['GITHUB_ACTIONS'] == 'true'
-    rubocop_spec = Gem::Specification.find_by_name('rubocop')
-    if Gem::Version.new(rubocop_spec.version) >= Gem::Version.new('1.2')
-      task.formatters << 'github'
-    end
+begin
+  require 'rubocop/rake_task'
+rescue LoadError
+  # RuboCop is an optional group
+else
+  RuboCop::RakeTask.new(:rubocop) do |task|
+    # These make the rubocop experience maybe slightly less terrible
+    task.options = ['--display-cop-names', '--display-style-guide', '--extra-details']
+    # Use Rubocop's Github Actions formatter if possible
+    task.formatters << 'github' if ENV['GITHUB_ACTIONS'] == 'true'
   end
 end
 
@@ -28,10 +27,11 @@ RSpec::Core::RakeTask.new(:spec)
 begin
   require 'rubygems'
   require 'github_changelog_generator/task'
-rescue LoadError # rubocop:disable Lint/HandleExceptions
+rescue LoadError
+  # github_changelog_generator is in the optional `release` group
 else
   GitHubChangelogGenerator::RakeTask.new :changelog do |config|
-    config.exclude_labels = %w[duplicate question invalid wontfix wont-fix skip-changelog]
+    config.exclude_labels = %w[duplicate question invalid wontfix wont-fix skip-changelog github_actions]
     config.user = 'voxpupuli'
     config.project = 'metadata-json-lint'
     gem_version = Gem::Specification.load("#{config.project}.gemspec").version

data/lib/metadata-json-lint/rake_task.rb

@@ -5,7 +5,5 @@ require 'json'
 
 desc 'Run metadata-json-lint'
 task :metadata_lint do
-  if File.exist?('metadata.json')
-    abort unless MetadataJsonLint.parse('metadata.json')
-  end
+  abort if File.exist?('metadata.json') && !MetadataJsonLint.parse('metadata.json')
 end

data/lib/metadata-json-lint/schema.rb

@@ -4,8 +4,7 @@ module MetadataJsonLint
   # Provides validation of metadata.json against a JSON schema document
   # maintained in this class. Provides a good first pass over the metadata with
   # type checking and basic format/length validations.
-  #
-  # rubocop:disable Metrics/ClassLength # schema data structure is quite large
+  ## schema data structure is quite large
   class Schema
     # Based on https://docs.puppet.com/puppet/latest/modules_metadata.html
     #
@@ -159,9 +158,9 @@ module MetadataJsonLint
           raise JSON::Schema::CustomFormatError, "must be a valid semantic version: #{e.message}"
         end
       elsif value.match(semver_full_regex).nil?
-        raise JSON::Schema::CustomFormatError, "must be a valid semantic version: Unable to parse '#{value}' as a semantic version identifier"
+        raise JSON::Schema::CustomFormatError,
+              "must be a valid semantic version: Unable to parse '#{value}' as a semantic version identifier"
       end
     end
   end
 end
-# rubocop:enable Metrics/ClassLength

data/lib/metadata-json-lint/version_requirement.rb

@@ -7,7 +7,10 @@ module MetadataJsonLint
 
       if defined?(SemanticPuppet::VersionRange)
         @range = SemanticPuppet::VersionRange.parse(requirement)
-        raise ArgumentError, "Range matches no versions: \"#{requirement}\"" if @range == SemanticPuppet::VersionRange::EMPTY_RANGE
+        if @range == SemanticPuppet::VersionRange::EMPTY_RANGE
+          raise ArgumentError,
+                "Range matches no versions: \"#{requirement}\""
+        end
       elsif requirement.match(/\A[a-z0-9*.\-^~><=|\t ]*\Z/i).nil?
         raise ArgumentError, "Unparsable version range: \"#{requirement}\""
       end

data/lib/metadata_json_lint.rb

@@ -1,9 +1,7 @@
 require 'json'
 require 'spdx-licenses'
 require 'optparse'
-
-require 'metadata-json-lint/semantic_puppet_loader'
-MetadataJsonLint::SemanticPuppetLoader.try_load
+require 'semantic_puppet'
 
 require 'metadata-json-lint/schema'
 require 'metadata-json-lint/version_requirement'
@@ -17,7 +15,7 @@ module MetadataJsonLint
       :strict_license,
       :strict_dependencies,
       :strict_puppet_version,
-      :format
+      :format,
     ).new(
       true, # fail_on_warnings
       true, # strict_license
@@ -32,11 +30,13 @@ module MetadataJsonLint
     OptionParser.new do |opts|
       opts.banner = 'Usage: metadata-json-lint [options] [metadata.json]'
 
-      opts.on('--[no-]strict-dependencies', "Fail on open-ended module version dependencies. Defaults to '#{options[:strict_dependencies]}'.") do |v|
+      opts.on('--[no-]strict-dependencies',
+              "Fail on open-ended module version dependencies. Defaults to '#{options[:strict_dependencies]}'.") do |v|
         options[:strict_dependencies] = v
       end
 
-      opts.on('--[no-]strict-license', "Don't fail on strict license check. Defaults to '#{options[:strict_license]}'.") do |v|
+      opts.on('--[no-]strict-license',
+              "Don't fail on strict license check. Defaults to '#{options[:strict_license]}'.") do |v|
         options[:strict_license] = v
       end
 
@@ -44,11 +44,13 @@ module MetadataJsonLint
         options[:fail_on_warnings] = v
       end
 
-      opts.on('--[no-]strict-puppet-version', "Fail on strict Puppet Version check based on current supported Puppet versions. Defaults to '#{options[:strict_puppet_version]}'.") do |v|
+      opts.on('--[no-]strict-puppet-version',
+              "Fail on strict Puppet Version check based on current supported Puppet versions. Defaults to '#{options[:strict_puppet_version]}'.") do |v|
         options[:strict_puppet_version] = v
       end
 
-      opts.on('-f', '--format FORMAT', %i[text json], 'The format in which results will be output (text, json)') do |format|
+      opts.on('-f', '--format FORMAT', %i[text json],
+              'The format in which results will be output (text, json)') do |format|
         options[:format] = format
       end
     end.parse!
@@ -90,7 +92,7 @@ module MetadataJsonLint
     # Validate basic structure against JSON schema
     schema_errors = Schema.new.validate(parsed)
     schema_errors.each do |err|
-      error (err[:field] == 'root' ? :required_fields : err[:field]), err[:message]
+      error ((err[:field] == 'root') ? :required_fields : err[:field]), err[:message]
     end
 
     validate_dependencies!(parsed['dependencies']) if parsed['dependencies']
@@ -99,9 +101,7 @@ module MetadataJsonLint
     # From: https://docs.puppetlabs.com/puppet/latest/reference/modules_publishing.html#write-a-metadatajson-file
     deprecated_fields = %w[types checksum]
     deprecated_fields.each do |field|
-      unless parsed[field].nil?
-        error :deprecated_fields, "Deprecated field '#{field}' found in metadata.json."
-      end
+      error :deprecated_fields, "Deprecated field '#{field}' found in metadata.json." unless parsed[field].nil?
     end
 
     # The nested 'requirements' name of 'pe' is deprecated as well.
@@ -121,16 +121,14 @@ module MetadataJsonLint
 
       case options[:format]
       when :json
-        puts JSON.fast_generate(:result => result, :warnings => @warnings, :errors => @errors)
+        puts JSON.fast_generate(result: result, warnings: @warnings, errors: @errors)
       else
         @warnings.each { |warn| puts "(WARN) #{warn}" }
         @errors.each { |err| puts "(ERROR) #{err}" }
         puts result
       end
 
-      if !@errors.empty? || (!@warnings.empty? && (options[:fail_on_warnings] == true))
-        return false
-      end
+      return false if !@errors.empty? || (!@warnings.empty? && (options[:fail_on_warnings] == true))
     end
 
     true
@@ -153,9 +151,7 @@ module MetadataJsonLint
     return unless requirements.is_a?(Array)
 
     requirements.each do |requirement|
-      if requirement['name'] == 'pe'
-        warn :requirements, "The 'pe' requirement is no longer supported by the Forge."
-      end
+      warn :requirements, "The 'pe' requirement is no longer supported by the Forge." if requirement['name'] == 'pe'
 
       begin
         puppet_req = VersionRequirement.new(requirement.fetch('version_requirement', ''))
@@ -164,7 +160,7 @@ module MetadataJsonLint
         error :requirements, "Invalid 'version_requirement' field in metadata.json: #{e}"
       end
 
-      validate_puppet_ver!(puppet_req) unless puppet_req.instance_variable_get('@requirement').nil?
+      validate_puppet_ver!(puppet_req) unless puppet_req.instance_variable_get(:@requirement).nil?
     end
 
     validate_requirements_unique(requirements)
@@ -181,17 +177,16 @@ module MetadataJsonLint
     end
 
     return unless requirement.mixed_syntax?
+
     warn(:requirement, 'Mixing "x" or "*" version syntax with operators is not recommended in ' \
-      "metadata.json, use one style in the puppet version: #{requirement.instance_variable_get('@requirement')}")
+                       "metadata.json, use one style in the puppet version: #{requirement.instance_variable_get(:@requirement)}")
   end
   module_function :validate_puppet_ver!
 
   def validate_dependencies!(deps)
     dep_names = []
     deps.each do |dep|
-      if dep_names.include?(dep['name'])
-        warn :dependencies, "Duplicate dependencies on #{dep['name']}"
-      end
+      warn :dependencies, "Duplicate dependencies on #{dep['name']}" if dep_names.include?(dep['name'])
       dep_names << dep['name']
 
       begin
@@ -208,7 +203,7 @@ module MetadataJsonLint
       # See https://tickets.puppetlabs.com/browse/PUP-2781
       if dep.key?('version_range')
         warn :dependencies, "Dependency #{dep['name']} has a 'version_range' attribute " \
-          'which is no longer used by the forge.'
+                            'which is no longer used by the forge.'
       end
     end
   end
@@ -219,7 +214,7 @@ module MetadataJsonLint
     # From: https://docs.puppet.com/puppet/latest/reference/modules_metadata.html#best-practice-set-an-upper-bound-for-dependencies
     if options[:strict_dependencies] && requirement.open_ended?
       msg = "Dependency #{dep['name']} has an open " \
-        "ended dependency version requirement #{dep['version_requirement']}"
+            "ended dependency version requirement #{dep['version_requirement']}"
       warn(:dependencies, msg)
     end
 
@@ -227,15 +222,16 @@ module MetadataJsonLint
     # From: https://docs.puppet.com/puppet/latest/modules_metadata.html#version-specifiers
     # Supported in Puppet 5 and higher, but the syntax is unclear and incompatible with older versions
     return unless requirement.mixed_syntax?
+
     warn(:dependencies, 'Mixing "x" or "*" version syntax with operators is not recommended in ' \
-      "metadata.json, use one style in the #{dep['name']} dependency: #{dep['version_requirement']}")
+                        "metadata.json, use one style in the #{dep['name']} dependency: #{dep['version_requirement']}")
   end
   module_function :validate_version_requirement!
 
   def format_error(check, msg)
     case options[:format]
     when :json
-      { :check => check, :msg => msg }
+      { check: check, msg: msg }
     else
       "#{check}: #{msg}"
     end

data/metadata-json-lint.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'metadata-json-lint'
-  s.version     = '3.0.3'
+  s.version     = '4.0.0'
   s.summary     = 'metadata-json-lint /path/to/metadata.json'
   s.description = 'Utility to verify Puppet metadata.json files'
   s.authors     = ['Vox Pupuli']
@@ -8,17 +8,16 @@ Gem::Specification.new do |s|
 
   s.files       = `git ls-files -z`.split("\x0")
   s.executables = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  s.test_files  = s.files.grep(%r{^(tests|spec)/})
 
   s.homepage    = 'https://github.com/voxpupuli/metadata-json-lint'
   s.license     = 'Apache-2.0'
 
-  s.required_ruby_version = '>= 2.1.0'
+  s.required_ruby_version = '>= 2.7.0'
+
   s.add_runtime_dependency 'json-schema', '>= 2.8', '< 5.0'
+  s.add_runtime_dependency 'semantic_puppet', '~> 1.0'
   s.add_runtime_dependency 'spdx-licenses', '~> 1.0'
-  s.add_development_dependency 'pry'
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec'
-  s.add_development_dependency 'rubocop', '~> 0.57.2'
-  s.add_development_dependency 'semantic_puppet'
+  s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
+  s.add_development_dependency 'rspec', '~> 3.12'
+  s.add_development_dependency 'voxpupuli-rubocop', '~> 2.0'
 end

data/spec/metadata_json_lint_spec.rb

@@ -11,12 +11,13 @@ describe MetadataJsonLint do
     context 'with pe' do
       let :requirements do
         [
-          { 'name' => 'pe' }
+          { 'name' => 'pe' },
         ]
       end
 
       it do
-        expect(described_class).to receive('warn').with(:requirements, "The 'pe' requirement is no longer supported by the Forge.")
+        expect(described_class).to receive('warn').with(:requirements,
+                                                        "The 'pe' requirement is no longer supported by the Forge.")
         expect { described_class.validate_requirements!(requirements) }.not_to raise_error
       end
     end
@@ -24,12 +25,13 @@ describe MetadataJsonLint do
     context 'with invalid requirement' do
       let :requirements do
         [
-          { 'name' => 'puppet', 'version_requirement' => 'a' }
+          { 'name' => 'puppet', 'version_requirement' => 'a' },
         ]
       end
 
       it do
-        expect(described_class).to receive('error').with(:requirements, "Invalid 'version_requirement' field in metadata.json: Unparsable version range: \"a\"")
+        expect(described_class).to receive('error').with(:requirements,
+                                                         "Invalid 'version_requirement' field in metadata.json: Unparsable version range: \"a\"")
         expect { described_class.validate_requirements!(requirements) }.not_to raise_error
       end
     end

data/spec/schema_spec.rb

@@ -4,10 +4,13 @@ describe MetadataJsonLint::Schema do
   end
 
   describe '#validate' do
-    let(:minimal) { { author: '', dependencies: [], license: 'A', name: 'a-a', source: '', summary: '', version: '1.0.0' } }
+    let(:minimal) do
+      { author: '', dependencies: [], license: 'A', name: 'a-a', source: '', summary: '', version: '1.0.0' }
+    end
 
     context 'with empty hash' do
       subject { described_class.new.validate({}) }
+
       it { is_expected.to be_a(Array) }
       it { expect(subject.size).to eq(7) }
       it { is_expected.to include(field: 'root', message: "The file did not contain a required property of 'author'") }
@@ -15,24 +18,39 @@ describe MetadataJsonLint::Schema do
 
     context 'with minimal entries' do
       subject { described_class.new.validate(minimal) }
+
       it { is_expected.to eq([]) }
     end
 
     context 'with validation error on entry' do
       subject { described_class.new.validate(minimal.merge(summary: 'A' * 145)) }
-      it { is_expected.to eq([{ field: 'summary', message: "The property 'summary' was not of a maximum string length of 144" }]) }
+
+      it {
+        expect(subject).to eq([{ field: 'summary',
+                                 message: "The property 'summary' was not of a maximum string length of 144", }])
+      }
     end
 
     context 'with validation error on nested entry' do
       subject { described_class.new.validate(minimal.merge(dependencies: [{ name: 'in###id' }])) }
+
       it { expect(subject.size).to eq(1) }
-      it { is_expected.to include(field: 'dependencies', message: a_string_matching(%r{The property 'dependencies/0/name' value "in###id" did not match the regex})) }
+
+      it {
+        expect(subject).to include(field: 'dependencies',
+                                   message: a_string_matching(%r{The property 'dependencies/0/name' value "in###id" did not match the regex}))
+      }
     end
 
     context 'with semver validation failure' do
       subject { described_class.new.validate(minimal.merge(version: 'a')) }
+
       it { expect(subject.size).to eq(1) }
-      it { is_expected.to include(field: 'version', message: a_string_matching(/The property 'version' must be a valid semantic version/)) }
+
+      it {
+        expect(subject).to include(field: 'version',
+                                   message: a_string_matching(/The property 'version' must be a valid semantic version/))
+      }
     end
   end
 end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ begin
   require 'simplecov'
   require 'simplecov-console'
   require 'codecov'
-rescue LoadError # rubocop:disable Lint/HandleExceptions
+rescue LoadError
 else
   SimpleCov.start do
     track_files 'lib/**/*.rb'
@@ -18,7 +18,7 @@ else
 
   SimpleCov.formatters = [
     SimpleCov::Formatter::Console,
-    SimpleCov::Formatter::Codecov
+    SimpleCov::Formatter::Codecov,
   ]
 end
 

data/tests/broken/expected

@@ -1 +1 @@
-Error: Unable to parse metadata.json: [0-9]*: unexpected token at
+Error: Unable to parse metadata.json:.* unexpected token at

data/tests/rake_chaining/Rakefile

@@ -1,7 +1,7 @@
 $LOAD_PATH.unshift(File.expand_path('../../lib', __dir__))
 require 'metadata-json-lint/rake_task'
 
-task :test => %i[metadata_lint success]
+task test: %i[metadata_lint success]
 task :success do
   puts 'Successfully linted'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metadata-json-lint
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 4.0.0
 platform: ruby
 authors:
 - Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-24 00:00:00.000000000 Z
+date: 2023-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json-schema
@@ -31,7 +31,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: spdx-licenses
+  name: semantic_puppet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -45,75 +45,67 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: spdx-licenses
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '1.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
+        version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.0.6
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.57.2
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.57.2
+        version: '3.12'
 - !ruby/object:Gem::Dependency
-  name: semantic_puppet
+  name: voxpupuli-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 description: Utility to verify Puppet metadata.json files
 email: voxpupuli@groups.io
 executables:
@@ -137,7 +129,6 @@ files:
 - bin/metadata-json-lint
 - lib/metadata-json-lint/rake_task.rb
 - lib/metadata-json-lint/schema.rb
-- lib/metadata-json-lint/semantic_puppet_loader.rb
 - lib/metadata-json-lint/version_requirement.rb
 - lib/metadata_json_lint.rb
 - metadata-json-lint.gemspec
@@ -225,7 +216,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -236,76 +227,4 @@ rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: metadata-json-lint /path/to/metadata.json
-test_files:
-- spec/metadata_json_lint_spec.rb
-- spec/schema_spec.rb
-- spec/spec_helper.rb
-- spec/version_requirement_spec.rb
-- tests/bad_license/Rakefile
-- tests/bad_license/expected
-- tests/bad_license/metadata.json
-- tests/broken/Rakefile
-- tests/broken/expected
-- tests/broken/metadata.json
-- tests/duplicate-dep/Rakefile
-- tests/duplicate-dep/expected
-- tests/duplicate-dep/metadata.json
-- tests/duplicate-requirement/Rakefile
-- tests/duplicate-requirement/expected
-- tests/duplicate-requirement/metadata.json
-- tests/json_format/Rakefile
-- tests/json_format/expected
-- tests/json_format/metadata.json
-- tests/long_summary/Rakefile
-- tests/long_summary/expected
-- tests/long_summary/metadata.json
-- tests/missing_version_requirement/Rakefile
-- tests/missing_version_requirement/expected
-- tests/missing_version_requirement/metadata.json
-- tests/mixed_version_syntax/Rakefile
-- tests/mixed_version_syntax/expected
-- tests/mixed_version_syntax/metadata.json
-- tests/multiple_problems/Rakefile
-- tests/multiple_problems/expected
-- tests/multiple_problems/metadata.json
-- tests/no_dependencies/Rakefile
-- tests/no_dependencies/metadata.json
-- tests/no_files/.gitkeep
-- tests/no_files/expected
-- tests/no_pe/Rakefile
-- tests/no_pe/metadata.json
-- tests/no_version_range/Rakefile
-- tests/no_version_range/metadata.json
-- tests/non_array_requirements/Rakefile
-- tests/non_array_requirements/expected
-- tests/non_array_requirements/metadata.json
-- tests/noname/Rakefile
-- tests/noname/expected
-- tests/noname/metadata.json
-- tests/open_ended_dependency/Rakefile
-- tests/open_ended_dependency/expected
-- tests/open_ended_dependency/metadata.json
-- tests/perfect/Rakefile
-- tests/perfect/metadata.json
-- tests/proprietary/Rakefile
-- tests/proprietary/metadata.json
-- tests/rake_chaining/Rakefile
-- tests/rake_chaining/metadata.json
-- tests/rake_global_options/Rakefile
-- tests/rake_global_options/expected
-- tests/rake_global_options/metadata.json
-- tests/rake_multiple_json_options/Rakefile
-- tests/rake_multiple_json_options/metadata_license.json
-- tests/rake_multiple_json_options/metadata_ok.json
-- tests/requirements_eol_version/Rakefile
-- tests/requirements_eol_version/expected
-- tests/requirements_eol_version/metadata.json
-- tests/tags_no_array/Rakefile
-- tests/tags_no_array/expected
-- tests/tags_no_array/metadata.json
-- tests/tags_with_array/Rakefile
-- tests/tags_with_array/metadata.json
-- tests/test.sh
-- tests/types/Rakefile
-- tests/types/expected
-- tests/types/metadata.json
+test_files: []

data/lib/metadata-json-lint/semantic_puppet_loader.rb

@@ -1,47 +0,0 @@
-module MetadataJsonLint
-  # Attempts the various methods of loading SemanticPuppet.
-  module SemanticPuppetLoader
-    def try_load
-      try_load_puppet
-      return if defined?(SemanticPuppet)
-
-      try_load_semantic
-      return if defined?(SemanticPuppet)
-
-      try_load_semantic_puppet
-      return if defined?(SemanticPuppet)
-
-      warn 'Could not find semantic_puppet gem, falling back to internal functionality. Version checks may be less robust.'
-    end
-    module_function :try_load
-
-    # Most modern Puppet versions have SemanticPuppet vendored in the proper
-    # namespace and automatically load it at require time.
-    def try_load_puppet
-      require 'puppet'
-    rescue LoadError
-      nil
-    end
-    module_function :try_load_puppet
-
-    # Older Puppet 4.x versions have SemanticPuppet vendored but under the
-    # Semantic namespace and require it on demand, so we need to load it
-    # ourselves and then alias it to SemanticPuppet for convenience.
-    def try_load_semantic
-      require 'semantic'
-      Kernel.const_set('SemanticPuppet', Semantic)
-    rescue LoadError
-      nil
-    end
-    module_function :try_load_semantic
-
-    # If Puppet is not available or is a version that does not have
-    # SemanticPuppet vendored, try to load the external gem.
-    def try_load_semantic_puppet
-      require 'semantic_puppet'
-    rescue LoadError
-      nil
-    end
-    module_function :try_load_semantic_puppet
-  end
-end