meta_tags-rails 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 08c61215c330314bcbee5e80a86098d964f102d6
-  data.tar.gz: c64995388c5381275aef544dba93aab23249966f
+  metadata.gz: 807097d6d5b1ccf24d1ab4ea890f6c4eb99f17d4
+  data.tar.gz: 706635320906ea8377d49bb3025fca4d4a886d1c
 SHA512:
-  metadata.gz: e74bc2a195aa7ebd1c4954452411c0386ca537c3a0307f603f1f568f585deb1ee5b2f25f468eb30f34adfc0f8089e687d474d5eb3a767bd9055abfb47f326819
-  data.tar.gz: 5f90b7bb8abb85f3761441c7ba9f3a4e467d3bec8683fb496e52245cfefac602773e050165be7235b9c57074f920962587c15f19beec60cbc9df514094e29930
+  metadata.gz: 86a9ae9bb75d89e9321321012e7564eddc0c0057322a768ced90a70baa7a568be6c7672377cb9327f89f3cd1f71121ae7252b86f12fd617250f58baee684524f
+  data.tar.gz: cf90284bae016aeb2121e508e04eb4142d370e363df6a888510f9bad70b061b2ed05aab880071ff9194da3645e7fe1f15e5ef920f346e1fc7e612d7a6096b4b3

data/.travis.yml

@@ -1,7 +1,10 @@
+sudo: false
+cache: bundler
+
 rvm:
   - 2.0.0
   - 2.1.7
-  - 2.2.3
+  - 2.2.2
 
 env:
   - "RAILS_VERSION=3.1.0"
@@ -9,13 +12,15 @@ env:
   - "RAILS_VERSION=4.0.0"
   - "RAILS_VERSION=4.1.0"
   - "RAILS_VERSION=4.2.0"
+  - "RAILS_VERSION=5.0.0"
 
 matrix:
+  allow_failures:
+    - env: "RAILS_VERSION=5.0.0"
+      rvm:
+        - 2.0.0
+        - 2.1.7
 
 notifications:
   recipients:
-    - kpumuk@kpumuk.info
-
-addons:
-  code_climate:
-    repo_token: "8792cbc0d1780830ddd3dd7eb1c25f09f386ba8f04449ad830039469406a6ab3"
+    - Elektron1c97@gmail.com

data/README.md

@@ -1,9 +1,6 @@
 # MetaTags: a gem to make your Rails application SEO-friendly
 
-[![Travis-CI build status](https://secure.travis-ci.org/kpumuk/meta-tags.svg)](http://travis-ci.org/kpumuk/meta-tags)
-[![Gem Version](https://badge.fury.io/rb/meta-tags.svg)](http://badge.fury.io/rb/meta-tags)
-[![Code Climate](https://codeclimate.com/github/kpumuk/meta-tags.png)](https://codeclimate.com/github/kpumuk/meta-tags)
-[![Coverage](https://codeclimate.com/github/kpumuk/meta-tags/coverage.png)](https://codeclimate.com/github/kpumuk/meta-tags)
+[![Travis-CI build status](https://travis-ci.org/Elektron1c97/meta_tags-rails.svg?branch=master)](https://travis-ci.org/Elektron1c97/meta_tags-rails)
 
 Search Engine Optimization (SEO) plugin for Ruby on Rails applications.
 

data/lib/meta_tags-rails/controller_helper.rb

@@ -12,20 +12,14 @@ module MetaTags
   module ControllerHelper
     extend ActiveSupport::Concern
 
-    included do
-      alias_method_chain :render, :meta_tags
-    end
-
     # Processes the <tt>@page_title</tt>, <tt>@page_keywords</tt>, and
     # <tt>@page_description</tt> instance variables and calls +render+.
-    def render_with_meta_tags(*args, &block)
+    def render(*args, &block)
       self.meta_tags[:title]       = @page_title       if @page_title
       self.meta_tags[:keywords]    = @page_keywords    if @page_keywords
       self.meta_tags[:description] = @page_description if @page_description
-
-      render_without_meta_tags(*args, &block)
+      super
     end
-    protected :render_with_meta_tags
 
     # Set meta tags for the page.
     #

data/lib/meta_tags-rails/renderer.rb

@@ -30,6 +30,8 @@ module MetaTags
       render_links(tags)
 
       render_hash(tags, :og, name_key: :property)
+      render_hash(tags, :fb, name_key: :property)
+      render_hash(tags, :al, name_key: :property)
       render_hashes(tags)
       render_custom(tags)
 
@@ -147,7 +149,7 @@ module MetaTags
     # @param [Array<Tag>] tags a buffer object to store tag in.
     #
     def render_links(tags)
-      [ :canonical, :prev, :next, :author, :publisher ].each do |tag_name|
+      [ :canonical, :prev, :next, :author, :publisher, :amphtml ].each do |tag_name|
         href = meta_tags.extract(tag_name)
         if href.present?
           @normalized_meta_tags[tag_name] = href

data/lib/meta_tags-rails/version.rb

@@ -1,4 +1,4 @@
 module MetaTags
   # Gem version.
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/lib/meta_tags-rails.rb

@@ -34,4 +34,4 @@ require 'meta_tags-rails/text_normalizer'
 require 'meta_tags-rails/view_helper'
 
 ActionView::Base.send :include, MetaTags::ViewHelper
-ActionController::Base.send :include, MetaTags::ControllerHelper
+ActionController::Base.send :prepend, MetaTags::ControllerHelper

data/spec/controller_helper_spec.rb

@@ -1,11 +1,14 @@
 require 'spec_helper'
 
-class MetaTagsController < ActionController::Base
+class ActionController::Base
   attr_reader :rendered
 
-  def render_without_meta_tags
+  def render(*args, &block)
     @rendered = true
   end
+end
+
+class MetaTagsController < ActionController::Base
 
   def index
     @page_title       = 'title'

data/spec/view_helper/title_spec.rb

@@ -75,12 +75,6 @@ describe MetaTags::ViewHelper do
       subject.display_meta_tags(site: 'someSite', separator: ':').tap do |meta|
         expect(meta).to eq('<title>someSite : someTitle</title>')
       end
-      subject.display_meta_tags(site: 'someSite', separator: '&amp;').tap do |meta|
-        expect(meta).to eq('<title>someSite &amp;amp;amp; someTitle</title>')
-      end
-      subject.display_meta_tags(site: 'someSite', separator: '&amp;'.html_safe).tap do |meta|
-        expect(meta).to eq('<title>someSite &amp;amp; someTitle</title>')
-      end
       subject.display_meta_tags(site: 'someSite: ', separator: false).tap do |meta|
         expect(meta).to eq('<title>someSite: someTitle</title>')
       end

data/spec/view_helper_spec.rb

@@ -51,6 +51,35 @@ describe MetaTags::ViewHelper do
         expect(meta).to have_tag('meta', with: { content: "facebook description", property: "og:description" })
       end
     end
+
+    it 'should work with app links parameters' do
+      subject.set_meta_tags('al' => {
+        'ios' => {
+          'url' => 'http://example.com',
+          'app_name' => 'My App'
+        }
+      })
+      subject.display_meta_tags(site: 'someSite').tap do |meta|
+        expect(meta).to have_tag('meta', with: { content: "http://example.com", property: "al:ios:url" })
+        expect(meta).to have_tag('meta', with: { content: "My App", property: "al:ios:app_name" })
+      end
+    end
+
+    it 'should work with amp url parameters' do
+      subject.set_meta_tags('amphtml' => 'http://example.com')
+      subject.display_meta_tags(site: 'someSite').tap do |meta|
+        expect(meta).to have_tag('link', with: { rel: "amphtml", href: "http://example.com" })
+      end
+    end
+
+    it 'should work with facebook parameters' do
+      subject.set_meta_tags('fb' => {
+        'app_id' => 'something'
+      })
+      subject.display_meta_tags(site: 'someSite').tap do |meta|
+        expect(meta).to have_tag('meta', with: { content: "something", property: "fb:app_id" })
+      end
+    end
   end
 
   it_behaves_like '.set_meta_tags'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: meta_tags-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Dmytro Shteflyuk
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-03 00:00:00.000000000 Z
+date: 2016-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack