meta_information 1.0.4 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d1de3cceee376e56a9f4d49f6608c4d46e8b6054
-  data.tar.gz: bcb9ea854f3ab2e68f9e510ca88d7100c854a236
+SHA256:
+  metadata.gz: a986aa80d954fde7cd758f23b62fa4bc6c6ef564ab06a86b55f8b4980739812e
+  data.tar.gz: f2d878d8d1c57665677608e71e6d5f75dcfccf256ea4b625750695bab8740ca1
 SHA512:
-  metadata.gz: 669f92134cf2387d3512147dfedc9857fb2922a4f11393c5bfd77ba1fd59c1444fee60bc08d149e0a69922627da7d9f15207f23a33c9015740d891aa3885215a
-  data.tar.gz: f0b443ef842d188520586e568201a403869988238a0ce3801d2cca86c16b07d96bab1a472d4421686c7dd09a51dcfe0e6f9a5d903e98efe0ddeb0180f5aabac8
+  metadata.gz: 00ad8369eb9559cb958b4fd2443c5e09d42a2c03d0ed1d4425ca7247f02d2abc90b66ecb4884a6d11faed122d74a812dbb87e36a273c2c0e8bad63f8dfbd1c87
+  data.tar.gz: 32798218b16280ca2cc0e7f58659d04f8b91853935a00646dade439b85e927305cc2a2f4d8e1bc8d5c0ff72cebfc22c29b45a1d18c753b70102ee13db6ec0d54

data/CHANGELOG.md

@@ -0,0 +1,6 @@
+## Changelog
+
+### 1.1.0
+
+- Added rubocop
+- Replaced open-uri by net/http

data/Gemfile

@@ -1,5 +1,12 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
-ruby ['>= 2.1.0', '<= 2.4.0'] # 2.4.0 is latest ruby on 2017-07-09
+ruby ['>= 2.1.0', '<= 2.7.0']
 
 gem 'nokogiri'
-gem 'rspec'
+
+group :development, :test do
+  gem 'pry'
+  gem 'rspec'
+  gem 'rubocop'
+end

data/README.md

@@ -1,18 +1,26 @@
 # MetaInformation
+
 [![Gem Version](https://badge.fury.io/rb/meta_information.svg)](https://badge.fury.io/rb/meta_information)
 
 Simple gem for parsing meta information from websites. It scan all meta-tags by name or property attributes.
+
 ## Instalation
+
 Add this line to your application's Gemfile:
+
 ```ruby
 gem 'meta_information'
 ```
+
 Then run `bundle install`
 Or install it yourself as:
+
 ```sh
 gem install meta_information
 ```
+
 ## Usage
+
 ```ruby
 require 'pp'
 meta = MetaInformation.get_meta('https://www.awesome_site.com/awesome_page')
@@ -36,5 +44,7 @@ pp meta
 #   {:type=>"property", :name=>nil, :property=>"fb:app_id", :content=>"1234567890"},
 ###
 ```
+
 ## License
+
 MIT License.

data/ROADMAP.md

@@ -0,0 +1,3 @@
+## ROADMAP
+
+- Instead of returing hash, module `MetaInformation` should return struct object as a result. Each node should be a struct with methods to recognize a tag such as `.twitter?`, `.og?`, `.fb?`, '.vk?' (check it by property attr).

data/lib/meta_information.rb

@@ -1,16 +1,18 @@
-require 'meta_information/version'
+# frozen_string_literal: true
+
+require_relative 'meta_information/version'
 require 'nokogiri'
-require 'open-uri'
+require 'uri'
+require 'net/http'
 
-# MetaInformation - module for scaning meta information
-# form web page
-# for usage
+# MetaInformation - module for scaning meta information from web page
 # MetaInformation.get_meta('https://some_site.com/some_page')
 module MetaInformation
   extend self
 
   def get_meta(input_url)
     return not_valid_url_error unless valid_url?(input_url)
+    return not_valid_url_scheme unless valid_url_scheme?(input_url)
 
     document = create_document(input_url)
     return nokogiri_error if document == false
@@ -21,16 +23,19 @@ module MetaInformation
 
   private
 
+  # TODO: change to struct
   def create_meta_array(document)
-    document.css('meta').map do |node|
-      {
-        type: node_type(node),
-        name: node['name'],
-        property: node['property'],
-        content: node['content'],
-        itemprop: node['itemprop']
-      }
-    end
+    document
+      .css('meta').reject { |node| node_type(node).nil? }
+      .map do |node|
+        {
+          type: node_type(node),
+          name: node['name'],
+          property: node['property'],
+          content: node['content'],
+          itemprop: node['itemprop']
+        }
+      end
   end
 
   def node_type(node)
@@ -41,17 +46,28 @@ module MetaInformation
     elsif !node['itemprop'].nil?
       'itemprop'
     else
-      ''
+      nil
     end
   end
 
   def valid_url?(uri)
-    !(uri =~ URI.regexp).nil?
+    !(uri =~ URI::DEFAULT_PARSER.make_regexp).nil?
+  end
+
+  def valid_url_scheme?(input_url)
+    URI(input_url).is_a?(URI::HTTP)
   end
 
   def create_document(input_url)
-    Nokogiri::HTML(open(input_url))
-  rescue
+    uri = URI(input_url)
+    res = Net::HTTP.get_response(uri)
+
+    raise 'Response code is not 2xx' if !(res.code.to_i >= 200 && res.code.to_i <= 299)
+    raise 'Response is without body' unless res.class.body_permitted?
+
+    Nokogiri::HTML(res.body)
+  rescue StandardError => e
+    puts e
     false
   end
 
@@ -62,6 +78,13 @@ module MetaInformation
     }
   end
 
+  def not_valid_url_scheme
+    {
+      success: false,
+      error: 'url must be http(s)'
+    }
+  end
+
   def nokogiri_error
     {
       success: false,

data/lib/meta_information/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MetaInformation
-  VERSION = '1.0.4'
+  VERSION = '1.1.0'
 end

data/meta_information.gemspec

@@ -1,17 +1,25 @@
-$:.push File.expand_path("../lib", __FILE__)
-require "meta_information/version"
+# frozen_string_literal: true
+
+$LOAD_PATH.push File.expand_path('lib', __dir__)
+require 'meta_information/version'
 
 Gem::Specification.new do |s|
+  s.required_ruby_version = '>= 2.1.0'
   s.name        = 'meta_information'
   s.version     = MetaInformation::VERSION
-  s.date        = '2017-07-31'
+  s.date        = '2021-02-12'
   s.summary     = 'MetaInformation - Simple gem for parsing meta information'
-  s.description = 'Simple gem for parsing meta information from websites. It scan all meta-tags by name, itemprop or property attributes.'
+  s.description = 'Simple gem for parsing meta information from websites. It scans all meta-tags by name, itemprop or property attributes.'
   s.author      = 'Vladislav Kopylov'
   s.email       = 'kopylov.vlad@gmail.com'
-  s.files       = `git ls-files`.split("\n")
+  s.files       = `git ls-files -z`.split("\x0").reject { |f| f =~ /^bin/ }
+  s.executables = []
   s.homepage    = 'https://github.com/kopylovvlad/meta_information'
   s.license     = 'MIT'
 
-  s.add_dependency('nokogiri', '~> 1.7', '>= 1.7.0')
+  s.add_dependency('nokogiri')
+
+  s.add_development_dependency('pry')
+  s.add_development_dependency('rspec')
+  s.add_development_dependency('rubocop')
 end

data/spec/config.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 RSpec.configure do |rspec|
   rspec.shared_context_metadata_behavior = :apply_to_host_groups
   rspec.include_context 'shared stuff', include_shared: true
-end
+end

data/spec/lib/meta_information_spec.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require './lib/meta_information'
-require './spec/shared_stuff.rb'
-require './spec/config.rb'
+require './spec/shared_stuff'
+require './spec/config'
 
 RSpec.describe 'MetaInformation' do
   include_context 'shared stuff'
@@ -17,6 +19,13 @@ RSpec.describe 'MetaInformation' do
       )
     end
 
+    it 'should return not_valid_url_scheme_error' do
+      result = MetaInformation.get_meta('ftp://some_url.com')
+      expect(result).to(
+        eq(success: false, error: 'url must be http(s)')
+      )
+    end
+
     describe 'with mock for valid_url?' do
       before do
         allow(MetaInformation).to receive(:valid_url?).and_return(true)
@@ -112,23 +121,23 @@ RSpec.describe 'MetaInformation' do
   describe 'private hash equal' do
     it 'not_valid_url_error hash' do
       expect(MetaInformation.send(:not_valid_url_error)).to eq({
-        success: false,
-        error: 'url is not valid'
-      })
+                                                                 success: false,
+                                                                 error: 'url is not valid'
+                                                               })
     end
 
     it 'nokogiri_error hash' do
       expect(MetaInformation.send(:nokogiri_error)).to eq({
-        success: false,
-        error: 'error with parsing a document'
-      })
+                                                            success: false,
+                                                            error: 'error with parsing a document'
+                                                          })
     end
 
     it 'success_hash hash' do
       expect(MetaInformation.send(:success_hash)).to eq({
-        succes: 'true',
-        error: ''
-      })
+                                                          succes: 'true',
+                                                          error: ''
+                                                        })
     end
   end
 
@@ -155,10 +164,10 @@ RSpec.describe 'MetaInformation' do
       expect(MetaInformation.send(:node_type, node)).to eq('itemprop')
     end
 
-    it 'must return empty string' do
+    it 'must return nil' do
       document = Nokogiri::HTML('<meta content="og_title" />')
       node = document.css('meta').first
-      expect(MetaInformation.send(:node_type, node)).to eq('')
+      expect(MetaInformation.send(:node_type, node)).to eq(nil)
     end
   end
 end

data/spec/shared_stuff.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_context 'shared stuff', shared_context: :metadata do
   let(:default_html) do
     '

metadata

@@ -1,36 +1,72 @@
 --- !ruby/object:Gem::Specification
 name: meta_information
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.1.0
 platform: ruby
 authors:
 - Vladislav Kopylov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-31 00:00:00.000000000 Z
+date: 2021-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
-description: Simple gem for parsing meta information from websites. It scan all meta-tags
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Simple gem for parsing meta information from websites. It scans all meta-tags
   by name, itemprop or property attributes.
 email: kopylov.vlad@gmail.com
 executables: []
@@ -39,10 +75,11 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".ruby-version"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
+- ROADMAP.md
 - lib/meta_information.rb
 - lib/meta_information/version.rb
 - meta_information.gemspec
@@ -61,15 +98,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: MetaInformation - Simple gem for parsing meta information

data/.ruby-version

@@ -1 +0,0 @@
-ruby-2.3.3