meta_events 1.2.0 → 1.2.1

data/CHANGES.md

@@ -1,5 +1,18 @@
 # `meta_events` Changelog
 
+### 1.2.1, 6 November 2014
+
+* Fixed an issue where you could get a `NoMethodError` (`undefined method 'watch' for Spring:Module`) if running with
+  Spring, depending on your exact load order and dependency set. (Thanks to [charle5](https://github.com/charle5) for
+  the catch, and [charle5](https://github.com/charle5) and [Fabian Stehle](https://github.com/fstehle) for fixes!)
+* Fixed an issue where the JavaScript exception you would get if you tried to invoke a front-end event that hadn't
+  been registered would have the wrong event name in it. (Thanks to [Hubert Lee](https://github.com/hube) for the
+  catch and the fix!)
+* Fixed an issue where using `link_to` with a block would fail if you're using `meta_events`, due to the way Rails
+  renames parameters in this scenario. (Thanks to [David Yarbro](https://github.com/yarbro) for the catch and the
+  fix, and [Mark Quezada](https://github.com/markquezada) for submitting it as a pull request!)
+* Added installation instructions. (Thanks to [Anthony](https://github.com/Aerlinger) for the pull request!)
+
 ### 1.2.0, 30 June 2014
 
 * You can now customize the separator used in nested properties by passing (_e.g._) `:property_separator => ' '` to

data/CONTRIBUTORS.md

@@ -10,6 +10,17 @@ Additional contributions by:
 * [Pete Sharum](https://github.com/petesharum): Fix for `Time` objects passed in; turns out `Time#utc` _modifies_ its
   receiver, which is bad.
 * [Jesse Rusak](https://github.com/jder): doc typos and fixes for usage of `Rails.logger`.
+* [charle5](https://github.com/charle5): Fix for `NoMethodError` (`undefined method 'watch' for Spring:Module`)
+  when used with Spring in certain circumstances.
+* [Fabian Stehle](https://github.com/fstehle): Fix for `NoMethodError` (`undefined method 'watch' for Spring:Module`)
+  when used with Spring in certain circumstances.
+* [Hubert Lee](https://github.com/hube): Fix for issue where the JavaScript exception you would get if you tried to
+  invoke a front-end event that hadn't been registered would have the wrong event name in it.
+* [David Yarbro](https://github.com/yarbro): Fix for issue where using `link_to` with a block would fail if you're
+  using `meta_events`, due to the way Rails renames parameters in this scenario.
+* [Mark Quezada](https://github.com/markquezada): Submitting a pull request for issue where using `link_to` with a
+  block would fail if you're using `meta_events`, due to the way Rails renames parameters in this scenario.
+* [Anthony](https://github.com/Aerlinger): Improved installation instructions.
 
 Inspiration for ideas by:
 

data/README.md

@@ -14,6 +14,22 @@ Current build status: ![Current Build Status](https://api.travis-ci.org/swiftype
 Brought to you by the folks at [Swiftype](https://www.swiftype.com/). First version written by
 [Andrew Geweke](https://www.github.com/ageweke). For additional contributors, see [CONTRIBUTORS](CONTRIBUTORS.md).
 
+### Installation
+
+If you're in a project using [Bundler](http://bundler.io/) — for example, any Rails project, most Gems, and
+probably most other Ruby software these days — and therefore have a [`Gemfile`](http://bundler.io/gemfile.html),
+simply add this to the end of your `Gemfile`:
+
+```ruby
+gem 'meta_events'
+```
+
+Alternatively, if you aren't using Bundler:
+
+```ruby
+gem install meta_events
+```
+
 ### Background
 
 Sending user-centric events to (_e.g._) Mixpanel is far from difficult; it's a single method call. However, in a

data/lib/meta_events/helpers.rb

@@ -93,11 +93,17 @@ module MetaEvents
     # Obviously, feel free to create a shorter alias for this method in your application; we give it a long, unique
     # name here so that we don't accidentally collide with another helper method in your project.
     def meta_events_tracked_link_to(name = nil, options = nil, html_options = nil, &block)
+      html_options, options, name = options, name, nil if block_given?
+
       unless html_options && html_options[:meta_event]
         raise ArgumentError, "You asked for a tracked link, but you didn't provide a :meta_event: #{html_options.inspect}"
       end
 
-      link_to(name, options, meta_events_tracking_attributes_for(html_options, meta_events_tracker), &block)
+      if block_given?
+        link_to(options, meta_events_tracking_attributes_for(html_options, meta_events_tracker), &block)
+      else
+        link_to(name, options, meta_events_tracking_attributes_for(html_options, meta_events_tracker))
+      end
     end
 
 

data/lib/meta_events/railtie.rb

@@ -1,3 +1,17 @@
+# See if we can load Spring -- but don't fail if we can't; this just helps us decide whether to call
+# Spring.watch.
+begin
+  gem 'spring'
+rescue Gem::LoadError => le
+  # ok
+end
+
+begin
+  require 'spring/watcher'
+rescue LoadError => le
+  # ok
+end
+
 module MetaEvents
   class Railtie < Rails::Railtie
     def say(x)
@@ -20,9 +34,7 @@ module MetaEvents
         ::MetaEvents::Tracker.default_definitions = config_meta_events
         say "Loaded event definitions from #{config_meta_events.inspect}"
 
-        if defined?(::Spring)
-          Spring.watch config_meta_events
-        end
+        Spring.watch config_meta_events if defined?(::Spring)
       end
     end
   end

data/lib/meta_events/version.rb

@@ -1,3 +1,3 @@
 module MetaEvents
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/vendor/assets/javascripts/meta_events.js.erb

@@ -116,7 +116,7 @@ MetaEvents = (function() {
 
     if (eventData == null) {
       <% if Rails.env.development? %>
-      throw "No front-end event has been registered named '" + name + "'. Did you forget to call meta_events_define_frontend_event on the server?";
+      throw "No front-end event has been registered named '" + eventAlias + "'. Did you forget to call meta_events_define_frontend_event on the server?";
       <% end %>
       return;
     }

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: meta_events
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
+  prerelease: 
 platform: ruby
 authors:
 - Andrew Geweke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-30 00:00:00.000000000 Z
+date: 2014-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -27,6 +30,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -37,6 +41,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -47,6 +52,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -54,6 +60,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -61,6 +68,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -68,6 +76,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -75,6 +84,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -82,6 +92,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -124,26 +135,27 @@ files:
 homepage: http://www.github.com/swiftype/meta_events
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 1.8.23.2
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Structured, documented, powerful event emitting library for Mixpanel and
   other such systems.
 test_files:

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NzJiMzIzNTY1ZGVhZTQwZjFmYWE1YWM5NTY3YzRhYjMyNDMyZDgwYw==
-  data.tar.gz: !binary |-
-    Y2FkY2IxOTdhNTFmODVhMTQ1YTk1ODUxNzViNDIxNGNkOGFhMTk5ZQ==
-SHA512:
-  metadata.gz: !binary |-
-    MDA0ZjdjYWYwZTFiODRjZTdlNzk5YmJlOTc0ZGExZmQwOThlOWE0MWZjZWQ1
-    OTIzZjgxN2ZhY2M2OTM5YjVjMzUyY2I2NDE3ZWYwZDVjZTU0NmM1MTAyMWYx
-    NjBiNDFmMjhmMTljM2I5OTQ0ODRlNjA0MmIwZTA4MjljYmM5YjQ=
-  data.tar.gz: !binary |-
-    YTU5Y2NlMmIyZWUxODIzODI4ZWMzZTk2OTM3ZTViMmY1OGM4MTBkYjU5OGEy
-    MjkzMmQwZjBkMWM3Y2ZjOTM4MmJiNWZiMGI0YWY3MjE5ZmJkMDk2NzdmNDgy
-    MTkwYzBmYThlNGQ4MDZiMTcyYjRhYjBiYzdhNmE0ZmNhZDczYWE=