meta_events 1.1.1 → 1.1.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Nzk0YTYzYzQ3ZjRhZjEwZTY2MGViNDllNzIzNzY1ZTljYjY4NzIzZg==
+    NDEzNzUyNjM1MmVhOGM1YmRhODUzYTI3Njg0ZDk4Mjc3MDY3OWFjYQ==
   data.tar.gz: !binary |-
-    MTkyYmZjNTA4ZWUwYTQzNmE5NDE5NGQ2MjgyMDA4ODI5Y2I1MzQ2ZA==
+    NjE4N2Q4MDc1YjFmNmM0MDUxZDEwYzA5NzQ5ODY2ZjNlMDQ1NTgyMA==
 SHA512:
   metadata.gz: !binary |-
-    MzI3NjNhNjQ1NWY2ZDliNDNkODdkYWM0Yzk5OTQyZTc4NjQ3MWU3YmIxODc4
-    OTcwOGNlOGQ4MTJiNTRhY2ZjNjIxZjQ2ZmJhNjBkNGJkNDE2ZmUxZTQ3NTJk
-    M2E5ODAzZmE3ZjNjNzc2ZmUzMTkxZTgxYmRlMWNiMmI5ZTYzMmE=
+    NGY3ZGFkYzU5MjE0MmI0YjZhNDRmZGRhMjM3NWM4MmJjNmNmZDlmMGY1MzQw
+    NzM5MWVhNzU0ODEyMTZmZDU1Y2NjZDZiMTRlYmNmZTNjMDFkMmMwMGIzMWUz
+    MjNmNTRkZDg4OTc5Mzg2ZGJjMTNiNzM0YjQyNWNhMjBhOTU3MDI=
   data.tar.gz: !binary |-
-    YTM3ODBmYmQyMDNiOWI5MzI5ZjM2OGY4ZThmMjNjZmMzMmMyNDBkOTBjYWNi
-    YzYyNTZmNjY2MTg5ODI2YmI5M2ZkNjUxYmM3ODg1ODVjODZhNDAyM2EyZDM4
-    ZDg0NmQ2ZDQ5ZjM0YTAxZDA1MDNjNWNhYWY2ZWRlMzFkZTUyZWQ=
+    ZDRhYzExNDUyOTA1ODFkMDFkYmY5ODllZDcxZGIyOWE2N2M0ZTFlN2ZjYWYz
+    NDAwNTY3Njk2YWUyMDA3MzhmMjMyMjQzMjBiZGM0ZmNiNGVhNjNmNjZkYzVh
+    Njc0ZWRmOTQwYWFlNDhkYzMyZTk2ZThlOWY5NTEyMGYyMTc2YTk=

data/CHANGES.md

@@ -1,5 +1,10 @@
 # `meta_events` Changelog
 
+### 1.1.2, 29 May 2014
+
+* The `:external_name` on an Event was not correctly passed (instead of the fully-qualified event name) when using
+  link auto-tracking. This fixes the issue, and adds a spec to make sure it works properly.
+
 ### 1.1.1, 26 May 2014
 
 * 1.1.0 was accidentally released with a bad dependency that prevented it from installing against anything that used

data/README.md

@@ -4,7 +4,7 @@ and a powerful properties system that makes it easy to pass large numbers of con
 
 MetaEvents supports:
 
-* Ruby 1.8.7, 1.9.3, 2.0.0, 2.1.0, or JRuby 1.7.9
+* Ruby 1.8.7, 1.9.3, 2.0.0, 2.1.1, or JRuby 1.7.11
 
 These are, however, just the versions it's tested against; MetaEvents contains no code that should be at all
 particularly dependent on exact Ruby versions, and should be compatible with a broad set of versions.

data/lib/meta_events/helpers.rb

@@ -76,7 +76,7 @@ module MetaEvents
       output_attributes[:class] = classes
 
       # Set the data attributes we'll be looking for...
-      output_attributes["data-#{meta_events_prefix_attribute('evt')}"] = props_data[:event_name]
+      output_attributes["data-#{meta_events_prefix_attribute('evt')}"] = props_data[:external_name]
       output_attributes["data-#{meta_events_prefix_attribute('prp')}"] = props_data[:properties].to_json
 
       # And we're done!

data/lib/meta_events/version.rb

@@ -1,3 +1,3 @@
 module MetaEvents
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/meta_events/controller_methods_and_helpers_spec.rb

@@ -194,6 +194,12 @@ describe MetaEvents::ControllerMethods do
       expect(remaining['data']).to be_nil
     end
 
+    it "should use the #external_name for the event" do
+      me = { :category => 'foo', :event => 'custom', :properties => { :something => 'awesome' } }
+      remaining = expect_meta4({ :meta_event => me }, %w{mejtp_trk}, 'super-amazing-custom', { 'something' => 'awesome', 'imp1' => 'imp1val1' })
+      expect(remaining['data']).to be_nil
+    end
+
     it "should combine the class with an existing class string" do
       me = { :category => 'foo', :event => 'bar', :properties => { :something => 'awesome' } }
       remaining = expect_meta4({ :meta_event => me, :class => 'bonko baz' }, [ 'bonko baz', 'mejtp_trk' ], 'xy1_foo_bar', { 'something' => 'awesome', 'imp1' => 'imp1val1' })

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: meta_events
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Andrew Geweke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-27 00:00:00.000000000 Z
+date: 2014-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json