met_museum 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a79a7c355d8200cfccab7fdb7fbd01f37a74ee82a555de9a4697a6800616d2e4
-  data.tar.gz: 647315d7446816af5ce68035edcbedf32593a89aad70c511632f8ce3abe652c5
+  metadata.gz: 747d015331b55f840aa0065fbfc3e2822fda2f2f52a5a6ddede4b7f62ade5735
+  data.tar.gz: ac3158ff771e89fc1fb3d563920b02797c97c15be9dbd8a1ed5618649b53194b
 SHA512:
-  metadata.gz: e31f31134b22d04612fdc5ef4f303cbfe2f25a1da5b9e0b2784b0fc3415daa8b876afba041f1747dd407dbab0cf57ca29e0a7350c6dfb0c0c0215b1fca655816
-  data.tar.gz: 28828344996f33389508a8664939a18fd3f182800dfe81bb3bf14d7b68864ecaa56d94698d73c93df6592af98be7f631d896aaf648b9d10b730fa9f3eb864fc5
+  metadata.gz: c02a1a47672656535464183e79b4129b0d4b12632b48382afe8a3aff36d24af355620b51097324157f04342c361dcf62d74396916b52edf05359de6a011a37b1
+  data.tar.gz: 33eedda5f92fe536476dd03c0ba50aad36610f09440fcf15317b905baeac576108d3ac7993269a2619ed403c3ab5883a21193d87da2f72c3fb9e5358a67dd58f

data/.github/workflows/ruby.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [ '2.5', '2.6', '2.7', '3.0' ]
+        ruby: [ '2.6', '2.7', '3.0', '3.1' ]
     name: Ruby ${{ matrix.ruby }} spec
     steps:
     - uses: actions/checkout@v2
@@ -26,6 +26,7 @@ jobs:
       # uses: ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0
       with:
         ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
     - name: Install dependencies
       run: bundle install
     - name: Run spec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    met_museum (1.4.0)
+    met_museum (1.4.1)
       faraday
       oj
 
@@ -26,7 +26,7 @@ GEM
     rainbow (3.0.0)
     rake (13.0.1)
     regexp_parser (1.7.1)
-    rexml (3.2.4)
+    rexml (3.2.5)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -54,7 +54,7 @@ GEM
     rubocop-ast (0.1.0)
       parser (>= 2.7.0.1)
     ruby-progressbar (1.10.1)
-    ruby2_keywords (0.0.2)
+    ruby2_keywords (0.0.5)
     unicode-display_width (1.7.0)
 
 PLATFORMS

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2020 hyuraku
+Copyright (c) 2021 hyuraku
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/lib/met_museum/collection.rb

@@ -2,6 +2,9 @@ require "met_museum/api_expections"
 require "met_museum/endpoint"
 require "met_museum/http_status_code"
 
+require "faraday"
+require "oj"
+
 module MetMuseum
   class Collection
     # Return a listing of all valid Object IDs available to use
@@ -15,10 +18,11 @@ module MetMuseum
         metadataDate: nil,
         departmentIds: nil
       }.merge(args)
+
       options[:metadataDate] = check_date(options[:metadataDate])
       query = { metadataDate: options[:metadataDate], departmentIds: options[:departmentIds] }
-      response = new_faraday(API_ENDPOINT, PUBLIC_URI, query)
-      return_response(response)
+      response = create_request(API_ENDPOINT, PUBLIC_URI, query)
+      arrange_response(response)
     end
 
     # returns a record for an object, containing all open access data about that object, including its image (if the image is available under Open Access)
@@ -80,8 +84,8 @@ module MetMuseum
     # @return [Hash<GalleryNumber, string>] Gallery number, where available
 
     def object(object_id)
-      response = new_faraday(API_ENDPOINT, "#{PUBLIC_URI}/#{object_id}")
-      return_response(response)
+      response = create_request(API_ENDPOINT, "#{PUBLIC_URI}/#{object_id}")
+      arrange_response(response)
     end
 
     # returns a listing of all departments
@@ -89,8 +93,8 @@ module MetMuseum
     # @return [Integer] departments Department ID as an integer. The departmentId is to be used as a query parameter on the `/objects` endpoint
     # @return [String] departments Display name for a department
     def department
-      response = new_faraday(API_ENDPOINT, DEPARTMENTS_URI)
-      return_response(response)
+      response = create_request(API_ENDPOINT, DEPARTMENTS_URI)
+      arrange_response(response)
     end
 
     # returns a listing of all Object IDs for objects that contain the search query within the object’s data
@@ -102,17 +106,17 @@ module MetMuseum
     # @return [Array<Object>] objects An array containing the objects that contain the search query within the object’s data
     def search(query, **args)
       args.merge!({q: query})
-      response = new_faraday(API_ENDPOINT, SEARCH_URI, args)
-      origin_response = return_response(response)
+      response = create_request(API_ENDPOINT, SEARCH_URI, args)
+      origin_response = arrange_response(response)
       limit = args[:limit].to_i
       return origin_response if limit <= 0
 
-      origin_response["objectIDs"][0..limit - 1].map { |id| MetMuseum::Collection.new.object(id) }
+      origin_response["objectIDs"].lazy.map { |id| MetMuseum::Collection.new.object(id) }.first(limit)
     end
 
     private
 
-    def new_faraday(url, dir, params = nil)
+    def create_request(url, dir, params = nil)
       Faraday.new(url: url).get dir, params
     end
 
@@ -127,7 +131,7 @@ module MetMuseum
       raise TypeError, "Write certain date"
     end
 
-    def return_response(response)
+    def arrange_response(response)
       return Oj.load(response.body) if response_successful?(response)
 
       raise MetMuseum.error_class(response), "Code: #{response.status}, response: #{response.body}"

data/lib/met_museum/version.rb

@@ -1,3 +1,3 @@
 module MetMuseum
-  VERSION = "1.4.0".freeze
+  VERSION = "1.4.1".freeze
 end

data/lib/met_museum.rb

@@ -1,6 +1,3 @@
-require "faraday"
-require "oj"
-
 require "met_museum/collection"
 require "met_museum/version"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: met_museum
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - hyuraku
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-12-29 00:00:00.000000000 Z
+date: 2022-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -140,7 +140,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/hyuraku/met_museum
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -155,8 +155,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.3.3
+signing_key:
 specification_version: 4
 summary: MET museum api wrapper
 test_files: []