met_museum 1.3.6 → 1.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f6c889b04efc44af710a4bf5ee316ac4f1eb1f8c1c639854a51b6cc4e721052
-  data.tar.gz: 497b94cb694f008ba8df1023e8c4ba3e51e9e4574c1b9479a6a21b325af7dcfe
+  metadata.gz: 42eaa0e635711cb6b371d1a7cc524b552f40c402c7506b9cda10ef48487f7f3b
+  data.tar.gz: 1259dc15496c35bde977e5a66a0449dfb068d2bee0ef6914294bba38a474ae39
 SHA512:
-  metadata.gz: 0acb38e8a3e368d04515b8fb36519022e965ce65634cf02d1ea9c9062d57d577b270a26f954f711022b424a95290095c5361857c8ee414e5cdda1005d5c66b42
-  data.tar.gz: bb2730f3aa1efa1f5f06520279e71eb187a6ff813906409fdbbd8340575a64102d0ae6e6875fbe0c3475954fa6f37b4d7264c15b276e8093166071f19cc19359
+  metadata.gz: 6d8fb6c6316e77adaf4d700e97f68b8af64bc0f9e24a508486252955387778644621e76dc0754f20aadcbd4aa7df1db89e00b6230ea10b1c5955f2bb4e8c9b50
+  data.tar.gz: 625e78ae82ad40f8f533e4cb9d3d94e293511ae411d9cbcf5008475770e76b71382efc7914e1f7d1592ad8d1a85b87b7c8f2f9dee64fb9e8987b61518bcf01c9

data/.github/workflows/ruby.yml

@@ -0,0 +1,32 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on: [push, pull_request]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.6', '2.7' ]
+    name: Ruby ${{ matrix.ruby }} spec
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+    # uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies
+      run: bundle install
+    - name: Run spec
+      run: bundle exec rake

data/.rubocop.yml

@@ -0,0 +1,13 @@
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Documentation:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: true
+  Max: 20

data/.travis.yml

@@ -3,6 +3,7 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
+  - 2.7.1
   - 2.6.0
   - 2.5.0
 script:

data/Gemfile

@@ -1,7 +1,7 @@
 source "https://rubygems.org"
 
 group :development do
-  gem 'pry'
+  gem "pry"
 end
 
 # Specify your gem's dependencies in met_museum.gemspec

data/Gemfile.lock

@@ -1,24 +1,31 @@
 PATH
   remote: .
   specs:
-    met_museum (1.3.5)
+    met_museum (1.3.7)
       faraday
       oj
 
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.1)
     coderay (1.1.2)
     diff-lcs (1.3)
-    faraday (0.17.1)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
     method_source (0.9.2)
     multipart-post (2.1.1)
     oj (3.10.0)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
+    rainbow (3.0.0)
     rake (13.0.1)
+    regexp_parser (1.7.1)
+    rexml (3.2.4)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -34,6 +41,19 @@ GEM
     rspec-retry (0.6.1)
       rspec-core (> 3.3)
     rspec-support (3.8.0)
+    rubocop (0.86.0)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
+      rexml
+      rubocop-ast (>= 0.0.3, < 1.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.1.0)
+      parser (>= 2.7.0.1)
+    ruby-progressbar (1.10.1)
+    unicode-display_width (1.7.0)
 
 PLATFORMS
   ruby
@@ -45,6 +65,7 @@ DEPENDENCIES
   rake (~> 13.0)
   rspec (~> 3.0)
   rspec-retry
+  rubocop
 
 BUNDLED WITH
    2.0.2

data/Rakefile

@@ -3,4 +3,4 @@ require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/lib/met_museum/collection.rb

@@ -10,13 +10,14 @@ module MetMuseum
     # @params [Integer] departmentIds Returns any objects in a specific department
     # @return [Hash<total, Integer>] The total number of publicly-available objects
     # @return [Hash<objectIDs, Array<Integer>>] An array containing the object ID of publicly-available object
-    def objects(options = {})
+    def objects(**args)
       options = {
         metadataDate: nil,
         departmentIds: nil
-      }.merge(options)
+      }.merge(args)
       options[:metadataDate] = check_date(options[:metadataDate])
-      response = new_faraday(API_ENDPOINT, PUBLIC_URI, {:metadataDate => options[:metadataDate], :departmentIds => options[:departmentIds]})
+      query = { metadataDate: options[:metadataDate], departmentIds: options[:departmentIds] }
+      response = new_faraday(API_ENDPOINT, PUBLIC_URI, query)
       return_response(response)
     end
 
@@ -74,9 +75,9 @@ module MetMuseum
     # @return [Hash<tags,  Array<String>>] An array of subject keyword tags associated with the object
     # @return [Hash<objectWikidata_URL, string>] Wikidata URL for the object
     # @return [Hash<isTimelineWork, boolean>] Whether the object is on the Timeline of Art History website
-    
-    def object(objectID)
-      response = new_faraday(API_ENDPOINT, "#{PUBLIC_URI}/#{objectID}")
+
+    def object(object_id)
+      response = new_faraday(API_ENDPOINT, "#{PUBLIC_URI}/#{object_id}")
       return_response(response)
     end
 
@@ -96,57 +97,31 @@ module MetMuseum
     # @return [Integer] total The total number of publicly-available objects
     # @return [Array<Integer>] objectIDs An array containing the object ID of publicly-available object
     # @return [Array<Object>] objects An array containing the objects that contain the search query within the object’s data
-    def search(query, options = {})
-      options = {
-        limit: 0,
-        isHighlight: false,
-        departmentId: nil,
-        isOnView: nil,
-        artistOrCulture: nil,
-        medium: nil,
-        hasImages: nil,
-        geoLocation: nil,
-        dateBegin: 0,
-        dateEnd: 2000
-      }.merge(options)
+    def search(query, **args)
+      options = default_search_options.merge(args)
       response = new_faraday(API_ENDPOINT, SEARCH_URI, {
-        :q => query,
-        :isHighlight => options[:isHighlight],
-        :departmentId => options[:departmentId],
-        :isOnView => options[:isOnView],
-        :artistOrCulture => options[:artistOrCulture],
-        :medium => options[:medium]&.multi_option,
-        :hasImages => options[:hasImages],
-        :geoLocation => options[:geoLocation]&.multi_option,
-        :dateBegin => options[:dateBegin],
-        :dateEnd => options[:dateEnd]
-      })
+                               q: query,
+                               isHighlight: options[:isHighlight],
+                               departmentId: options[:departmentId],
+                               isOnView: options[:isOnView],
+                               artistOrCulture: options[:artistOrCulture],
+                               medium: options[:medium]&.multi_option,
+                               hasImages: options[:hasImages],
+                               geoLocation: options[:geoLocation]&.multi_option,
+                               dateBegin: options[:dateBegin],
+                               dateEnd: options[:dateEnd]
+                             })
       origin_response = return_response(response)
-      return origin_response if options[:limit] <= 0
-      origin_response["objectIDs"][0..options[:limit] - 1].map{|id| MetMuseum::Collection.new.object(id)}
+      limit = options[:limit].to_i
+      return origin_response if limit <= 0
+
+      origin_response["objectIDs"][0..limit - 1].map { |id| MetMuseum::Collection.new.object(id) }
     end
 
     private
 
     def new_faraday(url, dir, params = nil)
-      Faraday.new(:url => url).get dir, params
-    end
-
-    def error_class(response)
-      case response.status
-      when HTTP_BAD_REQUEST_CODE
-        BadRequestError
-      when HTTP_UNAUTHORIZED_CODE
-        UnauthorizedError
-      when HTTP_FORBIDDEN_CODE
-        ForbiddenError
-      when HTTP_NOT_FOUND_CODE
-        NotFoundError
-      when HTTP_UNPROCESSABLE_ENTITY_CODE
-        UnprocessableEntityError
-      else
-        ApiError
-      end
+      Faraday.new(url: url).get dir, params
     end
 
     def response_successful?(response)
@@ -155,7 +130,7 @@ module MetMuseum
 
     def check_date(date)
       return nil if date.nil?
-      return date.to_date.to_s if date.kind_of? Date
+      return date.to_date.to_s if date.is_a? Date
 
       raise TypeError, "Write certain date"
     end
@@ -163,13 +138,29 @@ module MetMuseum
     def return_response(response)
       return Oj.load(response.body) if response_successful?(response)
 
-      raise error_class(response), "Code: #{response.status}, response: #{response.body}"
+      raise MetMuseum.error_class(response), "Code: #{response.status}, response: #{response.body}"
     end
 
     def multi_option
-      return self if self.kind_of? String
-      return self.join('|') if self.kind_of? Array
+      return self if is_a? String
+      return join("|") if is_a? Array
+
       raise TypeError, "Write String or Array type"
     end
+
+    def default_search_options
+      {
+        limit: 0,
+        isHighlight: false,
+        departmentId: nil,
+        isOnView: nil,
+        artistOrCulture: nil,
+        medium: nil,
+        hasImages: nil,
+        geoLocation: nil,
+        dateBegin: 0,
+        dateEnd: 2000
+      }
+    end
   end
 end

data/lib/met_museum/http_status_code.rb

@@ -1,8 +1,25 @@
 module MetMuseum
-  HTTP_OK_CODE = 200.freeze
-  HTTP_BAD_REQUEST_CODE = 400.freeze
-  HTTP_UNAUTHORIZED_CODE = 401.freeze
-  HTTP_FORBIDDEN_CODE = 403.freeze
-  HTTP_NOT_FOUND_CODE = 404.freeze
-  HTTP_UNPROCESSABLE_ENTITY_CODE = 429.freeze
+  HTTP_OK_CODE = 200
+  HTTP_BAD_REQUEST_CODE = 400
+  HTTP_UNAUTHORIZED_CODE = 401
+  HTTP_FORBIDDEN_CODE = 403
+  HTTP_NOT_FOUND_CODE = 404
+  HTTP_UNPROCESSABLE_ENTITY_CODE = 429
+
+  def self.error_class(response)
+    case response.status
+    when HTTP_BAD_REQUEST_CODE
+      BadRequestError
+    when HTTP_UNAUTHORIZED_CODE
+      UnauthorizedError
+    when HTTP_FORBIDDEN_CODE
+      ForbiddenError
+    when HTTP_NOT_FOUND_CODE
+      NotFoundError
+    when HTTP_UNPROCESSABLE_ENTITY_CODE
+      UnprocessableEntityError
+    else
+      ApiError
+    end
+  end
 end

data/lib/met_museum/version.rb

@@ -1,3 +1,3 @@
 module MetMuseum
-  VERSION = "1.3.6"
+  VERSION = "1.3.7".freeze
 end

data/met_museum.gemspec

@@ -1,5 +1,4 @@
-
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "met_museum/version"
 
@@ -9,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["hyuraku"]
   spec.email         = ["calenthird@gamil.com"]
 
-  spec.summary       = %q{MET museum api wrapper}
-  spec.description   = %q{The Metropolitan Museum of Art Collection API wrapper }
+  spec.summary       = "MET museum api wrapper"
+  spec.description   = "The Metropolitan Museum of Art Collection API wrapper "
   spec.homepage      = "https://github.com/hyuraku/met_museum"
   spec.license       = "MIT"
 
@@ -27,7 +26,7 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
   spec.bindir        = "exe"
@@ -38,6 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-retry"
+  spec.add_development_dependency "rubocop"
 
   spec.add_dependency "faraday"
   spec.add_dependency "oj"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: met_museum
 version: !ruby/object:Gem::Version
-  version: 1.3.6
+  version: 1.3.7
 platform: ruby
 authors:
 - hyuraku
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-13 00:00:00.000000000 Z
+date: 2020-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -101,8 +115,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile