met_museum 1.3.4 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f318ac9ca9aedae15b10e0202143b88719a0df5324a8057f33dda6ea52e59909
-  data.tar.gz: 1fb234a9ebbfd1f6bcd39f4626446a0fabaae0f10e7a98a9b41e0bb69c3783df
+  metadata.gz: 5697b8911725b17dc47469633a365f8a9b9f9e3127e65e43746338565fefd56a
+  data.tar.gz: c7d6ca7fab4b88319c3310c9eebac808cf43c3ec92f50d4d247e844200f6b53b
 SHA512:
-  metadata.gz: c88e7b0f617dd49b90f05d6d78e5e0d0172dab5465b765adf747258d012b10879206e8a5065bfde771f140bb69b9c8ec3065332172af0bcab12467e4215ae9eb
-  data.tar.gz: d972b17a10bc8042d5663a361e4c8da5d611a7dcd0d7eef887c6e95ac274eb94adc608e5ef548ca9a9c9976dcafaae1674ff1dbd821e1d22be5e812a62dfd2f4
+  metadata.gz: 1f2be3bb4815092bff418ec2d4e68dc0facf97cb5f0c6cb74ce18f0d7d614f0c36ce12e6b6e5a296b94231e52f5dcc85dbcbf4d601eade9c88a262b3c4d97b71
+  data.tar.gz: 11a8dd620debdbc18c1d2ae0ef1221e7e7386669c6b75a6a8683bc68a4157645ed014b2a3c9bad270e521422f49e06e6c9bc64be87b319709722762eb11cd91b

data/.travis.yml

@@ -5,7 +5,6 @@ cache: bundler
 rvm:
   - 2.6.0
   - 2.5.0
-  - 2.4.2
 script:
   - bundle exec rspec spec/
 before_install:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    met_museum (1.3.3)
+    met_museum (1.3.5)
       faraday
       oj
 
@@ -10,11 +10,11 @@ GEM
   specs:
     coderay (1.1.2)
     diff-lcs (1.3)
-    faraday (0.15.4)
+    faraday (0.17.1)
       multipart-post (>= 1.2, < 3)
     method_source (0.9.2)
     multipart-post (2.1.1)
-    oj (3.9.0)
+    oj (3.10.0)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)

data/lib/met_museum/collection.rb

@@ -6,6 +6,7 @@ module MetMuseum
   class Collection
     # Return a listing of all valid Object IDs available to use
     # @param [Date] metadataDate Returns any objects with updated data after this date
+    # @param [DateTime] metadataDate Returns any objects with updated data after this date
     # @params [Integer] departmentIds Returns any objects in a specific department
     # @return [Hash<total, Integer>] The total number of publicly-available objects
     # @return [Hash<objectIDs, Array<Integer>>] An array containing the object ID of publicly-available object
@@ -15,7 +16,7 @@ module MetMuseum
         departmentIds: nil
       }.merge(options)
       options[:metadataDate] = check_date(options[:metadataDate])
-      response = Faraday.new(:url => API_ENDPOINT).get PUBLIC_URI, {:metadataDate => options[:metadataDate], :departmentIds => options[:departmentIds]}
+      response = new_faraday(API_ENDPOINT, PUBLIC_URI, {:metadataDate => options[:metadataDate], :departmentIds => options[:departmentIds]})
       return_response(response)
     end
 
@@ -72,7 +73,7 @@ module MetMuseum
     # @return [Hash<objectURL, String>] URL to object's page on metmuseum.org
     # @return [Hash<tags,  Array<String>>] An array of subject keyword tags associated with the object
     def object(objectID)
-      response = Faraday.get "#{API_ENDPOINT}#{PUBLIC_URI}/#{objectID}"
+      response = new_faraday(API_ENDPOINT, "#{PUBLIC_URI}/#{objectID}")
       return_response(response)
     end
 
@@ -81,7 +82,7 @@ module MetMuseum
     # @return [Integer] departments Department ID as an integer. The departmentId is to be used as a query parameter on the `/objects` endpoint
     # @return [String] departments Display name for a department
     def department
-      response = Faraday.get "#{API_ENDPOINT}#{DEPARTMENTS_URI}"
+      response = new_faraday(API_ENDPOINT, DEPARTMENTS_URI)
       return_response(response)
     end
 
@@ -105,9 +106,9 @@ module MetMuseum
         dateBegin: 0,
         dateEnd: 2000
       }.merge(options)
-      response = Faraday.new(:url => API_ENDPOINT).get SEARCH_URI, {
-        :q => query, 
-        :isHighlight => options[:isHighlight], 
+      response = new_faraday(API_ENDPOINT, SEARCH_URI, {
+        :q => query,
+        :isHighlight => options[:isHighlight],
         :departmentId => options[:departmentId],
         :isOnView => options[:isOnView],
         :artistOrCulture => options[:artistOrCulture],
@@ -116,7 +117,7 @@ module MetMuseum
         :geoLocation => options[:geoLocation],
         :dateBegin => options[:dateBegin],
         :dateEnd => options[:dateEnd]
-      }
+      })
       origin_response = return_response(response)
       return origin_response if options[:limit] <= 0
       origin_response["objectIDs"][0..options[:limit] - 1].map{|id| MetMuseum::Collection.new.object(id)}
@@ -124,6 +125,10 @@ module MetMuseum
 
     private
 
+    def new_faraday(url, dir, params = nil)
+      Faraday.new(:url => url).get dir, params
+    end
+
     def error_class(response)
       case response.status
       when HTTP_BAD_REQUEST_CODE
@@ -148,7 +153,7 @@ module MetMuseum
 
     def check_date(date)
       return nil if date.nil?
-      return date.to_s if date.class == Date
+      return date.to_date.to_s if date.kind_of?(Date)
 
       raise TypeError, "Write certain date"
     end

data/lib/met_museum/version.rb

@@ -1,3 +1,3 @@
 module MetMuseum
-  VERSION = "1.3.4"
+  VERSION = "1.3.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: met_museum
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
 platform: ruby
 authors:
 - hyuraku
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-08 00:00:00.000000000 Z
+date: 2020-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -139,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: MET museum api wrapper