messagebus-sdk 5.0.3 → 5.0.4

data/lib/messagebus-sdk/actionmailer_client.rb

@@ -23,8 +23,8 @@ class MessagebusActionMailerClient < MessagebusApiClient
 
   def deliver!(message)
     #minimum required headers
-    if message.to.first.nil? ||message.subject.nil? || message.from.first.nil?  || message.return_path.nil? then
-      raise "Messagebus API error=Missing required header: :toEmail => #{message.to.first} :subject => #{message.subject} :fromEmail => #{message.from.first}"
+    if message.to.nil? ||  message.to.first.nil? || message.subject.nil? || message.from.first.nil?  || message.return_path.nil? then
+      raise "Messagebus API error=Missing required header: :toEmail => #{message.to} :subject => #{message.subject} :fromEmail => #{message.from.first}"
     end
 
     message_from_email = from_email_with_name(message.header[:from].to_s)
@@ -41,15 +41,15 @@ class MessagebusActionMailerClient < MessagebusApiClient
 
     custom_headers = {}
 
-    custom_headers["bcc"] = message.bcc[0] if !message.bcc.nil?
+    custom_headers["bcc"] = message.bcc[0] if !message.bcc.nil? && message.bcc.length != 0
 
     session_key = DEFAULT
     message.header.fields.each do |f|
       if f.name == HEADER_SESSION_KEY
-        session_key = f.value
+        session_key = f.value.to_s
       else
         if f.name =~ /x-.*/i
-          custom_headers[f.name] = f.value
+          custom_headers[f.name] = f.value.to_s
         end
       end
     end

data/lib/messagebus-sdk/messagebus_version.rb

@@ -13,7 +13,7 @@
 # under the License.
 
 module MessagebusSDK
-  VERSION = "5.0.3"
+  VERSION = "5.0.4"
 
   class Info
     @@ClientVersion = MessagebusSDK::VERSION

data/spec/messagebus-sdk/actionmailer_client_spec.rb

@@ -67,5 +67,20 @@ describe MessagebusActionMailerClient do
       message_params["customHeaders"]["x-tracking"].should == "1234"
       message_params["customHeaders"]["X-MESSAGEBUS-SESSIONKEY"].should be_nil
     end
+
+    it "ignores bcc is empty array" do
+      to_email = "hello@example.com"
+      session_key = "7215ee9c7d9dc229d2921a40e899ec4a"
+      bcc = []
+      message = MessageBusActionMailerTest.new_message(to_email, session_key, bcc)
+
+      FakeWeb.register_uri(:post, "#{API_URL}/message/email/send", :body => json_valid_send)
+      message.deliver
+
+      message_body = JSON.parse(FakeWeb.last_request.body)
+      message_params = message_body["messages"][0]
+      message_params["sessionKey"].should == session_key
+      message_params["customHeaders"]["bcc"].should be_nil
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: messagebus-sdk
 version: !ruby/object:Gem::Version
-  version: 5.0.3
+  version: 5.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-24 00:00:00.000000000 Z
+date: 2014-07-28 00:00:00.000000000 Z
 dependencies: []
 description: SDK for Message Bus service
 email: