message_bus 4.3.4 → 4.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 76a5b68eec4b7cfbe611e8b2a1fa0d60ac5d48dc33594419613ff07579cabe63
-  data.tar.gz: 9164fb39f5850d69ff83ce373ea398e9cd4086d9edc319c62c36f1bbdd1ffd99
+  metadata.gz: a4df966b88978a23a9caeb38eec64b374d66ce1e364c419d1ac04c722dba36a7
+  data.tar.gz: 7bb707ad44b5fb96d8682ed25993d535700a1f8617e3af70ead34c5514b842dc
 SHA512:
-  metadata.gz: 6d9b70b183065bc17178443c8e008b921d3952b3ad9b45c3d30b2b19c388e6b7d9311537d654c0523449926918c797d9a4a5156f1b5631976b605e48b8878444
-  data.tar.gz: 7ae3c8104dcfb41af4b58d4baad29371307cbbf13bb6de6e364cddb48b6a271b147a55c123068a74537789dff7ba414a4fa5b4e1953893a5af6b29188ba85906
+  metadata.gz: 600284061dbb261638b47f69535ddf937eaea43038bfce18495be6bcaa7550b9ce910bb32221ed8773e62a855b4adcc829131d9f74f0115d4777d25d451bf11f
+  data.tar.gz: 2ec82be8cf27b4eca3da26e7d122a9a7640d8294ffe2212a3f13c0995238276c3ef5519c03869bbb8ce584651d91620bcf464c56ca5017eaf239237a70deee2b

data/CHANGELOG

@@ -1,5 +1,16 @@
+28-06-2023
+
+- Version 4.3.6
+
+  - Don't error when trying to write a message to a closed client take 2
+
 20-06-2023
 
+- Version 4.3.5
+
+  - Revert "Make headers all lowercase in rack middleware (#328)".
+    This seems to have broken MessageBus in production so reverting for now.
+
 - Version 4.3.4
 
   - Revert "FIX: Don't error when trying to write a message to a closed client (#336)".

data/lib/message_bus/client.rb

@@ -278,7 +278,7 @@ class MessageBus::Client
       @async_response << data
       @async_response << postfix
       @async_response << NEWLINE
-    else
+    elsif @io
       @io.write(chunk_length.to_s(16) << NEWLINE << data << postfix << NEWLINE)
     end
   end

data/lib/message_bus/rack/middleware.rb

@@ -82,10 +82,10 @@ class MessageBus::Rack::Middleware
     return [404, {}, ["not found"]] unless client_id
 
     headers = {}
-    headers["cache-control"] = "must-revalidate, private, max-age=0"
-    headers["content-type"] = "application/json; charset=utf-8"
-    headers["pragma"] = "no-cache"
-    headers["expires"] = "0"
+    headers["Cache-Control"] = "must-revalidate, private, max-age=0"
+    headers["Content-Type"] = "application/json; charset=utf-8"
+    headers["Pragma"] = "no-cache"
+    headers["Expires"] = "0"
 
     if @bus.extra_response_headers_lookup
       @bus.extra_response_headers_lookup.call(env).each do |k, v|

data/lib/message_bus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MessageBus
-  VERSION = "4.3.4"
+  VERSION = "4.3.6"
 end

data/spec/lib/message_bus/client_spec.rb

@@ -99,6 +99,12 @@ describe MessageBus::Client do
       chunk2.length.must_equal 0
     end
 
+    it "does not raise an error when trying to write a message to a closed client using chunked encoding" do
+      @client.use_chunked = true
+      assert(@client.closed?)
+      @client << MessageBus::Message.new(1, 1, "/test", "test")
+    end
+
     it "does not bleed data across sites" do
       @client.site_id = "test"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: message_bus
 version: !ruby/object:Gem::Version
-  version: 4.3.4
+  version: 4.3.6
 platform: ruby
 authors:
 - Sam Saffron
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-20 00:00:00.000000000 Z
+date: 2023-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack