message_bus 3.3.2 → 3.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89229a2e20ef4e018c1e483fc24784fca853901f589fc25eabaca7cefa88d195
-  data.tar.gz: 36ec7e44a6223a60f4e51a937977ba74122e8ac36c8e5df9551beb5b0a3d679d
+  metadata.gz: 2df4ed426f8b349c63bd56de7f73f846a65cef0a689de7c3d5a017a7eabaf2ac
+  data.tar.gz: a1f05881617167d9b680c8a1ac192fdd02dea903e1ff4b5fa692fe26c4533633
 SHA512:
-  metadata.gz: f8847a0e7fd1f836000bda6ef017c498697489f84cf437732feab601b2a9c924aa981f4e96457360e36647568a00246e728459918a91afbda1e7b86e757f6520
-  data.tar.gz: 9217b0226498fca5fd7dc4159d72b5c86d0f588dff13cf1ddf8e3b8ce4d5f04fcb42f03cb4310233100603391f90ac6d1a8b1ee0a1cf4281ab2e1275799f7907
+  metadata.gz: a9feb43d0b0725bcc3190704f9f673bf3b7ce2e6d1c5c6e70212f21ebad241e082c0095ed08b1144d73cbef50f0585f858cc4cd1215e72e668eeb37df4d2f1bd
+  data.tar.gz: e69da95765f2017b005977486f4be3077055357b9ff17a70894a4a0d95c2e9fa02cd2b50dc14d301961d07eccb097733be378f2b05fb3edbd0c1b9a32376999c

data/.travis.yml

@@ -1,9 +1,9 @@
 before_install: gem install bundler
 language: ruby
 rvm:
-  - 2.4
   - 2.5
   - 2.6
+  - 2.7
 gemfile:
   - Gemfile
 addons:

data/CHANGELOG

@@ -1,5 +1,21 @@
 - Unrelease
 
+18-09-2020
+
+- Version 3.3.3
+
+  - FIX: `queue_in_memory` option not being passed to the backends.
+  - FIX: `MessageBus::DistributedCache#publish` should raise on error.
+
+    On the redis backend, any errors encountered during `MessageBus#publish`
+    will add the message into an in memory queue and silently swallow the
+    error. While this is behavior is OK for normal message_bus usage, it may
+    lead to inconsistency when using `DistributedCache`. If a process
+    doesn't publish successfully to another process, it will still update
+    its in memory cache leaving the other processes unaware. As such, the
+    distributed cache is out of sync and will require another successful
+    write to the cache to resync all the caches.
+
 15-09-2020
 
 - Version 3.3.2

data/lib/message_bus.rb

@@ -365,13 +365,17 @@ module MessageBus::Implementation
       client_ids: client_ids
     )
 
-    channel_opts = nil
+    channel_opts = {}
 
-    if opts && ((age = opts[:max_backlog_age]) || (size = opts[:max_backlog_size]))
-      channel_opts = {
-        max_backlog_size: size,
-        max_backlog_age: age
-      }
+    if opts
+      if ((age = opts[:max_backlog_age]) || (size = opts[:max_backlog_size]))
+        channel_opts[:max_backlog_size] = size,
+        channel_opts[:max_backlog_age] = age
+      end
+
+      if opts.has_key?(:queue_in_memory)
+        channel_opts[:queue_in_memory] = opts[:queue_in_memory]
+      end
     end
 
     encoded_channel_name = encode_channel_name(channel, site_id)

data/lib/message_bus/distributed_cache.rb

@@ -16,11 +16,12 @@ module MessageBus
 
       attr_accessor :app_version
 
-      def initialize(message_bus = nil)
+      def initialize(message_bus = nil, publish_queue_in_memory: true)
         @subscribers = []
         @subscribed = false
         @lock = Mutex.new
         @message_bus = message_bus || MessageBus
+        @publish_queue_in_memory = publish_queue_in_memory
       end
 
       def subscribers
@@ -76,12 +77,10 @@ module MessageBus
         message[:hash_key] = hash.key
         message[:app_version] = @app_version if @app_version
 
-        begin
-          @message_bus.publish(CHANNEL_NAME, message, user_ids: [-1])
-        rescue => e
-          @message_bus.logger.warn("DistributedCache failed to publish: #{e.message}\n#{e.backtrace.join("\n")}")
-          raise
-        end
+        @message_bus.publish(CHANNEL_NAME, message,
+          user_ids: [-1],
+          queue_in_memory: @publish_queue_in_memory
+        )
       end
 
       def set(hash, key, value)

data/lib/message_bus/timer_thread.rb

@@ -45,7 +45,14 @@ class MessageBus::TimerThread
     while running
       @mutex.synchronize do
         running = @thread && @thread.alive?
-        @thread.wakeup if running
+
+        if running
+          begin
+            @thread.wakeup
+          rescue ThreadError
+            raise if @thread.alive?
+          end
+        end
       end
       sleep 0
     end

data/lib/message_bus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MessageBus
-  VERSION = "3.3.2"
+  VERSION = "3.3.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: message_bus
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.3.3
 platform: ruby
 authors:
 - Sam Saffron
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-15 00:00:00.000000000 Z
+date: 2020-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack