mesh-medical-subject-headings 2.0.4 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1779cff991e94c43a9adf2429b4ec0c487c2d0b4
-  data.tar.gz: 4ef7e94c5f20c098648bcb1a1a8874e1c4905b8c
+  metadata.gz: 9536958aba4f9e6c5d022f6180f5f3af98fee4b4
+  data.tar.gz: 7d14f05245143439b2b0f28629ceb805afb83141
 SHA512:
-  metadata.gz: 0cf3b2a10bec165bf2652cd0d8ece4ab04900c8743c052ed9174e05526ccbb35cce6e68ac66e9703060e726aaa3c3e7aac77e360e80f57b5f3b235648f4efaaa
-  data.tar.gz: d8a2662c49f5235c8a0aa0165fe1188b2ab6a9a347f66b23dfd99f1cee40d7b1b91a2f6e3b48dc002d73e566db7ab9fc9fa7033956dcc78f2e6f316c187e87d5
+  metadata.gz: 08ca55381c6a598544df5ed90cc1187d4fd021d184ed40cca1c0953f0a8d06e6114debf6e6a47bfecc872d879d67ba3f6a4e428fc0c60b4ea34a8d9c9fee3a03
+  data.tar.gz: 0a1cd8123ef2680ac7dd6fb4b027ff0ba4fcd41bac2be3fbef161a8ace226d14196eaeee9ea73ccd9c9dcdca139a59ab4e2bb5b8cb5b4f18eedcfa05392a6ee9

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+#2.0.5 / 2014-06-25
+* [FEATURE] Improve performance of linkify_summaries further.
+
 #2.0.4 / 2014-06-25
 * [FEATURE] tree can now linkify_summaries for all headings. Performance optimisations to make this viable.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mesh-medical-subject-headings (2.0.4)
+    mesh-medical-subject-headings (2.0.5)
 
 GEM
   remote: https://rubygems.org/

data/lib/MESH/heading.rb

@@ -10,33 +10,27 @@ module MESH
     end
 
     def original_heading(locale = default_locale)
-      return @original_heading[locale]
+      @original_heading[locale]
     end
 
     def natural_language_name(locale = default_locale)
-      return @natural_language_name[locale]
+      @natural_language_name[locale]
     end
 
     def summary(locale = default_locale)
-      return @summary[locale]
+      @summary[locale]
     end
 
     def linkify_summary
       return if summary.nil?
-      @linkified_summary = summary.dup
-      @linkified_summary.scan(/[A-Z]+[A-Z,\s]+[A-Z]+/).each do |text|
+      @linkified_summary = summary.gsub(/[A-Z]+[A-Z,\s]+[A-Z]+/).each do |text|
         heading = @tree.find_by_entry(text)
-        if heading
-          replacement_text = yield text, heading
-          @linkified_summary.sub!(text, replacement_text)
-        end
+        heading ? yield(text, heading) : text
       end
-      @linkified_summary
     end
 
     def entries(locale = default_locale)
       @entries[locale] ||= []
-      return @entries[locale]
     end
 
 
@@ -88,7 +82,7 @@ module MESH
     end
 
     def to_s
-      return "#{unique_id}, #{original_heading}, [#{tree_numbers.join(',')}]"
+      "#{unique_id}, #{original_heading}, [#{tree_numbers.join(',')}]"
     end
 
     def inspect

data/lib/MESH/version.rb

@@ -1,3 +1,3 @@
 module Mesh
-  VERSION = "2.0.4"
-end
+  VERSION = "2.0.5"
+end

data/test/mesh_core_test.rb

@@ -144,7 +144,8 @@ module MESH
 
     def test_linkify_summary
       mh = @mesh_tree.find('D001471')
-      assert_equal 'A condition with damage to the lining of the lower ESOPHAGUS resulting from chronic acid reflux (ESOPHAGITIS, REFLUX). Through the process of metaplasia, the squamous cells are replaced by a columnar epithelium with cells resembling those of the INTESTINE or the salmon-pink mucosa of the STOMACH. Barrett\'s columnar epithelium is a marker for severe reflux and precursor to ADENOCARCINOMA of the esophagus.', mh.summary
+      original_summary = 'A condition with damage to the lining of the lower ESOPHAGUS resulting from chronic acid reflux (ESOPHAGITIS, REFLUX). Through the process of metaplasia, the squamous cells are replaced by a columnar epithelium with cells resembling those of the INTESTINE or the salmon-pink mucosa of the STOMACH. Barrett\'s columnar epithelium is a marker for severe reflux and precursor to ADENOCARCINOMA of the esophagus.'
+      assert_equal original_summary, mh.summary
 
       found = {
         'ESOPHAGUS' => false,
@@ -154,15 +155,15 @@ module MESH
         'ADENOCARCINOMA' => false
       }
 
-      # start = Time.now
+      #start = Time.now
       linkified_summary = mh.linkify_summary do |text, heading|
         found[text] = true unless heading.nil?
         "<foo>#{text.downcase}</foo>"
       end
-      # finish = Time.now
-      # puts start
-      # puts finish
-      # puts finish - start
+      #finish = Time.now
+      #puts start
+      #puts finish
+      #puts finish - start
 
       assert_equal 5, found.length
       assert found['ESOPHAGUS']
@@ -171,6 +172,7 @@ module MESH
       assert found['STOMACH']
       assert found['ADENOCARCINOMA']
 
+      assert_equal original_summary, mh.summary
       assert_equal 'A condition with damage to the lining of the lower <foo>esophagus</foo> resulting from chronic acid reflux (<foo>esophagitis, reflux</foo>). Through the process of metaplasia, the squamous cells are replaced by a columnar epithelium with cells resembling those of the <foo>intestine</foo> or the salmon-pink mucosa of the <foo>stomach</foo>. Barrett\'s columnar epithelium is a marker for severe reflux and precursor to <foo>adenocarcinoma</foo> of the esophagus.', linkified_summary
 
     end
@@ -738,4 +740,4 @@ ALL  there is no increased sensitivity to treatment, but there is increased risk
 '
     end
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mesh-medical-subject-headings
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 2.0.5
 platform: ruby
 authors:
 - Rob Styles