merit 0.3.3 → 0.4.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    merit (0.3.2)
+    merit (0.4.0)
       ambry
 
 GEM

data/README.markdown

@@ -40,8 +40,8 @@ holds. Badges may have levels, and may be temporary. Define rules on
 
 ## Examples
 
-    grant_on 'comments#vote', :badge => 'relevant-commenter', :to => :user do
-      { :votes => 5 }
+    grant_on 'comments#vote', :badge => 'relevant-commenter', :to => :user do |comment|
+      comment.votes.count == 5
     end
 
     grant_on ['users#create', 'users#update'], :badge => 'autobiographer', :temporary => true do |user|
@@ -74,21 +74,18 @@ method(s) defined in the <tt>:to</tt> option. Define rules on
 
 # Defining rank rules
 
-Rankings are very similar to badges. They give "badges" which have a hierarchy
-defined by <tt>level</tt>'s lexicografical order (greater is better). If a
-rank is granted, lower level ranks are taken off. 5 stars is a common ranking
-use case.
-
-They are not given at specified actions like badges, you should define a cron
-job to test if ranks are to be granted.
+5 stars is a common ranking use case. They are not given at specified actions
+like badges, you should define a cron job to test if ranks are to be granted.
 
 Define rules on <tt>app/models/merit_rank_rules.rb</tt>:
 
 <tt>set_rank</tt> accepts:
 
-* <tt>badge_name</tt> name of this ranking
 * <tt>:level</tt> ranking level (greater is better)
 * <tt>:to</tt> model or scope to check if new rankings apply
+* <tt>:level_name</tt> attribute name (default is empty and results in
+  '<tt>level</tt>' attribute, if set it's appended like
+  '<tt>level_#{level_name}</tt>')
 
 Check for rules on a rake task executed in background like:
 
@@ -99,11 +96,11 @@ Check for rules on a rake task executed in background like:
 
 ## Examples
 
-    set_rank :stars, :level => 2, :to => Commiter.active do |commiter|
+    set_rank :level => 2, :to => Commiter.active do |commiter|
       commiter.branches > 1 && commiter.followers >= 10
     end
 
-    set_rank :stars, :level => 3, :to => Commiter.active do |commiter|
+    set_rank :level => 3, :to => Commiter.active do |commiter|
       commiter.branches > 2 && commiter.followers >= 20
     end
 
@@ -111,7 +108,7 @@ Check for rules on a rake task executed in background like:
 
 # Grant manually
 
-You may also add badges/rank "by hand" from controller actions:
+You may also add badges "by hand" from controller actions:
 
     Badge.find(3).grant_to(current_user)
 
@@ -128,6 +125,12 @@ installation, and configuring <tt>config.orm = :mongo_mapper</tt> in
 
 # Notes on upgrades
 
+## to 0.4.0
+
+Rankings are now integer attributes on "meritable" models ("<tt>level</tt>"),
+they are not badges anymore. <tt>set_rank</tt> now doesn't accept
+<tt>badge_name</tt>.
+
 ## to 0.3.0
 
 Badges data is now stored in <tt>config/initializers/merit.rb</tt> using
@@ -142,7 +145,8 @@ Added <tt>had_errors</tt> boolean attribute to <tt>merit_actions</tt> table.
 
 # To-do list
 
-* Use ActiveSupport's Array#wrap where I build arrays by hand
+* rescue ActiveRecord::... should depend on ORM used (MongoMapper?)
+* Why 1.8.7 tests are not passing?
 * Ranking should not be badges, so .badges doesn't return them (2-stars
   shouldn't be badge).
 * :value parameter (for star voting for example) should be configurable

data/app/models/badge.rb

@@ -36,13 +36,4 @@ class Badge
     sash = object_or_sash.respond_to?(:sash) ? object_or_sash.sash : object_or_sash
     sash.rm_badge(id) if sash.badge_ids.include?(id)
   end
-
-  # Give rank to sash if it's greater. Delete lower ranks it may have.
-  def grant_rank_to(sash)
-    # Grant to sash if had lower rank. Do nothing if has same or greater rank.
-    if sash.has_lower_rank_than(self)
-      Badge.by_name(name).keys.each{|id| sash.rm_badge(id) } # Clean up old ranks
-      sash.add_badge(id)
-    end
-  end
 end

data/app/models/merit_action.rb

@@ -26,7 +26,7 @@ class MeritAction
           else
             begin
               target = target_object.send(to)
-            rescue
+            rescue ActiveRecord::RecordNotFound
               Rails.logger.warn "[merit] No target_object found on check_rules."
               return
             end

data/lib/generators/active_record/templates/add_fields_to_model.rb

@@ -2,6 +2,7 @@ class AddFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration
   def self.up
     add_column :<%= table_name %>, :sash_id, :integer
     add_column :<%= table_name %>, :points, :integer, :default => 0
+    add_column :<%= table_name %>, :level, :integer, :default => 0
     <%- resource = table_name.singularize -%>
     <%= resource.camelize %>.all.each{|<%= resource %>| <%= resource %>.update_attribute(:points, 0) } # Update existing entries
   end
@@ -9,5 +10,6 @@ class AddFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration
   def self.down
     remove_column :<%= table_name %>, :sash_id
     remove_column :<%= table_name %>, :points
+    remove_column :<%= table_name %>, :level
   end
 end

data/lib/generators/merit/templates/merit_badge_rules.rb

@@ -23,13 +23,13 @@ class MeritBadgeRules
     # grant_on 'users#create', :badge => 'just-registered', :to => :itself
 
     # If it has 10 comments, grant commenter-10 badge
-    # grant_on 'comments#create', :badge => 'commenter', :level => 10 do
-    #   { :user => { :comments => { :count => 10 } } }
+    # grant_on 'comments#create', :badge => 'commenter', :level => 10 do |comment|
+    #   comment.user.comments.count == 10
     # end
 
     # If it has 5 votes, grant relevant-commenter badge
-    # grant_on 'comments#vote', :badge => 'relevant-commenter', :to => :user do
-    #   { :votes => 5 }
+    # grant_on 'comments#vote', :badge => 'relevant-commenter', :to => :user do |comment|
+    #   comment.votes.count == 5
     # end
 
     # Changes his name by one wider than 4 chars (arbitrary ruby code case)

data/lib/generators/merit/templates/merit_rank_rules.rb

@@ -1,29 +1,26 @@
-# Rankings are very similar to badges. They give "badges" which have a hierarchy
-# defined by +level+'s lexicografical order (greater is better). If a rank is
-# granted, lower level ranks are taken off. 5 stars is a common ranking use
-# case.
-#
-# They are not given at specified actions like badges, you should define a cron
-# job to test if ranks are to be granted.
+# 5 stars is a common ranking use case. They are not given at specified
+# actions like badges, you should define a cron job to test if ranks are to be
+# granted.
 #
 # +set_rank+ accepts:
-# * +badge_name+ name of this ranking
 # * :+level+ ranking level (greater is better)
 # * :+to+ model or scope to check if new rankings apply
+# * :+level_name+ attribute name (default is empty and results in 'level'
+#   attribute, if set it's appended like 'level_#{level_name}')
 
 class MeritRankRules
   include Merit::RankRules
 
   def initialize
-    # set_rank :stars, :level => 1, :to => Commiter.active do |commiter|
+    # set_rank :level => 1, :to => Commiter.active do |commiter|
     #   commiter.repositories.count > 1 && commiter.followers >= 10
     # end
     #
-    # set_rank :stars, :level => 2, :to => Commiter.active do |commiter|
+    # set_rank :level => 2, :to => Commiter.active do |commiter|
     #   commiter.branches.count > 1 && commiter.followers >= 10
     # end
     #
-    # set_rank :stars, :level => 3, :to => Commiter.active do |commiter|
+    # set_rank :level => 3, :to => Commiter.active do |commiter|
     #   commiter.branches.count > 2 && commiter.followers >= 20
     # end
   end

data/lib/merit.rb

@@ -1,4 +1,3 @@
-require 'merit/core_extensions'
 require 'merit/rule'
 require 'merit/rules_badge'
 require 'merit/rules_points'
@@ -25,6 +24,7 @@ module Merit
       # Merit.orm now set
       if Merit.orm == :active_record
         require "merit/models/#{Merit.orm}/badges_sash"
+        require "merit/models/#{Merit.orm}/sash"
       end
 
       ActiveSupport.on_load(:action_controller) do

data/lib/merit/model_additions.rb

@@ -9,6 +9,7 @@ module Merit
         plugin Merit
         key :sash_id, String
         key :points, Integer, :default => 0
+        key :level, Integer, :default => 0
       end
     end
   end
@@ -27,5 +28,9 @@ module Merit
   end
 end
 
-ActiveRecord::Base.send :include, Merit if Object.const_defined?('ActiveRecord')
-MongoMapper::Document.plugin Merit if Object.const_defined?('MongoMapper')
+if Object.const_defined?('ActiveRecord')
+  ActiveRecord::Base.send :include, Merit
+end
+if Object.const_defined?('MongoMapper')
+  MongoMapper::Document.plugin Merit
+end

data/lib/merit/models/active_record/sash.rb

@@ -15,7 +15,7 @@ class Sash < ActiveRecord::Base
     badges_sash = badges_sashes.first
     badges_sashes.delete_all
     # delete doesn't run callbacks, do it by hand
-    if Object.const_defined?('BadgesSashObserver')
+    if Object.const_defined?('BadgesSashObserver') && badges_sash.present?
       BadgesSashObserver.instance.after_delete(badges_sash)
     end
   end

data/lib/merit/rule.rb

@@ -1,34 +1,25 @@
 module Merit
   # Rules has a badge name and level, a target to badge, a conditions block
   # and a temporary option.
+  # Could split this class between badges and rankings functionality
   class Rule
-    attr_accessor :badge_name, :level, :to, :temporary, :block, :model_name
+    attr_accessor :badge_name, :level, :to, :temporary, :block, :model_name, :level_name
 
     # Does this rule's condition block apply?
     def applies?(target_obj = nil)
-      # no block given: always true
-      no_block_or_true = true
-      unless block.nil?
-        case block.parameters.count
-        when 1
-          # block expects parameter: pass target_object
-          if target_obj.nil?
-            no_block_or_true = false
-            Rails.logger.warn "[merit] no target_obj found on Rule#applies?"
-          else
-            no_block_or_true = block.call(target_obj)
-          end
-
-        when 0
-          # block evaluates to true, or is a hash of methods and expected value
-          called = block.call
-          if called.kind_of?(Hash)
-            no_block_or_true = called.conditions_apply? target_obj
-          end
+      return true if block.nil? # no block given: always true
 
+      case block.parameters.count
+      when 1 # Expects target object
+        if target_obj.present?
+          return block.call(target_obj)
+        else
+          Rails.logger.warn "[merit] no target_obj found on Rule#applies?"
+          return false
         end
+      when 0 # evaluates to boolean
+        return block.call
       end
-      no_block_or_true
     end
 
     # Is this rule's badge temporary?
@@ -58,7 +49,7 @@ module Merit
                else
                  begin
                    action.target_object(model_name).send(to)
-                 rescue
+                 rescue ActiveRecord::RecordNotFound
                    Rails.logger.warn "[merit] #{action.target_model.singularize}.find(#{action.target_id}) not found, no badges giving today"
                    return
                  end

data/lib/merit/rules_badge.rb

@@ -3,8 +3,7 @@ module Merit
   # app/models/merit_rules.rb, con la siguiente sintaxis:
   #
   #   grant_on 'users#create', :badge => 'just', :level => 'registered' do
-  #     # Nothing, or code block which evaluates to true
-  #     # or with a { methods -> expected_values } hash.
+  #     # Nothing, or code block which evaluates to boolean
   #   end
   #
   # También se puede asignar medallas desde métodos en controladores:

data/lib/merit/rules_rank.rb

@@ -1,51 +1,45 @@
 module Merit
-  # Rankings are very similar to badges. They give "badges" which have a hierarchy
-  # defined by +level+'s lexicografical order (greater is better). If a rank is
-  # granted, lower level ranks are taken off. 5 stars is a common ranking use
-  # case.
-  #
-  # They are not given at specified actions like badges, you should define a cron
-  # job to test if ranks are to be granted.
+  # 5 stars is a common ranking use case. They are not given at specified
+  # actions like badges, you should define a cron job to test if ranks are to be
+  # granted.
   #
   # +set_rank+ accepts:
-  # * +badge_name+ name of this ranking
   # * :+level+ ranking level (greater is better)
   # * :+to+ model or scope to check if new rankings apply
+  # * :+level_name+ attribute name (default is empty and results in 'level'
+  #   attribute, if set it's appended like 'level_#{level_name}')
   module RankRules
     # Populates +defined_rules+ hash with following hierarchy:
-    #   defined_rules[ModelToRank][rankings] = [level, conditions_block]
-    def set_rank(ranking, *args, &block)
+    #   defined_rules[ModelToRank] = { levels => blocks }
+    def set_rank(*args, &block)
       options = args.extract_options!
 
       rule = Rule.new
-      rule.badge_name = ranking
-      rule.level      = options[:level]
-      rule.block      = block
+      rule.block = block
+      rule.level_name = options[:level_name].present? ? "level_#{options[:level_name]}" : 'level'
 
       defined_rules[options[:to]] ||= {}
-      defined_rules[options[:to]][ranking] ||= []
-      defined_rules[options[:to]][ranking] << rule
+      defined_rules[options[:to]].merge!({ options[:level] => rule })
     end
 
     # Check rules defined for a merit_action
     def check_rank_rules
-      defined_rules.each do |scoped_model, rankings| # For each model
-        rankings.each do |ranking, rules| # For each model's ranking (stars, etc)
-          rules.each do |rule|            # For each ranking's rule (level)
-            scoped_model.all.each{|obj| grant_rank(rule, obj) }
+      defined_rules.each do |scoped_model, level_and_rules|
+        level_and_rules = level_and_rules.sort
+        level_and_rules.each do |level, rule|
+          begin
+            scoped_model.where("#{rule.level_name} < #{level}").each do |obj|
+              if rule.applies?(obj)
+                obj.update_attribute rule.level_name, level
+              end
+            end
+          rescue ActiveRecord::StatementInvalid
+            Rails.logger.warn "[merit] Please add #{rule.level_name} column/attribute to #{scoped_model.new.class.name}"
           end
         end
       end
     end
 
-    # Grant rank if rule applies
-    # Badge checks if it's rank is greater than sash's current one.
-    def grant_rank(rule, target_object)
-      if rule.applies? target_object
-        rule.badge.grant_rank_to target_object.sash
-      end
-    end
-
     # Currently defined rules
     def defined_rules
       @defined_rules ||= {}

data/merit.gemspec

@@ -5,7 +5,7 @@ Gem::Specification.new do |s|
   s.summary     = "General reputation Rails engine."
   s.description = "General reputation Rails engine."
   s.files       = `git ls-files`.split("\n").reject{|f| f =~ /^\./ }
-  s.version     = "0.3.3"
+  s.version     = "0.4.0"
   s.authors     = ["Tute Costa"]
   s.email       = 'tutecosta@gmail.com'
   s.add_dependency 'ambry'

data/test/dummy/app/models/merit_badge_rules.rb

@@ -23,8 +23,8 @@ class MeritBadgeRules
     grant_on 'users#create', :badge => 'just-registered', :to => :itself
 
     # If it has 10 comments, grant commenter-10 badge
-    grant_on 'comments#create', :badge => 'commenter', :level => 10 do
-      { :user => { :comments => { :count => 10 } } }
+    grant_on 'comments#create', :badge => 'commenter', :level => 10 do |comment|
+      comment.user.comments.count == 10
     end
 
     # If it has at least 10 votes, grant relevant-commenter badge

data/test/dummy/app/models/merit_rank_rules.rb

@@ -1,15 +1,12 @@
-# Rankings are very similar to badges. They give "badges" which have a hierarchy
-# defined by +level+'s lexicografical order (greater is better). If a rank is
-# granted, lower level ranks are taken off. 5 stars is a common ranking use
-# case.
-#
-# They are not given at specified actions like badges, you should define a cron
-# job to test if ranks are to be granted.
+# 5 stars is a common ranking use case. They are not given at specified
+# actions like badges, you should define a cron job to test if ranks are to be
+# granted.
 #
 # +set_rank+ accepts:
-# * +badge_name+ name of this ranking
 # * :+level+ ranking level (greater is better)
 # * :+to+ model or scope to check if new rankings apply
+# * :+level_name+ attribute name (default is empty and results in 'level'
+#   attribute, if set it's appended like 'level_#{level_name}')
 
 class MeritRankRules
   include Merit::RankRules
@@ -17,7 +14,7 @@ class MeritRankRules
   def initialize
     # i stars for i chars name
     (1..5).each do |i|
-      set_rank :stars, :level => i, :to => User do |user|
+      set_rank :level => i, :to => User do |user|
         user.name.length == i
       end
     end

data/test/dummy/db/migrate/20120318022220_add_fields_to_users.rb

@@ -2,11 +2,13 @@ class AddFieldsToUsers < ActiveRecord::Migration
   def self.up
     add_column :users, :sash_id, :integer
     add_column :users, :points, :integer, :default => 0
+    add_column :users, :level, :integer, :default => 0
     User.all.each{|user| user.update_attribute(:points, 0) } # Update existing entries
   end
 
   def self.down
     remove_column :users, :sash_id
     remove_column :users, :points
+    remove_column :users, :level
   end
 end

data/test/integration/navigation_test.rb

@@ -95,7 +95,7 @@ class NavigationTest < ActiveSupport::IntegrationCase
     assert_equal 45, user.points, 'Voting comments should grant 5 points'
   end
 
-  test 'user workflow should grant stars at some times' do
+  test 'user workflow should grant levels at some times' do
     user = User.first
     assert user.badges.empty?
 
@@ -105,9 +105,10 @@ class NavigationTest < ActiveSupport::IntegrationCase
     click_button('Update User')
 
     user = User.where(:name => 'ab').first
-    stars2 = Badge.by_name(:stars).by_level(2).first
+    assert_equal 0, user.level, "User level should be 0."
     MeritRankRules.new.check_rank_rules
-    assert_equal user.badges.to_a, [stars2], "User badges: #{user.badges.collect(&:name).inspect} should contain only 2-stars badge."
+    user.reload
+    assert_equal 2, user.level, "User level should be 2."
 
     # Edit user's name by short name. Doesn't go back to previous rank.
     visit "/users/#{user.id}/edit"
@@ -116,7 +117,8 @@ class NavigationTest < ActiveSupport::IntegrationCase
 
     user = User.where(:name => 'a').first
     MeritRankRules.new.check_rank_rules
-    assert_equal user.badges.to_a, [stars2], "User badges: #{user.badges.collect(&:name).inspect} should contain only 2-stars badge."
+    user.reload
+    assert_equal 2, user.level, "User level should be 2."
 
     # Edit user's name by 5 chars name
     visit "/users/#{user.id}/edit"
@@ -124,10 +126,8 @@ class NavigationTest < ActiveSupport::IntegrationCase
     click_button('Update User')
 
     user = User.where(:name => 'abcde').first
-    stars5 = Badge.by_name(:stars).by_level(5).first
-    assert_equal Badge.find_by_id(user.sash.badge_ids).by_name(:stars).count, 1, "Should not contain more than 2 stars ranking."
     MeritRankRules.new.check_rank_rules
     user.reload
-    assert user.badges.to_a.include?(stars5), "User badges: #{user.badges.collect(&:inspect)} should contain 5-stars badge."
+    assert_equal 5, user.level, "User level should be 5."
   end
 end

data/test/merit_unit_test.rb

@@ -1,13 +1,6 @@
 require 'test_helper'
 
 class MeritUnitTest < ActiveSupport::TestCase
-  test "Hash#conditions_apply? tests if object responds what's expected" do
-    hash = { :first => { :odd? => true }, :count => 2 }
-    assert hash.conditions_apply? [1,3]
-    assert not(hash.conditions_apply? [1,2,3])
-    assert not(hash.conditions_apply? [2,3])
-  end
-
   test "Rule applies?" do
     rule = Merit::Rule.new
     assert rule.applies?, 'empty conditions should make rule apply'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: merit
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-01 00:00:00.000000000 Z
+date: 2012-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ambry
-  requirement: &70294954461660 !ruby/object:Gem::Requirement
+  requirement: &70321858339760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70294954461660
+  version_requirements: *70321858339760
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70294954459920 !ruby/object:Gem::Requirement
+  requirement: &70321858339140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70294954459920
+  version_requirements: *70321858339140
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70294954482520 !ruby/object:Gem::Requirement
+  requirement: &70321858337900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70294954482520
+  version_requirements: *70321858337900
 - !ruby/object:Gem::Dependency
   name: haml
-  requirement: &70294954481580 !ruby/object:Gem::Requirement
+  requirement: &70321858336840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70294954481580
+  version_requirements: *70321858336840
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &70294954480960 !ruby/object:Gem::Requirement
+  requirement: &70321858330240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70294954480960
+  version_requirements: *70321858330240
 description: General reputation Rails engine.
 email: tutecosta@gmail.com
 executables: []
@@ -79,7 +79,6 @@ files:
 - Rakefile
 - app/models/badge.rb
 - app/models/merit_action.rb
-- app/models/sash.rb
 - lib/generators/active_record/merit_generator.rb
 - lib/generators/active_record/templates/add_fields_to_model.rb
 - lib/generators/active_record/templates/create_badges_sashes.rb
@@ -93,7 +92,6 @@ files:
 - lib/generators/merit/templates/merit_rank_rules.rb
 - lib/merit.rb
 - lib/merit/controller_extensions.rb
-- lib/merit/core_extensions.rb
 - lib/merit/model_additions.rb
 - lib/merit/models/active_record/badges_sash.rb
 - lib/merit/models/active_record/merit_action.rb

data/app/models/sash.rb

@@ -1,10 +0,0 @@
-require "merit/models/#{Merit.orm}/sash"
-
-class Sash
-  # Decides if sash has lower rank than a given badge
-  def has_lower_rank_than(badge)
-    badges = Badge.find_by_id(badge_ids)
-    levels = badges.by_name(badge.name).collect(&:level)
-    levels.all_lower_than badge.level
-  end
-end

data/lib/merit/core_extensions.rb

@@ -1,28 +0,0 @@
-# Hash core extensions:
-#   * conditions_apply?(obj)
-class Hash
-  # Methods over object (applied recursively) respond what's expected?
-  # Example (evaluates to true):
-  #   { :first => { :odd? => true }, :count => 2 }.conditions_apply? [1,3]
-  def conditions_apply?(obj)
-    applies = true
-    self.each do |method, value|
-      called_obj = obj.send(method)
-      if value.kind_of?(Hash)
-        applies = applies && value.conditions_apply?(called_obj)
-      else
-        applies = applies && called_obj == value
-      end
-    end
-    applies
-  end
-end
-
-# Array core extensions:
-#   * all_lower_than(value)
-class Array
-  # All array values are lower than parameter
-  def all_lower_than(value)
-    self.select{|elem| elem >= value }.empty?
-  end
-end