menu_builder 0.4.4 → 0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9892ebf03c1453e32f80de3f3bbbdd9da851a657
-  data.tar.gz: d0ffd34b7f563921e9af1e25605f0b5b93eb7a95
+SHA256:
+  metadata.gz: bd40fb9093c6a9304773af1f8d1df754a9b1b6f73892e2a32fea0b0eff1ce2e8
+  data.tar.gz: f2338b661e62a06aa7bbc00e6ca95267ac2be218678795a113fd93f7454bd77e
 SHA512:
-  metadata.gz: 62dfbba5498cb7e7ae3c9013cb4f534d33615f85e0780cb9033bb57a4f8980d505d59dff52f8276c8c168c527351637bf9922655dfca7af10b43b8d54bfda9dd
-  data.tar.gz: 786bf942fe3ec80d7b64da0397594184d597d49671fc58c2bc3503fb9fe1e3e1955ad6b3925338bf3af9d4af4da5d5fcc20a6dc26e16714f58fa89d6e0655d43
+  metadata.gz: 6286c8604678a2f7d6e0b9a540663bbe0677a1c77ae7512f719570676fc38c5fd370f1f40b0f70c73800c3f0ac2a9e64e3e2402743ab62d3c5a2c09155fe6a6d
+  data.tar.gz: 077b99f82df070266dea96fdae091e4f7d916531b45c2f7c5cbe59f97d123214e49ed737ae8bcd62d6fc6863327cc1a084eb137dfbc527585ad28210262b435e

data/.gitignore

@@ -20,3 +20,4 @@ pkg
 
 ## PROJECT::SPECIFIC
 .rvmrc
+.tool-versions

data/.rubocop.yml

@@ -0,0 +1,137 @@
+require:
+  - rubocop-rails
+
+AllCops:
+  Exclude:
+    - db/schema.rb
+    - db/**
+  TargetRubyVersion: 3.0
+  NewCops: enable
+
+Rails:
+  Enabled: true
+
+Rails/Validation:
+  Enabled: false
+
+Rails/Delegate:
+  Enabled: false
+
+Rails/DynamicFindBy:
+  Whitelist:
+    - find_by_expiring_token
+    - find_by_alias
+    - find_by_unicode
+
+Rails/UnknownEnv:
+  Environments:
+    - production
+    - development
+    - test
+    - staging
+
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
+Rails/InverseOf:
+  Enabled: false
+
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/Alias:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/NegatedIf:
+  Enabled: false
+
+Style/SymbolProc:
+  Enabled: false
+
+Style/Semicolon:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Enabled: false
+
+Naming/AccessorMethodName:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/FormatString:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: never
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Max: 15
+
+Layout/LineLength:
+  Exclude:
+    - config/routes.rb
+    - config/routes/marketing.rb
+  Max: 120
+
+Layout/DotPosition:
+  EnforcedStyle: trailing
+  Enabled: true
+
+Naming/PredicateName:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/LambdaCall:
+  Enabled: false
+
+Style/Lambda:
+  Enabled: false
+
+Style/NumericLiterals:
+  Enabled: false
+
+Style/SingleLineMethods:
+  Enabled: false
+
+Metrics/MethodLength:
+  Max: 50
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Bundler/OrderedGems:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Style/EmptyMethod:
+  Enabled: false

data/Gemfile.lock

@@ -0,0 +1,69 @@
+PATH
+  remote: .
+  specs:
+    menu_builder (1.0.0)
+      actionpack (> 6.0)
+      activemodel (> 6.0)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    actionpack (7.0.2.3)
+      actionview (= 7.0.2.3)
+      activesupport (= 7.0.2.3)
+      rack (~> 2.0, >= 2.2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actionview (7.0.2.3)
+      activesupport (= 7.0.2.3)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activemodel (7.0.2.3)
+      activesupport (= 7.0.2.3)
+    activesupport (7.0.2.3)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    builder (3.2.4)
+    concurrent-ruby (1.1.10)
+    crass (1.0.6)
+    erubi (1.10.0)
+    i18n (1.10.0)
+      concurrent-ruby (~> 1.0)
+    loofah (2.16.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    minitest (5.15.0)
+    nokogiri (1.13.4-x86_64-darwin)
+      racc (~> 1.4)
+    racc (1.6.0)
+    rack (2.2.3)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails-controller-testing (1.0.5)
+      actionpack (>= 5.0.1.rc1)
+      actionview (>= 5.0.1.rc1)
+      activesupport (>= 5.0.1.rc1)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.4.2)
+      loofah (~> 2.3)
+    rake (13.0.6)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+
+PLATFORMS
+  x86_64-darwin-21
+
+DEPENDENCIES
+  menu_builder!
+  rails-controller-testing
+  rake
+
+BUNDLED WITH
+   2.2.32

data/README.rdoc

@@ -1,8 +1,6 @@
 = menu_builder
 
-A simple helper to make easier the process of highlighting menu items based on current
-url. The goal here is to reduce the amount of if/elses you would typically need in your
-views to achieve the same results.
+A simple helper + controller macro to make easier to highligh menu items based on actions (instead of urls)
 
 == Instalation
 
@@ -10,8 +8,6 @@ views to achieve the same results.
 
 == Usage
 
-First flag at class level in your Controller which item should be highlighted
-
 === Controller
 
   class DashboardController < ApplicationController
@@ -19,9 +15,7 @@ First flag at class level in your Controller which item should be highlighted
     ...
   end
 
-You can also change to menu item at action level instead of class level. This
-option is helpful when you have most of the actions pointing to one menu item
-but a few actions pointing to another.
+You can also change to menu item at action level instead of class level.
 
   class DashboardController < ApplicationController
     menu_item :mydashboard
@@ -32,6 +26,17 @@ but a few actions pointing to another.
     end
   end
 
+And you can prepend or append just one item to the collection
+
+  class DashboardController < ApplicationController
+    menu_item :mydashboard
+
+    def prices
+      append_menu_item :prices
+      ...
+    end
+  end
+
 === View
 
 ==== ERB code

data/lib/menu_builder/controller.rb

@@ -3,21 +3,29 @@ module MenuBuilder
     extend ActiveSupport::Concern
 
     def menu_items(*items)
-      instance_variable_set('@menu_items', items)
+      @menu_items = items
     end
     alias_method :menu_item, :menu_items
 
+    def append_menu_items(*items)
+      @menu_items += items
+    end
+    alias_method :append_menu_item, :append_menu_items
+
+    def prepend_menu_items(*items)
+      @menu_items = items + @menu_items
+    end
+    alias_method :prepend_menu_item, :prepend_menu_items
+
     module ClassMethods
       def menu_items(*items)
         options = items.extract_options!
 
         before_action(options) do |controller|
-          controller.instance_variable_set('@menu_items', items)
+          controller.instance_variable_set("@menu_items", items)
         end
       end
       alias_method :menu_item, :menu_items
-
     end
-
   end
 end

data/lib/menu_builder/version.rb

@@ -1,3 +1,3 @@
 module MenuBuilder
-  VERSION = "0.4.4"
+  VERSION = "0.5".freeze
 end

data/menu_builder.gemspec

@@ -1,5 +1,4 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
+$LOAD_PATH.push File.expand_path("../lib", __FILE__)
 require "menu_builder/version"
 
 Gem::Specification.new do |s|
@@ -8,9 +7,8 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Daniel Lopes"]
   s.email       = ["danielvlopes@gmail.com"]
-  s.homepage    = "http://objetiva.co/"
-  s.summary     = %q{minimalist solution for menus and tabs in Rails}
-  s.description = %q{helper and controller macros to define current menu item and also create the menu in view.}
+  s.summary     = "minimalist solution for menus and tabs in Rails"
+  s.description = "helper and controller macros to define current menu item and also create the menu in view."
 
   s.rubyforge_project = "menu_builder"
 
@@ -18,6 +16,8 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
-  s.add_dependency 'actionpack', '>3.0'
-  s.add_dependency 'activemodel', '>3.0'
+  s.add_dependency "actionpack", ">6.0"
+  s.add_dependency "activemodel", ">6.0"
+  s.add_development_dependency "rails-controller-testing"
+  s.add_development_dependency "rake"
 end

data/test/controller_test.rb

@@ -1,25 +1,5 @@
 require "test_helper"
-
-class ActiveSupport::TestCase
-  setup do
-    @routes = MenuBuilder::Routes
-  end
-end
-
-class BooksController < ApplicationController
-  menu_item :books
-  def index ; end
-end
-
-class SettingsController < ApplicationController
-  menu_items :settings, :home
-
-  def index ; end
-
-  def notifications
-    menu_item :notification
-  end
-end
+require_relative "./support/controllers"
 
 class BooksControllerTest < ActionController::TestCase
   test "assigns the current tab" do
@@ -29,13 +9,25 @@ class BooksControllerTest < ActionController::TestCase
 end
 
 class SettingsControllerTest < ActionController::TestCase
-  test "ability to assign more than one current tab" do
+  test "can assign more than one current tab" do
     get :index
-    assert_equal([:settings, :home], assigns(:menu_items))
+    assert_equal(%i[settings home], assigns(:menu_items))
   end
 
-  test "that instance level menu_items override class level" do
+  test "can set action level menu_items" do
     get :notifications
     assert_equal([:notification], assigns(:menu_items))
   end
-end
+end
+
+class AuthorsControllerTest < ActionController::TestCase
+  test "ability to append items" do
+    get :profile
+    assert_equal(%i[authors author_1 profile], assigns(:menu_items))
+  end
+
+  test "that instance level menu_items override class level" do
+    get :related
+    assert_equal(%i[related authors author_1], assigns(:menu_items))
+  end
+end

data/test/helper_test.rb

@@ -40,7 +40,7 @@ class HelperTest < ActionView::TestCase
 
     assert_select "li.current", 1
   end
-  
+
   test "customize the current item class" do
     @menu_items = [:home]
     concat(menu({:current_class => "active"}) { |m|
@@ -63,7 +63,7 @@ class HelperTest < ActionView::TestCase
 
     assert_select "li.current", 2
   end
-  
+
   test "accept more than one menu item for a custom current item class" do
     @menu_items = [:settings, :notifications]
 
@@ -76,8 +76,8 @@ class HelperTest < ActionView::TestCase
     assert_select "li.current", 0
     assert_select "li.active", 2
   end
-  
-  
+
+
   test "accept more than one menu" do
     @menu_items = [:settings, :notifications]
 
@@ -120,5 +120,5 @@ class HelperTest < ActionView::TestCase
 
     assert_select "ul > li > a > img"
   end
-  
+
 end

data/test/support/controllers.rb

@@ -1,6 +1,59 @@
-class ApplicationController < ActionController::Base
-  protected
-  def default_render
-    render :text => action_name
+MenuBuilder::Routes = ActionDispatch::Routing::RouteSet.new
+MenuBuilder::Routes.draw do
+  get "books" => "books#index"
+
+  get "author/profile" => "authors#profile"
+  get "author/related" => "authors#related"
+
+  get "settings" => "settings#index"
+  get "settings/notifications" => "settings#notifications"
+end
+
+class ApplicationController < ActionController::Base; end
+ActionController::Base.send :include, MenuBuilder::Routes.url_helpers
+
+class ActiveSupport::TestCase
+  setup do
+    @routes = MenuBuilder::Routes
+  end
+end
+
+class BooksController < ApplicationController
+  menu_item :books
+  def index
+    head :ok
+  end
+end
+
+class SettingsController < ApplicationController
+  menu_items :settings, :home
+
+  def index
+    head :ok
+  end
+
+  def notifications
+    menu_item :notification
+    head :ok
+  end
+end
+
+class AuthorsController < ApplicationController
+  before_action :set_base_items
+
+  def profile
+    append_menu_item :profile
+    head :ok
+  end
+
+  def related
+    prepend_menu_item :related
+    head :ok
+  end
+
+  private
+
+  def set_base_items
+    menu_item :authors, :author_1
   end
 end

data/test/test_helper.rb

@@ -1,21 +1,28 @@
-require 'rubygems'
-require 'test/unit'
+require "rubygems"
 
-require 'action_controller'
-require 'action_view'
-require 'action_view/template'
-require 'active_support'
-require 'rails/railtie'
+require "active_support/testing/autorun"
+require "abstract_controller"
+require "abstract_controller/railties/routes_helpers"
+require "action_controller"
+require "action_view"
+require "action_view/testing/resolvers"
+require "action_dispatch"
+require "active_support/dependencies"
+require "rails-controller-testing"
 
-$:.unshift File.expand_path(File.dirname(__FILE__) + '/../lib')
-require 'menu_builder'
+module Rails
+  class << self
+    def env
+      @_env ||= ActiveSupport::StringInquirer.new(ENV["RAILS_ENV"] || ENV["RACK_ENV"] || "test")
+    end
 
-Dir["#{File.dirname(__FILE__)}/support/*.rb"].each { |f| require f }
-
-MenuBuilder::Routes = ActionDispatch::Routing::RouteSet.new
-MenuBuilder::Routes.draw do
-  match ':controller(/:action(/:id(.:format)))'
+    def root; end
+  end
 end
 
-class ApplicationController < ActionController::Base; end
-ActionController::Base.send :include, MenuBuilder::Routes.url_helpers
+Rails::Controller::Testing.install
+
+$LOAD_PATH.unshift File.expand_path("#{File.dirname(__FILE__)}/../lib")
+require "menu_builder"
+
+Dir["#{File.dirname(__FILE__)}/support/*.rb"].each { |f| require f }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: menu_builder
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: '0.5'
 platform: ruby
 authors:
 - Daniel Lopes
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-15 00:00:00.000000000 Z
+date: 2022-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -16,28 +16,56 @@ dependencies:
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '6.0'
+- !ruby/object:Gem::Dependency
+  name: rails-controller-testing
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: helper and controller macros to define current menu item and also create
   the menu in view.
 email:
@@ -48,7 +76,9 @@ extra_rdoc_files: []
 files:
 - ".document"
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.rdoc
 - Rakefile
@@ -62,10 +92,10 @@ files:
 - test/helper_test.rb
 - test/support/controllers.rb
 - test/test_helper.rb
-homepage: http://objetiva.co/
+homepage:
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -80,9 +110,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: menu_builder
-rubygems_version: 2.6.12
-signing_key: 
+rubygems_version: 3.2.32
+signing_key:
 specification_version: 4
 summary: minimalist solution for menus and tabs in Rails
 test_files: