memonic 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 00f453f84636c12710e40937eb247d502fa5fc29
-  data.tar.gz: d5b6864989b1496753b02832360238144cb3a014
+  metadata.gz: 0fc00b69e78cf989af051b858a3c4089ecf7cc74
+  data.tar.gz: 1a485d6ea4594d13607dc2fec5782845faf09bb0
 SHA512:
-  metadata.gz: ae5580d59462a61d65e2143fe7b7e1c38c2289c93febf54eb906b0eb7ae45c5bfc7ce16c3873be64ee8b42aa4c4545edb99d09167cba93500682603e48519d5e
-  data.tar.gz: 05e101e9d9c3d31722ab298bc59c86f5d6187ca263374081992cd690d9882eeff3efdbbe75277ca927cebdd130bd685f3828e4495fa91a1ad206677d053f2076
+  metadata.gz: d18ad8bb33991680d7d7a69975387c321708073994eed5dd8a774a09e9c2e083f61c09287e843048204924f4d80ce8a5694d934357aeb4fb787bb64a100fabdd
+  data.tar.gz: bb4d536f13bfa0b0e9d287693ccd1e74675b0858db3e27fb698db4f0be266a3e255a55826cec9b42e071a2f499aecdc2df411e8a6b490bfc5af267bf4562e528

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+## 1.0.3
+
+- More performance improvements (details below).
+- Calling `memoize(:value) { ... }` now defines a `__value___` method as well
+  as a `value` method.
+
+### Performance improvements
+
+1. The instance version of `memoize` now only checks with the variable is
+   defined if `instance_variable_get` returns a false value. This yields a
+   modest improvement in performance.
+2. The class version of `memoize` no longer piggy-backs on the instance
+   version. Instead it defines a `__value__` method using the provided block,
+   then defines a `value` method using `class_eval`. This yields a dramatic
+   improvement in performance, making the class version almost as fast as
+   doing it yourself.
+
 ## 1.0.2
 
 Performance improvement.

data/README.md

@@ -44,6 +44,11 @@ you would want to use it, but if you do, here's how:
 
 Note that the '@' prefix **is** necessary.
 
+## Notes
+
+Calling `memoize(:value) { ... }` on the class defines a `__value__` method
+as well as `value`.
+
 ## Background
 
 Memoization is a common optimization technique in which the result of a

data/lib/memonic.rb

@@ -8,17 +8,29 @@ module Memonic
   private
 
   def memoize(variable, &block)
-    if instance_variable_defined?(variable)
-      instance_variable_get(variable)
-    else
-      instance_variable_set(variable, instance_exec(&block))
+    instance_variable_get(variable) || begin
+      if instance_variable_defined?(variable)
+        instance_variable_get(variable)
+      else
+        instance_variable_set(variable, instance_exec(&block))
+      end
     end
   end
 
   module ClassMethods
     def memoize(name, &block)
-      variable = "@#{name}".to_sym
-      define_method(name) { memoize(variable, &block) }
+      define_method("__#{name}__", &block)
+      class_eval <<-RUBY
+        def #{name}
+          @#{name} || begin
+            if defined?(@#{name})
+              @#{name}
+            else
+              @#{name} = __#{name}__
+            end
+          end
+        end
+      RUBY
     end
   end
 end

data/lib/memonic/version.rb

@@ -1,3 +1,3 @@
 module Memonic
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/memonic_spec.rb

@@ -7,7 +7,12 @@ describe Memonic do
       allow(memoizer).to receive(:computation).and_call_original
     end
 
-    it "returns the computation result" do
+    it "returns the computation result on the first call" do
+      expect(memoizer.value).to be result
+    end
+
+    it "returns the same result on subsequent calls" do
+      memoizer.value
       expect(memoizer.value).to be result
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: memonic
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - John Carney
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-16 00:00:00.000000000 Z
+date: 2015-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler