memo_tomato 0.0.1 → 0.0.2

data/.gitignore

@@ -1,4 +1,5 @@
 *.gem
 .bundle
+.redcar
 Gemfile.lock
 pkg/*

data/.rspec

@@ -0,0 +1 @@
+--color

data/lib/memo_tomato/parser/base.rb

@@ -9,7 +9,7 @@ module MemoTomato
         parse_content @content
       end
 
-      def parse_movie(movie)
+      def parse_entry(movie)
         MemoTomato::Movie.new(
           :id => movie.id,
           :title => movie.title,
@@ -20,28 +20,24 @@ module MemoTomato
           :synopsis => movie.synopsis,
           :image => movie.posters.detailed,
           :studio => movie.studio,
-          :cast => 
-            movie.abridged_cast.collect do |actor|
+          :cast =>
+            Array(movie.abridged_cast).collect do |actor|
               MemoTomato::Actor.new(
                 :name => actor.name,
                 :characters => actor.characters
               )
             end,
-          :directors => 
-            unless movie.abridged_directors == nil
-              movie.abridged_directors.collect do |director|
-                MemoTomato::Director.new(
-                  :name => director.name
-                )
-              end
+          :directors =>
+            Array(movie.abridged_directors).collect do |director|
+              MemoTomato::Director.new(
+                :name => director.name
+              )
             end,
-          :genres => 
-            unless movie.genres == nil
-              movie.genres.collect do |genre|
-                MemoTomato::Genre.new(
-                  :type => genre
-                )
-              end
+          :genres =>
+            Array(movie.genres).collect do |genre|
+              MemoTomato::Genre.new(
+                :type => genre
+              )
             end
         )
       end

data/lib/memo_tomato/parser/movie_info.rb

@@ -5,7 +5,7 @@ module MemoTomato
         parsed_response = MultiJson.decode(content.body)
         parsed_response = Hashie::Mash.new(parsed_response)
         
-        parse_movie(parsed_response)
+        parse_entry(parsed_response)
       end
 
     end

data/lib/memo_tomato/parser/search_movie.rb

@@ -7,7 +7,7 @@ module MemoTomato
         
         # In our case we want the first 30 movies
         parsed_response.movies.collect do |movie|
-          parse_movie(movie)
+          parse_entry(movie)
         end
       end
     end

data/lib/memo_tomato/parser/similar_movies.rb

@@ -6,7 +6,7 @@ module MemoTomato
         parsed_response = Hashie::Mash.new(parsed_response)
         
         parsed_response.movies.collect do |movie|
-          parse_movie(movie)
+          parse_entry(movie)
         end
       end
     end

data/lib/memo_tomato/parser/upcoming_movies.rb

@@ -6,7 +6,7 @@ module MemoTomato
         parsed_response = Hashie::Mash.new(parsed_response)
         
         parsed_response.movies.collect do |movie|
-          parse_movie(movie)
+          parse_entry(movie)
         end
       end
     end

data/lib/memo_tomato/version.rb

@@ -1,3 +1,3 @@
 module MemoTomato
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/memo_tomato/parser/movie_info_spec.rb

@@ -1,14 +1,22 @@
 require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+require 'pry'
 
 describe MemoTomato::Parser::MovieInfo do
   let(:client) { MemoTomato::Client.new(:apikey => "abcd1234") }
   
   it 'should be awesome' do
     mock_api :get, 'movies/770672122' , 'movies/770672122', :params => client.params do
-      m = client.movie_info("770672122")
-      m.id.should == 770672122
-      m.directors.first.name.should == "Lee Unkrich"
-      m.genres.first.type.should == "Animation"
+      movie = client.movie_info("770672122")
+      movie.id.should == 770672122
+      movie.directors.first.name.should == "Lee Unkrich"
+      movie.genres.first.type.should == "Animation"
+    end
+  end
+  
+  it 'should handle missing attributes like director' do
+    mock_api :get, 'movies/770885199' , 'movies/770885199', :params => client.params do
+      movie = client.movie_info("770885199")
+      movie.directors.should == []
     end
   end
 end

data/spec/mock_json/movies/770885199.json

@@ -0,0 +1,40 @@
+{
+    "id": 770885199,
+    "title": "Monty Python Meets Beyond the Fringe",
+    "year": "",
+    "genres": [
+        "Comedy"
+    ],
+    "mpaa_rating": "Unrated",
+    "runtime": 85,
+    "release_dates": {},
+    "ratings": {
+        "critics_score": -1,
+        "audience_score": 100
+    },
+    "synopsis": "",
+    "posters": {
+        "thumbnail": "http://images.rottentomatoescdn.com/images/redesign/poster_default.gif",
+        "profile": "http://images.rottentomatoescdn.com/images/redesign/poster_default.gif",
+        "detailed": "http://images.rottentomatoescdn.com/images/redesign/poster_default.gif",
+        "original": "http://images.rottentomatoescdn.com/images/redesign/poster_default.gif"
+    },
+    "abridged_cast": [
+        {
+            "name": "Monty Python Cast",
+            "id": "770882204"
+        },
+        {
+            "name": "Beyond The Fringe Cast",
+            "id": "770882205"
+        }
+    ],
+    "links": {
+        "self": "http://api.rottentomatoes.com/api/public/v1.0/movies/770885199.json",
+        "alternate": "http://www.rottentomatoes.com/m/monty_python_meets_beyond_the_fringe/",
+        "cast": "http://api.rottentomatoes.com/api/public/v1.0/movies/770885199/cast.json",
+        "clips": "http://api.rottentomatoes.com/api/public/v1.0/movies/770885199/clips.json",
+        "reviews": "http://api.rottentomatoes.com/api/public/v1.0/movies/770885199/reviews.json",
+        "similar": "http://api.rottentomatoes.com/api/public/v1.0/movies/770885199/similar.json"
+    }
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: memo_tomato
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,12 +10,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-08 00:00:00.000000000 +02:00
+date: 2012-03-14 00:00:00.000000000 +02:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &83055000 !ruby/object:Gem::Requirement
+  requirement: &10456680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -23,10 +23,10 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *83055000
+  version_requirements: *10456680
 - !ruby/object:Gem::Dependency
   name: httpclient
-  requirement: &83054750 !ruby/object:Gem::Requirement
+  requirement: &10506980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -34,10 +34,10 @@ dependencies:
         version: 2.2.0.2
   type: :runtime
   prerelease: false
-  version_requirements: *83054750
+  version_requirements: *10506980
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &83054520 !ruby/object:Gem::Requirement
+  requirement: &10506520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -45,10 +45,10 @@ dependencies:
         version: 1.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *83054520
+  version_requirements: *10506520
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &83054290 !ruby/object:Gem::Requirement
+  requirement: &10506060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -56,10 +56,10 @@ dependencies:
         version: 0.9.8.4
   type: :development
   prerelease: false
-  version_requirements: *83054290
+  version_requirements: *10506060
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &83054060 !ruby/object:Gem::Requirement
+  requirement: &10505600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -67,10 +67,10 @@ dependencies:
         version: 0.8.7
   type: :development
   prerelease: false
-  version_requirements: *83054060
+  version_requirements: *10505600
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &83053830 !ruby/object:Gem::Requirement
+  requirement: &10505140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -78,10 +78,10 @@ dependencies:
         version: '2'
   type: :development
   prerelease: false
-  version_requirements: *83053830
+  version_requirements: *10505140
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &83053600 !ruby/object:Gem::Requirement
+  requirement: &10504680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -89,10 +89,10 @@ dependencies:
         version: 1.6.2
   type: :development
   prerelease: false
-  version_requirements: *83053600
+  version_requirements: *10504680
 - !ruby/object:Gem::Dependency
   name: timecop
-  requirement: &83053370 !ruby/object:Gem::Requirement
+  requirement: &10504220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -100,7 +100,7 @@ dependencies:
         version: 0.3.5
   type: :development
   prerelease: false
-  version_requirements: *83053370
+  version_requirements: *10504220
 description: https://github.com/appsbakery/memo_tomato
 email:
 - tagrudev@gmail.com
@@ -110,6 +110,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
 - Gemfile
 - README.md
 - Rakefile
@@ -138,6 +139,7 @@ files:
 - spec/mock_json/movies.json
 - spec/mock_json/movies/770672122.json
 - spec/mock_json/movies/770672122/similar.json
+- spec/mock_json/movies/770885199.json
 - spec/spec_helper.rb
 has_rdoc: true
 homepage: http://www.appsbakery.eu