memery 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a2db1b80dc2da0ad38dea657f09a1f4a029017d5c67610e27a71af3aeb9aef4
-  data.tar.gz: b2e8bc1c499d2462096b0b4045c41de110ea8ea27b5750e23cbdf1a74c57d9f9
+  metadata.gz: 91c69224d38dc7b680a40c666d20e36ba65383235e70cec68b8b54b5e42f61ef
+  data.tar.gz: 8340fb04f65f8f57a5ee177d6affcb3183d892f65fae04153fb5c2e74d3ee2cf
 SHA512:
-  metadata.gz: 813057c9b895b2b789a75c48ea49366a9a951494e90d07a21a628b46ed2bda35e3f9a8407a5efcbf0bf73712ddaff6002d8685e083d6b767e8c52d3102b65743
-  data.tar.gz: 24a8b9ef7c10341336e301f6e9c09644101fd7c593f9535483cdbf8360ac8ac003d94869200303269fb8d3c6b7103675f7691a7c5d46b31acfd74f5f40b19a59
+  metadata.gz: 1acd168dd8d4bc989ac51ca5c37eb1229cf86c8378aac3ef0fef716e4ba81bb50e85975712ac4ea1997ded3c58db43647ffe342f186d6f3a12d7bfc87e646293
+  data.tar.gz: 219204fb9a75cd005dcd3102740ba81a67302b5b15609bfceb4c0fe0484698c5a0f1467ce737f7d30067ad85a7b2d9be68df4d489d56d11d6f6789536c7b0533

data/.travis.yml

@@ -3,10 +3,10 @@ language: ruby
 sudo: false
 
 rvm:
-  - 2.2
   - 2.3
   - 2.4
   - 2.5
+  - 2.6
   - ruby-head
 
 before_install: gem install bundler
@@ -19,7 +19,7 @@ matrix:
   fast_finish: true
   # Only run RuboCop on the latest Ruby
   include:
-    - rvm: 2.5
+    - rvm: 2.6
       env: SUITE="rubocop"
   allow_failures:
     - rvm: ruby-head

data/CHANGELOG.md

@@ -1,8 +1,12 @@
 ## [Unreleased]
 
+## [1.1.0] - 2019-08-05
+### Fixed
+- Optimize speed and memory for cached values returns. ([@AlexWayfer]) [#10]
+
 ## [1.0.0] - 2018-08-31
 ### Added
-- Add `:condition` option for `.memoize` method ([@AlexWayfer]) [#7]
+- Add `:condition` option for `.memoize` method. ([@AlexWayfer]) [#7]
 
 ## [0.6.0] - 2018-04-20
 ### Added
@@ -15,10 +19,12 @@
 [0.5.0]: https://github.com/tycooon/memery/tree/v0.5.0
 [0.6.0]: https://github.com/tycooon/memery/compare/v0.5.0...v0.6.0
 [1.0.0]: https://github.com/tycooon/memery/compare/v0.6.0...v1.0.0
-[Unreleased]: https://github.com/tycooon/memery/compare/v0.6.0...HEAD
+[1.1.0]: https://github.com/tycooon/memery/compare/v1.0.0...v1.1.0
+[Unreleased]: https://github.com/tycooon/memery/compare/v1.1.0...HEAD
 
 [@tycooon]: https://github.com/tycooon
 [@AlexWayfer]: https://github.com/AlexWayfer
 
 [#3]: https://github.com/tycooon/memery/pull/3
 [#7]: https://github.com/tycooon/memery/pull/7
+[#10]: https://github.com/tycooon/memery/pull/10

data/README.md

@@ -8,7 +8,7 @@ def user
 end
 ```
 
-However, this approach dosn't work if the calculated result can be `nil` or `false` or in case the method is using arguments. You will also require extra `begin`/`end` lines in case your method requires multiple lines:
+However, this approach doesn't work if calculated result can be `nil` or `false` or in case the method is using arguments. You will also require extra `begin`/`end` lines in case your method requires multiple lines:
 
 ```ruby
 def user
@@ -31,7 +31,8 @@ end
 ```
 
 ## Installation
-Juts add `gem "memery"` to your Gemfile.
+
+Simply add `gem "memery"` to your Gemfile.
 
 ## Usage
 
@@ -117,7 +118,7 @@ a.call # => 42
 ```
 
 ## Difference with other gems
-Memery is very similar to [Memoist](https://github.com/matthewrudy/memoist). The difference is that it doesn't override methods, instead it uses Ruby 2 `Module.prepend` feature. This approach is cleaner and it allows subclasses' methods to work properly: if you redefine a memoized method in a subclass, it's not memoized by default, but you can memoize it normally (without using awkward `identifier: ` argument) and it will just work:
+Memery is very similar to [Memoist](https://github.com/matthewrudy/memoist). The difference is that it doesn't override methods, instead it uses Ruby 2 `Module.prepend` feature. This approach is cleaner (for example you are able to inspect the original method body using `method(:x).super_method.source`) and it allows subclasses' methods to work properly: if you redefine a memoized method in a subclass, it's not memoized by default, but you can memoize it normally (without using awkward `identifier: ` argument) and it will just work:
 
 ```ruby
 class A
@@ -172,10 +173,13 @@ a.users {}
 However, this solution is kind of hacky.
 
 ## Contributing
+
 Bug reports and pull requests are welcome on GitHub at https://github.com/tycooon/memery.
 
 ## License
+
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 
 ## Author
+
 Created by Yuri Smirnov.

data/lib/memery.rb

@@ -44,16 +44,15 @@ module Memery
             return super(*args, &block)
           end
 
-          @_memery_memoized_values ||= {}
+          key = "#{method_name}_#{mod_id}"
 
-          key = [method_name, mod_id].join("_").to_sym
-          store = @_memery_memoized_values[key] ||= {}
+          store = @_memery_memoized_values&.[](key)
 
-          if store.key?(args)
-            store[args]
-          else
-            store[args] = super(*args)
-          end
+          return store[args] if store&.key?(args)
+
+          @_memery_memoized_values ||= {}
+          @_memery_memoized_values[key] ||= {}
+          @_memery_memoized_values[key][args] = super(*args)
         end
 
         send(visibility, method_name)

data/lib/memery/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Memery
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/memery.gemspec

@@ -25,6 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "rubocop-config-umbrellio"
   spec.add_development_dependency "simplecov"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: memery
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Yuri Smirnov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-31 00:00:00.000000000 Z
+date: 2019-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,20 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-config-umbrellio
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -147,8 +133,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A gem for memoization.