memcached 0.16.2 → 0.16.3

data/BENCHMARKS

@@ -9,47 +9,49 @@ You can easily run your own benchmarks, as long as you have memcached itself on
 
 These benchmarks were run on an OS X 10.5 Core 2 Duo machine (10,000 iterations):
 
-Ruby 1.8.7p174
-Loaded memcached 0.16.2
-Loaded memcache-client 1.7.4
-                                         user     system      total        real
-set:plain:noblock:memcached:net      0.270000   0.110000   0.380000 (  0.911797)
-set:plain:noblock:memcached:uds      0.250000   0.060000   0.310000 (  0.471307)
-set:plain:memcached:net              0.640000   0.980000   1.620000 (  3.662495)
-set:plain:memcached:uds              0.500000   0.560000   1.060000 (  1.962946)
-set:plain:memcache-client            7.640000   3.200000  10.840000 ( 11.264549)
-set:ruby:noblock:memcached:net       0.450000   0.110000   0.560000 (  1.049771)
-set:ruby:noblock:memcached:uds       0.420000   0.060000   0.480000 (  0.581246)
-set:ruby:memcached:net               0.890000   0.990000   1.880000 (  4.022136)
-set:ruby:memcached:uds               0.770000   0.590000   1.360000 (  2.462128)
-set:ruby:memcache-client             7.210000   3.000000  10.210000 ( 12.328381)
-get:plain:memcached:net              0.730000   0.970000   1.700000 (  3.866983)
-get:plain:memcached:uds              0.650000   0.600000   1.250000 (  2.477487)
-get:plain:memcache-client            8.340000   2.910000  11.250000 ( 12.963698)
-get:ruby:memcached:net               0.910000   0.930000   1.840000 (  4.232627)
-get:ruby:memcached:uds               0.750000   0.580000   1.330000 (  2.107293)
-get:ruby:memcache-client             9.180000   3.160000  12.340000 ( 13.018086)
-multiget:ruby:memcached:net          0.510000   0.360000   0.870000 (  1.286799)
-multiget:ruby:memcached:uds          0.500000   0.270000   0.770000 (  0.957104)
-multiget:ruby:memcache-client        5.000000   1.140000   6.140000 (  6.357939)
-missing:ruby:memcached:net           0.990000   1.040000   2.030000 (  3.863125)
-missing:ruby:memcached:uds           0.860000   0.650000   1.510000 (  2.375266)
-missing:ruby:memcached:inline        0.960000   1.030000   1.990000 (  3.810818)
-missing:ruby:memcached:uds:inline    0.830000   0.640000   1.470000 (  2.189629)
-missing:ruby:memcache-client         7.690000   3.180000  10.870000 ( 11.838813)
-mixed:ruby:noblock:memcached:net     1.840000   2.530000   4.370000 (  8.177355)
-mixed:ruby:noblock:memcached:uds     1.420000   1.050000   2.470000 (  4.167074)
-mixed:ruby:memcached:net             1.830000   1.980000   3.810000 (  7.666954)
-mixed:ruby:memcached:uds             1.520000   1.160000   2.680000 (  4.286830)
-mixed:ruby:memcache-client          17.980000   6.490000  24.470000 ( 26.107002)
-hash:murmur                          0.040000   0.000000   0.040000 (  0.039768)
-hash:default                         0.040000   0.000000   0.040000 (  0.041131)
-hash:jenkins                         0.050000   0.000000   0.050000 (  0.051128)
-hash:md5                             0.090000   0.010000   0.100000 (  0.092318)
-hash:crc                             0.040000   0.000000   0.040000 (  0.036825)
-hash:hsieh                           0.020000   0.000000   0.020000 (  0.020522)
-hash:fnv1_32                         0.050000   0.000000   0.050000 (  0.044151)
-hash:fnv1a_32                        0.040000   0.000000   0.040000 (  0.046496)
-hash:fnv1_64                         0.100000   0.000000   0.100000 (  0.110565)
-hash:fnv1a_64                        0.050000   0.000000   0.050000 (  0.052217)
+  Ruby 1.8.7p174
+  Loaded memcached 0.16.3
+  Loaded memcache-client 1.7.4
+
+                                           user     system      total        real
+  set:plain:noblock:memcached:net      0.260000   0.110000   0.370000 (  0.941733)
+  set:plain:noblock:memcached:uds      0.250000   0.060000   0.310000 (  0.470593)
+  set:plain:memcached:net              0.640000   1.040000   1.680000 (  4.352426)
+  set:plain:memcached:uds              0.500000   0.560000   1.060000 (  2.130330)
+  set:plain:memcache-client            7.500000   3.160000  10.660000 ( 11.394051)
+  set:ruby:noblock:memcached:net       0.430000   0.070000   0.500000 (  1.393856)
+  set:ruby:noblock:memcached:uds       0.440000   0.040000   0.480000 (  0.751106)
+  set:ruby:memcached:net               0.890000   0.910000   1.800000 (  5.539385)
+  set:ruby:memcached:uds               0.790000   0.610000   1.400000 (  3.257946)
+  set:ruby:memcache-client             7.710000   3.160000  10.870000 ( 11.494342)
+  get:plain:memcached:net              0.730000   0.940000   1.670000 (  4.305591)
+  get:plain:memcached:uds              0.610000   0.580000   1.190000 (  2.225602)
+  get:plain:memcache-client            8.960000   3.110000  12.070000 ( 13.710735)
+  get:ruby:memcached:net               0.910000   0.980000   1.890000 (  4.364018)
+  get:ruby:memcached:uds               0.750000   0.570000   1.320000 (  2.236862)
+  get:ruby:memcache-client             9.310000   3.180000  12.490000 ( 13.077060)
+  multiget:ruby:memcached:net          0.510000   0.350000   0.860000 (  1.471429)
+  multiget:ruby:memcached:uds          0.500000   0.260000   0.760000 (  1.138027)
+  multiget:ruby:memcache-client        4.840000   1.110000   5.950000 (  6.511808)
+  get-miss:ruby:memcached:net          0.960000   1.030000   1.990000 (  4.510132)
+  get-miss:ruby:memcached:uds          0.830000   0.640000   1.470000 (  2.708862)
+  get-miss:ruby:memcache-client        7.810000   3.190000  11.000000 ( 11.390215)
+  append-miss:ruby:memcached:net       1.000000   1.030000   2.030000 (  4.923893)
+  append-miss:ruby:memcached:uds       0.890000   0.680000   1.570000 (  3.202743)
+  append-miss:ruby:memcache-client     7.740000   3.180000  10.920000 ( 11.339136)
+  mixed:ruby:noblock:memcached:net     1.800000   2.370000   4.170000 (  8.616549)
+  mixed:ruby:noblock:memcached:uds     1.410000   1.090000   2.500000 (  5.035893)
+  mixed:ruby:memcached:net             1.830000   1.900000   3.730000 (  9.046367)
+  mixed:ruby:memcached:uds             1.570000   1.190000   2.760000 (  6.583020)
+  mixed:ruby:memcache-client          17.910000   6.440000  24.350000 ( 24.946386)
+  hash:murmur                          0.040000   0.000000   0.040000 (  0.039152)
+  hash:default                         0.040000   0.000000   0.040000 (  0.041841)
+  hash:jenkins                         0.050000   0.000000   0.050000 (  0.052283)
+  hash:md5                             0.090000   0.000000   0.090000 (  0.092901)
+  hash:crc                             0.040000   0.000000   0.040000 (  0.037710)
+  hash:fnv1a_32                        0.050000   0.000000   0.050000 (  0.047746)
+  hash:hsieh                           0.020000   0.000000   0.020000 (  0.020477)
+  hash:fnv1_32                         0.050000   0.000000   0.050000 (  0.046204)
+  hash:fnv1_64                         0.100000   0.000000   0.100000 (  0.106735)
+  hash:fnv1a_64                        0.060000   0.000000   0.060000 (  0.054646)
 

data/CHANGELOG

@@ -1,4 +1,6 @@
 
+v0.16.3. Optimize append/prepend on miss.
+
 v0.16.2. Fix memory leak.
 
 v0.16.1. Use seeded random. Fix realloc bug on Linux.

data/lib/memcached/exceptions.rb

@@ -47,6 +47,15 @@ Subclasses correspond one-to-one with server response strings or libmemcached er
 
 =end
   class Error < RuntimeError
+    attr_accessor :no_backtrace
+    
+    def set_backtrace(*args)
+      @no_backtrace ? [] : super
+    end
+    
+    def backtrace(*args)
+      @no_backtrace ? [] : super
+    end
   end 
 
 #:stopdoc:
@@ -71,17 +80,5 @@ Subclasses correspond one-to-one with server response strings or libmemcached er
     EXCEPTIONS << exception_class
   end
   
-  class NotFound
-    attr_accessor :no_backtrace
-    
-    def set_backtrace(*args)
-      @no_backtrace ? [] : super
-    end
-    
-    def backtrace(*args)
-      @no_backtrace ? [] : super
-    end
-  end
-  
 #:startdoc:
 end

data/lib/memcached/memcached.rb

@@ -63,7 +63,7 @@ Valid option parameters are:
 <tt>:tcp_nodelay</tt>:: Turns on the no-delay feature for connecting sockets. Accepts <tt>true</tt> or <tt>false</tt>. Performance may or may not change, depending on your system.
 <tt>:no_block</tt>:: Whether to use pipelining for writes. Accepts <tt>true</tt> or <tt>false</tt>.
 <tt>:buffer_requests</tt>:: Whether to use an internal write buffer. Accepts <tt>true</tt> or <tt>false</tt>. Calling <tt>get</tt> or closing the connection will force the buffer to flush. Note that <tt>:buffer_requests</tt> might not work well without <tt>:no_block</tt> also enabled.
-<tt>:show_backtraces</tt>:: Whether <b>Memcached::NotFound</b> exceptions should include backtraces. Generating backtraces is slow, so this is off by default. Turn it on to ease debugging.
+<tt>:show_backtraces</tt>:: Whether <b>Memcached::NotFound</b> and <b>Memcached::NotStored</b> exceptions should include backtraces. Generating backtraces is slow, so this is off by default. Turn it on to ease debugging.
 <tt>:connect_timeout</tt>:: How long to wait for a connection to a server. Defaults to 2 seconds. Set to <tt>0</tt> if you want to wait forever.
 <tt>:timeout</tt>:: How long to wait for a response from the server. Defaults to 0.25 seconds. Set to <tt>0</tt> if you want to wait forever.
 <tt>:default_ttl</tt>:: The <tt>ttl</tt> to use on set if no <tt>ttl</tt> is specified, in seconds. Defaults to one week. Set to <tt>0</tt> if you want things to never expire.
@@ -119,8 +119,10 @@ Please note that when pipelining is enabled, setter and deleter methods do not r
 
     # Not found exceptions
     unless options[:show_backtraces]
-      @not_found_instance = NotFound.new
-      @not_found_instance.no_backtrace = true
+      @not_found = NotFound.new
+      @not_found.no_backtrace = true      
+      @not_stored = NotStored.new
+      @not_stored.no_backtrace = true      
     end
   end
 
@@ -386,10 +388,12 @@ Please note that when pipelining is enabled, setter and deleter methods do not r
 
   # Checks the return code from Rlibmemcached against the exception list. Raises the corresponding exception if the return code is not Memcached::Success or Memcached::ActionQueued. Accepts an integer return code and an optional key, for exception messages.
   def check_return_code(ret, key = nil) #:doc:
-    if ret == 0 # Lib::MEMCACHED_SUCCESS
-    elsif ret == Lib::MEMCACHED_BUFFERED
-    elsif ret == Lib::MEMCACHED_NOTFOUND and !options[:show_backtraces]
-      raise @not_found_instance
+    if ret == 0 # Memcached::Success
+    elsif ret == Lib::MEMCACHED_BUFFERED # Memcached::ActionQueued
+    elsif ret == Lib::MEMCACHED_NOTFOUND and @not_found
+      raise @not_found
+    elsif ret == Lib::MEMCACHED_NOTSTORED and @not_stored
+      raise @not_stored
     else
       message = "Key #{inspect_keys(key, (detect_failure if ret == Lib::MEMCACHED_SERVER_MARKED_DEAD)).inspect}"
       if key.is_a?(String)

data/memcached.gemspec

@@ -2,12 +2,12 @@
 
 Gem::Specification.new do |s|
   s.name = %q{memcached}
-  s.version = "0.16.2"
+  s.version = "0.16.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Evan Weaver"]
   s.cert_chain = ["/Users/eweaver/p/configuration/gem_certificates/evan_weaver-original-public_cert.pem"]
-  s.date = %q{2009-09-02}
+  s.date = %q{2009-09-04}
   s.description = %q{An interface to the libmemcached C client.}
   s.email = %q{}
   s.extensions = ["ext/extconf.rb"]

data/test/profile/benchmark.rb

@@ -312,66 +312,81 @@ class Bench
     
       if defined? Memcached
         @m = Memcached.new(*@opts_networked)
-        x.report("missing:ruby:memcached:net") do
+        x.report("get-miss:ruby:memcached:net") do
           n.times do
             begin @m.delete @key1; rescue Memcached::NotFound; end
-            begin @m.get @key1; rescue Memcached::NotFound; end
             begin @m.delete @key2; rescue Memcached::NotFound; end
-            begin @m.get @key2; rescue Memcached::NotFound; end
             begin @m.delete @key3; rescue Memcached::NotFound; end
+            begin @m.get @key1; rescue Memcached::NotFound; end
+            begin @m.get @key2; rescue Memcached::NotFound; end
             begin @m.get @key3; rescue Memcached::NotFound; end
           end
         end
         @m = Memcached.new(*@opt_unix)
-        x.report("missing:ruby:memcached:uds") do
+        x.report("get-miss:ruby:memcached:uds") do
           n.times do
             begin @m.delete @key1; rescue Memcached::NotFound; end
-            begin @m.get @key1; rescue Memcached::NotFound; end
             begin @m.delete @key2; rescue Memcached::NotFound; end
-            begin @m.get @key2; rescue Memcached::NotFound; end
             begin @m.delete @key3; rescue Memcached::NotFound; end
+            begin @m.get @key1; rescue Memcached::NotFound; end
+            begin @m.get @key2; rescue Memcached::NotFound; end
             begin @m.get @key3; rescue Memcached::NotFound; end
           end
         end
+      end      
+
+      if defined? MemCache
+        @m = MemCache.new(*@opts_networked)
+        x.report("get-miss:ruby:memcache-client") do
+          n.times do
+            begin @m.delete @key1; rescue; end
+            begin @m.delete @key2; rescue; end
+            begin @m.delete @key3; rescue; end
+            begin @m.get @key1; rescue; end
+            begin @m.get @key2; rescue; end
+            begin @m.get @key3; rescue; end
+          end
+        end
       end
+      
       if defined? Memcached
         @m = Memcached.new(*@opts_networked)
-        x.report("missing:ruby:memcached:inline") do
+        x.report("append-miss:ruby:memcached:net") do
           n.times do
-            @m.delete @key1 rescue nil
-            @m.get @key1 rescue nil
-            @m.delete @key2 rescue nil
-            @m.get @key2 rescue nil
-            @m.delete @key3 rescue nil
-            @m.get @key3 rescue nil
+            begin @m.delete @key1; rescue Memcached::NotFound; end
+            begin @m.delete @key2; rescue Memcached::NotFound; end
+            begin @m.delete @key3; rescue Memcached::NotFound; end
+            begin @m.append @key1, @value; rescue Memcached::NotStored; end
+            begin @m.append @key2, @value; rescue Memcached::NotStored; end
+            begin @m.append @key3, @value; rescue Memcached::NotStored; end
           end
         end
         @m = Memcached.new(*@opt_unix)
-        x.report("missing:ruby:memcached:uds:inline") do
+        x.report("append-miss:ruby:memcached:uds") do
           n.times do
-            @m.delete @key1 rescue nil
-            @m.get @key1 rescue nil
-            @m.delete @key2 rescue nil
-            @m.get @key2 rescue nil
-            @m.delete @key3 rescue nil
-            @m.get @key3 rescue nil
+            begin @m.delete @key1; rescue Memcached::NotFound; end
+            begin @m.delete @key2; rescue Memcached::NotFound; end
+            begin @m.delete @key3; rescue Memcached::NotFound; end
+            begin @m.append @key1, @value; rescue Memcached::NotStored; end
+            begin @m.append @key2, @value; rescue Memcached::NotStored; end
+            begin @m.append @key3, @value; rescue Memcached::NotStored; end
           end
         end
       end
       if defined? MemCache
         @m = MemCache.new(*@opts_networked)
-        x.report("missing:ruby:memcache-client") do
+        x.report("append-miss:ruby:memcache-client") do
           n.times do
             begin @m.delete @key1; rescue; end
-            begin @m.get @key1; rescue; end
             begin @m.delete @key2; rescue; end
-            begin @m.get @key2; rescue; end
             begin @m.delete @key3; rescue; end
-            begin @m.get @key3; rescue; end
+            begin @m.append @key1, @value; rescue; end
+            begin @m.append @key2, @value; rescue; end
+            begin @m.append @key3, @value; rescue; end
           end
         end
       end
-          
+                      
       if defined? Memcached
         @m = Memcached.new(
         @opts_networked[0],
@@ -484,10 +499,9 @@ class Bench
             end
           end
         end
-    
       end
-    end
-    
+
+    end    
   end
 end
 

data/test/unit/memcached_test.rb

@@ -155,6 +155,11 @@ class MemcachedTest < Test::Unit::TestCase
     rescue Memcached::NotFound => e
       assert e.backtrace.empty?
     end
+    begin
+      cache.append key, @value
+    rescue Memcached::NotStored => e
+      assert e.backtrace.empty?
+    end     
   end
 
   def test_initialize_with_backtraces
@@ -697,7 +702,7 @@ class MemcachedTest < Test::Unit::TestCase
   end
   
   def test_errno_message
-    Rlibmemcached::MemcachedServerSt.any_instance.expects("cached_errno").returns(1)
+    Rlibmemcached::MemcachedServerSt.any_instance.stubs("cached_errno").returns(1)
     @cache.send(:check_return_code, Rlibmemcached::MEMCACHED_ERRNO, key)    
   rescue Memcached::SystemError => e
     assert_match /^Errno 1: "Operation not permitted". Key/, e.message

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: memcached
 version: !ruby/object:Gem::Version 
-  version: 0.16.2
+  version: 0.16.3
 platform: ruby
 authors: 
 - Evan Weaver
@@ -30,7 +30,7 @@ cert_chain:
   yZ0=
   -----END CERTIFICATE-----
 
-date: 2009-09-02 00:00:00 -07:00
+date: 2009-09-04 00:00:00 -07:00
 default_executable: 
 dependencies: []
 

metadata.gz.sig

@@ -1,2 +1,2 @@
-t�3I�r/G��&��2j#���ҩ�|���
-8iwA�t	��ҡ�-��ѝ��}-�_a�~���a�.<O��&P�Si�c5v�`���.���v��YIu��Ff®m�<�(�f������u�ԅy0��6���}��X<-�8�
w$� 9�o���MF{��	ck���j��]*�ݔŴBz$�GXN�
-�a����������*���P�a��b&s���\���e�]G�&�*���v�2}e�g:l�
+RK�y��e������[�<R��
+R�u��#�1����d�D%$	����T��\€t��ሤ�4$����0&j��7����AV8��|	�ΜOv��m�}���?��^e���'bd�d�V��T�ɨ�頸���� (98���"��	�Ƀf )�O�E���{�����;|�߹E��X65�F5����