memcached 0.15.2 → 0.15.3

data/CHANGELOG

@@ -1,4 +1,6 @@
 
+v0.15.3. UDP fix. 0-value fix. Enforce server_add response code. Better tests.
+
 v0.15.2. Don't require memcached itself to build. Fix for AUTO_EJECT_HOSTS in random and modulus pools. Support binary protocol.
 
 v0.15.1. Fix build problem.

data/Manifest

@@ -13,7 +13,6 @@ lib/memcached/rails.rb
 lib/memcached.rb
 LICENSE
 Manifest
-memcached.gemspec
 Rakefile
 README
 test/profile/benchmark.rb

data/lib/memcached/behaviors.rb

@@ -44,7 +44,7 @@ class Memcached
     case behavior
       when :hash then raise(ArgumentError, msg) unless HASH_VALUES[value]
       when :distribution then raise(ArgumentError, msg) unless DISTRIBUTION_VALUES[value]
-      when *DIRECT_VALUE_BEHAVIORS then raise(ArgumentError, msg) unless value.is_a?(Numeric) and value > 0
+      when *DIRECT_VALUE_BEHAVIORS then raise(ArgumentError, msg) unless value.is_a?(Numeric) and value >= 0
       else
         raise(ArgumentError, msg) unless BEHAVIOR_VALUES[value]
     end

data/lib/memcached/memcached.rb

@@ -418,13 +418,20 @@ Please note that when pipelining is enabled, setter and deleter methods do not r
 
   # Set the servers on the struct.
   def set_servers(servers)
-    add_method = options[:use_udp] ? "memcached_server_add_udp_with_weight" : "memcached_server_add_with_weight"
     Array(servers).each_with_index do |server, index|
+      # Socket
       if server.is_a?(String) and File.socket?(server)
-        Lib.memcached_server_add_unix_socket_with_weight(@struct, server, options[:default_weight].to_i)
+        args = [@struct, server, options[:default_weight].to_i]
+        check_return_code(Lib.memcached_server_add_unix_socket_with_weight(*args))
+      # Network
       elsif server.is_a?(String) and server =~ /^[\w\d\.-]+(:\d{1,5}){0,2}$/
         host, port, weight = server.split(":")
-        Lib.memcached_server_add_with_weight(@struct, host, port.to_i, (weight || options[:default_weight]).to_i)
+        args = [@struct, host, port.to_i, (weight || options[:default_weight]).to_i]                
+        if options[:use_udp] #
+          check_return_code(Lib.memcached_server_add_udp_with_weight(*args))
+        else
+          check_return_code(Lib.memcached_server_add_with_weight(*args))
+        end
       else
         raise ArgumentError, "Servers must be either in the format 'host:port[:weight]' (e.g., 'localhost:11211' or  'localhost:11211:10') for a network server, or a valid path to a Unix domain socket (e.g., /var/run/memcached)."
       end

data/memcached.gemspec

@@ -2,29 +2,30 @@
 
 Gem::Specification.new do |s|
   s.name = %q{memcached}
-  s.version = "0.15.2"
+  s.version = "0.15.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Evan Weaver"]
   s.cert_chain = ["/Users/eweaver/p/configuration/gem_certificates/evan_weaver-original-public_cert.pem"]
-  s.date = %q{2009-08-04}
+  s.date = %q{2009-08-07}
   s.description = %q{An interface to the libmemcached C client.}
   s.email = %q{}
   s.extensions = ["ext/extconf.rb"]
   s.extra_rdoc_files = ["BENCHMARKS", "CHANGELOG", "COMPATIBILITY", "lib/memcached/behaviors.rb", "lib/memcached/exceptions.rb", "lib/memcached/memcached.rb", "lib/memcached/rails.rb", "lib/memcached.rb", "LICENSE", "README", "TODO"]
-  s.files = ["BENCHMARKS", "CHANGELOG", "COMPATIBILITY", "ext/extconf.rb", "ext/libmemcached-0.31.tar.gz", "ext/rlibmemcached.i", "ext/rlibmemcached_wrap.c", "lib/memcached/behaviors.rb", "lib/memcached/exceptions.rb", "lib/memcached/integer.rb", "lib/memcached/memcached.rb", "lib/memcached/rails.rb", "lib/memcached.rb", "LICENSE", "Manifest", "memcached.gemspec", "Rakefile", "README", "test/profile/benchmark.rb", "test/profile/profile.rb", "test/profile/valgrind.rb", "test/setup.rb", "test/teardown.rb", "test/test_helper.rb", "test/unit/binding_test.rb", "test/unit/memcached_test.rb", "test/unit/rails_test.rb", "TODO"]
+  s.files = ["BENCHMARKS", "CHANGELOG", "COMPATIBILITY", "ext/extconf.rb", "ext/libmemcached-0.31.tar.gz", "ext/rlibmemcached.i", "ext/rlibmemcached_wrap.c", "lib/memcached/behaviors.rb", "lib/memcached/exceptions.rb", "lib/memcached/integer.rb", "lib/memcached/memcached.rb", "lib/memcached/rails.rb", "lib/memcached.rb", "LICENSE", "Manifest", "Rakefile", "README", "test/profile/benchmark.rb", "test/profile/profile.rb", "test/profile/valgrind.rb", "test/setup.rb", "test/teardown.rb", "test/test_helper.rb", "test/unit/binding_test.rb", "test/unit/memcached_test.rb", "test/unit/rails_test.rb", "TODO", "memcached.gemspec"]
+  s.has_rdoc = true
   s.homepage = %q{http://blog.evanweaver.com/files/doc/fauna/memcached/}
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Memcached", "--main", "README"]
   s.require_paths = ["lib", "ext"]
   s.rubyforge_project = %q{fauna}
-  s.rubygems_version = %q{1.3.4}
+  s.rubygems_version = %q{1.3.1}
   s.signing_key = %q{/Users/eweaver/p/configuration/gem_certificates/evan_weaver-original-private_key.pem}
   s.summary = %q{An interface to the libmemcached C client.}
   s.test_files = ["test/test_helper.rb", "test/unit/binding_test.rb", "test/unit/memcached_test.rb", "test/unit/rails_test.rb"]
 
   if s.respond_to? :specification_version then
     current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
+    s.specification_version = 2
 
     if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
     else

data/test/setup.rb

@@ -11,12 +11,19 @@ unless defined? UNIX_SOCKET_NAME
   log = "/tmp/memcached.log"
   system ">#{log}"
   
-  # Network memcached
+  # TCP memcached
   (43042..43046).each do |port|
-    system "memcached #{verbosity} -U #{port} -p #{port} >> #{log} 2>&1 &"
-  end
+    cmd = "memcached #{verbosity} -U 0 -p #{port} >> #{log} 2>&1 &"
+    raise "'#{cmd}' failed to start" unless system(cmd)
+  end  
+  # UDP memcached
+  (43052..43053).each do |port|
+    cmd = "memcached #{verbosity} -U #{port} -p 0 >> #{log} 2>&1 &"
+    raise "'#{cmd}' failed to start" unless system(cmd)
+  end  
   # Domain socket memcached
   (0..1).each do |i|
-    system "memcached -M -s #{UNIX_SOCKET_NAME}#{i} #{verbosity} >> #{log} 2>&1 &"
+    cmd = "memcached -M -s #{UNIX_SOCKET_NAME}#{i} #{verbosity} >> #{log} 2>&1 &"
+    raise "'#{cmd}' failed to start" unless system(cmd)
   end
 end

data/test/unit/memcached_test.rb

@@ -8,6 +8,7 @@ class MemcachedTest < Test::Unit::TestCase
 
   def setup
     @servers = ['localhost:43042', 'localhost:43043', "#{UNIX_SOCKET_NAME}0"]
+    @udp_servers = ['localhost:43052', 'localhost:43053']
 
     # Maximum allowed prefix key size for :hash_with_prefix_key_key => false
     @prefix_key = 'prefix_key_'
@@ -22,10 +23,10 @@ class MemcachedTest < Test::Unit::TestCase
     @udp_options = {
       :prefix_key => @prefix_key,
       :hash => :default,
-      :udp => true,
+      :use_udp => true,
       :distribution => :modula
     }
-    @udp_cache = Memcached.new(@servers, @udp_options)
+    @udp_cache = Memcached.new(@udp_servers, @udp_options)
 
     @nb_options = {
       :prefix_key => @prefix_key,
@@ -218,13 +219,14 @@ class MemcachedTest < Test::Unit::TestCase
     result = @cache.get key
     assert_equal @value, result
   end
-  
-  def test_udp_get
-    @udp_cache.set key, @value
-    result = @udp_cache.get key
-    assert_equal @value, result
-  end  
 
+  def test_udp_get
+    @udp_cache.set(key, @value)
+    assert_raises(Memcached::ActionNotSupported) do
+      @udp_cache.get(key)
+    end
+  end
+  
   def test_get_nil
     @cache.set key, nil, 0
     result = @cache.get key

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: memcached
 version: !ruby/object:Gem::Version 
-  version: 0.15.2
+  version: 0.15.3
 platform: ruby
 authors: 
 - Evan Weaver
@@ -30,7 +30,7 @@ cert_chain:
   yZ0=
   -----END CERTIFICATE-----
 
-date: 2009-08-04 00:00:00 -07:00
+date: 2009-08-07 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -68,7 +68,6 @@ files:
 - lib/memcached.rb
 - LICENSE
 - Manifest
-- memcached.gemspec
 - Rakefile
 - README
 - test/profile/benchmark.rb
@@ -81,10 +80,9 @@ files:
 - test/unit/memcached_test.rb
 - test/unit/rails_test.rb
 - TODO
+- memcached.gemspec
 has_rdoc: true
 homepage: http://blog.evanweaver.com/files/doc/fauna/memcached/
-licenses: []
-
 post_install_message: 
 rdoc_options: 
 - --line-numbers
@@ -111,9 +109,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: fauna
-rubygems_version: 1.3.4
+rubygems_version: 1.3.1
 signing_key: 
-specification_version: 3
+specification_version: 2
 summary: An interface to the libmemcached C client.
 test_files: 
 - test/test_helper.rb

metadata.gz.sig

@@ -1 +1 @@
-\�~�lus��)�$���w)�xs�inB�w=��*[�çO]Q;��j^�B	W��/HФ'�L����EIt8�=�'�H�\��AX��V���{��{2��s@�h�kz�p׼�����'�'��rj�����6Nj
+<�[({�+��I~�P�׾�ܧ�I+�:���twݕq��b�g� �Ծ�݃�a%+����A���b9��qU
cQ������=�2wF�rQ<��X:�����q�BLB\t*J�����c���;(��u��~tBs�7_����wg㣏?@�RČ-A3���8d�#<2Ʌ�`����X!Ӓ|�C�����q-,��?���B�r�pL����i�
AQ-����0ɗ�cjc��Ȧ��4�9����R�c����0�W