memcache-client 1.8.2 → 1.8.3

data/History.rdoc

@@ -1,3 +1,7 @@
+= 1.8.3 (2010-04-26)
+
+ * Don't allow blank keys. (Bill Horsman)
+
 = 1.8.2 (2010-04-03)
 
  * Fix concurrency issues with eventmachine support.

data/lib/memcache.rb

@@ -700,6 +700,7 @@ class MemCache
   def get_server_for_key(key, options = {})
     raise ArgumentError, "illegal character in key #{key.inspect}" if
       key =~ /\s/
+    raise ArgumentError, "key cannot be blank" if key.nil? || key.strip.size == 0
     raise ArgumentError, "key too long #{key.inspect}" if key.length > 250
     raise MemCacheError, "No servers available" if @servers.empty?
     return @servers.first if @servers.length == 1

data/lib/memcache/version.rb

@@ -2,5 +2,5 @@ class MemCache
   ##
   # The version of MemCache you are using.
 
-  VERSION = "1.8.2"
+  VERSION = "1.8.3"
 end

data/test/test_mem_cache.rb

@@ -677,6 +677,13 @@ class TestMemCache < Test::Unit::TestCase
     assert_equal 'illegal character in key "space key"', e.message
   end
 
+  def test_get_server_for_blank_key
+    e = assert_raise ArgumentError do
+      @cache.get_server_for_key ''
+    end
+    assert_equal 'key cannot be blank', e.message
+  end
+
   def test_get_server_for_key_length
     @cache.get_server_for_key 'x' * 250
     long_key = 'x' * 251

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 8
-  - 2
-  version: 1.8.2
+  - 3
+  version: 1.8.3
 platform: ruby
 authors: 
 - Eric Hodel
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-03 00:00:00 -05:00
+date: 2010-04-26 00:00:00 -05:00
 default_executable: memcached_top
 dependencies: []