mechanize 2.5 → 2.5.1

data/CHANGELOG.rdoc

@@ -1,8 +1,14 @@
 = Mechanize CHANGELOG
 
+=== 2.5.1
+
+* Bug fix
+  * Mechanize no longer copies POST requests during a redirect which was
+    introduced by #215.  Pull request #229 by Godfrey Chan.
+
 === 2.5
 
-* Minor enhancement
+* Minor enhancements
   * Added Mechanize#ignore_bad_chunking for working around servers that don't
     terminate chunked transfer-encoding properly.  Enabling this may cause
     data loss.  Issue #116

data/examples/rubyforge.rb

@@ -5,11 +5,13 @@ require 'mechanize'
 require 'logger'
 
 # Create a new mechanize object
-agent = Mechanize.new { |a| a.log = Logger.new(STDERR) }
+mech = Mechanize.new
+mech.log = Logger.new $stderr
+mech.agent.http.debug_output = $stderr
 
 # Load the rubyforge website
-page = agent.get('http://rubyforge.org/')
-page = agent.click page.link_with(:text => /Log In/) # Click the login link
+page = mech.get('http://rubyforge.org/')
+page = mech.click page.link_with(:text => /Log In/) # Click the login link
 form = page.forms[1] # Select the first form
 form.form_loginname = ARGV[0]
 form.form_pw        = ARGV[1]

data/lib/mechanize.rb

@@ -73,7 +73,7 @@ class Mechanize
   ##
   # The version of Mechanize you are using.
 
-  VERSION = '2.5'
+  VERSION = '2.5.1'
 
   ##
   # Base mechanize error class

data/lib/mechanize/http/agent.rb

@@ -938,6 +938,11 @@ class Mechanize::HTTP::Agent
 
     redirect_method = method == :head ? :head : :get
 
+    # Make sure we are not copying over the POST headers from the original request
+    ['Content-Length', 'Content-MD5', 'Content-Type'].each do |key|
+      headers.delete key
+    end
+
     @history.push(page, page.uri)
     new_uri = resolve response['Location'].to_s, page
 

data/test/test_mechanize_http_agent.rb

@@ -1384,6 +1384,8 @@ class TestMechanizeHttpAgent < Mechanize::TestCase
 
     headers = {
       'Range' => 'bytes=0-9999',
+      'Content-Type' => 'application/x-www-form-urlencoded',
+      'Content-Length' => '9999',
     }
 
     page = fake_page
@@ -1392,7 +1394,9 @@ class TestMechanizeHttpAgent < Mechanize::TestCase
 
     assert_equal URI('http://fake.example/http_headers'), page.uri
 
-    assert_match 'range|bytes=0-999', page.body
+    assert_match 'range|bytes=0-9999', page.body
+    refute_match 'content-type|application/x-www-form-urlencoded', page.body
+    refute_match 'content-length|9999', page.body
   end
 
   def test_response_redirect_malformed
@@ -1414,7 +1418,7 @@ class TestMechanizeHttpAgent < Mechanize::TestCase
 
     assert_raises Mechanize::RedirectLimitReachedError do
       @agent.response_redirect({ 'Location' => '/index.html' }, :get,
-                               fake_page, @agent.redirection_limit, referer)
+                               fake_page, @agent.redirection_limit, {}, referer)
     end
   end
 
@@ -1423,7 +1427,7 @@ class TestMechanizeHttpAgent < Mechanize::TestCase
 
     page = fake_page
     page = @agent.response_redirect({ 'Location' => '/other' }, :get, page, 0,
-                                    page)
+                                    {}, page)
 
     assert_equal URI('http://fake.example'), page.uri
   end
@@ -1435,7 +1439,7 @@ class TestMechanizeHttpAgent < Mechanize::TestCase
     response.instance_variable_set :@header, { 'location' => %w[/index.html] }
 
     page = fake_page
-    page = @agent.response_redirect response, :get, page, 0, page
+    page = @agent.response_redirect response, :get, page, 0, {}, page
 
     assert_equal URI('http://fake.example/index.html'), page.uri
   end
@@ -1447,7 +1451,7 @@ class TestMechanizeHttpAgent < Mechanize::TestCase
     response.instance_variable_set :@header, { 'location' => %w[/index.html] }
 
     page = fake_page
-    page = @agent.response_redirect response, :get, page, 0, page
+    page = @agent.response_redirect response, :get, page, 0, {}, page
 
     assert_equal URI('http://fake.example/'), page.uri
   end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: mechanize
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 25
   prerelease: 
   segments: 
   - 2
   - 5
-  version: "2.5"
+  - 1
+  version: 2.5.1
 platform: ruby
 authors: 
 - Eric Hodel
@@ -39,7 +40,7 @@ cert_chain:
   U81zGHMUBOvz/VGT6wJwYJ3emS2nfA2NOHFfgA==
   -----END CERTIFICATE-----
 
-date: 2012-05-09 00:00:00 Z
+date: 2012-05-15 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: net-http-digest_auth